198069 2019-05-21 02:51:57 -0700 Undefined reference platformCloseFrontendPageAndWindow() linking against libWPEWebKit-1.0.so after r245536 2019-05-21 11:00:38 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra commit-queue don.olmstead hi inspector-bugzilla-changes joepeck ross.kirsling timothy webkit-bug-importer oldest_to_newest 1537838 0 psaavedra 2019-05-21 02:51:57 -0700 Undefined reference platformCloseFrontendPageAndWindow() linking against libWPEWebKit-1.0.so after r245536 I got this linking time issue trying to build Cog (the reference browser for WPE in meta-webkit - https://github.com/Igalia/cog) against the latest master: ``` libWPEWebKit-1.0.so: undefined reference to `WebKit::RemoteWebInspectorProxy::platformCloseFrontendPageAndWindow()' ``` The issues was introduced in [WinCairo] Implement Remote Web Inspector Client. https://bugs.webkit.org/show_bug.cgi?id=197434 The WPE platform still needs a dummy definition of `WebPageProxy* RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow()` Uploaded a patch with a proposal for change 1537839 1 370306 psaavedra 2019-05-21 02:54:40 -0700 Created attachment 370306 patch 1537882 2 370306 ross.kirsling 2019-05-21 08:22:00 -0700 Comment on attachment 370306 patch Thanks -- sorry for the trouble! 1537923 3 370306 commit-queue 2019-05-21 10:57:50 -0700 Comment on attachment 370306 patch Clearing flags on attachment: 370306 Committed r245587: <https://trac.webkit.org/changeset/245587> 1537924 4 commit-queue 2019-05-21 10:57:52 -0700 All reviewed patches have been landed. Closing bug. 1537926 5 webkit-bug-importer 2019-05-21 11:00:38 -0700 <rdar://problem/50991894> 370306 2019-05-21 02:54:40 -0700 2019-05-21 10:57:50 -0700 patch bug-198069-20190521115438.patch text/plain 1345 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEyZWM1YTdiYjczYjkwNjgx ZjRhZDFlYjBiNzc3NGJhZGMwNmZjNTkuLjQ1ZDRlMjE5MzNiZjYyZmQ3YTliMDE4ZmE2MDIxNjhh OGRjNDc4YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDUtMjEgIFBhYmxvIFNh YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgVW5kZWZpbmVkIHJlZmVy ZW5jZSBwbGF0Zm9ybUNsb3NlRnJvbnRlbmRQYWdlQW5kV2luZG93KCkgbGlua2luZyBhZ2FpbnN0 IGxpYldQRVdlYktpdC0xLjAuc28gYWZ0ZXIgcjI0NTUzNgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MDY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvUmVtb3RlV2ViSW5zcGVjdG9y UHJveHkuY3BwOgorCiAyMDE5LTA1LTIwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2ZXJ0IHIyNDU1MDEKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZVdlYkluc3BlY3RvclByb3h5LmNwcCBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1JlbW90ZVdlYkluc3BlY3RvclByb3h5LmNwcAppbmRleCA5NTQwOThi MGY1ZmIyMGM0OTdkZDQ2OTgzMmYwOWZjZjAwYWRkODc1Li42Njc5ZDQ1YmQ5OTY5MjA0YWZjZjVi YjJmNGU5YTQ4ZTYxNjQzODlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9S ZW1vdGVXZWJJbnNwZWN0b3JQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv UmVtb3RlV2ViSW5zcGVjdG9yUHJveHkuY3BwCkBAIC0xNzAsNyArMTcwLDcgQEAgdm9pZCBSZW1v dGVXZWJJbnNwZWN0b3JQcm94eTo6Y2xvc2VGcm9udGVuZFBhZ2VBbmRXaW5kb3coKQogICAgIHBs YXRmb3JtQ2xvc2VGcm9udGVuZFBhZ2VBbmRXaW5kb3coKTsKIH0KIAotI2lmICFFTkFCTEUoUkVN T1RFX0lOU1BFQ1RPUikgJiYgIVBMQVRGT1JNKE1BQykKKyNpZiAoIUVOQUJMRShSRU1PVEVfSU5T UEVDVE9SKSAmJiAhUExBVEZPUk0oTUFDKSkgfHwgUExBVEZPUk0oV1BFKQogV2ViUGFnZVByb3h5 KiBSZW1vdGVXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DcmVhdGVGcm9udGVuZFBhZ2VBbmRX aW5kb3coKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7Cg==