198055 2019-05-20 15:40:52 -0700 [Meta][WinCairo] Enable WebDriver 2024-02-15 13:51:52 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 269315 1 don.olmstead webkit-unassigned bburg fujii haruhisa.shin webkit-bug-importer oldest_to_newest 1537710 0 don.olmstead 2019-05-20 15:40:52 -0700 WebDriver support is nice to have. 2010599 1 haruhisa.shin 2024-02-05 01:31:25 -0800 Pull request: https://github.com/WebKit/WebKit/pull/23847 2013065 2 ews-feeder 2024-02-13 00:11:13 -0800 Committed 274530@main (db706f64b581): <https://commits.webkit.org/274530@main> Reviewed commits have been landed. Closing PR #23847 and removing active labels. 2013066 3 webkit-bug-importer 2024-02-13 00:12:14 -0800 <rdar://problem/122855467> 2013259 4 fujii 2024-02-13 12:30:59 -0800 Debug build is crashing. I'm going to revert. PTAL. Buildbot: builder WinCairo-64-bit-Debug-Tests build 21837 : 274532@main https://build.webkit.org/#/builders/727/builds/21837 ASSERTION FAILED: (m_client && !client) || (!m_client && client) C:\BW\WinCairo-64-bit-Debug-Build\build\Source\JavaScriptCore\inspector/remote/RemoteInspector.cpp(166) : setClient 1 00007FF8F5DD1CA9 WTFCrash 2 00007FF8E80E383D WTFCrashWithInfo 3 00007FF8E90F17DD Inspector::RemoteInspector::setClient 4 00007FF8EA6213B2 WebKit::AutomationClient::AutomationClient 5 00007FF8EA6342D7 std::make_unique<WebKit::AutomationClient,WebKit::WebProcessPool &,0> 6 00007FF8EA632EB0 WTF::makeUnique<WebKit::AutomationClient,WebKit::WebProcessPool &> 7 00007FF8EA6328CF WebKit::WebProcessPool::platformInitialize 8 00007FF8EB6F4108 WebKit::WebProcessPool::WebProcessPool 9 00007FF8EB6F36DC WebKit::WebProcessPool::create 10 00007FF8EB87BC10 WKContextCreateWithConfiguration 11 00007FF64CA1F65D WTR::TestController::generatePageConfiguration 12 00007FF64CA20806 WTR::TestController::createWebViewWithOptions 13 00007FF64CA21520 WTR::TestController::ensureViewSupportsOptionsForTest 14 00007FF64CA24052 WTR::TestController::configureViewForTest 15 00007FF64CA78C4A WTR::TestInvocation::invoke 16 00007FF64CA24378 WTR::TestController::runTest 17 00007FF64CA2462E WTR::TestController::runTestingServerLoop 18 00007FF64CA1D1D7 WTR::TestController::run 19 00007FF64CA1CDCA WTR::TestController::TestController 20 00007FF64CAA8F8D main 21 00007FF64CE8F674 __scrt_common_main_seh 22 00007FF904EF4DE0 BaseThreadInitThunk 23 00007FF91541EC4B RtlUserThreadStart 2013379 5 haruhisa.shin 2024-02-13 17:42:14 -0800 (In reply to Fujii Hironori from comment #4) > Debug build is crashing. I'm going to revert. PTAL. > > Buildbot: builder WinCairo-64-bit-Debug-Tests build 21837 : 274532@main > https://build.webkit.org/#/builders/727/builds/21837 > > ASSERTION FAILED: (m_client && !client) || (!m_client && client) > C:\BW\WinCairo-64-bit-Debug-Build\build\Source\JavaScriptCore\inspector/ > remote/RemoteInspector.cpp(166) : setClient > 1 00007FF8F5DD1CA9 WTFCrash > 2 00007FF8E80E383D WTFCrashWithInfo > 3 00007FF8E90F17DD Inspector::RemoteInspector::setClient > 4 00007FF8EA6213B2 WebKit::AutomationClient::AutomationClient > 5 00007FF8EA6342D7 > std::make_unique<WebKit::AutomationClient,WebKit::WebProcessPool &,0> > 6 00007FF8EA632EB0 > WTF::makeUnique<WebKit::AutomationClient,WebKit::WebProcessPool &> > 7 00007FF8EA6328CF WebKit::WebProcessPool::platformInitialize > 8 00007FF8EB6F4108 WebKit::WebProcessPool::WebProcessPool > 9 00007FF8EB6F36DC WebKit::WebProcessPool::create > 10 00007FF8EB87BC10 WKContextCreateWithConfiguration > 11 00007FF64CA1F65D WTR::TestController::generatePageConfiguration > 12 00007FF64CA20806 WTR::TestController::createWebViewWithOptions > 13 00007FF64CA21520 WTR::TestController::ensureViewSupportsOptionsForTest > 14 00007FF64CA24052 WTR::TestController::configureViewForTest > 15 00007FF64CA78C4A WTR::TestInvocation::invoke > 16 00007FF64CA24378 WTR::TestController::runTest > 17 00007FF64CA2462E WTR::TestController::runTestingServerLoop > 18 00007FF64CA1D1D7 WTR::TestController::run > 19 00007FF64CA1CDCA WTR::TestController::TestController > 20 00007FF64CAA8F8D main > 21 00007FF64CE8F674 __scrt_common_main_seh > 22 00007FF904EF4DE0 BaseThreadInitThunk > 23 00007FF91541EC4B RtlUserThreadStart Thank you for the information. I will confirm today. 2013857 6 haruhisa.shin 2024-02-15 01:19:07 -0800 The socket port implementation can only hold one JSC::RemoteInspector::Client. However, when two or more WebContext(WebProcessPool) were created, each would attempt to set the JSC::RemoteInspector::Client, resulting in the above assertion. One test before "animation/cross-fade-background-image.html" is "animation/crash-on-removing-animation.html". This test caused WTR to restart, which generated a second WebContext, thus causing the above assertion. Also, when "New Window" was executed in MiniBrowser, multiple WebContxts were created and the same assertion occurred. To fix this problem, in the WebProessPool::platformInitialize(), do not create a new AutomationClient if JSC::RemoteInspector::Client is already set. This means that only the first generated WebContext can be manipulated by WebDriver. 2013858 7 haruhisa.shin 2024-02-15 01:22:15 -0800 Pull request: https://github.com/WebKit/WebKit/pull/24495 2014125 8 ews-feeder 2024-02-15 13:51:50 -0800 Committed 274762@main (b09419cb34e8): <https://commits.webkit.org/274762@main> Reviewed commits have been landed. Closing PR #24495 and removing active labels.