198035 2019-05-20 02:29:32 -0700 Fix 32-bit bytecode cache crashes 2019-05-20 23:31:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff rmorisset saam webkit-bug-importer ysuzuki oldest_to_newest 1537552 0 tzagallo 2019-05-20 02:29:32 -0700 ... 1537555 1 370247 tzagallo 2019-05-20 02:35:11 -0700 Created attachment 370247 Patch 1537556 2 tzagallo 2019-05-20 02:40:25 -0700 <rdar://problem/49905560> 1537736 3 370247 msaboff 2019-05-20 16:26:33 -0700 Comment on attachment 370247 Patch r=me 1537818 4 370247 commit-queue 2019-05-20 23:31:12 -0700 Comment on attachment 370247 Patch Clearing flags on attachment: 370247 Committed r245563: <https://trac.webkit.org/changeset/245563> 1537819 5 commit-queue 2019-05-20 23:31:14 -0700 All reviewed patches have been landed. Closing bug. 370247 2019-05-20 02:35:11 -0700 2019-05-20 23:31:12 -0700 Patch bug-198035-20190520113510.patch text/plain 4468 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1Mzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YjRkYTQ3MmUwY2U5OTNjMTU0MTkzZjliOGZlZTQwNDRlNzk2ZTU5Li5kOGU2OGU3NWI4YjQ1ZjAx NTNlODZjYjY2MGNjM2FhMjRiNWE0YWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxOS0wNS0yMCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggMzItYml0IGJ0eWVjb2RlIGNhY2hlIGNyYXNoZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODAzNQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNDk5MDU1NjA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlcmUgd2VyZSAyIDMyLWJpdCBpc3N1ZXMgd2l0aCB0aGUgYnl0 ZWNvZGUgY2FjaGU6CisgICAgICAgIC0gVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGU6Om1fY2Fj aGVkQ29kZUJsb2NrRm9yQ29uc3RydWN0T2Zmc2V0IHdhcyBub3QgaW5pdGlhbGl6ZWQuCisgICAg ICAgICAgVGhlIGNvZGUgd2FzIHJlbHlpbmcgb24gdGhlIG90aGVyIG1lbWJlciBvZiB0aGUgdW5p b24sIGBtX3VubGlua2VkQ29kZUJsb2NrRm9yQ29uc3RydWN0YCwKKyAgICAgICAgICBpbml0aWFs aXppbmcgYm90aCBtX2NhY2hlZENvZGVCbG9ja0ZvckNhbGxPZmZzZXQgYW5kIG1fY2FjaGVkQ29k ZUJsb2NrRm9yQ29uc3RydWN0T2Zmc2V0LgorICAgICAgICAgIFRoaXMgaXMgdW5kZWZpbmVkIGJl aGF2aW9yIGFuZCBpcyBhbHNvIGluY29ycmVjdCBpbiAzMi1iaXQuIFNpbmNlIG1fdW5saW5rZWRD b2RlQmxvY2tGb3JDb25zdHJ1Y3QKKyAgICAgICAgICBpcyAzMi1iaXQsIGl0IG9ubHkgaW5pdGlh bGl6ZXMgdGhlIGZpcnN0IG1lbWJlciBvZiB0aGUgc3RydWN0LgorICAgICAgICAtIEVuY29kZXI6 OlBhZ2Ugd2FzIG5vdCBhbGlnbmVkIGF0IHRoZSBlbmQuIFRoaXMgbGVhZCB0byB1bmFsaWduZWQg YWxsb2NhdGlvbnMgb24gc3Vic2VxdWVudAorICAgICAgICAgIHBhZ2VzLCBzaW5jZSB0aGUgc3Rh cnQgb2YgdGhlIGZvbGxvd2luZyBwYWdlIHdvdWxkIG5vdCBiZSBhbGlnbmVkLgorCisgICAgICAg ICogcnVudGltZS9DYWNoZWRUeXBlcy5jcHA6CisgICAgICAgIChKU0M6OkVuY29kZXI6OnJlbGVh c2UpOgorICAgICAgICAoSlNDOjpFbmNvZGVyOjpQYWdlOjphbGlnbkVuZCk6CisgICAgICAgIChK U0M6OkVuY29kZXI6OmFsbG9jYXRlTmV3UGFnZSk6CisgICAgICAgIChKU0M6OlZhcmlhYmxlTGVu Z3RoT2JqZWN0OjpidWZmZXIgY29uc3QpOgorICAgICAgICAoSlNDOjpWYXJpYWJsZUxlbmd0aE9i amVjdDo6YWxsb2NhdGUpOgorICAgICAgICAoSlNDOjpVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJs ZTo6VW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUpOgorCiAyMDE5LTA1LTE1ICBTYWFtIEJhcmF0 aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEJvdW5kIGxpdmVuZXNzIG9mIFNldEFy Z3VtZW50TWF5YmUgbm9kZXMgd2hlbiBtYXhpbWFsIGZsdXNoIGluc2VydGlvbiBwaGFzZSBpcyBl bmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRU eXBlcy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAK aW5kZXggM2I2MTBhOGQ3Nzc4YTdkN2I4MWJhMGJlNmMxMzdhNGJkNzYzNmEzZC4uMjllMjFjOGQ0 MDc4NTI5OWVmMzhhNmM1MTZmYjVjMDFhNTVkOGQ3MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNwcApAQCAtMTQ2LDYgKzE0NiwxMCBAQCBwdWJsaWM6 CiAKICAgICBSZWY8Q2FjaGVkQnl0ZWNvZGU+IHJlbGVhc2UoKQogICAgIHsKKyAgICAgICAgaWYg KCFtX2N1cnJlbnRQYWdlKQorICAgICAgICAgICAgcmV0dXJuIENhY2hlZEJ5dGVjb2RlOjpjcmVh dGUoKTsKKworICAgICAgICBtX2N1cnJlbnRQYWdlLT5hbGlnbkVuZCgpOwogICAgICAgICBzaXpl X3Qgc2l6ZSA9IG1fYmFzZU9mZnNldCArIG1fY3VycmVudFBhZ2UtPnNpemUoKTsKICAgICAgICAg TWFsbG9jUHRyPHVpbnQ4X3Q+IGJ1ZmZlciA9IE1hbGxvY1B0cjx1aW50OF90Pjo6bWFsbG9jKHNp emUpOwogICAgICAgICB1bnNpZ25lZCBvZmZzZXQgPSAwOwpAQCAtMTkzLDYgKzE5NywxNSBAQCBw cml2YXRlOgogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAKKyAgICAgICAg dm9pZCBhbGlnbkVuZCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHB0cmRpZmZfdCBzaXplID0g cm91bmRVcFRvTXVsdGlwbGVPZihhbGlnbm9mKHN0ZDo6bWF4X2FsaWduX3QpLCBtX29mZnNldCk7 CisgICAgICAgICAgICBpZiAoc2l6ZSA9PSBtX29mZnNldCkKKyAgICAgICAgICAgICAgICByZXR1 cm47CisgICAgICAgICAgICBBU1NFUlQoc3RhdGljX2Nhc3Q8c2l6ZV90PihzaXplKSA8PSBtX2Nh cGFjaXR5KTsKKyAgICAgICAgICAgIG1fb2Zmc2V0ID0gc2l6ZTsKKyAgICAgICAgfQorCiAgICAg cHJpdmF0ZToKICAgICAgICAgTWFsbG9jUHRyPHVpbnQ4X3Q+IG1fYnVmZmVyOwogICAgICAgICBw dHJkaWZmX3QgbV9vZmZzZXQ7CkBAIC0yMDIsOCArMjE1LDEwIEBAIHByaXZhdGU6CiAgICAgdm9p ZCBhbGxvY2F0ZU5ld1BhZ2Uoc2l6ZV90IHNpemUgPSAwKQogICAgIHsKICAgICAgICAgc3RhdGlj IHNpemVfdCBtaW5QYWdlU2l6ZSA9IHBhZ2VTaXplKCk7Ci0gICAgICAgIGlmIChtX2N1cnJlbnRQ YWdlKQorICAgICAgICBpZiAobV9jdXJyZW50UGFnZSkgeworICAgICAgICAgICAgbV9jdXJyZW50 UGFnZS0+YWxpZ25FbmQoKTsKICAgICAgICAgICAgIG1fYmFzZU9mZnNldCArPSBtX2N1cnJlbnRQ YWdlLT5zaXplKCk7CisgICAgICAgIH0KICAgICAgICAgaWYgKHNpemUgPCBtaW5QYWdlU2l6ZSkK ICAgICAgICAgICAgIHNpemUgPSBtaW5QYWdlU2l6ZTsKICAgICAgICAgZWxzZQpAQCAtMzgzLDYg KzM5OCw3IEBAIHByb3RlY3RlZDoKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogICAgIGNvbnN0 IFQqIGJ1ZmZlcigpIGNvbnN0CiAgICAgeworICAgICAgICBBU1NFUlQoIShiaXR3aXNlX2Nhc3Q8 dWludHB0cl90PihidWZmZXIoKSkgJSBhbGlnbm9mKFQpKSk7CiAgICAgICAgIHJldHVybiBiaXR3 aXNlX2Nhc3Q8Y29uc3QgVCo+KGJ1ZmZlcigpKTsKICAgICB9CiAKQEAgLTQwMyw2ICs0MTksNyBA QCBwcm90ZWN0ZWQ6CiAgICAgVCogYWxsb2NhdGUoRW5jb2RlciYgZW5jb2RlciwgdW5zaWduZWQg c2l6ZSA9IDEpCiAgICAgewogICAgICAgICB1aW50OF90KiByZXN1bHQgPSBhbGxvY2F0ZShlbmNv ZGVyLCBzaXplb2YoVCkgKiBzaXplKTsKKyAgICAgICAgQVNTRVJUKCEoYml0d2lzZV9jYXN0PHVp bnRwdHJfdD4ocmVzdWx0KSAlIGFsaWdub2YoVCkpKTsKICAgICAgICAgcmV0dXJuIG5ldyAocmVz dWx0KSBUW3NpemVdOwogICAgIH0KIApAQCAtMjEwMCw4ICsyMTE3LDExIEBAIEFMV0FZU19JTkxJ TkUgVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGU6OlVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxl KERlY29kZXImIGRlCiAgICAgICAgICAgICAgICAgY29kZUJsb2NrT2Zmc2V0ID0gb2Zmc2V0Owog ICAgICAgICAgICAgICAgIG1faXNDYWNoZWQgPSB0cnVlOwogICAgICAgICAgICAgICAgIGxlYWZF eGVjdXRhYmxlcy0tOworICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KICAg ICAgICAgfQorCisgICAgICAgIGNvZGVCbG9ja09mZnNldCA9IDA7CiAgICAgfTsKIAogICAgIGlm ICghY2FjaGVkRXhlY3V0YWJsZS51bmxpbmtlZENvZGVCbG9ja0ZvckNhbGwoKS5pc0VtcHR5KCkg fHwgIWNhY2hlZEV4ZWN1dGFibGUudW5saW5rZWRDb2RlQmxvY2tGb3JDb25zdHJ1Y3QoKS5pc0Vt cHR5KCkpIHsKQEAgLTIxMDksNiArMjEyOSw4IEBAIEFMV0FZU19JTkxJTkUgVW5saW5rZWRGdW5j dGlvbkV4ZWN1dGFibGU6OlVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlKERlY29kZXImIGRlCiAg ICAgICAgIGNoZWNrQm91bmRzKG1fY2FjaGVkQ29kZUJsb2NrRm9yQ29uc3RydWN0T2Zmc2V0LCBj YWNoZWRFeGVjdXRhYmxlLnVubGlua2VkQ29kZUJsb2NrRm9yQ29uc3RydWN0KCkpOwogICAgICAg ICBpZiAobV9pc0NhY2hlZCkKICAgICAgICAgICAgIG1fZGVjb2RlciA9ICZkZWNvZGVyOworICAg ICAgICBlbHNlCisgICAgICAgICAgICBtX2RlY29kZXIgPSBudWxscHRyOwogICAgIH0KIAogICAg IGlmIChsZWFmRXhlY3V0YWJsZXMpCg==