198031 2019-05-19 23:11:08 -0700 Add a mach-lookup for 'AGXCompilerService' 2019-05-20 10:43:01 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zhifei_fang webkit-unassigned ap bfulgham commit-queue dino ews-feeder mjs pvollan webkit-bug-importer zhifei_fang oldest_to_newest 1537528 0 zhifei_fang 2019-05-19 23:11:08 -0700 <rdar://problem/50552974> 1537529 1 370240 zhifei_fang 2019-05-19 23:20:42 -0700 Created attachment 370240 Patch 1537545 2 mjs 2019-05-20 02:03:13 -0700 Looks good to me but perhaps Brent or Per Arne should look at it as well. 1537570 3 370240 pvollan 2019-05-20 07:12:00 -0700 Comment on attachment 370240 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370240&action=review R=me. > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-402 > (deny mach-lookup > - (global-name "com.apple.AGXCompilerService") Do you need to explicitly allow it, or is it enough to remove it from the deny list? 1537615 4 370240 ews-feeder 2019-05-20 10:34:56 -0700 Comment on attachment 370240 Patch Rejecting attachment 370240 from commit-queue. zhifei_fang@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1537618 5 370240 commit-queue 2019-05-20 10:41:21 -0700 Comment on attachment 370240 Patch Clearing flags on attachment: 370240 Committed r245520: <https://trac.webkit.org/changeset/245520> 1537619 6 commit-queue 2019-05-20 10:41:23 -0700 All reviewed patches have been landed. Closing bug. 1537620 7 webkit-bug-importer 2019-05-20 10:43:01 -0700 <rdar://problem/50951531> 370240 2019-05-19 23:20:42 -0700 2019-05-20 10:41:21 -0700 Patch bug-198031-20190519232041.patch text/plain 1576 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU5ZjY2OWY5N2NjYmYwOWFi MWVlMmE3YWU5OGY3ZjUxNzk0NzlhYmIuLjYwMjAwNmYyMGI5MjMxNzdhYjMzZjQzZjE2MzM4MTFk YThkZjUwZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDUtMTkgIFpoaWZlaSBG YW5nICA8emhpZmVpX2ZhbmdAYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IFdlYkNvbnRlbnQg bWFjaC1sb29rdXAgQUdYQ29tcGlsZXJTZXJ2aWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgwMzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUw NTUyOTc0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250 ZW50LnNiOgorCiAyMDE5LTA1LTE5ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+ CiAKICAgICAgICAgW1BvaW50ZXIgRXZlbnRzXSBMaXN0ZW5pbmcgdG8gYSAicG9pbnRlcm92ZXIi LCAicG9pbnRlcmVudGVyIiwgInBvaW50ZXJvdXQiIG9yICJwb2ludGVybGVhdmUiIGV2ZW50IGFs b25lIGRvZXMgbm90IGZpcmUgdGhlIGV2ZW50IG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNv bnRlbnQuc2IgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2Nv bS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgppbmRleCBkMTM1MDBkODBiZTg1MmI0YzNjYjJl ZGUzYjMyNmVmNmE1MzExMzNhLi42OWNmODQwM2VjZWNjOTdkOTdkN2Y5M2UxOTY1YjEwNDgzZTZl ZGQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMv aW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgorKysgYi9Tb3VyY2UvV2ViS2l0L1Jl c291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5z YgpAQCAtMzk5LDcgKzM5OSw2IEBACiA7OyBGSVhNRTogcmVtb3ZlIG92ZXJyaWRkZW4gcnVsZXMg b25jZSB0aGUgZmluYWwgbGlzdCBoYXMgYmVlbgogOzsgZXN0YWJsaXNoZWQsIHNlZSBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzODQwCiAoZGVueSBtYWNoLWxvb2t1 cAotICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLkFHWENvbXBpbGVyU2VydmljZSIpCiAgICAg KGdsb2JhbC1uYW1lICJjb20uYXBwbGUuQ29yZUF1dGhlbnRpY2F0aW9uLmRhZW1vbi5saWJ4cGMi KQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLkZpbGVDb29yZGluYXRpb24iKQogICAgIChn bG9iYWwtbmFtZSAiY29tLmFwcGxlLkZpbGVQcm92aWRlciIpCg==