198004 2019-05-17 15:01:20 -0700 Web Inspector: Storage tab crashes easily when adding new local/session storage entries. 2019-05-20 13:46:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 198003 1 ross.kirsling hi commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1537274 0 ross.kirsling 2019-05-17 15:01:20 -0700 (Evidently somebody noticed this a year ago on our end but it never got reported upstream... :sad_panda:) Steps: 1. Open Storage tab 2. Double-click an empty row 3. Enter text for key 4. Press tab 5. Enter text for value 6. Press tab Result: > TypeError:​ undefined is not an object (evaluating 'this._editingNode._element.children')​ (at DataGrid.js:​523:​49)​ > _startEditingNodeAtColumnIndex @ DataGrid.js:​523:​49 > moveToNextCell @ DataGrid.js:​596:​52 > _editingCommitted @ DataGrid.js:​606:​28 > _editingCommitted @ [native code]​ > editingCommitted @ EditingSupport.js:​197:​26 > blurEventListener @ EditingSupport.js:​143:​30 Notes: - After step 4, the text for the key disappears. - If you press enter instead of tab in step 6, the crash does not occur and the text for the key re-appears, but now the text for the value disappears. 1537673 1 370268 hi 2019-05-20 13:05:14 -0700 Created attachment 370268 Patch 1537678 2 370268 ross.kirsling 2019-05-20 13:18:56 -0700 Comment on attachment 370268 Patch Woohoo! r=me 1537685 3 370268 commit-queue 2019-05-20 13:45:28 -0700 Comment on attachment 370268 Patch Clearing flags on attachment: 370268 Committed r245535: <https://trac.webkit.org/changeset/245535> 1537686 4 commit-queue 2019-05-20 13:45:29 -0700 All reviewed patches have been landed. Closing bug. 1537687 5 webkit-bug-importer 2019-05-20 13:46:19 -0700 <rdar://problem/50958823> 370268 2019-05-20 13:05:14 -0700 2019-05-20 13:45:28 -0700 Patch bug-198004-20190520130513.patch text/plain 3828 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ3NmVmYjY0MzBjZDBlMmM0MjVlNjYxOGY3ZjMx N2I5NWIyN2UzZTYuLjE5N2IxNzA1MjEwMDEyOThiZjU2NDZmNjA0OTJjYzkyODU5NWFhYWYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTA1LTIwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT dG9yYWdlIHRhYiBjcmFzaGVzIGVhc2lseSB3aGVuIGFkZGluZyBuZXcgbG9jYWwvc2Vzc2lvbiBz dG9yYWdlIGVudHJpZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTgwMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanM6CisgICAgICAgIChXSS5E YXRhR3JpZC5wcm90b3R5cGUuX3N0YXJ0RWRpdGluZ05vZGVBdENvbHVtbkluZGV4KToKKyAgICAg ICAgRm9yY2UgYSBsYXlvdXQgaW4gdGhlIGNhc2UgdGhhdCBhIG5ldyBgUGxhY2Vob2xkZXJEYXRh R3JpZE5vZGVgIHdhcyBhZGRlZCB0byB0aGUgZW5kIG9mIHRoZQorICAgICAgICBgRGF0YUdyaWRg IGFzIHBhcnQgb2YgdGhlIGBlZGl0Q2FsbGJhY2tgLiBXZWIgSW5zcGVjdG9yIHdvbid0IGNyYXNo IHdpdGhvdXQgdGhpcywgYnV0IGl0CisgICAgICAgIHdvbid0IHByb3Blcmx5IHNlbGVjdC9mb2N1 cyB0aGUgbmV4dCByb3cgd2hlbiB0YWJiaW5nIGZyb20gdGhlIGxhc3QgY29sdW1uIHRvIHRoZSBu ZXh0IHJvdy4KKworICAgICAgICAoV0kuRGF0YUdyaWQucHJvdG90eXBlLl9lZGl0aW5nQ29tbWl0 dGVkKToKKyAgICAgICAgU2F2ZSB0aGUgbmV3IHZhbHVlIG9mIHRoZSBjb2x1bW4gYmVmb3JlIHJl bW92aW5nIHRoZSBlZGl0aW5nIHN0eWxlcywgYXMgdGhhdCByZWZyZXNoZXMgdGhlCisgICAgICAg IGBEYXRhR3JpZE5vZGVgLiBJZiB0aGUgbmV3IHZhbHVlIGlzbid0IHNhdmVkLCB0aGUgb2xkIHZh bHVlIGlzIHVzZWQgZHVyaW5nIHRoZSByZWZyZXNoLgorCisgICAgICAgIChXSS5EYXRhR3JpZC5w cm90b3R5cGUuX2tleURvd24pOgorICAgICAgICBEcml2ZS1ieTogdXNlIGBnZXQgZWxlbWVudGAg aW5zdGVhZCBvZiB1c2luZyB0aGUgbWVtYmVyIHZhcmlhYmxlIGRpcmVjdGx5LCBhcyB0aGUgdW5k ZXJseWluZworICAgICAgICB2YWx1ZSBtaWdodCBub3QgaGF2ZSBiZWVuIGluaXRpYWxpemVkIHll dC4KKwogMjAxOS0wNS0xNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVzOiBDUFUvbWVtb3J5IHRpbWVsaW5lIGJhcnMg c29tZXRpbWVzIGRvbid0IGRyYXcgY29ycmVjdGx5IGFuZCBqdW1wIGFyb3VuZCBvbiBzY3JvbGxp bmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RGF0YUdyaWQuanMKaW5kZXggMThjNTA0YzhiNmUwMjc4ZGY5OWIxY2YyZjExNGViMjIyMmI4ODdh ZC4uZmIxNmZkZTAwOWMxMWQxMDMwYTE3YzAzYjI2ZmJmMGQ0NmYwMzI3MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMK QEAgLTUxNiwxMSArNTE2LDEzIEBAIFdJLkRhdGFHcmlkID0gY2xhc3MgRGF0YUdyaWQgZXh0ZW5k cyBXSS5WaWV3CiAgICAgewogICAgICAgICBjb25zb2xlLmFzc2VydChub2RlLCAiSW52YWxpZCBh cmd1bWVudDogbXVzdCBwcm92aWRlIERhdGFHcmlkTm9kZSB0byBlZGl0LiIpOwogCisgICAgICAg IHRoaXMudXBkYXRlTGF5b3V0SWZOZWVkZWQoKTsKKwogICAgICAgICB0aGlzLl9lZGl0aW5nID0g dHJ1ZTsKICAgICAgICAgdGhpcy5fZWRpdGluZ05vZGUgPSBub2RlOwogICAgICAgICB0aGlzLl9l ZGl0aW5nTm9kZS5zZWxlY3QoKTsKIAotICAgICAgICB2YXIgZWxlbWVudCA9IHRoaXMuX2VkaXRp bmdOb2RlLl9lbGVtZW50LmNoaWxkcmVuW2NvbHVtbkluZGV4XTsKKyAgICAgICAgdmFyIGVsZW1l bnQgPSB0aGlzLl9lZGl0aW5nTm9kZS5lbGVtZW50LmNoaWxkcmVuW2NvbHVtbkluZGV4XTsKICAg ICAgICAgV0kuc3RhcnRFZGl0aW5nKGVsZW1lbnQsIHRoaXMuX3N0YXJ0RWRpdGluZ0NvbmZpZyhl bGVtZW50KSk7CiAgICAgICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50 KGVsZW1lbnQsIDAsIGVsZW1lbnQsIDEpOwogICAgIH0KQEAgLTU1OSw3ICs1NjEsOSBAQCBXSS5E YXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV0kuVmlldwogICAgICAgICB2YXIgY29s dW1uSW5kZXggPSB0aGlzLm9yZGVyZWRDb2x1bW5zLmluZGV4T2YoY29sdW1uSWRlbnRpZmllcik7 CiAKICAgICAgICAgdmFyIHRleHRCZWZvcmVFZGl0aW5nID0gdGhpcy5fZWRpdGluZ05vZGUuZGF0 YVtjb2x1bW5JZGVudGlmaWVyXSB8fCAiIjsKKwogICAgICAgICB2YXIgY3VycmVudEVkaXRpbmdO b2RlID0gdGhpcy5fZWRpdGluZ05vZGU7CisgICAgICAgIGN1cnJlbnRFZGl0aW5nTm9kZS5kYXRh W2NvbHVtbklkZW50aWZpZXJdID0gbmV3VGV4dC50cmltKCk7CiAKICAgICAgICAgLy8gUmV0dXJu cyBhbiBvYmplY3Qgd2l0aCB0aGUgbmV4dCBub2RlIGFuZCBjb2x1bW4gaW5kZXggdG8gZWRpdCwg YW5kIHdoZXRoZXIgaXQKICAgICAgICAgLy8gaXMgYW4gYXBwcm9wcmlhdGUgdGltZSB0byByZS1z b3J0IHRoZSB0YWJsZSByb3dzLiBXaGVuIGVkaXRpbmcsIHdlIHdhbnQgdG8KQEAgLTU5OCw4ICs2 MDIsNiBAQCBXSS5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV0kuVmlldwogCiAg ICAgICAgIHRoaXMuX2VkaXRpbmdDYW5jZWxsZWQoZWxlbWVudCk7CiAKLSAgICAgICAgLy8gVXBk YXRlIHRhYmxlJ3MgZGF0YSBtb2RlbCwgYW5kIGRlbGVnYXRlIHRvIHRoZSBjYWxsYmFjayB0byB1 cGRhdGUgb3RoZXIgbW9kZWxzLgotICAgICAgICBjdXJyZW50RWRpdGluZ05vZGUuZGF0YVtjb2x1 bW5JZGVudGlmaWVyXSA9IG5ld1RleHQudHJpbSgpOwogICAgICAgICB0aGlzLl9lZGl0Q2FsbGJh Y2soY3VycmVudEVkaXRpbmdOb2RlLCBjb2x1bW5JZGVudGlmaWVyLCB0ZXh0QmVmb3JlRWRpdGlu ZywgbmV3VGV4dCwgbW92ZURpcmVjdGlvbik7CiAKICAgICAgICAgdmFyIHRleHREaWRDaGFuZ2Ug PSB0ZXh0QmVmb3JlRWRpdGluZy50cmltKCkgIT09IG5ld1RleHQudHJpbSgpOwpAQCAtMTM5OSw3 ICsxNDAxLDcgQEAgV0kuRGF0YUdyaWQgPSBjbGFzcyBEYXRhR3JpZCBleHRlbmRzIFdJLlZpZXcK ICAgICAgICAgfSBlbHNlIGlmIChpc0VudGVyS2V5KGV2ZW50KSkgewogICAgICAgICAgICAgaWYg KHRoaXMuX2VkaXRDYWxsYmFjaykgewogICAgICAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOwot ICAgICAgICAgICAgICAgIHRoaXMuX3N0YXJ0RWRpdGluZyh0aGlzLnNlbGVjdGVkTm9kZS5fZWxl bWVudC5jaGlsZHJlblswXSk7CisgICAgICAgICAgICAgICAgdGhpcy5fc3RhcnRFZGl0aW5nKHRo aXMuc2VsZWN0ZWROb2RlLmVsZW1lbnQuY2hpbGRyZW5bMF0pOwogICAgICAgICAgICAgfQogICAg ICAgICB9CiAK