198000 2019-05-17 14:14:12 -0700 [ews-app] Status bubble should not turn orange when any build step has warnings 2019-06-20 14:20:49 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197812 https://bugs.webkit.org/show_bug.cgi?id=199079 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1537250 0 aakash_jain 2019-05-17 14:14:12 -0700 https://bugs.webkit.org/show_bug.cgi?id=197812 added support for status-bubble turning orange when in-progress build has any failed step. However, it also turns orange in case of steps with a warning. warning is common for compile-webkit step. Status bubbles should not turn orange in case of build step with warnings. 1537251 1 370150 aakash_jain 2019-05-17 14:15:37 -0700 Created attachment 370150 Patch 1537322 2 370150 commit-queue 2019-05-17 16:41:53 -0700 Comment on attachment 370150 Patch Clearing flags on attachment: 370150 Committed r245487: <https://trac.webkit.org/changeset/245487> 1537323 3 commit-queue 2019-05-17 16:41:54 -0700 All reviewed patches have been landed. Closing bug. 1537324 4 webkit-bug-importer 2019-05-17 16:42:18 -0700 <rdar://problem/50910655> 370150 2019-05-17 14:15:37 -0700 2019-05-17 16:41:53 -0700 Patch bug-198000-20190517171536.patch text/plain 1288 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NTQ3NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA1LTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gU3RhdHVzIGJ1YmJsZSBzaG91bGQgbm90IHR1cm4gb3Jh bmdlIHdoZW4gYW55IGJ1aWxkIHN0ZXAgaGFzIHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgwMDAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAv ZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weToKKyAgICAgICAgKFN0YXR1c0J1YmJsZS5fZG9lc19i dWlsZF9jb250YWluc19hbnlfZmFpbGVkX3N0ZXApOgorCiAyMDE5LTA1LTE3ICBLZWl0aCBSb2xs aW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4K SW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1 YmJsZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3 cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHJldmlzaW9uIDI0NTQ3NikKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQkod29ya2luZyBj b3B5KQpAQCAtMTU1LDcgKzE1NSw3IEBAIGNsYXNzIFN0YXR1c0J1YmJsZShWaWV3KToKIAogICAg IGRlZiBfZG9lc19idWlsZF9jb250YWluc19hbnlfZmFpbGVkX3N0ZXAoc2VsZiwgYnVpbGQpOgog ICAgICAgICBmb3Igc3RlcCBpbiBidWlsZC5zdGVwX3NldC5hbGwoKToKLSAgICAgICAgICAgIGlm IHN0ZXAucmVzdWx0IGFuZCBzdGVwLnJlc3VsdCAhPSBCdWlsZGJvdC5TVUNDRVNTOgorICAgICAg ICAgICAgaWYgc3RlcC5yZXN1bHQgYW5kIHN0ZXAucmVzdWx0ICE9IEJ1aWxkYm90LlNVQ0NFU1Mg YW5kIHN0ZXAucmVzdWx0ICE9IEJ1aWxkYm90LldBUk5JTkdTOgogICAgICAgICAgICAgICAgIHJl dHVybiBUcnVlCiAgICAgICAgIHJldHVybiBGYWxzZQogCg==