197996 2019-05-17 13:27:39 -0700 [ews-build] Add clickable url in UI for uploaded S3 archive 2019-05-17 16:47:04 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1537215 0 aakash_jain 2019-05-17 13:27:39 -0700 We started uploading archives to S3 since https://bugs.webkit.org/show_bug.cgi?id=197922. It would be nice to have a clickable link in the UI for the archive URL. 1537243 1 370148 aakash_jain 2019-05-17 14:01:29 -0700 Created attachment 370148 Patch 1537245 2 aakash_jain 2019-05-17 14:03:01 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/39/builds/542 1537246 3 ews-watchlist 2019-05-17 14:04:32 -0700 Attachment 370148 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:793: [TransferToS3.start] Use of super on an old style class [pylint/E1002] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1537249 4 370148 jbedard 2019-05-17 14:12:06 -0700 Comment on attachment 370148 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370148&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:800 > + match = re.search(r'S3 URL: (?P<url>[^\s]+)', log_text) Can we have a comment here with an example of the line we're mapping? 1537258 5 370153 aakash_jain 2019-05-17 14:34:28 -0700 Created attachment 370153 Patch 1537260 6 aakash_jain 2019-05-17 14:35:35 -0700 > Can we have a comment here with an example of the line we're mapping? Added 1537263 7 ews-watchlist 2019-05-17 14:37:36 -0700 Attachment 370153 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:793: [TransferToS3.start] Use of super on an old style class [pylint/E1002] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1537328 8 370153 commit-queue 2019-05-17 16:45:44 -0700 Comment on attachment 370153 Patch Clearing flags on attachment: 370153 Committed r245489: <https://trac.webkit.org/changeset/245489> 1537329 9 commit-queue 2019-05-17 16:45:46 -0700 All reviewed patches have been landed. Closing bug. 1537331 10 webkit-bug-importer 2019-05-17 16:47:04 -0700 <rdar://problem/50910773> 370148 2019-05-17 14:01:29 -0700 2019-05-17 14:34:25 -0700 Patch bug-197996-20190517170126.patch text/plain 1550 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NTQ3NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA1LTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgY2xpY2thYmxlIHVybCBpbiBVSSBmb3IgdXBs b2FkZWQgUzMgYXJjaGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk3OTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisKIDIwMTkt MDUtMTcgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQgYnVpbGQgZml4LgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWls ZC9zdGVwcy5weQkocmV2aXNpb24gMjQ1NDc2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03OTAsNyArNzkwLDE3IEBAIGNs YXNzIFRyYW5zZmVyVG9TMyhtYXN0ZXIuTWFzdGVyU2hlbGxDb20KICAgICAgICAga3dhcmdzWydj b21tYW5kJ10gPSBzZWxmLmNvbW1hbmQKICAgICAgICAgbWFzdGVyLk1hc3RlclNoZWxsQ29tbWFu ZC5fX2luaXRfXyhzZWxmLCBsb2dFbnZpcm9uPUZhbHNlLCAqKmt3YXJncykKIAorICAgIGRlZiBz dGFydChzZWxmKToKKyAgICAgICAgc2VsZi5sb2dfb2JzZXJ2ZXIgPSBsb2dvYnNlcnZlci5CdWZm ZXJMb2dPYnNlcnZlcih3YW50U3RkZXJyPVRydWUpCisgICAgICAgIHNlbGYuYWRkTG9nT2JzZXJ2 ZXIoJ3N0ZGlvJywgc2VsZi5sb2dfb2JzZXJ2ZXIpCisgICAgICAgIHJldHVybiBzdXBlcihUcmFu c2ZlclRvUzMsIHNlbGYpLnN0YXJ0KCkKKwogICAgIGRlZiBmaW5pc2hlZChzZWxmLCByZXN1bHRz KToKKyAgICAgICAgbG9nX3RleHQgPSBzZWxmLmxvZ19vYnNlcnZlci5nZXRTdGRvdXQoKSArIHNl bGYubG9nX29ic2VydmVyLmdldFN0ZGVycigpCisgICAgICAgIG1hdGNoID0gcmUuc2VhcmNoKHIn UzMgVVJMOiAoP1A8dXJsPlteXHNdKyknLCBsb2dfdGV4dCkKKyAgICAgICAgaWYgbWF0Y2g6Cisg ICAgICAgICAgICBzZWxmLmFkZFVSTCgndXBsb2FkZWQgYXJjaGl2ZScsIG1hdGNoLmdyb3VwKCd1 cmwnKSkKKwogICAgICAgICBpZiByZXN1bHRzID09IFNVQ0NFU1M6CiAgICAgICAgICAgICB0cmln Z2VycyA9IHNlbGYuZ2V0UHJvcGVydHkoJ3RyaWdnZXJzJywgTm9uZSkKICAgICAgICAgICAgIGlm IHRyaWdnZXJzOgo= 370153 2019-05-17 14:34:28 -0700 2019-05-17 16:45:44 -0700 Patch bug-197996-20190517173427.patch text/plain 1684 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NTQ3NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA1LTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgY2xpY2thYmxlIHVybCBpbiBVSSBmb3IgdXBs b2FkZWQgUzMgYXJjaGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk3OTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9uYXRoYW4gQmVkYXJkLgor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorCiAyMDE5 LTA1LTE3ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkIGJ1aWxkIGZpeC4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWls ZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHMucHkJKHJldmlzaW9uIDI0NTQ3NikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtNzkwLDcgKzc5MCwxOCBAQCBj bGFzcyBUcmFuc2ZlclRvUzMobWFzdGVyLk1hc3RlclNoZWxsQ29tCiAgICAgICAgIGt3YXJnc1sn Y29tbWFuZCddID0gc2VsZi5jb21tYW5kCiAgICAgICAgIG1hc3Rlci5NYXN0ZXJTaGVsbENvbW1h bmQuX19pbml0X18oc2VsZiwgbG9nRW52aXJvbj1GYWxzZSwgKiprd2FyZ3MpCiAKKyAgICBkZWYg c3RhcnQoc2VsZik6CisgICAgICAgIHNlbGYubG9nX29ic2VydmVyID0gbG9nb2JzZXJ2ZXIuQnVm ZmVyTG9nT2JzZXJ2ZXIod2FudFN0ZGVycj1UcnVlKQorICAgICAgICBzZWxmLmFkZExvZ09ic2Vy dmVyKCdzdGRpbycsIHNlbGYubG9nX29ic2VydmVyKQorICAgICAgICByZXR1cm4gc3VwZXIoVHJh bnNmZXJUb1MzLCBzZWxmKS5zdGFydCgpCisKICAgICBkZWYgZmluaXNoZWQoc2VsZiwgcmVzdWx0 cyk6CisgICAgICAgIGxvZ190ZXh0ID0gc2VsZi5sb2dfb2JzZXJ2ZXIuZ2V0U3Rkb3V0KCkgKyBz ZWxmLmxvZ19vYnNlcnZlci5nZXRTdGRlcnIoKQorICAgICAgICBtYXRjaCA9IHJlLnNlYXJjaChy J1MzIFVSTDogKD9QPHVybD5bXlxzXSspJywgbG9nX3RleHQpCisgICAgICAgICMgU2FtcGxlIGxv ZzogUzMgVVJMOiBodHRwczovL3MzLXVzLXdlc3QtMi5hbWF6b25hd3MuY29tL2V3cy1hcmNoaXZl cy53ZWJraXQub3JnL2lvcy1zaW11bGF0b3ItMTIteDg2XzY0LXJlbGVhc2UvMTIzNDU2LnppcAor ICAgICAgICBpZiBtYXRjaDoKKyAgICAgICAgICAgIHNlbGYuYWRkVVJMKCd1cGxvYWRlZCBhcmNo aXZlJywgbWF0Y2guZ3JvdXAoJ3VybCcpKQorCiAgICAgICAgIGlmIHJlc3VsdHMgPT0gU1VDQ0VT UzoKICAgICAgICAgICAgIHRyaWdnZXJzID0gc2VsZi5nZXRQcm9wZXJ0eSgndHJpZ2dlcnMnLCBO b25lKQogICAgICAgICAgICAgaWYgdHJpZ2dlcnM6Cg==