197986 2019-05-17 08:23:38 -0700 [GLIB] Repeating timer is not stopped when stop is called from the callback 2019-05-20 01:12:21 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned benjamin bugs-noreply cdumez cmarcelo dbates ews-watchlist mcatanzaro webkit-bug-importer oldest_to_newest 1537113 0 cgarcia 2019-05-17 08:23:38 -0700 In case of repeating timers we always update the ready time to fire interval after the user callback is called. 1537114 1 370118 cgarcia 2019-05-17 08:27:04 -0700 Created attachment 370118 Patch 1537537 2 cgarcia 2019-05-20 01:11:04 -0700 Committed r245512: <https://trac.webkit.org/changeset/245512> 1537538 3 webkit-bug-importer 2019-05-20 01:12:21 -0700 <rdar://problem/50938404> 370118 2019-05-17 08:27:04 -0700 2019-05-17 10:02:30 -0700 Patch wtf-glib-repeating-timer-stop.diff text/plain 2378 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMzNiMGRiMTdlNzQuLjJhMDlkMjc1ZDc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5 LTA1LTE3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAg ICAgICBbR0xJQl0gUmVwZWF0aW5nIHRpbWVyIGlzIG5vdCBzdG9wcGVkIHdoZW4gc3RvcCBpcyBj YWxsZWQgZnJvbSB0aGUgY2FsbGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5Nzk4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEluIGNhc2Ugb2YgcmVwZWF0aW5nIHRpbWVycyB3ZSBhbHdheXMgdXBk YXRlIHRoZSByZWFkeSB0aW1lIHRvIGZpcmUgaW50ZXJ2YWwgYWZ0ZXIgdGhlIHVzZXIgY2FsbGJh Y2sgaXMgY2FsbGVkLgorCisgICAgICAgICogd3RmL2dsaWIvUnVuTG9vcEdMaWIuY3BwOgorICAg ICAgICAoV1RGOjpSdW5Mb29wOjpUaW1lckJhc2U6OnN0b3ApOiBSZXNldCBtX2ZpcmVJbnRlcnZh bCBhbmQgbV9pc1JlcGVhdGluZy4KKwogMjAxOS0wNS0xNiAgS2VpdGggTWlsbGVyICA8a2VpdGhf bWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBXYXNtIHNob3VsZCBjYWdlIHRoZSBtZW1vcnkg YmFzZSBwb2ludGVycyBpbiBzdHJ1Y3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nbGli L1J1bkxvb3BHTGliLmNwcCBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvUnVuTG9vcEdMaWIuY3BwCmlu ZGV4IDcyMGZjOWEyMzk0Li41ZTViYThhYmViZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv Z2xpYi9SdW5Mb29wR0xpYi5jcHAKKysrIGIvU291cmNlL1dURi93dGYvZ2xpYi9SdW5Mb29wR0xp Yi5jcHAKQEAgLTIxNiw2ICsyMTYsOCBAQCB2b2lkIFJ1bkxvb3A6OlRpbWVyQmFzZTo6c3RhcnQo U2Vjb25kcyBmaXJlSW50ZXJ2YWwsIGJvb2wgcmVwZWF0KQogdm9pZCBSdW5Mb29wOjpUaW1lckJh c2U6OnN0b3AoKQogewogICAgIGdfc291cmNlX3NldF9yZWFkeV90aW1lKG1fc291cmNlLmdldCgp LCAtMSk7CisgICAgbV9maXJlSW50ZXJ2YWwgPSB7IH07CisgICAgbV9pc1JlcGVhdGluZyA9IGZh bHNlOwogfQogCiBib29sIFJ1bkxvb3A6OlRpbWVyQmFzZTo6aXNBY3RpdmUoKSBjb25zdApkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDNhZTllZjQx MzdlLi45NmFiOTc4MDBiMiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA1LTE3ICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gUmVwZWF0aW5nIHRp bWVyIGlzIG5vdCBzdG9wcGVkIHdoZW4gc3RvcCBpcyBjYWxsZWQgZnJvbSB0aGUgY2FsbGJhY2sK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Nzk4Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIHRo ZSB0aW1lciBpcyBubyBsb25nZXIgYWN0aXZlIGFmdGVyIGl0IGhhcyBiZWVuIHN0b3BwZWQuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9SdW5Mb29wLmNwcDoKKyAgICAgICAg KFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE5LTA1LTE3ICBBYWthc2ggSmFpbiAgPGFha2Fz aF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgYnVpbGQgc3RlcCB0 byBUcmFuc2ZlciBhcmNoaXZlIHRvIFMzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dURi9SdW5Mb29wLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1J1 bkxvb3AuY3BwCmluZGV4IDkzNTBiMGU2ZmNiLi4yOTBlNWY2ZjA5MCAxMDA2NDQKLS0tIGEvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvUnVuTG9vcC5jcHAKKysrIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XVEYvUnVuTG9vcC5jcHAKQEAgLTExNCw2ICsxMTQsNyBAQCBURVNUKFdU Rl9SdW5Mb29wLCBSZXBlYXRpbmdUaW1lcikKICAgICBEZXJpdmVkUmVwZWF0aW5nVGltZXIgdGlt ZXIodGVzdEZpbmlzaGVkKTsKICAgICB0aW1lci5zdGFydFJlcGVhdGluZygxMF9tcyk7CiAgICAg VXRpbDo6cnVuKCZ0ZXN0RmluaXNoZWQpOworICAgIEFTU0VSVF9GQUxTRSh0aW1lci5pc0FjdGl2 ZSgpKTsKIH0KIAogVEVTVChXVEZfUnVuTG9vcCwgTWFueVRpbWVzKQo=