19798 2008-06-28 03:32:18 -0700 REGRESSION: Masks have several problems in trunk 2008-08-12 14:11:47 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 19799 1 zimmermann zimmermann eric hyatt oliver oldest_to_newest 84648 0 zimmermann 2008-06-28 03:32:18 -0700 All problems covered by existing LayoutTests. Unfortunately, when pixel tests aren't looked at, there is no way anyone could notice :( svg/W3C-SVG-1.1/masking-mask-01-b.svg - masks seem translated svg/custom/mask-inside-defs.svg - broken svg/custom/visibility-override-mask.svg - broken 88281 1 zimmermann 2008-08-11 21:24:41 -0700 Found the culprit: http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm Uploading fix soon. 88297 2 22744 zimmermann 2008-08-12 03:41:51 -0700 Created attachment 22744 Initial patch Would be nice if David could have a look, as one of his refactorings broke SVG <mask> support. 88335 3 22744 hyatt 2008-08-12 13:57:48 -0700 Comment on attachment 22744 Initial patch r=me 88337 4 zimmermann 2008-08-12 14:11:47 -0700 Landed in r35694. 22744 2008-08-12 03:41:51 -0700 2008-08-12 13:57:48 -0700 Initial patch MaskRegressions.diff text/plain 7486 zimmermann SW5kZXg6IFdlYkNvcmUvc3ZnL2dyYXBoaWNzL2NnL1NWR1Jlc291cmNlTWFza2VyQ2cubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9zdmcvZ3JhcGhpY3MvY2cvU1ZHUmVzb3VyY2VNYXNrZXJDZy5t bQkocmV2aXNpb24gMzU2NzgpCisrKyBXZWJDb3JlL3N2Zy9ncmFwaGljcy9jZy9TVkdSZXNvdXJj ZU1hc2tlckNnLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05Niw5ICs5NiwxMCBAQAogewogICAgIGlm ICghbV9tYXNrKQogICAgICAgICBtX21hc2suc2V0KG1fb3duZXJFbGVtZW50LT5kcmF3TWFza2Vy Q29udGVudChib3VuZGluZ0JveCwgbV9tYXNrUmVjdCkucmVsZWFzZSgpKTsKKwogICAgIGlmICgh bV9tYXNrKQogICAgICAgICByZXR1cm47Ci0gICAgCisKICAgICBJbnRTaXplIG1hc2tTaXplKHN0 YXRpY19jYXN0PGludD4obV9tYXNrUmVjdC53aWR0aCgpKSwgc3RhdGljX2Nhc3Q8aW50PihtX21h c2tSZWN0LmhlaWdodCgpKSk7CiAgICAgY2xhbXBJbWFnZUJ1ZmZlclNpemVUb1ZpZXdwb3J0KG1f b3duZXJFbGVtZW50LT5kb2N1bWVudCgpLT5yZW5kZXJlcigpLCBtYXNrU2l6ZSk7CiAKQEAgLTEw Niw3ICsxMDcsNyBAQAogICAgIGF1dG9fcHRyPEltYWdlQnVmZmVyPiBncmF5U2NhbGVJbWFnZShJ bWFnZUJ1ZmZlcjo6Y3JlYXRlKG1hc2tTaXplLCB0cnVlKSk7CiAgICAgaWYgKCFncmF5U2NhbGVJ bWFnZS5nZXQoKSkKICAgICAgICAgcmV0dXJuOwotICAgIAorCiAgICAgQkVHSU5fQkxPQ0tfT0JK Q19FWENFUFRJT05TCiAgICAgQ0dDb250ZXh0UmVmIGdyYXlTY2FsZUNvbnRleHQgPSBncmF5U2Nh bGVJbWFnZS0+Y29udGV4dCgpLT5wbGF0Zm9ybUNvbnRleHQoKTsKICAgICBDSUNvbnRleHQqIGNp R3JheXNjYWxlQ29udGV4dCA9IFtDSUNvbnRleHQgY29udGV4dFdpdGhDR0NvbnRleHQ6Z3JheVNj YWxlQ29udGV4dCBvcHRpb25zOm5pbF07CkBAIC0xMTUsMTAgKzExNiwxMSBAQAogICAgIENJSW1h Z2UqIGNvbG9yTWFzayA9IFtDSUltYWdlIGltYWdlV2l0aENHSW1hZ2U6bV9tYXNrLT5jZ0ltYWdl KCldOwogICAgIGlmICghY29sb3JNYXNrKQogICAgICAgICByZXR1cm47CisKICAgICBDSUltYWdl KiBncmF5U2NhbGVNYXNrID0gdHJhbnNmb3JtSW1hZ2VJbnRvR3JheXNjYWxlTWFzayhjb2xvck1h c2spOwogICAgIFtjaUdyYXlzY2FsZUNvbnRleHQgZHJhd0ltYWdlOmdyYXlTY2FsZU1hc2sgYXRQ b2ludDpDR1BvaW50WmVybyBmcm9tUmVjdDpDR1JlY3RNYWtlKDAsIDAsIG1hc2tTaXplLndpZHRo KCksIG1hc2tTaXplLmhlaWdodCgpKV07CiAKLSAgICBjb250ZXh0LT5jbGlwVG9JbWFnZUJ1ZmZl cihtX21hc2tSZWN0LCBncmF5U2NhbGVJbWFnZS5nZXQoKSk7CisgICAgQ0dDb250ZXh0Q2xpcFRv TWFzayhjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKSwgbV9tYXNrUmVjdCwgZ3JheVNjYWxlSW1h Z2UtPmNnSW1hZ2UoKSk7CiAgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogfQogCkluZGV4 OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2 aXNpb24gMzU2ODApCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSw1 ICsxLDIxIEBACiAyMDA4LTA4LTEyICBOaWtvbGFzIFppbW1lcm1hbm4gIDx6aW1tZXJtYW5uQGtk ZS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgCisgICAg ICAgIEZpeGVzOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3OTgK KyAgICAgICAgTWFza3MgYXJlIHRyYW5zbGF0ZWQsIGFuZCB0aGUgbWFzayBpbWFnZXMgYXJlIHN3 YXBwZWQgb24gdGhlIHktYXhpcy4KKworICAgICAgICBUdXJuZWQgb3V0IHRoYXQgaHR0cDovL3Ry YWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMzE4MzAvdHJ1bmsvV2ViQ29yZS9zdmcvZ3JhcGhpY3Mv Y2cvU1ZHUmVzb3VyY2VNYXNrZXJDZy5tbQorICAgICAgICBpcyBndWlsdHkuIEdyYXBoaWNzQ29u dGV4dDo6Y2xpcFRvSW1hZ2VCdWZmZXIoKSBkb2VzIHNvbWUgZXh0cmEgdHJhbnNmb3JtYXRpb25z IHRoYXQgU1ZHUmVzb3VyY2VzTWFza2VyQ2cgZG9lcyBub3Qgd2FudC4KKworICAgICAgICBMb25n IHRlcm0gZ29hbCBpcyB0byByZW1vdmUgdGhlIFNWR1Jlc291cmNlKi9TVkdQYWludFNlcnZlciog Y2xhc3NlcyBhbnl3YXksIHNvIGl0J3Mgb2theSB0byBkdXBsaWNhdGUKKyAgICAgICAgdGhlICJj bGlwIHRvIGltYWdlIGJ1ZmZlciIgZnVuY3Rpb25hbGl0eSwgaW4gdGhlIENHIHNwZWNpZmljIFNW R1Jlc291cmNlTWFza2VyQ2cgY2xhc3MgLSBhcyBpdCB3YXMgYmVmb3JlLgorCisgICAgICAgICog c3ZnL2dyYXBoaWNzL2NnL1NWR1Jlc291cmNlTWFza2VyQ2cubW06CisgICAgICAgIChXZWJDb3Jl OjpTVkdSZXNvdXJjZU1hc2tlcjo6YXBwbHlNYXNrKTogQ2hhbmdlZCBiYWNrIHRvIHVzZSBDRyBj bGlwcGluZyBhZ2Fpbi4KKworMjAwOC0wOC0xMiAgTmlrb2xhcyBaaW1tZXJtYW5uICA8emltbWVy bWFubkBrZGUub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlci4KIAogICAgICAgICBB ZGQgbmV3IGR5bmFtaWNlLXVwZGF0ZSBsYXlvdXQgdGVzdHMgY292ZXJpbmcgU1ZHTWFya2VyRWxl bWVudC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcvVzNDLVNWRy0xLjEvbWFz a2luZy1tYXNrLTAxLWItZXhwZWN0ZWQucG5nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KQ2Fubm90IGRpc3BsYXk6IGZp bGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5cGUuCnN2bjptaW1lLXR5cGUgPSBpbWFnZS9wbmcKSW5k ZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcvVzNDLVNWRy0xLjEvbWFza2luZy1tYXNr LTAxLWItZXhwZWN0ZWQuY2hlY2tzdW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL3N2Zy9XM0MtU1ZHLTEuMS9tYXNraW5nLW1hc2stMDEtYi1leHBlY3RlZC5jaGVja3N1 bQkocmV2aXNpb24gMzU2NzgpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL1czQy1T VkctMS4xL21hc2tpbmctbWFzay0wMS1iLWV4cGVjdGVkLmNoZWNrc3VtCSh3b3JraW5nIGNvcHkp CkBAIC0xICsxIEBACi03M2JiYTA5ZjVkNTkzNTZlNTViYWRlYTA5NDQ2NjI2NwpcIE5vIG5ld2xp bmUgYXQgZW5kIG9mIGZpbGUKKzk5OWM4YjQ1MGM1NWU5MDM1NDdiMTQwN2VjZmJhY2U3ClwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2 Zy9XM0MtU1ZHLTEuMS9jb29yZHMtdmlld2F0dHItMDItYi1leHBlY3RlZC5wbmcKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpDYW5ub3QgZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBiaW5hcnkgdHlwZS4Kc3ZuOm1pbWUt dHlwZSA9IGltYWdlL3BuZwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9XM0Mt U1ZHLTEuMS9jb29yZHMtdmlld2F0dHItMDItYi1leHBlY3RlZC5jaGVja3N1bQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL1czQy1TVkctMS4xL2Nvb3Jkcy12aWV3 YXR0ci0wMi1iLWV4cGVjdGVkLmNoZWNrc3VtCShyZXZpc2lvbiAzNTY3OCkKKysrIExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9zdmcvVzNDLVNWRy0xLjEvY29vcmRzLXZpZXdhdHRyLTAyLWItZXhw ZWN0ZWQuY2hlY2tzdW0JKHdvcmtpbmcgY29weSkKQEAgLTEgKzEgQEAKLTUwOWI1ODEzOWUxMmNk MGM0ZTNiMzhkMzM4ODA0NTUwClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorYmU3M2U2YzVh MzlhMjk4NDAxZThkYjcwNWMzMDJkZmYKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4 OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL1czQy1TVkctMS4xL21hc2tpbmctaW50cm8t MDEtZi1leHBlY3RlZC5jaGVja3N1bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvc3ZnL1czQy1TVkctMS4xL21hc2tpbmctaW50cm8tMDEtZi1leHBlY3RlZC5jaGVja3N1 bQkocmV2aXNpb24gMzU2NzgpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL1czQy1T VkctMS4xL21hc2tpbmctaW50cm8tMDEtZi1leHBlY3RlZC5jaGVja3N1bQkod29ya2luZyBjb3B5 KQpAQCAtMSArMSBAQAotNDU2OWVmMDg1MDA4YTA4NzQ3ZTkyNTgzNmVkZTdhYWQKXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCitjODEyZGY0NWM0YWY1NDI4NGM0MDNlYTM5NGZhMzBhNQpcIE5v IG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9z dmcvVzNDLVNWRy0xLjEvbWFza2luZy1pbnRyby0wMS1mLWV4cGVjdGVkLnBuZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 CkNhbm5vdCBkaXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBhIGJpbmFyeSB0eXBlLgpzdm46bWltZS10 eXBlID0gaW1hZ2UvcG5nCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2JhdGlr L21hc2tpbmcvbWFza1JlZ2lvbnMtZXhwZWN0ZWQuY2hlY2tzdW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9iYXRpay9tYXNraW5nL21hc2tSZWdpb25zLWV4cGVj dGVkLmNoZWNrc3VtCShyZXZpc2lvbiAzNTY3OCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9zdmcvYmF0aWsvbWFza2luZy9tYXNrUmVnaW9ucy1leHBlY3RlZC5jaGVja3N1bQkod29ya2lu ZyBjb3B5KQpAQCAtMSArMSBAQAotZjVkMWM1Nzk4YjAwYTRmOTZiZTdjY2M3NWY4ZTQ5MjAKXCBO byBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCis5NTAxZmQyMDFmZTYyYWFmYmZmNDg0MDgzMTM5ZDFk NQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9zdmcvYmF0aWsvbWFza2luZy9tYXNrUmVnaW9ucy1leHBlY3RlZC5wbmcKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpDYW5ub3QgZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBiaW5hcnkgdHlwZS4Kc3ZuOm1pbWUt dHlwZSA9IGltYWdlL3BuZwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0 b20vZ3JheXNjYWxlLWdyYWRpZW50LW1hc2stZXhwZWN0ZWQuY2hlY2tzdW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vZ3JheXNjYWxlLWdyYWRpZW50 LW1hc2stZXhwZWN0ZWQuY2hlY2tzdW0JKHJldmlzaW9uIDM1Njc4KQorKysgTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vZ3JheXNjYWxlLWdyYWRpZW50LW1hc2stZXhwZWN0ZWQu Y2hlY2tzdW0JKHdvcmtpbmcgY29weSkKQEAgLTEgKzEgQEAKLWY4MGY0MDYyMzFlMzMwYzliZDVj NDRiOTViNTU0NjYyClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorZmNhNDYyMTBkNGRmYWRk ZTIxZjg3ODFjNzhjMTE1MzEKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4OiBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2N1c3RvbS9ncmF5c2NhbGUtZ3JhZGllbnQtbWFzay1l eHBlY3RlZC5wbmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpDYW5ub3QgZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBi aW5hcnkgdHlwZS4Kc3ZuOm1pbWUtdHlwZSA9IGltYWdlL3BuZwpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g MzU2ODApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsNSAr MSwyMiBAQAogMjAwOC0wOC0xMiAgTmlrb2xhcyBaaW1tZXJtYW5uICA8emltbWVybWFubkBrZGUu b3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBtYXNrIHJlZ3Jlc3Npb25zLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL3N2Zy9XM0MtU1ZH LTEuMS9jb29yZHMtdmlld2F0dHItMDItYi1leHBlY3RlZC5jaGVja3N1bToKKyAgICAgICAgKiBw bGF0Zm9ybS9tYWMvc3ZnL1czQy1TVkctMS4xL2Nvb3Jkcy12aWV3YXR0ci0wMi1iLWV4cGVjdGVk LnBuZzoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvc3ZnL1czQy1TVkctMS4xL21hc2tpbmctaW50 cm8tMDEtZi1leHBlY3RlZC5jaGVja3N1bToKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvc3ZnL1cz Qy1TVkctMS4xL21hc2tpbmctaW50cm8tMDEtZi1leHBlY3RlZC5wbmc6CisgICAgICAgICogcGxh dGZvcm0vbWFjL3N2Zy9XM0MtU1ZHLTEuMS9tYXNraW5nLW1hc2stMDEtYi1leHBlY3RlZC5jaGVj a3N1bToKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvc3ZnL1czQy1TVkctMS4xL21hc2tpbmctbWFz ay0wMS1iLWV4cGVjdGVkLnBuZzoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvc3ZnL2JhdGlrL21h c2tpbmcvbWFza1JlZ2lvbnMtZXhwZWN0ZWQuY2hlY2tzdW06CisgICAgICAgICogcGxhdGZvcm0v bWFjL3N2Zy9iYXRpay9tYXNraW5nL21hc2tSZWdpb25zLWV4cGVjdGVkLnBuZzoKKyAgICAgICAg KiBwbGF0Zm9ybS9tYWMvc3ZnL2N1c3RvbS9ncmF5c2NhbGUtZ3JhZGllbnQtbWFzay1leHBlY3Rl ZC5jaGVja3N1bToKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvc3ZnL2N1c3RvbS9ncmF5c2NhbGUt Z3JhZGllbnQtbWFzay1leHBlY3RlZC5wbmc6CisKKzIwMDgtMDgtMTIgIE5pa29sYXMgWmltbWVy bWFubiAgPHppbW1lcm1hbm5Aa2RlLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIu CiAKICAgICAgICAgQWRkIG5ldyBkeW5hbWljZS11cGRhdGUgbGF5b3V0IHRlc3RzIGNvdmVyaW5n IFNWR01hcmtlckVsZW1lbnQuCg==