197967 2019-05-16 15:37:06 -0700 Storage Access API: Call completion handlers in NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() when feature is off 2019-05-16 16:33:48 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander bfulgham commit-queue webkit-bug-importer oldest_to_newest 1536937 0 wilander 2019-05-16 15:37:06 -0700 NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() should call their completion handlers when there is no Resource Load Statistics object, i.e. when Resource Load Statistics is off. 1536938 1 wilander 2019-05-16 15:37:18 -0700 <rdar://problem/50753129> 1536942 2 370080 wilander 2019-05-16 15:48:23 -0700 Created attachment 370080 Patch 1536947 3 370080 bfulgham 2019-05-16 15:59:16 -0700 Comment on attachment 370080 Patch Good catch. r=me 1536953 4 wilander 2019-05-16 16:08:55 -0700 Thank you, Brent! I'll wait for EWS feedback before landing. 1536967 5 370080 commit-queue 2019-05-16 16:33:46 -0700 Comment on attachment 370080 Patch Clearing flags on attachment: 370080 Committed r245427: <https://trac.webkit.org/changeset/245427> 1536968 6 commit-queue 2019-05-16 16:33:48 -0700 All reviewed patches have been landed. Closing bug. 370080 2019-05-16 15:48:23 -0700 2019-05-16 16:33:46 -0700 Patch bug-197967-20190516154822.patch text/plain 6560 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU5YjQzNzAyNzkxMjY0ODE3 Y2VkMmFlMTMxZGFmZGIxOTc2YWZhYTMuLjMzMDg5MDBhMTQ5YjIzZDFkNGE2N2FmMjFlMmMxNmM0 Nzc4MTNmNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDUtMTYgIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcmFnZSBBY2Nlc3MgQVBJ OiBDYWxsIGNvbXBsZXRpb24gaGFuZGxlcnMgaW4gTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nl c3M6Omhhc1N0b3JhZ2VBY2Nlc3MoKSBhbmQgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6 OnJlcXVlc3RTdG9yYWdlQWNjZXNzKCkgd2hlbiBmZWF0dXJlIGlzIG9mZgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3OTY3CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81MDc1MzEyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6aGFzU3RvcmFnZUFj Y2VzcygpIGFuZCBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6cmVxdWVzdFN0b3JhZ2VB Y2Nlc3MoKQorICAgICAgICBzaG91bGQgY2FsbCB0aGVpciBjb21wbGV0aW9uIGhhbmRsZXJzIHdo ZW4gdGhlcmUgaXMgbm8gUmVzb3VyY2UgTG9hZCBTdGF0aXN0aWNzIG9iamVjdCwgaS5lLiB3aGVu IFJlc291cmNlCisgICAgICAgIExvYWQgU3RhdGlzdGljcyBpcyBvZmYuIFRoaXMgaGFwcGVucyBm b3IgZXBoZW1lcmFsIHNlc3Npb25zIHdoaWNoIG1hZGUgY29kZSBmb3IgZmVkZXJhdGVkIGxvZ2lu IHByb3ZpZGVycworICAgICAgICBoYW5nLCB3YWl0aW5nIGZvciB0aGUgcmVzdWx0IHRvIGRvY3Vt ZW50Lmhhc1N0b3JhZ2VBY2Nlc3MoKS4KKworICAgICAgICBUaGUgZXhpc3RpbmcgbGF5b3V0IHRl c3QgY2FzZSB3YXMgYXVnbWVudGVkIHRvIHVzZSBhbiBlcGhlbWVyYWwgc2Vzc2lvbi4KKworICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcDoK KyAgICAgICAgKFdlYktpdDo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6Omhhc1N0b3Jh Z2VBY2Nlc3MpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vz czo6cmVxdWVzdFN0b3JhZ2VBY2Nlc3MpOgorCiAyMDE5LTA1LTE2ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFNQSSB0byBzZXQgYSBs aXN0IG9mIGhvc3RzIHRvIHdoaWNoIHRvIHNlbmQgY3VzdG9tIGhlYWRlciBmaWVsZHMgY3Jvc3Mt b3JpZ2luCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtD b25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwCmluZGV4IGU5Yzk4ZjJlMjIyN2ZlMWM1 MjUxNzcwZDA2MGQyZWQyZTNjY2RlNWIuLjM2YWNiMTdkYjFhMTA1YjY2ZjIzN2E0OWY3YTljZjIy ZmMyNGM4ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29y a0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwCkBAIC02ODIsMTcgKzY4Miwy NSBAQCB2b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpyZXNvdXJjZUxvYWRTdGF0 aXN0aWNzVXBkYXRlZChWZWN0b3I8V2ViQ29yZQogdm9pZCBOZXR3b3JrQ29ubmVjdGlvblRvV2Vi UHJvY2Vzczo6aGFzU3RvcmFnZUFjY2VzcyhQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQsIGNvbnN0 IFJlZ2lzdHJhYmxlRG9tYWluJiBzdWJGcmFtZURvbWFpbiwgY29uc3QgUmVnaXN0cmFibGVEb21h aW4mIHRvcEZyYW1lRG9tYWluLCB1aW50NjRfdCBmcmFtZUlELCB1aW50NjRfdCBwYWdlSUQsIENv bXBsZXRpb25IYW5kbGVyPHZvaWQoYm9vbCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7CiAgICAg aWYgKGF1dG8gbmV0d29ya1Nlc3Npb24gPSBuZXR3b3JrUHJvY2VzcygpLm5ldHdvcmtTZXNzaW9u KHNlc3Npb25JRCkpIHsKLSAgICAgICAgaWYgKGF1dG8qIHJlc291cmNlTG9hZFN0YXRpc3RpY3Mg PSBuZXR3b3JrU2Vzc2lvbi0+cmVzb3VyY2VMb2FkU3RhdGlzdGljcygpKQorICAgICAgICBpZiAo YXV0byogcmVzb3VyY2VMb2FkU3RhdGlzdGljcyA9IG5ldHdvcmtTZXNzaW9uLT5yZXNvdXJjZUxv YWRTdGF0aXN0aWNzKCkpIHsKICAgICAgICAgICAgIHJlc291cmNlTG9hZFN0YXRpc3RpY3MtPmhh c1N0b3JhZ2VBY2Nlc3Moc3ViRnJhbWVEb21haW4sIHRvcEZyYW1lRG9tYWluLCBmcmFtZUlELCBw YWdlSUQsIFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKKyAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgfQogICAgIH0KKworICAgIGNvbXBsZXRpb25IYW5kbGVyKHRydWUpOwogfQogCiB2 b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpyZXF1ZXN0U3RvcmFnZUFjY2VzcyhQ QUw6OlNlc3Npb25JRCBzZXNzaW9uSUQsIGNvbnN0IFJlZ2lzdHJhYmxlRG9tYWluJiBzdWJGcmFt ZURvbWFpbiwgY29uc3QgUmVnaXN0cmFibGVEb21haW4mIHRvcEZyYW1lRG9tYWluLCB1aW50NjRf dCBmcmFtZUlELCB1aW50NjRfdCBwYWdlSUQsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoV2ViQ29y ZTo6U3RvcmFnZUFjY2Vzc1dhc0dyYW50ZWQgd2FzR3JhbnRlZCwgV2ViQ29yZTo6U3RvcmFnZUFj Y2Vzc1Byb21wdFdhc1Nob3duIHByb21wdFdhc1Nob3duKT4mJiBjb21wbGV0aW9uSGFuZGxlcikK IHsKICAgICBpZiAoYXV0byBuZXR3b3JrU2Vzc2lvbiA9IG5ldHdvcmtQcm9jZXNzKCkubmV0d29y a1Nlc3Npb24oc2Vzc2lvbklEKSkgewotICAgICAgICBpZiAoYXV0byogcmVzb3VyY2VMb2FkU3Rh dGlzdGljcyA9IG5ldHdvcmtTZXNzaW9uLT5yZXNvdXJjZUxvYWRTdGF0aXN0aWNzKCkpCisgICAg ICAgIGlmIChhdXRvKiByZXNvdXJjZUxvYWRTdGF0aXN0aWNzID0gbmV0d29ya1Nlc3Npb24tPnJl c291cmNlTG9hZFN0YXRpc3RpY3MoKSkgewogICAgICAgICAgICAgcmVzb3VyY2VMb2FkU3RhdGlz dGljcy0+cmVxdWVzdFN0b3JhZ2VBY2Nlc3Moc3ViRnJhbWVEb21haW4sIHRvcEZyYW1lRG9tYWlu LCBmcmFtZUlELCBwYWdlSUQsIFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgfQogICAgIH0KKworICAgIGNvbXBsZXRpb25IYW5kbGVyKFdl YkNvcmU6OlN0b3JhZ2VBY2Nlc3NXYXNHcmFudGVkOjpZZXMsIFdlYkNvcmU6OlN0b3JhZ2VBY2Nl c3NQcm9tcHRXYXNTaG93bjo6Tm8pOwogfQogCiB2b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQ cm9jZXNzOjpyZXF1ZXN0U3RvcmFnZUFjY2Vzc1VuZGVyT3BlbmVyKFBBTDo6U2Vzc2lvbklEIHNl c3Npb25JRCwgV2ViQ29yZTo6UmVnaXN0cmFibGVEb21haW4mJiBkb21haW5Jbk5lZWRPZlN0b3Jh Z2VBY2Nlc3MsIHVpbnQ2NF90IG9wZW5lclBhZ2VJRCwgV2ViQ29yZTo6UmVnaXN0cmFibGVEb21h aW4mJiBvcGVuZXJEb21haW4pCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGI2YWJlNjVkZmE0YjcyMzA1ZmRiNzc1MWU4MTk1 OThhMGMwYWI2My4uOTBjMTQyMDU0NGFkMTFmYmU5Yzc3NjY3YjE0YmJkOTQyYTg1ZWY2NCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA1LTE2ICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJA YXBwbGUuY29tPgorCisgICAgICAgIFN0b3JhZ2UgQWNjZXNzIEFQSTogQ2FsbCBjb21wbGV0aW9u IGhhbmRsZXJzIGluIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpoYXNTdG9yYWdlQWNj ZXNzKCkgYW5kIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpyZXF1ZXN0U3RvcmFnZUFj Y2VzcygpIHdoZW4gZmVhdHVyZSBpcyBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5Nzk2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTA3NTMx Mjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBo dHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvaGFzLXN0b3JhZ2UtYWNjZXNzLXRydWUtaWYtZmVhdHVy ZS1vZmYuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6 CisgICAgICAgICAgICBUZXN0IGNhc2UgbWFya2VkIGFzIFsgUGFzcyBdLgorCiAyMDE5LTA1LTE2 ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBMYXlvdXQgVGVz dCBodHRwL3dwdC9jYWNoZS1zdG9yYWdlL2NhY2hlLXF1b3RhLWFkZC5hbnkuaHRtbCBpcyBhIGZs YWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZUFj Y2Vzcy9oYXMtc3RvcmFnZS1hY2Nlc3MtdHJ1ZS1pZi1mZWF0dXJlLW9mZi5odG1sIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL2hhcy1zdG9yYWdlLWFjY2Vzcy10cnVlLWlm LWZlYXR1cmUtb2ZmLmh0bWwKaW5kZXggZDNmY2I1MmQxMDQ0Yzc5MmYyNzYxNjdkMDYxN2VmZWJi YTk1YjI4MS4uYWNhZjA1MjhiNjFkOTk0YWNlNjMzMjVhZTM1MGE1ZWZmNGYwMTJkYSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL2hhcy1zdG9yYWdlLWFj Y2Vzcy10cnVlLWlmLWZlYXR1cmUtb2ZmLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zdG9yYWdlQWNjZXNzL2hhcy1zdG9yYWdlLWFjY2Vzcy10cnVlLWlmLWZlYXR1cmUtb2ZmLmh0 bWwKQEAgLTgsNiArOCw5IEBACiAgICAgICAgIGRlc2NyaXB0aW9uKCJUZXN0cyB0aGF0IGRvY3Vt ZW50Lmhhc1N0b3JhZ2VBY2Nlc3MoKSByZXR1cm5zIHRydWUgZm9yIGEgM3JkLXBhcnR5IGlmcmFt ZSBpZiB0aGVyZSBpcyBubyB3YXkgdG8gcmVxdWVzdCBhY2Nlc3MgKGZlYXR1cmUgb2ZmKS4iKTsK ICAgICAgICAganNUZXN0SXNBc3luYyA9IHRydWU7CiAKKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0 UnVubmVyKQorICAgICAgICAgICAgdGVzdFJ1bm5lci5zZXRQcml2YXRlQnJvd3NpbmdFbmFibGVk KHRydWUpOworCiAgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJtZXNzYWdlIiwgcmVj ZWl2ZU1lc3NhZ2UsIGZhbHNlKTsKIAogICAgICAgICBmdW5jdGlvbiByZWNlaXZlTWVzc2FnZShl dmVudCkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25z CmluZGV4IDgyYTY4OTA1NTVmNzUzNGMxOTIzZWVjZDVhMGIwYWVmZjgwZTFhOTIuLjI0ZTY2ZDMy ZGE1YmFhYzNjYzQxNWU2NjQ3YjIwYzdkNTVmZTliZDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTczMSw2ICs3MzEsNyBAQCBodHRwL3Rl c3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvdXNlci1pbnRlcmFjdGlvbi1yZXBvcnRlZC1hZnRl ci13ZWJzaXRlLWRhdGEtcgogWyBIaWdoU2llcnJhKyBdIGh0dHAvdGVzdHMvc3RvcmFnZUFjY2Vz cy9ncmFudC13aXRoLXByb21wdC1wcmVzZXJ2ZXMtZ2VzdHVyZS5odG1sIFsgUGFzcyBdCiBbIEhp Z2hTaWVycmErIF0gaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL2Rlbnktd2l0aC1wcm9tcHQtZG9l cy1ub3QtcHJlc2VydmUtZ2VzdHVyZS5odG1sIFsgU2tpcCBdCiBbIEhpZ2hTaWVycmErIF0gaHR0 cC90ZXN0cy9zdG9yYWdlQWNjZXNzL2Rlbnktd2l0aG91dC1wcm9tcHQtcHJlc2VydmVzLWdlc3R1 cmUuaHRtbCBbIFBhc3MgXQorWyBIaWdoU2llcnJhKyBdIGh0dHAvdGVzdHMvc3RvcmFnZUFjY2Vz cy9oYXMtc3RvcmFnZS1hY2Nlc3MtdHJ1ZS1pZi1mZWF0dXJlLW9mZi5odG1sIFsgUGFzcyBdCiAK ICMgQXMgb2YgaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzIyNzc2MiB0aGUgdGlt ZXN0YW1wUmVzb2x1dGlvbiBpcyBqdXN0IDUgc2Vjb25kcyB3aGljaCBtYWtlcyB0aGlzIHRlc3Qg Zmxha3kKIGh0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy91c2VyLWludGVyYWN0aW9u LW9ubHktcmVwb3J0ZWQtb25jZS13aXRoaW4tc2hvcnQtcGVyaW9kLW9mLXRpbWUuaHRtbCBbIFNr aXAgXQo=