<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>197949</bug_id>
          
          <creation_ts>2019-05-16 08:18:25 -0700</creation_ts>
          <short_desc>[ews-build] Download archives from S3</short_desc>
          <delta_ts>2019-10-22 12:47:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=197922</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=203263</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>jbedard</cc>
    
    <cc>lforschler</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1536806</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-05-16 08:18:25 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=197922 added support to upload archives to S3. We should start downloading these archives from S3 (instead of downloading them from build-master).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1536808</commentid>
    <comment_count>1</comment_count>
      <attachid>370044</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-05-16 08:22:46 -0700</bug_when>
    <thetext>Created attachment 370044
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1536811</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-05-16 08:28:12 -0700</bug_when>
    <thetext>Attachment 370044 did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:796:  [DownloadBuiltProduct.getResultSummary] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:797:  [DownloadBuiltProduct.getResultSummary] Instance of &apos;DownloadBuiltProduct&apos; has no &apos;results&apos; member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1038:  [TestDownloadBuiltProduct.test_failure] Passing unexpected keyword argument &apos;state_string&apos; in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1038:  [TestDownloadBuiltProduct.test_failure] No value passed for parameter &apos;status_text&apos; in function call  [pylint/E1120] [5]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1536813</commentid>
    <comment_count>3</comment_count>
      <attachid>370044</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-05-16 09:12:36 -0700</bug_when>
    <thetext>Comment on attachment 370044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370044&amp;action=review

&gt; Tools/BuildSlaveSupport/ews-build/steps.py:796
&gt; +    def getResultSummary(self):

Why didn&apos;t we have something like this previously? It looks like most of this change is just swapping out the url.

&gt; Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1017
&gt; +                        command=[&apos;python&apos;, &apos;Tools/BuildSlaveSupport/download-built-product&apos;, &apos;--platform=ios&apos;, &apos;--release&apos;, &apos;https://s3-us-west-2.amazonaws.com/ews-archives.webkit.org/ios-simulator-12-x86_64-release/1234.zip&apos;],

It feels like download-built-product is missing something. When I look at this script, it doesn&apos;t do anything with platform. It makes me think that the iOS simulator bit isn&apos;t actually going to work. I think we need to put the binaries into WebKitBuild/&lt;configuration&gt;-iphonesimulator.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1536858</commentid>
    <comment_count>4</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-05-16 11:46:41 -0700</bug_when>
    <thetext>&gt; Why didn&apos;t we have something like this previously?
I have been polishing these strings (e.g.: https://bugs.webkit.org/show_bug.cgi?id=195963, https://bugs.webkit.org/show_bug.cgi?id=195945, https://bugs.webkit.org/show_bug.cgi?id=195995), but this has been a low priority, especially the strings (like this one) which doesn&apos;t appear frequently.

&gt; It looks like most of this change is just swapping out the url.
Right.
&gt; &gt; Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1017
&gt; &gt; +                        command=[&apos;python&apos;, &apos;Tools/BuildSlaveSupport/download-built-product&apos;, &apos;--platform=ios&apos;, &apos;--release&apos;, &apos;https://s3-us-west-2.amazonaws.com/ews-archives.webkit.org/ios-simulator-12-x86_64-release/1234.zip&apos;],
&gt; 
&gt; It feels like download-built-product is missing something. When I look at this script, it doesn&apos;t do anything with platform.
Yeah, it only check if platform is windows or not. Do you prefer to remove this parameter? I kept it as it would be consistent with similar build.webkit.org step.

&gt;  It makes me think that the iOS simulator bit isn&apos;t actually going to work. I think we need to put the binaries into WebKitBuild/&lt;configuration&gt;-iphonesimulator.
It actually works, tested in https://ews-build.webkit-uat.org/#/builders/20/builds/2636 . The uploaded archive itself has the subfolder &quot;&lt;configuration&gt;-iphonesimulator.&apos; You can verify by downloading and unzipping this: https://s3-us-west-2.amazonaws.com/ews-archives.webkit.org/ios-simulator-12-x86_64-release/369972.zip</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537006</commentid>
    <comment_count>5</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-05-16 20:22:42 -0700</bug_when>
    <thetext>(In reply to Aakash Jain from comment #4)
&gt; ...
&gt; &gt; It feels like download-built-product is missing something. When I look at this script, it doesn&apos;t do anything with platform.
&gt; Yeah, it only check if platform is windows or not. Do you prefer to remove
&gt; this parameter? I kept it as it would be consistent with similar
&gt; build.webkit.org step.

I actually would prefer this variable be removed if it&apos;s not used.

&gt; ... 
&gt; &gt;  It makes me think that the iOS simulator bit isn&apos;t actually going to work. I think we need to put the binaries into WebKitBuild/&lt;configuration&gt;-iphonesimulator.
&gt; It actually works, tested in
&gt; https://ews-build.webkit-uat.org/#/builders/20/builds/2636 . The uploaded
&gt; archive itself has the subfolder &quot;&lt;configuration&gt;-iphonesimulator.&apos; You can
&gt; verify by downloading and unzipping this:
&gt; https://s3-us-west-2.amazonaws.com/ews-archives.webkit.org/ios-simulator-12-
&gt; x86_64-release/369972.zip

This part is surprising to me. It may just be surprising because this isn&apos;t how our internal archiving system works, but that may also be indicative of an architectural flaw in the WebKit archiving system. But since it&apos;s working, that&apos;s not in the scope of this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537011</commentid>
    <comment_count>6</comment_count>
      <attachid>370099</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-05-16 20:42:50 -0700</bug_when>
    <thetext>Created attachment 370099
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537013</commentid>
    <comment_count>7</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-05-16 20:44:50 -0700</bug_when>
    <thetext>Attachment 370099 did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:796:  [DownloadBuiltProduct.getResultSummary] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:797:  [DownloadBuiltProduct.getResultSummary] Instance of &apos;DownloadBuiltProduct&apos; has no &apos;results&apos; member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1036:  [TestDownloadBuiltProduct.test_failure] Passing unexpected keyword argument &apos;state_string&apos; in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1036:  [TestDownloadBuiltProduct.test_failure] No value passed for parameter &apos;status_text&apos; in function call  [pylint/E1120] [5]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537014</commentid>
    <comment_count>8</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-05-16 20:45:37 -0700</bug_when>
    <thetext>&gt; I actually would prefer this variable be removed if it&apos;s not used.
Done</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537025</commentid>
    <comment_count>9</comment_count>
      <attachid>370099</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-16 21:30:38 -0700</bug_when>
    <thetext>Comment on attachment 370099
Patch

Clearing flags on attachment: 370099

Committed r245433: &lt;https://trac.webkit.org/changeset/245433&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537026</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-16 21:30:39 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537028</commentid>
    <comment_count>11</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-05-16 21:31:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/50880970&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>370044</attachid>
            <date>2019-05-16 08:22:46 -0700</date>
            <delta_ts>2019-05-16 20:42:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-197949-20190516112245.patch</filename>
            <type>text/plain</type>
            <size>4259</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI0NTM5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE1IEBACisyMDE5LTA1LTE2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBEb3dubG9hZCBhcmNoaXZlcyBmcm9tIFMzCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc5NDkKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVT
dXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKERvd25sb2FkQnVpbHRQcm9kdWN0
KTogVXBkYXRlZCB0byB1c2UgUzMgVVJMLgorICAgICAgICAoRG93bmxvYWRCdWlsdFByb2R1Y3Qu
Z2V0UmVzdWx0U3VtbWFyeSk6IE1ldGhvZCB0byBkaXNwbGF5IGN1c3RvbSBmYWlsdXJlIHN0cmlu
Zy4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3Qu
cHk6IFVwZGF0ZWQgdW5pdC10ZXN0cy4KKwogMjAxOS0wNS0xNSAgQWFrYXNoIEphaW4gIDxhYWth
c2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVwbGFjZSBkb3VibGUtcXVvdGVzIHdpdGgg
c2luZ2xlIHF1b3RlcyBpbiBzdGVwcy5weQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv
ZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0
L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjQ1Mzk2KQorKysgVG9vbHMvQnVpbGRTbGF2
ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3ICszMyw3
IEBAIGltcG9ydCByZQogaW1wb3J0IHJlcXVlc3RzCiAKIEJVR19TRVJWRVJfVVJMID0gJ2h0dHBz
Oi8vYnVncy53ZWJraXQub3JnLycKLUVXU19VUkwgPSAnaHR0cHM6Ly9ld3MtYnVpbGQud2Via2l0
Lm9yZy8nCitTM1VSTCA9ICdodHRwczovL3MzLXVzLXdlc3QtMi5hbWF6b25hd3MuY29tLycKIFdp
dGhQcm9wZXJ0aWVzID0gcHJvcGVydGllcy5XaXRoUHJvcGVydGllcwogSW50ZXJwb2xhdGUgPSBw
cm9wZXJ0aWVzLkludGVycG9sYXRlCiAKQEAgLTc4NiwxMyArNzg2LDE4IEBAIGNsYXNzIFVwbG9h
ZEJ1aWx0UHJvZHVjdCh0cmFuc2Zlci5GaWxlVXAKIGNsYXNzIERvd25sb2FkQnVpbHRQcm9kdWN0
KHNoZWxsLlNoZWxsQ29tbWFuZCk6CiAgICAgY29tbWFuZCA9IFsncHl0aG9uJywgJ1Rvb2xzL0J1
aWxkU2xhdmVTdXBwb3J0L2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnLAogICAgICAgICBXaXRoUHJv
cGVydGllcygnLS1wbGF0Zm9ybT0lKHBsYXRmb3JtKXMnKSwgV2l0aFByb3BlcnRpZXMoJy0tJShj
b25maWd1cmF0aW9uKXMnKSwKLSAgICAgICAgV2l0aFByb3BlcnRpZXMoRVdTX1VSTCArICdhcmNo
aXZlcy8lKGZ1bGxQbGF0Zm9ybSlzLSUoYXJjaGl0ZWN0dXJlKXMtJShjb25maWd1cmF0aW9uKXMv
JShwYXRjaF9pZClzLnppcCcpXQorICAgICAgICBXaXRoUHJvcGVydGllcyhTM1VSTCArICdld3Mt
YXJjaGl2ZXMud2Via2l0Lm9yZy8lKGZ1bGxQbGF0Zm9ybSlzLSUoYXJjaGl0ZWN0dXJlKXMtJShj
b25maWd1cmF0aW9uKXMvJShwYXRjaF9pZClzLnppcCcpXQogICAgIG5hbWUgPSAnZG93bmxvYWQt
YnVpbHQtcHJvZHVjdCcKICAgICBkZXNjcmlwdGlvbiA9IFsnZG93bmxvYWRpbmcgYnVpbHQgcHJv
ZHVjdCddCiAgICAgZGVzY3JpcHRpb25Eb25lID0gWydEb3dubG9hZGVkIGJ1aWx0IHByb2R1Y3Qn
XQogICAgIGhhbHRPbkZhaWx1cmUgPSBUcnVlCiAgICAgZmx1bmtPbkZhaWx1cmUgPSBUcnVlCiAK
KyAgICBkZWYgZ2V0UmVzdWx0U3VtbWFyeShzZWxmKToKKyAgICAgICAgaWYgc2VsZi5yZXN1bHRz
ICE9IFNVQ0NFU1M6CisgICAgICAgICAgICByZXR1cm4ge3Unc3RlcCc6IHUnRmFpbGVkIHRvIGRv
d25sb2FkIGJ1aWx0IHByb2R1Y3QgZnJvbSBTMyd9CisgICAgICAgIHJldHVybiBzdXBlcihEb3du
bG9hZEJ1aWx0UHJvZHVjdCwgc2VsZikuZ2V0UmVzdWx0U3VtbWFyeSgpCisKIAogY2xhc3MgRXh0
cmFjdEJ1aWx0UHJvZHVjdChzaGVsbC5TaGVsbENvbW1hbmQpOgogICAgIGNvbW1hbmQgPSBbJ3B5
dGhvbicsICdUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUnLApJ
bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191
bml0dGVzdC5weQkocmV2aXNpb24gMjQ1Mzk2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv
ZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMDE0LDcgKzEw
MTQsNyBAQCBjbGFzcyBUZXN0RG93bmxvYWRCdWlsdFByb2R1Y3QoQnVpbGRTdGVwCiAgICAgICAg
IHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJzEyMzQnKQogICAgICAgICBzZWxmLmV4cGVj
dFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXIn
LAotICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFuZD1bJ3B5dGhvbicsICdUb29scy9CdWls
ZFNsYXZlU3VwcG9ydC9kb3dubG9hZC1idWlsdC1wcm9kdWN0JywgJy0tcGxhdGZvcm09aW9zJywg
ICctLXJlbGVhc2UnLCAnaHR0cHM6Ly9ld3MtYnVpbGQud2Via2l0Lm9yZy9hcmNoaXZlcy9pb3Mt
c2ltdWxhdG9yLTEyLXg4Nl82NC1yZWxlYXNlLzEyMzQuemlwJ10sCisgICAgICAgICAgICAgICAg
ICAgICAgICBjb21tYW5kPVsncHl0aG9uJywgJ1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2Rvd25s
b2FkLWJ1aWx0LXByb2R1Y3QnLCAnLS1wbGF0Zm9ybT1pb3MnLCAnLS1yZWxlYXNlJywgJ2h0dHBz
Oi8vczMtdXMtd2VzdC0yLmFtYXpvbmF3cy5jb20vZXdzLWFyY2hpdmVzLndlYmtpdC5vcmcvaW9z
LXNpbXVsYXRvci0xMi14ODZfNjQtcmVsZWFzZS8xMjM0LnppcCddLAogICAgICAgICAgICAgICAg
ICAgICAgICAgKQogICAgICAgICAgICAgKyAwLAogICAgICAgICApCkBAIC0xMDMwLDEyICsxMDMw
LDEyIEBAIGNsYXNzIFRlc3REb3dubG9hZEJ1aWx0UHJvZHVjdChCdWlsZFN0ZXAKICAgICAgICAg
c2VsZi5zZXRQcm9wZXJ0eSgncGF0Y2hfaWQnLCAnMTIzNDU2JykKICAgICAgICAgc2VsZi5leHBl
Y3RSZW1vdGVDb21tYW5kcygKICAgICAgICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGly
JywKLSAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9WydweXRob24nLCAnVG9vbHMvQnVp
bGRTbGF2ZVN1cHBvcnQvZG93bmxvYWQtYnVpbHQtcHJvZHVjdCcsICctLXBsYXRmb3JtPW1hYycs
ICAnLS1kZWJ1ZycsICdodHRwczovL2V3cy1idWlsZC53ZWJraXQub3JnL2FyY2hpdmVzL21hYy1z
aWVycmEteDg2XzY0LWRlYnVnLzEyMzQ1Ni56aXAnXSwKKyAgICAgICAgICAgICAgICAgICAgICAg
IGNvbW1hbmQ9WydweXRob24nLCAnVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZG93bmxvYWQtYnVp
bHQtcHJvZHVjdCcsICctLXBsYXRmb3JtPW1hYycsICctLWRlYnVnJywgJ2h0dHBzOi8vczMtdXMt
d2VzdC0yLmFtYXpvbmF3cy5jb20vZXdzLWFyY2hpdmVzLndlYmtpdC5vcmcvbWFjLXNpZXJyYS14
ODZfNjQtZGVidWcvMTIzNDU2LnppcCddLAogICAgICAgICAgICAgICAgICAgICAgICAgKQogICAg
ICAgICAgICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0ZGlvJywgc3Rkb3V0PSdVbmV4cGVjdGVkIGZh
aWx1cmUuJykKICAgICAgICAgICAgICsgMiwKICAgICAgICAgKQotICAgICAgICBzZWxmLmV4cGVj
dE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nRG93bmxvYWRlZCBidWlsdCBw
cm9kdWN0IChmYWlsdXJlKScpCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9RkFJ
TFVSRSwgc3RhdGVfc3RyaW5nPSdGYWlsZWQgdG8gZG93bmxvYWQgYnVpbHQgcHJvZHVjdCBmcm9t
IFMzJykKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>370099</attachid>
            <date>2019-05-16 20:42:50 -0700</date>
            <delta_ts>2019-05-16 21:30:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-197949-20190516234248.patch</filename>
            <type>text/plain</type>
            <size>4851</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI0NTM5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE1IEBACisyMDE5LTA1LTE2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBEb3dubG9hZCBhcmNoaXZlcyBmcm9tIFMzCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc5NDkKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVT
dXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKERvd25sb2FkQnVpbHRQcm9kdWN0
KTogVXBkYXRlZCB0byB1c2UgUzMgVVJMLgorICAgICAgICAoRG93bmxvYWRCdWlsdFByb2R1Y3Qu
Z2V0UmVzdWx0U3VtbWFyeSk6IE1ldGhvZCB0byBkaXNwbGF5IGN1c3RvbSBmYWlsdXJlIHN0cmlu
Zy4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3Qu
cHk6IFVwZGF0ZWQgdW5pdC10ZXN0cy4KKwogMjAxOS0wNS0xNSAgQWFrYXNoIEphaW4gIDxhYWth
c2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVwbGFjZSBkb3VibGUtcXVvdGVzIHdpdGgg
c2luZ2xlIHF1b3RlcyBpbiBzdGVwcy5weQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv
ZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0
L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjQ1Mzk2KQorKysgVG9vbHMvQnVpbGRTbGF2
ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3ICszMyw3
IEBAIGltcG9ydCByZQogaW1wb3J0IHJlcXVlc3RzCiAKIEJVR19TRVJWRVJfVVJMID0gJ2h0dHBz
Oi8vYnVncy53ZWJraXQub3JnLycKLUVXU19VUkwgPSAnaHR0cHM6Ly9ld3MtYnVpbGQud2Via2l0
Lm9yZy8nCitTM1VSTCA9ICdodHRwczovL3MzLXVzLXdlc3QtMi5hbWF6b25hd3MuY29tLycKIFdp
dGhQcm9wZXJ0aWVzID0gcHJvcGVydGllcy5XaXRoUHJvcGVydGllcwogSW50ZXJwb2xhdGUgPSBw
cm9wZXJ0aWVzLkludGVycG9sYXRlCiAKQEAgLTc4NSwxNCArNzg1LDE5IEBAIGNsYXNzIFVwbG9h
ZEJ1aWx0UHJvZHVjdCh0cmFuc2Zlci5GaWxlVXAKIAogY2xhc3MgRG93bmxvYWRCdWlsdFByb2R1
Y3Qoc2hlbGwuU2hlbGxDb21tYW5kKToKICAgICBjb21tYW5kID0gWydweXRob24nLCAnVG9vbHMv
QnVpbGRTbGF2ZVN1cHBvcnQvZG93bmxvYWQtYnVpbHQtcHJvZHVjdCcsCi0gICAgICAgIFdpdGhQ
cm9wZXJ0aWVzKCctLXBsYXRmb3JtPSUocGxhdGZvcm0pcycpLCBXaXRoUHJvcGVydGllcygnLS0l
KGNvbmZpZ3VyYXRpb24pcycpLAotICAgICAgICBXaXRoUHJvcGVydGllcyhFV1NfVVJMICsgJ2Fy
Y2hpdmVzLyUoZnVsbFBsYXRmb3JtKXMtJShhcmNoaXRlY3R1cmUpcy0lKGNvbmZpZ3VyYXRpb24p
cy8lKHBhdGNoX2lkKXMuemlwJyldCisgICAgICAgIFdpdGhQcm9wZXJ0aWVzKCctLSUoY29uZmln
dXJhdGlvbilzJyksCisgICAgICAgIFdpdGhQcm9wZXJ0aWVzKFMzVVJMICsgJ2V3cy1hcmNoaXZl
cy53ZWJraXQub3JnLyUoZnVsbFBsYXRmb3JtKXMtJShhcmNoaXRlY3R1cmUpcy0lKGNvbmZpZ3Vy
YXRpb24pcy8lKHBhdGNoX2lkKXMuemlwJyldCiAgICAgbmFtZSA9ICdkb3dubG9hZC1idWlsdC1w
cm9kdWN0JwogICAgIGRlc2NyaXB0aW9uID0gWydkb3dubG9hZGluZyBidWlsdCBwcm9kdWN0J10K
ICAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ0Rvd25sb2FkZWQgYnVpbHQgcHJvZHVjdCddCiAgICAg
aGFsdE9uRmFpbHVyZSA9IFRydWUKICAgICBmbHVua09uRmFpbHVyZSA9IFRydWUKIAorICAgIGRl
ZiBnZXRSZXN1bHRTdW1tYXJ5KHNlbGYpOgorICAgICAgICBpZiBzZWxmLnJlc3VsdHMgIT0gU1VD
Q0VTUzoKKyAgICAgICAgICAgIHJldHVybiB7dSdzdGVwJzogdSdGYWlsZWQgdG8gZG93bmxvYWQg
YnVpbHQgcHJvZHVjdCBmcm9tIFMzJ30KKyAgICAgICAgcmV0dXJuIHN1cGVyKERvd25sb2FkQnVp
bHRQcm9kdWN0LCBzZWxmKS5nZXRSZXN1bHRTdW1tYXJ5KCkKKwogCiBjbGFzcyBFeHRyYWN0QnVp
bHRQcm9kdWN0KHNoZWxsLlNoZWxsQ29tbWFuZCk6CiAgICAgY29tbWFuZCA9IFsncHl0aG9uJywg
J1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZScsCkluZGV4OiBU
b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0
LnB5CShyZXZpc2lvbiAyNDUzOTYpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp
bGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTEwMDcsMTQgKzEwMDcsMTMg
QEAgY2xhc3MgVGVzdERvd25sb2FkQnVpbHRQcm9kdWN0KEJ1aWxkU3RlcAogCiAgICAgZGVmIHRl
c3Rfc3VjY2VzcyhzZWxmKToKICAgICAgICAgc2VsZi5zZXR1cFN0ZXAoRG93bmxvYWRCdWlsdFBy
b2R1Y3QoKSkKLSAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncGxhdGZvcm0nLCAnaW9zJykKICAg
ICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywgJ2lvcy1zaW11bGF0b3ItMTIn
KQogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQog
ICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdhcmNoaXRlY3R1cmUnLCAneDg2XzY0JykKICAgICAg
ICAgc2VsZi5zZXRQcm9wZXJ0eSgncGF0Y2hfaWQnLCAnMTIzNCcpCiAgICAgICAgIHNlbGYuZXhw
ZWN0UmVtb3RlQ29tbWFuZHMoCiAgICAgICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2Rp
cicsCi0gICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsncHl0aG9uJywgJ1Rvb2xzL0J1
aWxkU2xhdmVTdXBwb3J0L2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnLCAnLS1wbGF0Zm9ybT1pb3Mn
LCAgJy0tcmVsZWFzZScsICdodHRwczovL2V3cy1idWlsZC53ZWJraXQub3JnL2FyY2hpdmVzL2lv
cy1zaW11bGF0b3ItMTIteDg2XzY0LXJlbGVhc2UvMTIzNC56aXAnXSwKKyAgICAgICAgICAgICAg
ICAgICAgICAgIGNvbW1hbmQ9WydweXRob24nLCAnVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZG93
bmxvYWQtYnVpbHQtcHJvZHVjdCcsICctLXJlbGVhc2UnLCAnaHR0cHM6Ly9zMy11cy13ZXN0LTIu
YW1hem9uYXdzLmNvbS9ld3MtYXJjaGl2ZXMud2Via2l0Lm9yZy9pb3Mtc2ltdWxhdG9yLTEyLXg4
Nl82NC1yZWxlYXNlLzEyMzQuemlwJ10sCiAgICAgICAgICAgICAgICAgICAgICAgICApCiAgICAg
ICAgICAgICArIDAsCiAgICAgICAgICkKQEAgLTEwMjMsMTkgKzEwMjIsMTggQEAgY2xhc3MgVGVz
dERvd25sb2FkQnVpbHRQcm9kdWN0KEJ1aWxkU3RlcAogCiAgICAgZGVmIHRlc3RfZmFpbHVyZShz
ZWxmKToKICAgICAgICAgc2VsZi5zZXR1cFN0ZXAoRG93bmxvYWRCdWlsdFByb2R1Y3QoKSkKLSAg
ICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncGxhdGZvcm0nLCAnbWFjJykKICAgICAgICAgc2VsZi5z
ZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywgJ21hYy1zaWVycmEnKQogICAgICAgICBzZWxmLnNl
dFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ2RlYnVnJykKICAgICAgICAgc2VsZi5zZXRQcm9w
ZXJ0eSgnYXJjaGl0ZWN0dXJlJywgJ3g4Nl82NCcpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHko
J3BhdGNoX2lkJywgJzEyMzQ1NicpCiAgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMo
CiAgICAgICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCi0gICAgICAgICAgICAg
ICAgICAgICAgICBjb21tYW5kPVsncHl0aG9uJywgJ1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2Rv
d25sb2FkLWJ1aWx0LXByb2R1Y3QnLCAnLS1wbGF0Zm9ybT1tYWMnLCAgJy0tZGVidWcnLCAnaHR0
cHM6Ly9ld3MtYnVpbGQud2Via2l0Lm9yZy9hcmNoaXZlcy9tYWMtc2llcnJhLXg4Nl82NC1kZWJ1
Zy8xMjM0NTYuemlwJ10sCisgICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsncHl0aG9u
JywgJ1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnLCAnLS1k
ZWJ1ZycsICdodHRwczovL3MzLXVzLXdlc3QtMi5hbWF6b25hd3MuY29tL2V3cy1hcmNoaXZlcy53
ZWJraXQub3JnL21hYy1zaWVycmEteDg2XzY0LWRlYnVnLzEyMzQ1Ni56aXAnXSwKICAgICAgICAg
ICAgICAgICAgICAgICAgICkKICAgICAgICAgICAgICsgRXhwZWN0U2hlbGwubG9nKCdzdGRpbycs
IHN0ZG91dD0nVW5leHBlY3RlZCBmYWlsdXJlLicpCiAgICAgICAgICAgICArIDIsCiAgICAgICAg
ICkKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJp
bmc9J0Rvd25sb2FkZWQgYnVpbHQgcHJvZHVjdCAoZmFpbHVyZSknKQorICAgICAgICBzZWxmLmV4
cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nRmFpbGVkIHRvIGRvd25s
b2FkIGJ1aWx0IHByb2R1Y3QgZnJvbSBTMycpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAo
KQogCiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>