197946 2019-05-16 06:23:36 -0700 [macOS,iOS] Add always-on logging for AVPlayerTimeControlStatus changes 2019-05-23 12:12:29 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble jonlee webkit-bug-importer oldest_to_newest 1536777 0 eric.carlson 2019-05-16 06:23:36 -0700 Add always-on logging for AVPlayerTimeControlStatus changes 1536778 1 eric.carlson 2019-05-16 06:24:48 -0700 <rdar://problem/50627457> 1536779 2 370040 eric.carlson 2019-05-16 06:34:34 -0700 Created attachment 370040 Patch 1538743 3 370040 commit-queue 2019-05-23 12:12:28 -0700 Comment on attachment 370040 Patch Clearing flags on attachment: 370040 Committed r245701: <https://trac.webkit.org/changeset/245701> 1538744 4 commit-queue 2019-05-23 12:12:29 -0700 All reviewed patches have been landed. Closing bug. 370040 2019-05-16 06:34:34 -0700 2019-05-23 12:12:28 -0700 Patch bug-197946-20190516063434.patch text/plain 3247 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1Mzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTc1N2Y0ZmUxN2JjZTVi MWFiMjZkZjhiMGYzNjRkNmNlMjQ0MmRkNC4uYmUyMzkyNWI2N2E4MzJmNDhiOWNmMjJiNDIyZjMy NmQ0YzkxN2ZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA1LTE2ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPUyxpT1Nd IEFkZCBhbHdheXMtb24gbG9nZ2luZyBmb3IgQVZQbGF5ZXJUaW1lQ29udHJvbFN0YXR1cyBjaGFu Z2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc5 NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUwNjI3NDU3PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3Vu ZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToKKyAgICAg ICAgKFdlYkNvcmU6OmNvbnZlcnRFbnVtZXJhdGlvblRvU3RyaW5nKToKKyAgICAgICAgKFdURjo6 TG9nQXJndW1lbnQ8QVZQbGF5ZXJUaW1lQ29udHJvbFN0YXR1cz46OnRvU3RyaW5nKToKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnRpbWVDb250 cm9sU3RhdHVzRGlkQ2hhbmdlKToKKwogMjAxOS0wNS0xNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0ZyZWVUeXBlXSBTb21lIGNoYXJhY3Rl ciBzZXF1ZW5jZXMgd2l0aCBhIHZhcmlhdGlvbiBzZWxlY3RvciBhcmUgbm90IHJlbmRlcmVkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24v b2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uT2JqQy5tbQppbmRleCA1YWZkOGNiYTFjZjg0MDgxN2JkOTUxNzk3Y2E5NjYw ZjI1NWY4NDc0Li5jMTIzZWQ1ZWQ4YTMxODYxOGRiYzMyZTIzZTEwNjIyYjY1NmQxMWI2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2Jq Yy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0 ZUFWRm91bmRhdGlvbk9iakMubW0KQEAgLTIwMCw2ICsyMDAsMzUgQEAgZW51bSBNZWRpYVBsYXll ckFWRm91bmRhdGlvbk9ic2VydmF0aW9uQ29udGV4dCB7CiBAZW5kCiAjZW5kaWYKIAorbmFtZXNw YWNlIFdlYkNvcmUgeworc3RhdGljIFN0cmluZyBjb252ZXJ0RW51bWVyYXRpb25Ub1N0cmluZyhB VlBsYXllclRpbWVDb250cm9sU3RhdHVzIGVudW1lcmF0aW9uVmFsdWUpCit7CisgICAgc3RhdGlj IGNvbnN0IE5ldmVyRGVzdHJveWVkPFN0cmluZz4gdmFsdWVzW10gPSB7CisgICAgICAgIE1BS0Vf U1RBVElDX1NUUklOR19JTVBMKCJBVlBsYXllclRpbWVDb250cm9sU3RhdHVzUGF1c2VkIiksCisg ICAgICAgIE1BS0VfU1RBVElDX1NUUklOR19JTVBMKCJBVlBsYXllclRpbWVDb250cm9sU3RhdHVz V2FpdGluZ1RvUGxheUF0U3BlY2lmaWVkUmF0ZSIpLAorICAgICAgICBNQUtFX1NUQVRJQ19TVFJJ TkdfSU1QTCgiQVZQbGF5ZXJUaW1lQ29udHJvbFN0YXR1c1BsYXlpbmciKSwKKyAgICB9OworICAg IHN0YXRpY19hc3NlcnQoIXN0YXRpY19jYXN0PHNpemVfdD4oQVZQbGF5ZXJUaW1lQ29udHJvbFN0 YXR1c1BhdXNlZCksICJBVlBsYXllclRpbWVDb250cm9sU3RhdHVzUGF1c2VkIGlzIG5vdCAwIGFz IGV4cGVjdGVkIik7CisgICAgc3RhdGljX2Fzc2VydChzdGF0aWNfY2FzdDxzaXplX3Q+KEFWUGxh eWVyVGltZUNvbnRyb2xTdGF0dXNXYWl0aW5nVG9QbGF5QXRTcGVjaWZpZWRSYXRlKSA9PSAxLCAi QVZQbGF5ZXJUaW1lQ29udHJvbFN0YXR1c1dhaXRpbmdUb1BsYXlBdFNwZWNpZmllZFJhdGUgaXMg bm90IDEgYXMgZXhwZWN0ZWQiKTsKKyAgICBzdGF0aWNfYXNzZXJ0KHN0YXRpY19jYXN0PHNpemVf dD4oQVZQbGF5ZXJUaW1lQ29udHJvbFN0YXR1c1BsYXlpbmcpID09IDIsICJBVlBsYXllclRpbWVD b250cm9sU3RhdHVzUGxheWluZyBpcyBub3QgMiBhcyBleHBlY3RlZCIpOworICAgIEFTU0VSVChz dGF0aWNfY2FzdDxzaXplX3Q+KGVudW1lcmF0aW9uVmFsdWUpIDwgV1RGX0FSUkFZX0xFTkdUSCh2 YWx1ZXMpKTsKKyAgICByZXR1cm4gdmFsdWVzW3N0YXRpY19jYXN0PHNpemVfdD4oZW51bWVyYXRp b25WYWx1ZSldOworfQorfQorCituYW1lc3BhY2UgV1RGIHsKK3RlbXBsYXRlPHR5cGVuYW1lIFR5 cGU+CitzdHJ1Y3QgTG9nQXJndW1lbnQ7CisKK3RlbXBsYXRlIDw+CitzdHJ1Y3QgTG9nQXJndW1l bnQ8QVZQbGF5ZXJUaW1lQ29udHJvbFN0YXR1cz4geworICAgIHN0YXRpYyBTdHJpbmcgdG9TdHJp bmcoY29uc3QgQVZQbGF5ZXJUaW1lQ29udHJvbFN0YXR1cyBzdGF0dXMpCisgICAgeworICAgICAg ICByZXR1cm4gY29udmVydEVudW1lcmF0aW9uVG9TdHJpbmcoc3RhdHVzKTsKKyAgICB9Cit9Owor fTsgLy8gbmFtZXNwYWNlIFdURgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiB1c2luZyBuYW1lc3Bh Y2UgUEFMOwogCkBAIC0zMDQ2LDYgKzMwNzUsOCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFW Rm91bmRhdGlvbk9iakM6OnRpbWVDb250cm9sU3RhdHVzRGlkQ2hhbmdlKGludCB0aW1lQ29udAog ICAgIGlmIChtX2NhY2hlZFRpbWVDb250cm9sU3RhdHVzID09IHRpbWVDb250cm9sU3RhdHVzKQog ICAgICAgICByZXR1cm47CiAKKyAgICBBTFdBWVNfTE9HKExPR0lERU5USUZJRVIsIHN0YXRpY19j YXN0PEFWUGxheWVyVGltZUNvbnRyb2xTdGF0dXM+KHRpbWVDb250cm9sU3RhdHVzKSwgIiwgb2Jz ZXJ2aW5nID0gIiwgbV9zaG91bGRPYnNlcnZlVGltZUNvbnRyb2xTdGF0dXMpOworCiAgICAgaWYg KCFtX3Nob3VsZE9ic2VydmVUaW1lQ29udHJvbFN0YXR1cykKICAgICAgICAgcmV0dXJuOwogCg==