197935 2019-05-15 17:32:23 -0700 AX: screenHasInvertedColors should use AppKit method, not CG 2019-05-16 02:22:29 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 ghughes ghughes cfleizach commit-queue webkit-bug-importer oldest_to_newest 1536670 0 ghughes 2019-05-15 17:32:23 -0700 screenHasInvertedColors should use [[NSWorkspace sharedWorkspace] accessibilityDisplayShouldInvertColors], not CGDisplayUsesInvertedPolarity 1536671 1 webkit-bug-importer 2019-05-15 17:32:36 -0700 <rdar://problem/50834405> 1536679 2 370012 ghughes 2019-05-15 17:47:11 -0700 Created attachment 370012 Patch 1536680 3 370012 cfleizach 2019-05-15 17:49:32 -0700 Comment on attachment 370012 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370012&action=review > Source/WebCore/platform/mac/PlatformScreenMac.mm:264 > +#if HAVE_ACCESSIBILITY_SUPPORT can you put this in a single method that can be called be both locations? 1536684 4 370013 ghughes 2019-05-15 17:57:49 -0700 Created attachment 370013 Patch 1536750 5 370013 commit-queue 2019-05-16 02:22:27 -0700 Comment on attachment 370013 Patch Clearing flags on attachment: 370013 Committed r245392: <https://trac.webkit.org/changeset/245392> 1536751 6 commit-queue 2019-05-16 02:22:29 -0700 All reviewed patches have been landed. Closing bug. 370012 2019-05-15 17:47:11 -0700 2019-05-15 17:57:48 -0700 Patch bug-197935-20190515174710.patch text/plain 2580 ghughes U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRjMGFmZmM3MDgwNzVl MWVmYTMxNGNiNGVkNmFjZWRjNDVjYWQ1NS4uZTBlMDViMmZmNWI4MDIzMWU3M2U0NWFkZjAyNWRh NzRmZmJhMTA5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA1LTE1ICBHcmVn IEh1Z2hlcyAgPGdodWdoZXNAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZWQgc2NyZWVuSGFz SW52ZXJ0ZWRDb2xvcnMgdG8gdXNlIEFwcEtpdCB3aGVuIGF2YWlsYWJsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3OTM1CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81MDgzNDQwNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbToKKyAgICAg ICAgKFdlYkNvcmU6OmNvbGxlY3RTY3JlZW5Qcm9wZXJ0aWVzKToKKyAgICAgICAgKFdlYkNvcmU6 OnNjcmVlbkhhc0ludmVydGVkQ29sb3JzKToKKwogMjAxOS0wNS0xNSAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFyayBiZWFjb24gYW5kIHBpbmcgbG9hZHMg YXMgbG93IHByaW9yaXR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv UGxhdGZvcm1TY3JlZW5NYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZv cm1TY3JlZW5NYWMubW0KaW5kZXggMDQwMjMxOTAyM2JjNDgwY2VmMjg0NTM5NWNjNWMzYWQ1YjNk YjU4OC4uMTNhYWZhYzZiZDgwYjE3MTc2NDA1M2U3MmQ5NzYwNzkwYzhjMjM1NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQpAQCAtMTEw LDcgKzExMCwxMyBAQCBQbGF0Zm9ybURpc3BsYXlJRCBwcmltYXJ5U2NyZWVuRGlzcGxheUlEKCkK IFNjcmVlblByb3BlcnRpZXMgY29sbGVjdFNjcmVlblByb3BlcnRpZXMoKQogewogICAgIEFTU0VS VChoYXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6OkNhbkNvbW11bmljYXRlV2l0 aFdpbmRvd1NlcnZlcikpOwotCisgICAgCisjaWYgSEFWRV9BQ0NFU1NJQklMSVRZX1NVUFBPUlQK KyAgICBib29sIHNjcmVlbkhhc0ludmVydGVkQ29sb3JzID0gW1tOU1dvcmtzcGFjZSBzaGFyZWRX b3Jrc3BhY2VdIGFjY2Vzc2liaWxpdHlEaXNwbGF5U2hvdWxkSW52ZXJ0Q29sb3JzXTsKKyNlbHNl CisgICAgYm9vbCBzY3JlZW5IYXNJbnZlcnRlZENvbG9ycyA9IENHRGlzcGxheVVzZXNJbnZlcnRl ZFBvbGFyaXR5KCk7CisjZW5kaWYKKyAgICAKICAgICBTY3JlZW5Qcm9wZXJ0aWVzIHNjcmVlblBy b3BlcnRpZXM7CiAKICAgICBmb3IgKE5TU2NyZWVuICpzY3JlZW4gaW4gW05TU2NyZWVuIHNjcmVl bnNdKSB7CkBAIC0xMjQsNyArMTMwLDYgQEAgU2NyZWVuUHJvcGVydGllcyBjb2xsZWN0U2NyZWVu UHJvcGVydGllcygpCiAgICAgICAgIGludCBzY3JlZW5EZXB0aCA9IE5TQml0c1BlclBpeGVsRnJv bURlcHRoKHNjcmVlbi5kZXB0aCk7CiAgICAgICAgIGludCBzY3JlZW5EZXB0aFBlckNvbXBvbmVu dCA9IE5TQml0c1BlclNhbXBsZUZyb21EZXB0aChzY3JlZW4uZGVwdGgpOwogICAgICAgICBib29s IHNjcmVlblN1cHBvcnRzRXh0ZW5kZWRDb2xvciA9IFtzY3JlZW4gY2FuUmVwcmVzZW50RGlzcGxh eUdhbXV0Ok5TRGlzcGxheUdhbXV0UDNdOwotICAgICAgICBib29sIHNjcmVlbkhhc0ludmVydGVk Q29sb3JzID0gQ0dEaXNwbGF5VXNlc0ludmVydGVkUG9sYXJpdHkoKTsKICAgICAgICAgYm9vbCBz Y3JlZW5Jc01vbm9jaHJvbWUgPSBDR0Rpc3BsYXlVc2VzRm9yY2VUb0dyYXkoKTsKICAgICAgICAg dWludDMyX3QgZGlzcGxheU1hc2sgPSBDR0Rpc3BsYXlJRFRvT3BlbkdMRGlzcGxheU1hc2soZGlz cGxheUlEKTsKICAgICAgICAgSU9SZWdpc3RyeUdQVUlEIGdwdUlEID0gMDsKQEAgLTI1Niw3ICsy NjEsMTEgQEAgYm9vbCBzY3JlZW5IYXNJbnZlcnRlZENvbG9ycygpCiAKICAgICAvLyBUaGlzIGlz IGEgc3lzdGVtLXdpZGUgYWNjZXNzaWJpbGl0eSBzZXR0aW5nLCBzYW1lIG9uIGFsbCBzY3JlZW5z LgogICAgIEFTU0VSVChoYXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6OkNhbkNv bW11bmljYXRlV2l0aFdpbmRvd1NlcnZlcikpOworI2lmIEhBVkVfQUNDRVNTSUJJTElUWV9TVVBQ T1JUCisgICAgcmV0dXJuIFtbTlNXb3Jrc3BhY2Ugc2hhcmVkV29ya3NwYWNlXSBhY2Nlc3NpYmls aXR5RGlzcGxheVNob3VsZEludmVydENvbG9yc107CisjZWxzZQogICAgIHJldHVybiBDR0Rpc3Bs YXlVc2VzSW52ZXJ0ZWRQb2xhcml0eSgpOworI2VuZGlmCiB9CiAKIGludCBzY3JlZW5EZXB0aChX aWRnZXQqIHdpZGdldCkK 370013 2019-05-15 17:57:49 -0700 2019-05-16 02:22:27 -0700 Patch bug-197935-20190515175749.patch text/plain 2410 ghughes U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRjMGFmZmM3MDgwNzVl MWVmYTMxNGNiNGVkNmFjZWRjNDVjYWQ1NS4uZTBlMDViMmZmNWI4MDIzMWU3M2U0NWFkZjAyNWRh NzRmZmJhMTA5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA1LTE1ICBHcmVn IEh1Z2hlcyAgPGdodWdoZXNAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZWQgc2NyZWVuSGFz SW52ZXJ0ZWRDb2xvcnMgdG8gdXNlIEFwcEtpdCB3aGVuIGF2YWlsYWJsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3OTM1CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81MDgzNDQwNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbToKKyAgICAg ICAgKFdlYkNvcmU6OmNvbGxlY3RTY3JlZW5Qcm9wZXJ0aWVzKToKKyAgICAgICAgKFdlYkNvcmU6 OnNjcmVlbkhhc0ludmVydGVkQ29sb3JzKToKKwogMjAxOS0wNS0xNSAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFyayBiZWFjb24gYW5kIHBpbmcgbG9hZHMg YXMgbG93IHByaW9yaXR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv UGxhdGZvcm1TY3JlZW5NYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZv cm1TY3JlZW5NYWMubW0KaW5kZXggMDQwMjMxOTAyM2JjNDgwY2VmMjg0NTM5NWNjNWMzYWQ1YjNk YjU4OC4uN2MzZDk2MDkwZmUxZTc0YWNmNDY1OTI2OGRkMDhhZmU2NDQ2YjdlYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQpAQCAtMTEy LDYgKzExMiw3IEBAIFNjcmVlblByb3BlcnRpZXMgY29sbGVjdFNjcmVlblByb3BlcnRpZXMoKQog ICAgIEFTU0VSVChoYXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6OkNhbkNvbW11 bmljYXRlV2l0aFdpbmRvd1NlcnZlcikpOwogCiAgICAgU2NyZWVuUHJvcGVydGllcyBzY3JlZW5Q cm9wZXJ0aWVzOworICAgIGJvb2wgc2NyZWVuSGFzSW52ZXJ0ZWRDb2xvcnMgPSBbW05TV29ya3Nw YWNlIHNoYXJlZFdvcmtzcGFjZV0gYWNjZXNzaWJpbGl0eURpc3BsYXlTaG91bGRJbnZlcnRDb2xv cnNdOwogCiAgICAgZm9yIChOU1NjcmVlbiAqc2NyZWVuIGluIFtOU1NjcmVlbiBzY3JlZW5zXSkg ewogICAgICAgICBhdXRvIGRpc3BsYXlJRCA9IFdlYkNvcmU6OmRpc3BsYXlJRChzY3JlZW4pOwpA QCAtMTI0LDcgKzEyNSw2IEBAIFNjcmVlblByb3BlcnRpZXMgY29sbGVjdFNjcmVlblByb3BlcnRp ZXMoKQogICAgICAgICBpbnQgc2NyZWVuRGVwdGggPSBOU0JpdHNQZXJQaXhlbEZyb21EZXB0aChz Y3JlZW4uZGVwdGgpOwogICAgICAgICBpbnQgc2NyZWVuRGVwdGhQZXJDb21wb25lbnQgPSBOU0Jp dHNQZXJTYW1wbGVGcm9tRGVwdGgoc2NyZWVuLmRlcHRoKTsKICAgICAgICAgYm9vbCBzY3JlZW5T dXBwb3J0c0V4dGVuZGVkQ29sb3IgPSBbc2NyZWVuIGNhblJlcHJlc2VudERpc3BsYXlHYW11dDpO U0Rpc3BsYXlHYW11dFAzXTsKLSAgICAgICAgYm9vbCBzY3JlZW5IYXNJbnZlcnRlZENvbG9ycyA9 IENHRGlzcGxheVVzZXNJbnZlcnRlZFBvbGFyaXR5KCk7CiAgICAgICAgIGJvb2wgc2NyZWVuSXNN b25vY2hyb21lID0gQ0dEaXNwbGF5VXNlc0ZvcmNlVG9HcmF5KCk7CiAgICAgICAgIHVpbnQzMl90 IGRpc3BsYXlNYXNrID0gQ0dEaXNwbGF5SURUb09wZW5HTERpc3BsYXlNYXNrKGRpc3BsYXlJRCk7 CiAgICAgICAgIElPUmVnaXN0cnlHUFVJRCBncHVJRCA9IDA7CkBAIC0yNTYsNyArMjU2LDcgQEAg Ym9vbCBzY3JlZW5IYXNJbnZlcnRlZENvbG9ycygpCiAKICAgICAvLyBUaGlzIGlzIGEgc3lzdGVt LXdpZGUgYWNjZXNzaWJpbGl0eSBzZXR0aW5nLCBzYW1lIG9uIGFsbCBzY3JlZW5zLgogICAgIEFT U0VSVChoYXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6OkNhbkNvbW11bmljYXRl V2l0aFdpbmRvd1NlcnZlcikpOwotICAgIHJldHVybiBDR0Rpc3BsYXlVc2VzSW52ZXJ0ZWRQb2xh cml0eSgpOworICAgIHJldHVybiBbW05TV29ya3NwYWNlIHNoYXJlZFdvcmtzcGFjZV0gYWNjZXNz aWJpbGl0eURpc3BsYXlTaG91bGRJbnZlcnRDb2xvcnNdOwogfQogCiBpbnQgc2NyZWVuRGVwdGgo V2lkZ2V0KiB3aWRnZXQpCg==