197911 2019-05-15 03:14:03 -0700 compilation failure with clang 9 2019-05-15 14:41:16 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 vjaquez vjaquez achristensen benjamin cdumez cmarcelo commit-queue dbates ews-watchlist keith_miller kenwong20052006 mark.lam ross.kirsling saam webkit-bug-importer oldest_to_newest 1536395 0 vjaquez 2019-05-15 03:14:03 -0700 While compiling webkit's master with clang, either 6 or 9 I got this error [3/864] Building CXX object Source/WTF/wtf/CMakeFiles/WTF.dir/MetaAllocator.cpp.o FAILED: Source/WTF/wtf/CMakeFiles/WTF.dir/MetaAllocator.cpp.o /usr/bin/clang++-9 -DBUILDING_GTK__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WTF -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -I/opt/webkit/WebKit/Source/bmalloc -I. -IDerivedSources -I/opt/webkit/WebKit/Source/ThirdParty -IDerivedSources/WTF -I/opt/webkit/WebKit/Source/WTF -I/opt/webkit/WebKit/Source/WTF/wtf -I/opt/webkit/WebKit/Source/WTF/wtf/dtoa -I/opt/webkit/WebKit/Source/WTF/wtf/persistence -I/opt/webkit/WebKit/Source/WTF/wtf/text -I/opt/webkit/WebKit/Source/WTF/wtf/text/icu -I/opt/webkit/WebKit/Source/WTF/wtf/threads -I/opt/webkit/WebKit/Source/WTF/wtf/unicode -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/uuid -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -ggdb -std=c++17 -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++17 -gsplit-dwarf -g -fPIC -MD -MT Source/WTF/wtf/CMakeFiles/WTF.dir/MetaAllocator.cpp.o -MF Source/WTF/wtf/CMakeFiles/WTF.dir/MetaAllocator.cpp.o.d -o Source/WTF/wtf/CMakeFiles/WTF.dir/MetaAllocator.cpp.o -c /opt/webkit/WebKit/Source/WTF/wtf/MetaAllocator.cpp In file included from /opt/webkit/WebKit/Source/WTF/wtf/MetaAllocator.cpp:30: In file included from /opt/webkit/WebKit/Source/WTF/wtf/MetaAllocator.h:34: In file included from /opt/webkit/WebKit/Source/WTF/wtf/MetaAllocatorHandle.h:32: In file included from /opt/webkit/WebKit/Source/WTF/wtf/MetaAllocatorPtr.h:29: /opt/webkit/WebKit/Source/WTF/wtf/PtrTag.h:431:23: error: use of undeclared identifier 'nullptr_t'; did you mean 'nullptr'? inline T* tagArrayPtr(nullptr_t, size_t size) ^~~~~~~~~ nullptr /opt/webkit/WebKit/Source/WTF/wtf/PtrTag.h:431:34: error: unexpected type name 'size_t': expected expression inline T* tagArrayPtr(nullptr_t, size_t size) ^ /opt/webkit/WebKit/Source/WTF/wtf/PtrTag.h:431:46: error: expected ';' at end of declaration inline T* tagArrayPtr(nullptr_t, size_t size) ^ ; /opt/webkit/WebKit/Source/WTF/wtf/PtrTag.h:432:1: error: expected unqualified-id { ^ /opt/webkit/WebKit/Source/WTF/wtf/PtrTag.h:438:11: error: redefinition of 'tagArrayPtr' as different kind of symbol inline T* tagArrayPtr(T* ptr, size_t) ^ /opt/webkit/WebKit/Source/WTF/wtf/PtrTag.h:431:11: note: previous definition is here inline T* tagArrayPtr(nullptr_t, size_t size) ^ 5 errors generated. 1536396 1 369943 vjaquez 2019-05-15 03:21:10 -0700 Created attachment 369943 Patch 1536426 2 369943 commit-queue 2019-05-15 08:13:08 -0700 Comment on attachment 369943 Patch Clearing flags on attachment: 369943 Committed r245325: <https://trac.webkit.org/changeset/245325> 1536427 3 commit-queue 2019-05-15 08:13:09 -0700 All reviewed patches have been landed. Closing bug. 1536428 4 webkit-bug-importer 2019-05-15 08:14:19 -0700 <rdar://problem/50810987> 1536604 5 ap 2019-05-15 14:41:16 -0700 *** Bug 197907 has been marked as a duplicate of this bug. *** 369943 2019-05-15 03:21:10 -0700 2019-05-15 08:13:08 -0700 Patch bug-197911-20190515122120.patch text/plain 1537 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZiYzYwYWE3ZTRiZjc0YWEyNzU0NjFj NGFjMTg1Y2FhNGQ5ODI2MDEuLjQ3ODU4NTc0MWE5MDYzMzY2MDU2ZGRjYTFjZGQyYmQ3NzZhYTQz NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDUtMTUgIFbDrWN0b3IgTWFudWVsIErDoXF1 ZXogTGVhbCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBjb21waWxhdGlvbiBmYWls dXJlIHdpdGggY2xhbmcgOQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk3OTExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVXNlIHN0ZCBuYW1lc3BhY2UgZm9yIG51bGxwdHJfdCBpbiB0YWdBcnJheVB0ciB0 ZW1wbGF0ZXMuCisKKyAgICAgICAgKiB3dGYvUHRyVGFnLmg6CisgICAgICAgIChXVEY6OnRhZ0Fy cmF5UHRyKToKKwogMjAxOS0wNS0xNCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0NTI4MS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL1B0clRhZy5oIGIvU291cmNlL1dURi93dGYvUHRyVGFnLmgK aW5kZXggYTBlNzg1NjM1OTIxMTNhNjY3NTQzMjZhODU2OTgxNDhmZDZlZjBlOC4uMTQzNDliZGE0 N2UwYTY3NjEyNzBjZmNjOTk3OGUzOGNmOWVkZWM3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93 dGYvUHRyVGFnLmgKKysrIGIvU291cmNlL1dURi93dGYvUHRyVGFnLmgKQEAgLTEyMyw3ICsxMjMs NyBAQCBjb25zdGV4cHIgYm9vbCBlbmFibGVQdHJUYWdEZWJ1Z0Fzc2VydCA9IHRydWU7CiAKIAog dGVtcGxhdGU8dHlwZW5hbWUgVD4KLWlubGluZSBUKiB0YWdBcnJheVB0cihudWxscHRyX3QgcHRy LCBzaXplX3QgbGVuZ3RoKQoraW5saW5lIFQqIHRhZ0FycmF5UHRyKHN0ZDo6bnVsbHB0cl90IHB0 ciwgc2l6ZV90IGxlbmd0aCkKIHsKICAgICBBU1NFUlQoIWxlbmd0aCk7CiAgICAgcmV0dXJuIHB0 cmF1dGhfc2lnbl91bmF1dGhlbnRpY2F0ZWQoc3RhdGljX2Nhc3Q8VCo+KHB0ciksIHB0cmF1dGhf a2V5X3Byb2Nlc3NfZGVwZW5kZW50X2RhdGEsIGxlbmd0aCk7CkBAIC00MjgsNyArNDI4LDcgQEAg aW5saW5lIHZvaWQgcmVnaXN0ZXJQdHJUYWdMb29rdXAoUHRyVGFnTG9va3VwKikgeyB9CiBpbmxp bmUgdm9pZCByZXBvcnRCYWRUYWcoY29uc3Qgdm9pZCosIFB0clRhZykgeyB9CiAKIHRlbXBsYXRl PHR5cGVuYW1lIFQ+Ci1pbmxpbmUgVCogdGFnQXJyYXlQdHIobnVsbHB0cl90LCBzaXplX3Qgc2l6 ZSkKK2lubGluZSBUKiB0YWdBcnJheVB0cihzdGQ6Om51bGxwdHJfdCwgc2l6ZV90IHNpemUpCiB7 CiAgICAgQVNTRVJUX1VOVVNFRChzaXplLCAhc2l6ZSk7CiAgICAgcmV0dXJuIG51bGxwdHI7Cg==