19791 2008-06-27 08:41:57 -0700 Inspector should show the source file that called console.time and console.timeEnd 2008-08-18 11:05:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED DUPLICATE 17234 P2 Enhancement --- 1 keishi webkit-unassigned aroben ggaren oliver timothy oldest_to_newest 84567 0 keishi 2008-06-27 08:41:57 -0700 The Inspector should show the source file that called console.time and console.timeEnd like Firebug. 88097 1 22704 keishi 2008-08-08 04:55:17 -0700 Created attachment 22704 as far as I have [CustomCall] let's you override getCallData for a class like Console but I can't figure out how to override for a function like console.log. Also, I can't figure out what callData.native.function points to. I think it eventually calls Console::log but I don't know what is in between. 88107 2 timothy 2008-08-08 09:16:34 -0700 I think Geoff or Oliver should review this. I am not sure adding a new type of CallData is right. 88108 3 aroben 2008-08-08 09:17:23 -0700 (In reply to comment #2) > I think Geoff or Oliver should review this. I agree. > I am not sure adding a new type of CallData is right. That's what Geoff suggested in bug 17234. 88169 4 timothy 2008-08-09 21:58:30 -0700 I think using CustomCall for the Console object is fine. The majority of the console functions want this info. Also the CallType name in JSCore should have a more generic name, since it could be used for other code. 88183 5 timothy 2008-08-10 13:31:36 -0700 Why do we have bug 17234 and this bug? Wouldn't we fix all of the console functions at once, not just tim/timeEnd? 88213 6 keishi 2008-08-11 07:14:11 -0700 *** This bug has been marked as a duplicate of 17234 *** 88220 7 22704 timothy 2008-08-11 08:24:00 -0700 Comment on attachment 22704 as far as I have Clearing the review flag since this is a duplicate bug. Attach the patch to bug 17234. 88738 8 kmccullough 2008-08-18 11:05:37 -0700 I talked with Geoff about how to get the line numbers and source files for more than just these functions. I think we are going to be taking this in another direction. 22704 2008-08-08 04:55:17 -0700 2008-08-11 08:24:00 -0700 as far as I have c.txt text/plain 3274 keishi SW5kZXg6IEphdmFTY3JpcHRDb3JlL1ZNL01hY2hpbmUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT Y3JpcHRDb3JlL1ZNL01hY2hpbmUuY3BwCShyZXZpc2lvbiAzNTUxMSkKKysrIEphdmFTY3JpcHRD b3JlL1ZNL01hY2hpbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzg1LDYgKzIzODUsMjggQEAg SlNWYWx1ZSogTWFjaGluZTo6cHJpdmF0ZUV4ZWN1dGUoRXhlY3V0aQogICAgICAgICAgICAgTkVY VF9PUENPREU7CiAgICAgICAgIH0KIAorICAgICAgICBpZiAoY2FsbFR5cGUgPT0gQ2FsbFR5cGVD b25zb2xlKSB7CisgICAgICAgICAgICBpZiAoKmVuYWJsZWRQcm9maWxlclJlZmVyZW5jZSkKKyAg ICAgICAgICAgICAgICAoKmVuYWJsZWRQcm9maWxlclJlZmVyZW5jZSktPndpbGxFeGVjdXRlKGV4 ZWMsIHN0YXRpY19jYXN0PEpTT2JqZWN0Kj4odikpOworCisgICAgICAgICAgICBKU1ZhbHVlKiB0 aGlzVmFsdWUgPSB0aGlzVmFsID09IG1pc3NpbmdUaGlzT2JqZWN0TWFya2VyKCkgPyBleGVjLT5n bG9iYWxUaGlzVmFsdWUoKSA6IHJbdGhpc1ZhbF0uanNWYWx1ZShleGVjKTsKKyAgICAgICAgICAg IEFyZ0xpc3QgYXJncyhyICsgZmlyc3RBcmcgKyAxLCBhcmdDb3VudCAtIDEpOworCisgICAgICAg ICAgICBNQUNISU5FX1NBTVBMSU5HX2NhbGxpbmdIb3N0RnVuY3Rpb24oKTsKKworICAgICAgICAg ICAgSlNWYWx1ZSogcmV0dXJuVmFsdWUgPSBjYWxsRGF0YS5uYXRpdmUuZnVuY3Rpb24oZXhlYywg c3RhdGljX2Nhc3Q8SlNPYmplY3QqPih2KSwgdGhpc1ZhbHVlLCBhcmdzKTsKKyAgICAgICAgICAg IC8vSlNWYWx1ZSogcmV0dXJuVmFsdWUgPSBjYWxsRGF0YS5uYXRpdmUuZnVuY3Rpb24oZXhlYywg c3RhdGljX2Nhc3Q8SlNPYmplY3QqPih2KSwgdGhpc1ZhbHVlLCBhcmdzLCBjb2RlQmxvY2stPmxp bmVOdW1iZXJGb3JWUEModlBDKSwgY29kZUJsb2NrLT5vd25lck5vZGUpOworICAgICAgICAgICAg Vk1fQ0hFQ0tfRVhDRVBUSU9OKCk7CisKKyAgICAgICAgICAgIHJbZHN0XSA9IHJldHVyblZhbHVl OworCisgICAgICAgICAgICBpZiAoKmVuYWJsZWRQcm9maWxlclJlZmVyZW5jZSkKKyAgICAgICAg ICAgICAgICAoKmVuYWJsZWRQcm9maWxlclJlZmVyZW5jZSktPmRpZEV4ZWN1dGUoZXhlYywgc3Rh dGljX2Nhc3Q8SlNPYmplY3QqPih2KSk7CisKKyAgICAgICAgICAgICsrdlBDOworICAgICAgICAg ICAgTkVYVF9PUENPREU7CisgICAgICAgIH0KKwogICAgICAgICBBU1NFUlQoY2FsbFR5cGUgPT0g Q2FsbFR5cGVOb25lKTsKIAogICAgICAgICBleGNlcHRpb25WYWx1ZSA9IGNyZWF0ZU5vdEFGdW5j dGlvbkVycm9yKGV4ZWMsIHYsIHZQQywgY29kZUJsb2NrKTsKSW5kZXg6IEphdmFTY3JpcHRDb3Jl L2tqcy9DYWxsRGF0YS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL0NhbGxE YXRhLmNwcAkocmV2aXNpb24gMzU1MTEpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvQ2FsbERhdGEu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw3IEBAIG5hbWVzcGFjZSBLSlMgewogCiBK U1ZhbHVlKiBjYWxsKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSogZnVuY3Rpb25PYmplY3QsIENh bGxUeXBlIGNhbGxUeXBlLCBjb25zdCBDYWxsRGF0YSYgY2FsbERhdGEsIEpTVmFsdWUqIHRoaXNW YWx1ZSwgY29uc3QgQXJnTGlzdCYgYXJncykKIHsKLSAgICBpZiAoY2FsbFR5cGUgPT0gQ2FsbFR5 cGVIb3N0KQorICAgIGlmIChjYWxsVHlwZSA9PSBDYWxsVHlwZUhvc3QgfHwgY2FsbFR5cGUgPT0g Q2FsbFR5cGVDb25zb2xlKQogICAgICAgICByZXR1cm4gY2FsbERhdGEubmF0aXZlLmZ1bmN0aW9u KGV4ZWMsIHN0YXRpY19jYXN0PEpTT2JqZWN0Kj4oZnVuY3Rpb25PYmplY3QpLCB0aGlzVmFsdWUs IGFyZ3MpOwogICAgIEFTU0VSVChjYWxsVHlwZSA9PSBDYWxsVHlwZUpTKTsKICAgICAvLyBGSVhN RTogQ2FuIHRoaXMgYmUgZG9uZSBtb3JlIGVmZmljaWVudGx5IHVzaW5nIHRoZSBjYWxsRGF0YT8K SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9DYWxsRGF0YS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT Y3JpcHRDb3JlL2tqcy9DYWxsRGF0YS5oCShyZXZpc2lvbiAzNTUxMSkKKysrIEphdmFTY3JpcHRD b3JlL2tqcy9DYWxsRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw3ICs0MSw4IEBAIG5hbWVz cGFjZSBLSlMgewogICAgIGVudW0gQ2FsbFR5cGUgewogICAgICAgICBDYWxsVHlwZU5vbmUsCiAg ICAgICAgIENhbGxUeXBlSG9zdCwKLSAgICAgICAgQ2FsbFR5cGVKUworICAgICAgICBDYWxsVHlw ZUpTLAorICAgICAgICBDYWxsVHlwZUNvbnNvbGUKICAgICB9OwogCiAgICAgdHlwZWRlZiBKU1Zh bHVlKiAoKk5hdGl2ZUZ1bmN0aW9uKShFeGVjU3RhdGUqLCBKU09iamVjdCosIEpTVmFsdWUqIHRo aXNWYWx1ZSwgY29uc3QgQXJnTGlzdCYpOwpJbmRleDogSmF2YVNjcmlwdENvcmUva2pzL1Byb3Bl cnR5U2xvdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL1Byb3BlcnR5U2xv dC5jcHAJKHJldmlzaW9uIDM1NTExKQorKysgSmF2YVNjcmlwdENvcmUva2pzL1Byb3BlcnR5U2xv dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwLDcgKzQwLDcgQEAgSlNWYWx1ZSogUHJvcGVydHlT bG90OjpmdW5jdGlvbkdldHRlcihFeAogCiAgICAgQ2FsbERhdGEgY2FsbERhdGE7CiAgICAgQ2Fs bFR5cGUgY2FsbFR5cGUgPSBzbG90Lm1fZGF0YS5nZXR0ZXJGdW5jLT5nZXRDYWxsRGF0YShjYWxs RGF0YSk7Ci0gICAgaWYgKGNhbGxUeXBlID09IENhbGxUeXBlSG9zdCkKKyAgICBpZiAoY2FsbFR5 cGUgPT0gQ2FsbFR5cGVIb3N0IHx8IENhbGxUeXBlQ29uc29sZSkKICAgICAgICAgcmV0dXJuIGNh bGxEYXRhLm5hdGl2ZS5mdW5jdGlvbihleGVjLCBzbG90Lm1fZGF0YS5nZXR0ZXJGdW5jLCBzbG90 LnNsb3RCYXNlKCksIGV4ZWMtPmVtcHR5TGlzdCgpKTsKICAgICBBU1NFUlQoY2FsbFR5cGUgPT0g Q2FsbFR5cGVKUyk7CiAgICAgLy8gRklYTUU6IENhbiB0aGlzIGJlIGRvbmUgbW9yZSBlZmZpY2ll bnRseSB1c2luZyB0aGUgY2FsbERhdGE/Cg==