197890 2019-05-14 12:04:33 -0700 [WHLSL] parseEffectfulAssignment should not call parseCallExpression directly 2019-05-14 13:36:21 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue mmaxfield rmorisset webkit-bug-importer oldest_to_newest 1536172 0 rmorisset 2019-05-14 12:04:33 -0700 callExpression already appears in effSuffix which is in effPrefix which is in effAssignment, so having it directly in effAssignment as well is useless (and ambiguous). I've already fixed the grammar, this patch is fixing the parser. 1536176 1 369879 rmorisset 2019-05-14 12:08:37 -0700 Created attachment 369879 Patch 1536177 2 mmaxfield 2019-05-14 12:16:23 -0700 I think we can test this patch. If the program fails to parse, the JS call should return null. 1536178 3 369879 mmaxfield 2019-05-14 12:24:16 -0700 Comment on attachment 369879 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369879&action=review > Source/WebCore/ChangeLog:9 > + I've already fixed the grammar, this patch is fixing the parser. Let's link to the associated grammar fix and spec fix. 1536189 4 369882 rmorisset 2019-05-14 12:35:44 -0700 Created attachment 369882 Patch for landing Added link in the changelog. 1536190 5 369882 commit-queue 2019-05-14 12:38:15 -0700 Comment on attachment 369882 Patch for landing Rejecting attachment 369882 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 369882, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=369882&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=197890&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 369882 from bug 197890. Fetching: https://bugs.webkit.org/attachment.cgi?id=369882 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog patch: **** malformed patch at line 22: Video frame resizing should be using Trim patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12190332 1536199 6 369884 rmorisset 2019-05-14 12:55:30 -0700 Created attachment 369884 Patch for landing 1536219 7 369884 commit-queue 2019-05-14 13:35:38 -0700 Comment on attachment 369884 Patch for landing Clearing flags on attachment: 369884 Committed r245302: <https://trac.webkit.org/changeset/245302> 1536220 8 commit-queue 2019-05-14 13:35:40 -0700 All reviewed patches have been landed. Closing bug. 1536221 9 webkit-bug-importer 2019-05-14 13:36:21 -0700 <rdar://problem/50780514> 369879 2019-05-14 12:08:37 -0700 2019-05-14 12:35:44 -0700 Patch patch197890 text/plain 1555 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1M2RmN2E3ZDI4NS4uNzg5NjI0N2IyNDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNS0xNCAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFtXSExTTF0gcGFyc2VFZmZlY3RmdWxBc3NpZ25tZW50IHNob3VsZCBu b3QgY2FsbCBwYXJzZUNhbGxFeHByZXNzaW9uIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc4OTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjYWxsRXhwcmVzc2lvbiBhbHJlYWR5IGFwcGVh cnMgaW4gZWZmU3VmZml4IHdoaWNoIGlzIGluIGVmZlByZWZpeCB3aGljaCBpcyBpbiBlZmZBc3Np Z25tZW50LCBzbyBoYXZpbmcgaXQgZGlyZWN0bHkgaW4gZWZmQXNzaWdubWVudCBhcyB3ZWxsIGlz IHVzZWxlc3MgKGFuZCBhbWJpZ3VvdXMpLgorICAgICAgICBJJ3ZlIGFscmVhZHkgZml4ZWQgdGhl IGdyYW1tYXIsIHRoaXMgcGF0Y2ggaXMgZml4aW5nIHRoZSBwYXJzZXIuCisKKyAgICAgICAgKiBN b2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTFBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX SExTTDo6UGFyc2VyOjpwYXJzZUVmZmVjdGZ1bEFzc2lnbm1lbnQpOgorCiAyMDE5LTA1LTE0ICBZ b3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBWaWRlbyBmcmFtZSBy ZXNpemluZyBzaG91bGQgYmUgdXNpbmcgVHJpbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJncHUvV0hMU0wvV0hMU0xQYXJzZXIuY3BwCmluZGV4IDUzMzI1Njc2NjQ5Li4yMzU2 MjczZDVlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wv V0hMU0xQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNM L1dITFNMUGFyc2VyLmNwcApAQCAtMTgwMywxMiArMTgwMyw2IEBAIGF1dG8gUGFyc2VyOjpwYXJz ZUVmZmVjdGZ1bEFzc2lnbm1lbnQoKSAtPiBFeHBlY3RlZDxVbmlxdWVSZWY8QVNUOjpFeHByZXNz aW9uPiwKICAgICBpZiAoYXNzaWdubWVudCkKICAgICAgICAgcmV0dXJuIGFzc2lnbm1lbnQ7CiAK LSAgICBhc3NpZ25tZW50ID0gYmFja3RyYWNraW5nU2NvcGU8RXhwZWN0ZWQ8VW5pcXVlUmVmPEFT VDo6RXhwcmVzc2lvbj4sIEVycm9yPj4oWyZdKCkgewotICAgICAgICByZXR1cm4gcGFyc2VDYWxs RXhwcmVzc2lvbigpOwotICAgIH0pOwotICAgIGlmIChhc3NpZ25tZW50KQotICAgICAgICByZXR1 cm4gYXNzaWdubWVudDsKLQogICAgIHJldHVybiBVbmV4cGVjdGVkPEVycm9yPihhc3NpZ25tZW50 LmVycm9yKCkpOwogfQogCg== 369882 2019-05-14 12:35:44 -0700 2019-05-14 12:55:30 -0700 Patch for landing patch197890 text/plain 1697 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1M2RmN2E3ZDI4NS4uNzg5NjI0N2IyNDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNS0xNCAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFtXSExTTF0gcGFyc2VFZmZlY3RmdWxBc3NpZ25tZW50IHNob3VsZCBu b3QgY2FsbCBwYXJzZUNhbGxFeHByZXNzaW9uIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc4OTAKKworICAgICAgICBSZXZpZXdlZCBi eSBNeWxlcyBNYXhmaWVsZC4KKworICAgICAgICBjYWxsRXhwcmVzc2lvbiBhbHJlYWR5IGFwcGVh cnMgaW4gZWZmU3VmZml4IHdoaWNoIGlzIGluIGVmZlByZWZpeCB3aGljaCBpcyBpbiBlZmZBc3Np Z25tZW50LCBzbyBoYXZpbmcgaXQgZGlyZWN0bHkgaW4gZWZmQXNzaWdubWVudCBhcyB3ZWxsIGlz IHVzZWxlc3MgKGFuZCBhbWJpZ3VvdXMpLgorICAgICAgICBJJ3ZlIGFscmVhZHkgZml4ZWQgdGhl IGdyYW1tYXIgKGh0dHBzOi8vZ2l0aHViLmNvbS9ncHV3ZWIvV0hMU0wvY29tbWl0L2EwNzAwNWY0 ZDY5MmZlMzM3MDYxOGRjYTVkYjIxODk5MmIzNjIwNDkpLCB0aGlzIHBhdGNoIGlzIGZpeGluZyB0 aGUgcGFyc2VyLgorICAgICAgICBUaGUgc3BlYyBoYWQgdGhlIHJpZ2h0IHZlcnNpb24gZnJvbSB0 aGUgYmVnaW5uaW5nLgorCisgICAgICAgICogTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xQYXJz ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V0hMU0w6OlBhcnNlcjo6cGFyc2VFZmZlY3RmdWxB c3NpZ25tZW50KToKKwogMjAxOS0wNS0xNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgVmlkZW8gZnJhbWUgcmVzaXppbmcgc2hvdWxkIGJlIHVzaW5nIFRyaW0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMUGFy c2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMUGFyc2Vy LmNwcAppbmRleCA1MzMyNTY3NjY0OS4uMjM1NjI3M2Q1ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMUGFyc2VyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTFBhcnNlci5jcHAKQEAgLTE4MDMsMTIg KzE4MDMsNiBAQCBhdXRvIFBhcnNlcjo6cGFyc2VFZmZlY3RmdWxBc3NpZ25tZW50KCkgLT4gRXhw ZWN0ZWQ8VW5pcXVlUmVmPEFTVDo6RXhwcmVzc2lvbj4sCiAgICAgaWYgKGFzc2lnbm1lbnQpCiAg ICAgICAgIHJldHVybiBhc3NpZ25tZW50OwogCi0gICAgYXNzaWdubWVudCA9IGJhY2t0cmFja2lu Z1Njb3BlPEV4cGVjdGVkPFVuaXF1ZVJlZjxBU1Q6OkV4cHJlc3Npb24+LCBFcnJvcj4+KFsmXSgp IHsKLSAgICAgICAgcmV0dXJuIHBhcnNlQ2FsbEV4cHJlc3Npb24oKTsKLSAgICB9KTsKLSAgICBp ZiAoYXNzaWdubWVudCkKLSAgICAgICAgcmV0dXJuIGFzc2lnbm1lbnQ7Ci0KICAgICByZXR1cm4g VW5leHBlY3RlZDxFcnJvcj4oYXNzaWdubWVudC5lcnJvcigpKTsKIH0KIAo= 369884 2019-05-14 12:55:30 -0700 2019-05-14 13:35:38 -0700 Patch for landing patch197890 text/plain 1666 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1M2RmN2E3ZDI4NS4uNzg5NjI0N2IyNDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNS0xNCAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFtXSExTTF0gcGFyc2VFZmZlY3RmdWxBc3NpZ25tZW50IHNob3VsZCBu b3QgY2FsbCBwYXJzZUNhbGxFeHByZXNzaW9uIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc4OTAKKworICAgICAgICBSZXZpZXdlZCBi eSBNeWxlcyBNYXhmaWVsZC4KKworICAgICAgICBjYWxsRXhwcmVzc2lvbiBhbHJlYWR5IGFwcGVh cnMgaW4gZWZmU3VmZml4IHdoaWNoIGlzIGluIGVmZlByZWZpeCB3aGljaCBpcyBpbiBlZmZBc3Np Z25tZW50LCBzbyBoYXZpbmcgaXQgZGlyZWN0bHkgaW4gZWZmQXNzaWdubWVudCBhcyB3ZWxsIGlz IHVzZWxlc3MgKGFuZCBhbWJpZ3VvdXMpLgorICAgICAgICBJJ3ZlIGFscmVhZHkgZml4ZWQgdGhl IGdyYW1tYXIgKGh0dHBzOi8vZ2l0aHViLmNvbS9ncHV3ZWIvV0hMU0wvY29tbWl0L2EwNzAwNWY0 ZDY5MmZlMzM3MDYxOGRjYTVkYjIxODk5MmIzNjIwNDkpLCB0aGUgZ3JhbW1hciB3YXMgYWx3YXlz IGdvb2QsIHRoaXMgcGF0Y2ggaXMgZml4aW5nIHRoZSBwYXJzZXIuCisKKyAgICAgICAgKiBNb2R1 bGVzL3dlYmdwdS9XSExTTC9XSExTTFBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXSExT TDo6UGFyc2VyOjpwYXJzZUVmZmVjdGZ1bEFzc2lnbm1lbnQpOgorCiAyMDE5LTA1LTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBWaWRlbyBmcmFtZSByZXNp emluZyBzaG91bGQgYmUgdXNpbmcgVHJpbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJncHUvV0hMU0wvV0hMU0xQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJncHUvV0hMU0wvV0hMU0xQYXJzZXIuY3BwCmluZGV4IDUzMzI1Njc2NjQ5Li4yMzU2Mjcz ZDVlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hM U0xQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dI TFNMUGFyc2VyLmNwcApAQCAtMTgwMywxMiArMTgwMyw2IEBAIGF1dG8gUGFyc2VyOjpwYXJzZUVm ZmVjdGZ1bEFzc2lnbm1lbnQoKSAtPiBFeHBlY3RlZDxVbmlxdWVSZWY8QVNUOjpFeHByZXNzaW9u PiwKICAgICBpZiAoYXNzaWdubWVudCkKICAgICAgICAgcmV0dXJuIGFzc2lnbm1lbnQ7CiAKLSAg ICBhc3NpZ25tZW50ID0gYmFja3RyYWNraW5nU2NvcGU8RXhwZWN0ZWQ8VW5pcXVlUmVmPEFTVDo6 RXhwcmVzc2lvbj4sIEVycm9yPj4oWyZdKCkgewotICAgICAgICByZXR1cm4gcGFyc2VDYWxsRXhw cmVzc2lvbigpOwotICAgIH0pOwotICAgIGlmIChhc3NpZ25tZW50KQotICAgICAgICByZXR1cm4g YXNzaWdubWVudDsKLQogICAgIHJldHVybiBVbmV4cGVjdGVkPEVycm9yPihhc3NpZ25tZW50LmVy cm9yKCkpOwogfQogCg==