197885 2019-05-14 09:47:08 -0700 REGRESSION (r245249): ASSERTION FAILED: !m_needExceptionCheck seen with stress/proxy-delete.js and stress/proxy-property-descriptor.js 2019-05-14 14:38:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197693 InRadar P2 Normal --- 1 ryanhaddad tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1536102 0 ryanhaddad 2019-05-14 09:47:08 -0700 ASSERTION FAILED: !m_needExceptionCheck seen with stress/proxy-delete.js and stress/proxy-property-descriptor.js on the JSC Debug bot stress/proxy-delete.js.default: ERROR: Unchecked JS exception: stress/proxy-delete.js.default: This scope can throw a JS exception: getOwnPropertyDescriptor @ ./runtime/JSObject.cpp:3444 stress/proxy-delete.js.default: (ExceptionScope::m_recursionDepth was 6) stress/proxy-delete.js.default: But the exception was unchecked as of this scope: performDelete @ ./runtime/ProxyObject.cpp:615 stress/proxy-delete.js.default: (ExceptionScope::m_recursionDepth was 5) stress/proxy-delete.js.default: stress/proxy-delete.js.default: Unchecked exception detected at: stress/proxy-delete.js.default: 1 0x1140c10b3 JSC::VM::verifyExceptionCheckNeedIsSatisfied(unsigned int, JSC::ExceptionEventLocation&) stress/proxy-delete.js.default: 2 0x114098e21 JSC::ThrowScope::throwException(JSC::ExecState*, JSC::JSObject*) stress/proxy-delete.js.default: 3 0x112e6ea15 JSC::throwException(JSC::ExecState*, JSC::ThrowScope&, JSC::JSObject*) stress/proxy-delete.js.default: 4 0x113e17557 JSC::throwTypeError(JSC::ExecState*, JSC::ThrowScope&, WTF::String const&) stress/proxy-delete.js.default: 5 0x113e176d0 JSC::throwTypeError(JSC::ExecState*, JSC::ThrowScope&, WTF::ASCIILiteral) stress/proxy-delete.js.default: 6 0x1137364ad JSC::throwVMTypeError(JSC::ExecState*, JSC::ThrowScope&, WTF::ASCIILiteral) stress/proxy-delete.js.default: 7 0x11400ad71 bool JSC::ProxyObject::performDelete<JSC::ProxyObject::deleteProperty(JSC::JSCell*, JSC::ExecState*, JSC::PropertyName)::$_4>(JSC::ExecState*, JSC::PropertyName, JSC::ProxyObject::deleteProperty(JSC::JSCell*, JSC::ExecState*, JSC::PropertyName)::$_4) stress/proxy-delete.js.default: 8 0x1140057c5 JSC::ProxyObject::deleteProperty(JSC::JSCell*, JSC::ExecState*, JSC::PropertyName) stress/proxy-delete.js.default: 9 0x113b59523 operationDeleteById stress/proxy-delete.js.default: 10 0x113b59345 operationDeleteByIdJSResult stress/proxy-delete.js.default: 11 0x7491489f233 stress/proxy-delete.js.default: 12 0x112e3ce13 vmEntryToJavaScript stress/proxy-delete.js.default: 13 0x113abc00e JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) stress/proxy-delete.js.default: 14 0x113abb5a0 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*) stress/proxy-delete.js.default: 15 0x113de7345 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) stress/proxy-delete.js.default: 16 0x10fc5e277 runWithOptions(GlobalObject*, CommandLine&, bool&) stress/proxy-delete.js.default: 17 0x10fc33daa jscmain(int, char**)::$_6::operator()(JSC::VM&, GlobalObject*, bool&) const stress/proxy-delete.js.default: 18 0x10fc13204 int runJSC<jscmain(int, char**)::$_6>(CommandLine const&, bool, jscmain(int, char**)::$_6 const&) stress/proxy-delete.js.default: 19 0x10fc11931 jscmain(int, char**) stress/proxy-delete.js.default: 20 0x10fc1179e main stress/proxy-delete.js.default: 21 0x7fff615ed015 start https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/2788 1536103 1 webkit-bug-importer 2019-05-14 09:47:42 -0700 <rdar://problem/50770190> 1536104 2 webkit-bug-importer 2019-05-14 09:47:43 -0700 <rdar://problem/50770194> 1536121 3 369864 tzagallo 2019-05-14 10:12:42 -0700 Created attachment 369864 Patch 1536237 4 369864 ysuzuki 2019-05-14 14:10:15 -0700 Comment on attachment 369864 Patch r=me 1536255 5 369864 commit-queue 2019-05-14 14:38:18 -0700 Comment on attachment 369864 Patch Clearing flags on attachment: 369864 Committed r245311: <https://trac.webkit.org/changeset/245311> 1536256 6 commit-queue 2019-05-14 14:38:19 -0700 All reviewed patches have been landed. Closing bug. 369864 2019-05-14 10:12:42 -0700 2019-05-14 14:38:18 -0700 Patch bug-197885-20190514191240.patch text/plain 2690 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1Mjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj MjBmOTNiMjk3MzAxZDA3MGJjZDU5MjI2ZWMwYmNiOGM4OWE2YzExLi5kYTA5MTJkMzA1NjU2NmY4 NzEzYWMyNTM3ZjVlYzQ2YjUyYmNlMmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0wNS0xNCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjQ1MjQ5KTogQVNTRVJUSU9OIEZBSUxFRDogIW1f bmVlZEV4Y2VwdGlvbkNoZWNrIHNlZW4gd2l0aCBzdHJlc3MvcHJveHktZGVsZXRlLmpzIGFuZCBz dHJlc3MvcHJveHktcHJvcGVydHktZGVzY3JpcHRvci5qcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3ODg1CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81MDc3MDE5MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbiByMjQ1MjQ5IHdlIGFkZGVkIGEgdGhyb3cgc2NvcGUgdG8gSlNPYmplY3Q6OmdldE93 blByb3BlcnR5RGVzY3JpcHRvciBhbmQgaXRzCisgICAgICAgIGNhbGxlcnMgbm93IG5lZWQgdG8g Y2hlY2sgZm9yIGV4Y2VwdGlvbnMuCisKKyAgICAgICAgKiBydW50aW1lL1Byb3h5T2JqZWN0LmNw cDoKKyAgICAgICAgKEpTQzo6cGVyZm9ybVByb3h5R2V0KToKKyAgICAgICAgKEpTQzo6UHJveHlP YmplY3Q6OnBlcmZvcm1EZWxldGUpOgorCiAyMDE5LTA1LTEzICBZdXN1a2UgU3V6dWtpICA8eXN1 enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gQ29tcHJlc3MgSklUIHJlbGF0ZWQgZGF0 YSBtb3JlIGJ5IHVzaW5nIFBhY2tlZDw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9Qcm94eU9iamVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9Qcm94eU9iamVjdC5jcHAKaW5kZXggZTc4MDY2ZTRkOGNiZmM3ZGE3ZTE2YWU4N2NjN2M0NGYx YWI1YjdjNS4uYzdiYjJkYzNlMTUxODMyOGY4ZGIzNzA4ZTQ4M2JkMjJkNDBiZjZjYyAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJveHlPYmplY3QuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Byb3h5T2JqZWN0LmNwcApAQCAtMTY3LDcg KzE2Nyw5IEBAIHN0YXRpYyBKU1ZhbHVlIHBlcmZvcm1Qcm94eUdldChFeGVjU3RhdGUqIGV4ZWMs IFByb3h5T2JqZWN0KiBwcm94eU9iamVjdCwgSlNWYWx1CiAgICAgUkVUVVJOX0lGX0VYQ0VQVElP TihzY29wZSwgeyB9KTsKIAogICAgIFByb3BlcnR5RGVzY3JpcHRvciBkZXNjcmlwdG9yOwotICAg IGlmICh0YXJnZXQtPmdldE93blByb3BlcnR5RGVzY3JpcHRvcihleGVjLCBwcm9wZXJ0eU5hbWUs IGRlc2NyaXB0b3IpKSB7CisgICAgYm9vbCByZXN1bHQgPSB0YXJnZXQtPmdldE93blByb3BlcnR5 RGVzY3JpcHRvcihleGVjLCBwcm9wZXJ0eU5hbWUsIGRlc2NyaXB0b3IpOworICAgIEVYQ0VQVElP Tl9BU1NFUlQoIXNjb3BlLmV4Y2VwdGlvbigpIHx8ICFyZXN1bHQpOworICAgIGlmIChyZXN1bHQp IHsKICAgICAgICAgaWYgKGRlc2NyaXB0b3IuaXNEYXRhRGVzY3JpcHRvcigpICYmICFkZXNjcmlw dG9yLmNvbmZpZ3VyYWJsZSgpICYmICFkZXNjcmlwdG9yLndyaXRhYmxlKCkpIHsKICAgICAgICAg ICAgIGlmICghc2FtZVZhbHVlKGV4ZWMsIGRlc2NyaXB0b3IudmFsdWUoKSwgdHJhcFJlc3VsdCkp CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRocm93VHlwZUVycm9yKGV4ZWMsIHNjb3BlLCAiUHJv eHkgaGFuZGxlcidzICdnZXQnIHJlc3VsdCBvZiBhIG5vbi1jb25maWd1cmFibGUgYW5kIG5vbi13 cml0YWJsZSBwcm9wZXJ0eSBzaG91bGQgYmUgdGhlIHNhbWUgdmFsdWUgYXMgdGhlIHRhcmdldCdz IHByb3BlcnR5Il9zKTsKQEAgLTY1MCw3ICs2NTIsOSBAQCBib29sIFByb3h5T2JqZWN0OjpwZXJm b3JtRGVsZXRlKEV4ZWNTdGF0ZSogZXhlYywgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSwgRGVm YQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBQcm9wZXJ0eURlc2NyaXB0b3IgZGVzY3Jp cHRvcjsKLSAgICBpZiAodGFyZ2V0LT5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoZXhlYywgcHJv cGVydHlOYW1lLCBkZXNjcmlwdG9yKSkgeworICAgIGJvb2wgcmVzdWx0ID0gdGFyZ2V0LT5nZXRP d25Qcm9wZXJ0eURlc2NyaXB0b3IoZXhlYywgcHJvcGVydHlOYW1lLCBkZXNjcmlwdG9yKTsKKyAg ICBFWENFUFRJT05fQVNTRVJUKCFzY29wZS5leGNlcHRpb24oKSB8fCAhcmVzdWx0KTsKKyAgICBp ZiAocmVzdWx0KSB7CiAgICAgICAgIGlmICghZGVzY3JpcHRvci5jb25maWd1cmFibGUoKSkgewog ICAgICAgICAgICAgdGhyb3dWTVR5cGVFcnJvcihleGVjLCBzY29wZSwgIlByb3h5IGhhbmRsZXIn cyAnZGVsZXRlUHJvcGVydHknIG1ldGhvZCBzaG91bGQgcmV0dXJuIGZhbHNlIHdoZW4gdGhlIHRh cmdldCdzIHByb3BlcnR5IGlzIG5vdCBjb25maWd1cmFibGUiX3MpOwogICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwo=