197812 2019-05-10 21:00:45 -0700 [ews-app] Status bubble should turn orange when any build step fails 2019-05-17 14:14:12 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198000 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard lforschler webkit-bug-importer oldest_to_newest 1535312 0 aakash_jain 2019-05-10 21:00:45 -0700 [ews-app] Status bubble should turn orange when any build step fails. This would be similar to old EWS behavior. This should make engineers pay more attention to the EWS when one of step in build has failed, but the build hasn't finished (EWS might be retrying to confirm if the issue is pre-existing). It is especially important to look into EWS when there is some failure. EWS might take additional time between finding the first failure and confirming the failure (since it need to retry the patch, and do clean build etc.). During that time status-bubbles should be orange so that they are more noticeable. 1535313 1 369636 aakash_jain 2019-05-10 21:04:10 -0700 Created attachment 369636 Patch 1536078 2 369636 commit-queue 2019-05-14 09:18:29 -0700 Comment on attachment 369636 Patch Clearing flags on attachment: 369636 Committed r245282: <https://trac.webkit.org/changeset/245282> 1536079 3 commit-queue 2019-05-14 09:18:31 -0700 All reviewed patches have been landed. Closing bug. 1536082 4 webkit-bug-importer 2019-05-14 09:19:51 -0700 <rdar://problem/50769123> 369636 2019-05-10 21:04:10 -0700 2019-05-14 09:18:29 -0700 Patch bug-197812-20190511000408.patch text/plain 2284 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NTIwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA1LTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gU3RhdHVzIGJ1YmJsZSBzaG91bGQgdHVybiBvcmFuZ2Ug d2hlbiBhbnkgYnVpbGQgc3RlcCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk3ODEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9z dGF0dXNidWJibGUucHk6CisgICAgICAgIChTdGF0dXNCdWJibGUuX2J1aWxkX2J1YmJsZSk6IFR1 cm4gc3RhdHVzLWJ1YmJsZSBvcmFuZ2UgaWYgdGhlcmUgaXMgYW55IGZhaWxlZCBzdGVwIGluIHRo ZSBvbi1nb2luZyBidWlsZC4KKyAgICAgICAgKFN0YXR1c0J1YmJsZS5fZG9lc19idWlsZF9jb250 YWluc19hbnlfZmFpbGVkX3N0ZXApOiBNZXRob2QgdG8gY2hlY2sgaWYgYnVpbGQgY29udGFpbnMg YW55IGZhaWxlZCBzdGVwLgorCiAyMDE5LTA1LTEwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IFByb2Nlc3NTd2FwLk9wZW5lckxpbmtB ZnRlckFQSUNvbnRyb2xsZWRQcm9jZXNzU3dhcHBpbmdPZk9wZW5lciBBUEkgdGVzdApJbmRleDog VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdz L3N0YXR1c2J1YmJsZS5weQkocmV2aXNpb24gMjQ1MjA0KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5CSh3b3JraW5nIGNvcHkpCkBA IC03MSw3ICs3MSwxMCBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAgICAgIGJ1aWxk ZXJfZnVsbF9uYW1lID0gYnVpbGQuYnVpbGRlcl9uYW1lLnJlcGxhY2UoJy0nLCAnICcpCiAKICAg ICAgICAgaWYgYnVpbGQucmVzdWx0IGlzIE5vbmU6ICAjIEluLXByb2dyZXNzIGJ1aWxkCi0gICAg ICAgICAgICBidWJibGVbJ3N0YXRlJ10gPSAnc3RhcnRlZCcKKyAgICAgICAgICAgIGlmIHNlbGYu X2RvZXNfYnVpbGRfY29udGFpbnNfYW55X2ZhaWxlZF9zdGVwKGJ1aWxkKToKKyAgICAgICAgICAg ICAgICBidWJibGVbJ3N0YXRlJ10gPSAncHJvdmlzaW9uYWwtZmFpbCcKKyAgICAgICAgICAgIGVs c2U6CisgICAgICAgICAgICAgICAgYnViYmxlWydzdGF0ZSddID0gJ3N0YXJ0ZWQnCiAgICAgICAg ICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ0J1aWxkIGlzIGluLXByb2dyZXNzLiBS ZWNlbnQgbWVzc2FnZXM6XG5cbicgKyBzZWxmLl9zdGVwc19tZXNzYWdlcyhidWlsZCkKICAgICAg ICAgZWxpZiBidWlsZC5yZXN1bHQgPT0gQnVpbGRib3QuU1VDQ0VTUzoKICAgICAgICAgICAgIGlm IGlzX3BhcmVudF9idWlsZDoKQEAgLTE1MCw2ICsxNTMsMTIgQEAgY2xhc3MgU3RhdHVzQnViYmxl KFZpZXcpOgogICAgIGRlZiBfc2hvdWxkX2Rpc3BsYXlfc3RlcChzZWxmLCBzdGVwKToKICAgICAg ICAgcmV0dXJuIG5vdCBmaWx0ZXIobGFtYmRhIHN0ZXBfdG9faGlkZTogcmUuc2VhcmNoKHN0ZXBf dG9faGlkZSwgc3RlcC5zdGF0ZV9zdHJpbmcpLCBTdGF0dXNCdWJibGUuU1RFUFNfVE9fSElERSkK IAorICAgIGRlZiBfZG9lc19idWlsZF9jb250YWluc19hbnlfZmFpbGVkX3N0ZXAoc2VsZiwgYnVp bGQpOgorICAgICAgICBmb3Igc3RlcCBpbiBidWlsZC5zdGVwX3NldC5hbGwoKToKKyAgICAgICAg ICAgIGlmIHN0ZXAucmVzdWx0IGFuZCBzdGVwLnJlc3VsdCAhPSBCdWlsZGJvdC5TVUNDRVNTOgor ICAgICAgICAgICAgICAgIHJldHVybiBUcnVlCisgICAgICAgIHJldHVybiBGYWxzZQorCiAgICAg ZGVmIF9tb3N0X3JlY2VudF9zdGVwX21lc3NhZ2Uoc2VsZiwgYnVpbGQpOgogICAgICAgICByZWNl bnRfc3RlcCA9IGJ1aWxkLnN0ZXBfc2V0Lmxhc3QoKQogICAgICAgICBpZiBub3QgcmVjZW50X3N0 ZXA6Cg==