197807 2019-05-10 17:47:04 -0700 Call to JSToWasmICCallee::createStructure passes in wrong prototype value 2019-05-10 18:40:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1535278 0 saam 2019-05-10 17:47:04 -0700 ... 1535279 1 saam 2019-05-10 17:48:06 -0700 <rdar://problem/50530400> 1535281 2 369626 saam 2019-05-10 17:51:25 -0700 Created attachment 369626 patch 1535282 3 369626 ysuzuki 2019-05-10 17:52:10 -0700 Comment on attachment 369626 patch r=me 1535283 4 369626 keith_miller 2019-05-10 17:52:46 -0700 Comment on attachment 369626 patch View in context: https://bugs.webkit.org/attachment.cgi?id=369626&action=review > JSTests/stress/js-to-wasm-callee-has-correct-prototype.js:1 > +//@ runDefault("--jitPolicyScale=0", "--useSamplingProfiler=1") Don't we usually put these tests in the wasm directory? 1535284 5 saam 2019-05-10 17:53:28 -0700 (In reply to Keith Miller from comment #4) > Comment on attachment 369626 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369626&action=review > > > JSTests/stress/js-to-wasm-callee-has-correct-prototype.js:1 > > +//@ runDefault("--jitPolicyScale=0", "--useSamplingProfiler=1") > > Don't we usually put these tests in the wasm directory? Not always. If you grep through stress you will find some Wasm tests. 1535285 6 saam 2019-05-10 17:53:58 -0700 (In reply to Saam Barati from comment #5) > (In reply to Keith Miller from comment #4) > > Comment on attachment 369626 [details] > > patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=369626&action=review > > > > > JSTests/stress/js-to-wasm-callee-has-correct-prototype.js:1 > > > +//@ runDefault("--jitPolicyScale=0", "--useSamplingProfiler=1") > > > > Don't we usually put these tests in the wasm directory? > > Not always. If you grep through stress you will find some Wasm tests. The reason I put it here is it allowed me to do the `runDefault` at the top. That'd be different if I made it a Wasm test unfortunately. 1535301 7 369626 commit-queue 2019-05-10 18:40:05 -0700 Comment on attachment 369626 patch Clearing flags on attachment: 369626 Committed r245203: <https://trac.webkit.org/changeset/245203> 1535303 8 commit-queue 2019-05-10 18:40:07 -0700 All reviewed patches have been landed. Closing bug. 369626 2019-05-10 17:51:25 -0700 2019-05-10 18:40:05 -0700 patch b-backup.diff text/plain 3688 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDUyMDIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTA1LTEwICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIENhbGwgdG8gSlNUb1dhc21JQ0NhbGxlZTo6Y3JlYXRlU3RydWN0dXJl IHBhc3NlcyBpbiB3cm9uZyBwcm90b3R5cGUgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzgwNworICAgICAgICA8cmRhcjovL3Byb2JsZW0v NTA1MzA0MDA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBzdHJlc3MvanMtdG8td2FzbS1jYWxsZWUtaGFzLWNvcnJlY3QtcHJvdG90eXBlLmpzOiBB ZGRlZC4KKyAgICAgICAgKHRlc3QuZ2V0SW5zdGFuY2UpOgorICAgICAgICAodGVzdCk6CisKIDIw MTktMDUtMTAgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAg ICAgIFtUZXN0MjYyXSBVbnJldmlld2VkIGV4cGVjdGF0aW9ucyB1cGRhdGUgZm9sbG93aW5nIHIy NDUxODguCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9qcy10by13YXNtLWNhbGxlZS1oYXMtY29ycmVj dC1wcm90b3R5cGUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvanMtdG8td2FzbS1j YWxsZWUtaGFzLWNvcnJlY3QtcHJvdG90eXBlLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMv c3RyZXNzL2pzLXRvLXdhc20tY2FsbGVlLWhhcy1jb3JyZWN0LXByb3RvdHlwZS5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDIyIEBACisvL0AgcnVuRGVmYXVsdCgiLS1qaXRQb2xpY3lTY2Fs ZT0wIiwgIi0tdXNlU2FtcGxpbmdQcm9maWxlcj0xIikKKworZnVuY3Rpb24gdGVzdCgpIHsKKyAg ICBmdW5jdGlvbiBnZXRJbnN0YW5jZShieXRlcykgeworICAgICAgICBsZXQgdTggPSBVaW50OEFy cmF5LmZyb20oYnl0ZXMsIHg9PnguY2hhckNvZGVBdCgwKSk7CisgICAgICAgIGxldCBtb2R1bGUg PSBuZXcgV2ViQXNzZW1ibHkuTW9kdWxlKHU4LmJ1ZmZlcik7CisgICAgICAgIHJldHVybiBuZXcg V2ViQXNzZW1ibHkuSW5zdGFuY2UobW9kdWxlKTsKKyAgICB9CisKKyAgICBsZXQgd2ViQXNtID0g Z2V0SW5zdGFuY2UoJ1wwYXNtXHgwMVwwXDBcMFx4MDFceDhFXHg4MFx4ODBceDgwXDBceDAzYFww XHgwMVx4N0ZgXDBceDAxXHg3RmBceDAxXHg3Rlx4MDFceDdGXHgwM1x4ODhceDgwXHg4MFx4ODBc MFx4MDdcMFwwXDBceDAxXHgwMVx4MDJceDAyXHgwNFx4ODVceDgwXHg4MFx4ODBcMFx4MDFwXHgw MVx4MDdceDA3XHgwN1x4OTFceDgwXHg4MFx4ODBcMFx4MDJceDA1Y2FsbHRcMFx4MDVceDA1Y2Fs bHVcMFx4MDZcdFx4OERceDgwXHg4MFx4ODBcMFx4MDFcMEFcMFx4MEJceDA3XDBceDAxXHgwMlx4 MDNceDA0XDBceDAyXG7Dhlx4ODBceDgwXHg4MFwwXHgwN1x4ODRceDgwXHg4MFx4ODBcMFwwQVx4 MDFceDBCXHg4NFx4ODBceDgwXHg4MFwwXDBBXHgwMlx4MEJceDg0XHg4MFx4ODBceDgwXDBcMEFc eDAzXHgwQlx4ODRceDgwXHg4MFx4ODBcMFwwQVx4MDRceDBCXHg4NFx4ODBceDgwXHg4MFwwXDBB XHgwNVx4MEJceDg3XHg4MFx4ODBceDgwXDBcMCBcMFx4MTFcMFwwXHgwQlx4ODdceDgwXHg4MFx4 ODBcMFwwIFwwXHgxMVx4MDFcMFx4MEInKTsKKworICAgIGZvciAobGV0IGogPSAwOyBqIDwgMTAw MDsgaisrKSB7CisgICAgICAgIHRyeSB7CisgICAgICAgICAgICB3ZWJBc20uZXhwb3J0cy5jYWxs dCgtMSk7CisgICAgICAgIH0gY2F0Y2goZSkge30KKyAgICB9CisKKyAgICBzYW1wbGluZ1Byb2Zp bGVyU3RhY2tUcmFjZXMoKTsKK30KKworaWYgKHRoaXMuV2ViQXNzZW1ibHkpCisgICAgdGVzdCgp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDUxOTcpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTktMDUtMTAgIFNhYW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAg ICAgQ2FsbCB0byBKU1RvV2FzbUlDQ2FsbGVlOjpjcmVhdGVTdHJ1Y3R1cmUgcGFzc2VzIGluIHdy b25nIHByb3RvdHlwZSB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk3ODA3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDUzMDQwMD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3ZXJlIHBh c3NpbmcgdGhlIGVtcHR5IHZhbHVlIGluc3RlYWQgb2YgbnVsbC4gSG93ZXZlciwgdGhlIGVtcHR5 CisgICAgICAgIHZhbHVlIG1lYW5zIHRoZSBTdHJ1Y3R1cmUgaXMgcG9seSBwcm90by4gVGhhdCdz IGRlZmluaXRlbHkgbm90IHRoZSBjYXNlCisgICAgICAgIGhlcmUuCisKKyAgICAgICAgKiBydW50 aW1lL0pTR2xvYmFsT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxPYmplY3Q6Omlu aXQpOgorCiAyMDE5LTA1LTEwICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAK ICAgICAgICAgW0pTQ10gU3RyaW5nIHN1YnN0cmluZyBvcGVyYXRpb24gc2hvdWxkIHJldHVybiBy b3BlcyBjb25zaXN0ZW50bHkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT R2xvYmFsT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0dsb2JhbE9iamVjdC5jcHAJKHJldmlzaW9uIDI0NTE5NykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTA2Miw3ICsxMDYyLDcgQEAgcHV0RGlyZWN0V2l0aG91dFRyYW5zaXRpb24odm0sIHZtLnByb3Bl cgogICAgICAgICAgICAgfSk7CiAgICAgICAgIG1fanNUb1dhc21JQ0NhbGxlZVN0cnVjdHVyZS5p bml0TGF0ZXIoCiAgICAgICAgICAgICBbXSAoY29uc3QgSW5pdGlhbGl6ZXI8U3RydWN0dXJlPiYg aW5pdCkgewotICAgICAgICAgICAgICAgIGluaXQuc2V0KEpTVG9XYXNtSUNDYWxsZWU6OmNyZWF0 ZVN0cnVjdHVyZShpbml0LnZtLCBpbml0Lm93bmVyLCBKU1ZhbHVlKCkpKTsKKyAgICAgICAgICAg ICAgICBpbml0LnNldChKU1RvV2FzbUlDQ2FsbGVlOjpjcmVhdGVTdHJ1Y3R1cmUoaW5pdC52bSwg aW5pdC5vd25lciwganNOdWxsKCkpKTsKICAgICAgICAgICAgIH0pOwogICAgICAgICBtX3dlYkFz c2VtYmx5V3JhcHBlckZ1bmN0aW9uU3RydWN0dXJlLmluaXRMYXRlcigKICAgICAgICAgICAgIFtd IChjb25zdCBJbml0aWFsaXplcjxTdHJ1Y3R1cmU+JiBpbml0KSB7Cg==