197790 2019-05-10 11:57:38 -0700 Bugzilla should convert "r12345" to a trac.webkit.org link 2021-04-08 05:41:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224325 InRadar P2 Normal --- 1 jer.noble jer.noble ap clopez commit-queue ddkilzer lforschler webkit-bug-importer oldest_to_newest 1535109 0 jer.noble 2019-05-10 11:57:38 -0700 Bugzilla should convert "r12345" to a trac.webkit.org link 1535111 1 369575 jer.noble 2019-05-10 11:59:28 -0700 Created attachment 369575 Patch 1535473 2 ap 2019-05-12 14:36:42 -0700 *** Bug 168722 has been marked as a duplicate of this bug. *** 1535477 3 369575 ap 2019-05-12 14:53:33 -0700 Comment on attachment 369575 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369575&action=review I guess this should work in the overwhelming majority of cases. > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:32 > +use Bugzilla::Constants; > +use Bugzilla::Group; > +use Bugzilla::User; Which of these are actually used? > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:38 > + my ($self, $args) = @_; > + my $regexes = $args->{'regexes'}; Too much indentation. > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:49 > + return qq{<a href="//trac.webkit.org/$revision">$text</a>}; Why not say "https:"? These are separate servers, and while both are https only, there is no strict coupling. 1535784 4 jer.noble 2019-05-13 14:27:10 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 369575 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369575&action=review > > I guess this should work in the overwhelming majority of cases. Yep, and we can clean up and add more regex's if we come across more cases. > > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:32 > > +use Bugzilla::Constants; > > +use Bugzilla::Group; > > +use Bugzilla::User; > > Which of these are actually used? Turns out, none. I've removed them and the extension still works. > > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:38 > > + my ($self, $args) = @_; > > + my $regexes = $args->{'regexes'}; > > Too much indentation. Fixed. > > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:49 > > + return qq{<a href="//trac.webkit.org/$revision">$text</a>}; > > Why not say "https:"? These are separate servers, and while both are https > only, there is no strict coupling. Sure; I guess we don't have to worry about CORS stuff during actual navigation. 1535785 5 369782 jer.noble 2019-05-13 14:29:27 -0700 Created attachment 369782 Patch for landing 1535850 6 369782 commit-queue 2019-05-13 16:09:12 -0700 Comment on attachment 369782 Patch for landing Clearing flags on attachment: 369782 Committed r245261: <https://trac.webkit.org/changeset/245261> 1535851 7 commit-queue 2019-05-13 16:09:13 -0700 All reviewed patches have been landed. Closing bug. 1535854 8 webkit-bug-importer 2019-05-13 16:10:22 -0700 <rdar://problem/50743739> 369575 2019-05-10 11:59:28 -0700 2019-05-13 14:29:25 -0700 Patch bug-197790-20190510115927.patch text/plain 5244 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MTU4CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA0OTRlYjIzMzQ5ZmUwNWM1NGJiMGM2MzY4NDBhY2I1ZWFmODU3Zjg5Li41NjU1ODVhZjI3 ZDBlMGYzZjIxZDhlY2ZhYjcwZjEyOTBkMWMxNzIwIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdz LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wNS0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KKworICAgICAgICBCdWd6aWxsYSBzaG91bGQgY29udmVydCAicjEyMzQ1IiB0 byBhIHRyYWMud2Via2l0Lm9yZyBsaW5rCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTc3OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGV4dGVuc2lvbnMvVHJhYy9Db25maWcucG06IEFkZGVkLgorICAg ICAgICAqIGV4dGVuc2lvbnMvVHJhYy9FeHRlbnNpb24ucG06IEFkZGVkLgorICAgICAgICAoYnVn X2Zvcm1hdF9jb21tZW50KToKKyAgICAgICAgKF9yZXBsYWNlX3JldmlzaW9uKToKKwogMjAxOS0w NC0wNCAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IGFub3RoZXIgc3RhdHVzLWJ1YmJsZSBpZnJhbWUgdG8gZGlzcGxheSByZXN1bHRzIGZyb20gbmV3 IEVXUwpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2V4dGVuc2lvbnMvVHJh Yy9Db25maWcucG0gYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvZXh0ZW5zaW9ucy9UcmFjL0Nv bmZpZy5wbQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi4wNTY0MGU3NGE5ZGNlNjkwY2U4YzY4NDQ5MzUyNjc1NGM0Y2Qx NDJmCi0tLSAvZGV2L251bGwKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2V4dGVuc2lv bnMvVHJhYy9Db25maWcucG0KQEAgLTAsMCArMSwzMiBAQAorIyBDb3B5cmlnaHQgKEMpIDIwMTkg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZp Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp b25zCisjIGFyZSBtZXQ6CisjIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVz dCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAyLiAgUmVkaXN0cmli dXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQK KyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg ZGlzY2xhaW1lciBpbiB0aGUKKyMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisjCisjIFRISVMgU09GVFdBUkUg SVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycg QU5EIEFOWQorIyBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQg Tk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisjIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklM SVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKKyMgRElTQ0xBSU1F RC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJ QUJMRSBGT1IgQU5ZCisjIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVY RU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisjIChJTkNMVURJTkcsIEJVVCBOT1Qg TElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsK KyMgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElP TikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OCisjIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVU SEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisjIChJTkNMVURJTkcg TkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVT RSBPRiBUSElTCisjIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZ IE9GIFNVQ0ggREFNQUdFLgorCitwYWNrYWdlIEJ1Z3ppbGxhOjpFeHRlbnNpb246OlRyYWM7CisK K3VzZSBzdHJpY3Q7Cit1c2Ugd2FybmluZ3M7CisKK3VzZSBjb25zdGFudCBOQU1FID0+ICJUcmFj IjsKK3VzZSBjb25zdGFudCBSRVFVSVJFRF9NT0RVTEVTID0+IFtdOwordXNlIGNvbnN0YW50IE9Q VElPTkFMX01PRFVMRVMgPT4gW107CisKK19fUEFDS0FHRV9fLT5OQU1FOwpkaWZmIC0tZ2l0IGEv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2V4dGVuc2lvbnMvVHJhYy9FeHRlbnNpb24ucG0gYi9X ZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvZXh0ZW5zaW9ucy9UcmFjL0V4dGVuc2lvbi5wbQpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5lZmZmZTExNzkwMmZlMWMyMzNhOTBiYzYzODU0MGM5N2M3YmEwZTlhCi0tLSAvZGV2 L251bGwKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2V4dGVuc2lvbnMvVHJhYy9FeHRl bnNpb24ucG0KQEAgLTAsMCArMSw1MyBAQAorIyBDb3B5cmlnaHQgKEMpIDIwMTkgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNv dXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBh cmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisjIGFy ZSBtZXQ6CisjIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4g dGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9u cyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAyLiAgUmVkaXN0cmlidXRpb25zIGlu IGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5v dGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1l ciBpbiB0aGUKKyMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92 aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklE RUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycgQU5EIEFOWQor IyBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlU RUQgVE8sIFRIRSBJTVBMSUVECisjIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBG SVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKKyMgRElTQ0xBSU1FRC4gSU4gTk8g RVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1Ig QU5ZCisjIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwg T1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisjIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBU TywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsKKyMgTE9TUyBP RiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZF UiBDQVVTRUQgQU5EIE9OCisjIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENP TlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisjIChJTkNMVURJTkcgTkVHTElHRU5D RSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElT CisjIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLgorCitwYWNrYWdlIEJ1Z3ppbGxhOjpFeHRlbnNpb246OlRyYWM7CisKK3VzZSBzdHJp Y3Q7Cit1c2Ugd2FybmluZ3M7CisKK3VzZSBwYXJlbnQgcXcoQnVnemlsbGE6OkV4dGVuc2lvbik7 CisKK3VzZSBCdWd6aWxsYTo6Q29uc3RhbnRzOwordXNlIEJ1Z3ppbGxhOjpHcm91cDsKK3VzZSBC dWd6aWxsYTo6VXNlcjsKKworb3VyICRWRVJTSU9OID0gIjEuMC4wIjsKKworc3ViIGJ1Z19mb3Jt YXRfY29tbWVudCB7CisgICAgbXkgKCRzZWxmLCAkYXJncykgPSBAXzsKKyAgICAgICAgbXkgJHJl Z2V4ZXMgPSAkYXJncy0+eydyZWdleGVzJ307CisKKyAgICAjIFNob3VsZCBtYXRjaCAicjEyMzQ1 IiBhbmQgInRyYWMud2Via2l0Lm9yZy9yMTIzNDUiIGJ1dCBub3QgImh0dHBzOi8vdHJhYy53ZWJr aXQub3JnL3IxMjM0NSIKKyAgICBwdXNoKEAkcmVnZXhlcywgeyBtYXRjaCA9PiBxci8oPzwhXC8p XGIoKHJbWzpkaWdpdDpdXXs1LH0pKVxiLywgcmVwbGFjZSA9PiBcJl9yZXBsYWNlX3JldmlzaW9u IH0pOworICAgIHB1c2goQCRyZWdleGVzLCB7IG1hdGNoID0+IHFyLyg/PCFcLykodHJhYy53ZWJr aXQub3JnXC8ocltbOmRpZ2l0Ol1dezUsfSkpXGIvLCByZXBsYWNlID0+IFwmX3JlcGxhY2VfcmV2 aXNpb24gfSk7Cit9CisKK3N1YiBfcmVwbGFjZV9yZXZpc2lvbiB7CisgICAgbXkgJGFyZ3MgPSBz aGlmdDsKKyAgICBteSAkdGV4dCA9ICRhcmdzLT57bWF0Y2hlc30tPlswXTsKKyAgICBteSAkcmV2 aXNpb24gPSAkYXJncy0+e21hdGNoZXN9LT5bMV07CisgICAgcmV0dXJuIHFxezxhIGhyZWY9Ii8v dHJhYy53ZWJraXQub3JnLyRyZXZpc2lvbiI+JHRleHQ8L2E+fTsKK307CisKKyMgVGhpcyBtdXN0 IGJlIHRoZSBsYXN0IGxpbmUgb2YgeW91ciBleHRlbnNpb24uCitfX1BBQ0tBR0VfXy0+TkFNRTsK 369782 2019-05-13 14:29:27 -0700 2019-05-13 16:09:12 -0700 Patch for landing bug-197790-20190513142926.patch text/plain 5180 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MTU4CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA0OTRlYjIzMzQ5ZmUwNWM1NGJiMGM2MzY4NDBhY2I1ZWFmODU3Zjg5Li5iZGZkZWIzNzlj MWZjNzQ1NTI0NDIyOGY3MjRkZGZlYzQ3NzMzZjBiIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdz LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wNS0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KKworICAgICAgICBCdWd6aWxsYSBzaG91bGQgY29udmVydCAicjEyMzQ1IiB0 byBhIHRyYWMud2Via2l0Lm9yZyBsaW5rCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTc3OTAKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJv c2t1cnlha292LgorCisgICAgICAgICogZXh0ZW5zaW9ucy9UcmFjL0NvbmZpZy5wbTogQWRkZWQu CisgICAgICAgICogZXh0ZW5zaW9ucy9UcmFjL0V4dGVuc2lvbi5wbTogQWRkZWQuCisgICAgICAg IChidWdfZm9ybWF0X2NvbW1lbnQpOgorICAgICAgICAoX3JlcGxhY2VfcmV2aXNpb24pOgorCiAy MDE5LTA0LTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgYW5vdGhlciBzdGF0dXMtYnViYmxlIGlmcmFtZSB0byBkaXNwbGF5IHJlc3VsdHMgZnJv bSBuZXcgRVdTCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvZXh0ZW5zaW9u cy9UcmFjL0NvbmZpZy5wbSBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9leHRlbnNpb25zL1Ry YWMvQ29uZmlnLnBtCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA1NjQwZTc0YTlkY2U2OTBjZThjNjg0NDkzNTI2NzU0 YzRjZDE0MmYKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvZXh0 ZW5zaW9ucy9UcmFjL0NvbmZpZy5wbQpAQCAtMCwwICsxLDMyIEBACisjIENvcHlyaWdodCAoQykg MjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJlZGlzdHJpYnV0aW9u IGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorIyBt b2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNv bmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMgMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29k ZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlz dCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjIDIuICBSZWRp c3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHly aWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv d2luZyBkaXNjbGFpbWVyIGluIHRoZQorIyAgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIg bWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyMKKyMgVEhJUyBTT0ZU V0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMg SVMnJyBBTkQgQU5ZCisjIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcs IEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKKyMgV0FSUkFOVElFUyBPRiBNRVJDSEFO VEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorIyBESVND TEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMg QkUgTElBQkxFIEZPUiBBTlkKKyMgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lB TCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMKKyMgKElOQ0xVRElORywgQlVU IE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJ Q0VTOworIyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJS VVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04KKyMgQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFks IFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xV RElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBU SEUgVVNFIE9GIFRISVMKKyMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lC SUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKK3BhY2thZ2UgQnVnemlsbGE6OkV4dGVuc2lvbjo6VHJh YzsKKwordXNlIHN0cmljdDsKK3VzZSB3YXJuaW5nczsKKwordXNlIGNvbnN0YW50IE5BTUUgPT4g IlRyYWMiOwordXNlIGNvbnN0YW50IFJFUVVJUkVEX01PRFVMRVMgPT4gW107Cit1c2UgY29uc3Rh bnQgT1BUSU9OQUxfTU9EVUxFUyA9PiBbXTsKKworX19QQUNLQUdFX18tPk5BTUU7CmRpZmYgLS1n aXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvZXh0ZW5zaW9ucy9UcmFjL0V4dGVuc2lvbi5w bSBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9leHRlbnNpb25zL1RyYWMvRXh0ZW5zaW9uLnBt Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmFhYWI1ZWE3MTVhM2UxYTU2NzIyYzFkZTJmMDg1ZThiNTY0Njk1NDYKLS0t IC9kZXYvbnVsbAorKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvZXh0ZW5zaW9ucy9UcmFj L0V4dGVuc2lvbi5wbQpAQCAtMCwwICsxLDQ5IEBACisjIENvcHlyaWdodCAoQykgMjAxOSBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorIyBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMK KyMgYXJlIG1ldDoKKyMgMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJl dGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25k aXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjIDIuICBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorIyAg ICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNj bGFpbWVyIGluIHRoZQorIyAgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxz IHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQ Uk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJyBBTkQg QU5ZCisjIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1Qg TElNSVRFRCBUTywgVEhFIElNUExJRUQKKyMgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkg QU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorIyBESVNDTEFJTUVELiBJ TiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxF IEZPUiBBTlkKKyMgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBM QVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMKKyMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1J VEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOworIyBM T1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI T1dFVkVSIENBVVNFRCBBTkQgT04KKyMgQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIg SU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdM SUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9G IFRISVMKKyMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCisKK3BhY2thZ2UgQnVnemlsbGE6OkV4dGVuc2lvbjo6VHJhYzsKKwordXNl IHN0cmljdDsKK3VzZSB3YXJuaW5nczsKKwordXNlIHBhcmVudCBxdyhCdWd6aWxsYTo6RXh0ZW5z aW9uKTsKKworb3VyICRWRVJTSU9OID0gIjEuMC4wIjsKKworc3ViIGJ1Z19mb3JtYXRfY29tbWVu dCB7CisgICAgbXkgKCRzZWxmLCAkYXJncykgPSBAXzsKKyAgICBteSAkcmVnZXhlcyA9ICRhcmdz LT57J3JlZ2V4ZXMnfTsKKworICAgICMgU2hvdWxkIG1hdGNoICJyMTIzNDUiIGFuZCAidHJhYy53 ZWJraXQub3JnL3IxMjM0NSIgYnV0IG5vdCAiaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvcjEyMzQ1 IgorICAgIHB1c2goQCRyZWdleGVzLCB7IG1hdGNoID0+IHFyLyg/PCFcLylcYigocltbOmRpZ2l0 Ol1dezUsfSkpXGIvLCByZXBsYWNlID0+IFwmX3JlcGxhY2VfcmV2aXNpb24gfSk7CisgICAgcHVz aChAJHJlZ2V4ZXMsIHsgbWF0Y2ggPT4gcXIvKD88IVwvKSh0cmFjLndlYmtpdC5vcmdcLyhyW1s6 ZGlnaXQ6XV17NSx9KSlcYi8sIHJlcGxhY2UgPT4gXCZfcmVwbGFjZV9yZXZpc2lvbiB9KTsKK30K Kworc3ViIF9yZXBsYWNlX3JldmlzaW9uIHsKKyAgICBteSAkYXJncyA9IHNoaWZ0OworICAgIG15 ICR0ZXh0ID0gJGFyZ3MtPnttYXRjaGVzfS0+WzBdOworICAgIG15ICRyZXZpc2lvbiA9ICRhcmdz LT57bWF0Y2hlc30tPlsxXTsKKyAgICByZXR1cm4gcXF7PGEgaHJlZj0iaHR0cHM6Ly90cmFjLndl YmtpdC5vcmcvJHJldmlzaW9uIj4kdGV4dDwvYT59OworfTsKKworIyBUaGlzIG11c3QgYmUgdGhl IGxhc3QgbGluZSBvZiB5b3VyIGV4dGVuc2lvbi4KK19fUEFDS0FHRV9fLT5OQU1FOwo=