197782 2019-05-10 09:48:56 -0700 Let WebKit clients supply an application name for user agent in modern compatibility mode 2019-05-10 12:58:44 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue thorton webkit-bug-importer yongjun_zhang oldest_to_newest 1535035 0 wenson_hsieh 2019-05-10 09:48:56 -0700 <rdar://problem/50646747> 1535041 1 369558 wenson_hsieh 2019-05-10 09:53:20 -0700 Created attachment 369558 Patch 1535130 2 369558 wenson_hsieh 2019-05-10 12:30:01 -0700 Comment on attachment 369558 Patch Thanks for the review! 1535141 3 369558 commit-queue 2019-05-10 12:58:43 -0700 Comment on attachment 369558 Patch Clearing flags on attachment: 369558 Committed r245189: <https://trac.webkit.org/changeset/245189> 1535142 4 commit-queue 2019-05-10 12:58:44 -0700 All reviewed patches have been landed. Closing bug. 369558 2019-05-10 09:53:20 -0700 2019-05-10 12:58:43 -0700 Patch bug-197782-20190510095319.patch text/plain 5525 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM2MmFmYzI2ZWNlMWY2YTY4 NjgyYTkxMTY0NDdmY2JiMTFhMDk4MmEuLmM5ODk3YTkzNjQ5ZTY0ZGU5MjA4ZTZjYzYxZTNmN2Vk ZDYxODE2YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDUtMTAgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgTGV0IFdlYktpdCBjbGll bnRzIHN1cHBseSBhbiBhcHBsaWNhdGlvbiBuYW1lIGZvciB1c2VyIGFnZW50IGluIG1vZGVybiBj b21wYXRpYmlsaXR5IG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5Nzc4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTA2NDY3NDc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHBsdW1iaW5n IGZvciBhIG5ldyBwcml2YXRlIHByb3BlcnR5IG9uIFdLV2VicGFnZVByZWZlcmVuY2VzLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9BUElXZWJzaXRlUG9saWNpZXMuY3BwOgorICAgICAgICAo QVBJOjpXZWJzaXRlUG9saWNpZXM6OmNvcHkgY29uc3QpOgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvQVBJV2Vic2l0ZVBvbGljaWVzLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYnBhZ2VQcmVmZXJlbmNlcy5tbToKKyAgICAgICAgKC1bV0tXZWJwYWdlUHJlZmVyZW5jZXMg X2FwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudFdpdGhNb2Rlcm5Db21wYXRpYmlsaXR5XSk6Cisg ICAgICAgICgtW1dLV2VicGFnZVByZWZlcmVuY2VzIF9zZXRBcHBsaWNhdGlvbk5hbWVGb3JVc2Vy QWdlbnRXaXRoTW9kZXJuQ29tcGF0aWJpbGl0eTpdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2VicGFnZVByZWZlcmVuY2VzUHJpdmF0ZS5oOgorCiAyMDE5LTA1LTA5ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgbW9zdCBvZiByMjQ1MTUxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0FQSVdlYnNpdGVQb2xpY2llcy5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQVBJV2Vic2l0ZVBvbGljaWVzLmNwcAppbmRleCA3ZTQ0MzM4MTQxMzQx ZjkwMWZjZmRiYWMzOTUxMjVjYTkxYzFjYjM2Li45OWU4MzBjZThkNGQ2MTNjZjlkYTg1MGIyMWNh ODEyODE5ODIzNjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJ V2Vic2l0ZVBvbGljaWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJ V2Vic2l0ZVBvbGljaWVzLmNwcApAQCAtNjYsNiArNjYsNyBAQCBSZWY8V2Vic2l0ZVBvbGljaWVz PiBXZWJzaXRlUG9saWNpZXM6OmNvcHkoKSBjb25zdAogICAgICAgICBjdXN0b21IZWFkZXJGaWVs ZHMuYXBwZW5kKFdlYkNvcmU6OkhUVFBIZWFkZXJGaWVsZChmaWVsZCkpOwogICAgIHBvbGljaWVz LT5zZXRDdXN0b21IZWFkZXJGaWVsZHMoV1RGTW92ZShjdXN0b21IZWFkZXJGaWVsZHMpKTsKICAg ICBwb2xpY2llcy0+c2V0QWxsb3dTaXRlU3BlY2lmaWNRdWlya3NUb092ZXJyaWRlQ29tcGF0aWJp bGl0eU1vZGUobV9hbGxvd1NpdGVTcGVjaWZpY1F1aXJrc1RvT3ZlcnJpZGVDb21wYXRpYmlsaXR5 TW9kZSk7CisgICAgcG9saWNpZXMtPnNldEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudFdpdGhN b2Rlcm5Db21wYXRpYmlsaXR5KG1fYXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50V2l0aE1vZGVy bkNvbXBhdGliaWxpdHkpOwogICAgIHJldHVybiBwb2xpY2llczsKIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSVdlYnNpdGVQb2xpY2llcy5oIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSVdlYnNpdGVQb2xpY2llcy5oCmluZGV4IGYyOTBiNjli NzNiN2VkNjQxNDRjNjhkOWJmNjU3NmJlMTY4ODFjZTAuLjRkNDkyNjlhODRhZDhkOGQ0NTRmYTY3 MGEzNzVhZWM0ZmRkZjZhNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9BUElXZWJzaXRlUG9saWNpZXMuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv QVBJV2Vic2l0ZVBvbGljaWVzLmgKQEAgLTEwNCw2ICsxMDQsOSBAQCBwdWJsaWM6CiAgICAgYm9v bCBhbGxvd1NpdGVTcGVjaWZpY1F1aXJrc1RvT3ZlcnJpZGVDb21wYXRpYmlsaXR5TW9kZSgpIGNv bnN0IHsgcmV0dXJuIG1fYWxsb3dTaXRlU3BlY2lmaWNRdWlya3NUb092ZXJyaWRlQ29tcGF0aWJp bGl0eU1vZGU7IH0KICAgICB2b2lkIHNldEFsbG93U2l0ZVNwZWNpZmljUXVpcmtzVG9PdmVycmlk ZUNvbXBhdGliaWxpdHlNb2RlKGJvb2wgdmFsdWUpIHsgbV9hbGxvd1NpdGVTcGVjaWZpY1F1aXJr c1RvT3ZlcnJpZGVDb21wYXRpYmlsaXR5TW9kZSA9IHZhbHVlOyB9CiAKKyAgICBXVEY6OlN0cmlu ZyBhcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnRXaXRoTW9kZXJuQ29tcGF0aWJpbGl0eSgpIGNv bnN0IHsgcmV0dXJuIG1fYXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50V2l0aE1vZGVybkNvbXBh dGliaWxpdHk7IH0KKyAgICB2b2lkIHNldEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudFdpdGhN b2Rlcm5Db21wYXRpYmlsaXR5KGNvbnN0IFdURjo6U3RyaW5nJiBhcHBsaWNhdGlvbk5hbWUpIHsg bV9hcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnRXaXRoTW9kZXJuQ29tcGF0aWJpbGl0eSA9IGFw cGxpY2F0aW9uTmFtZTsgfQorCiBwcml2YXRlOgogICAgIFdlYnNpdGVQb2xpY2llcyhib29sIGNv bnRlbnRCbG9ja2Vyc0VuYWJsZWQsIE9wdGlvblNldDxXZWJLaXQ6OldlYnNpdGVBdXRvcGxheVF1 aXJrPiwgV2ViS2l0OjpXZWJzaXRlQXV0b3BsYXlQb2xpY3ksIFZlY3RvcjxXZWJDb3JlOjpIVFRQ SGVhZGVyRmllbGQ+JiYsIFdlYktpdDo6V2Vic2l0ZVBvcFVwUG9saWN5LCBSZWZQdHI8V2Vic2l0 ZURhdGFTdG9yZT4mJik7CiAKQEAgLTEyNCw2ICsxMjcsNyBAQCBwcml2YXRlOgogICAgIFdlYktp dDo6V2Vic2l0ZU1lZGlhU291cmNlUG9saWN5IG1fbWVkaWFTb3VyY2VQb2xpY3kgeyBXZWJLaXQ6 OldlYnNpdGVNZWRpYVNvdXJjZVBvbGljeTo6RGVmYXVsdCB9OwogICAgIFdlYktpdDo6V2Vic2l0 ZVNpbXVsYXRlZE1vdXNlRXZlbnRzRGlzcGF0Y2hQb2xpY3kgbV9zaW11bGF0ZWRNb3VzZUV2ZW50 c0Rpc3BhdGNoUG9saWN5IHsgV2ViS2l0OjpXZWJzaXRlU2ltdWxhdGVkTW91c2VFdmVudHNEaXNw YXRjaFBvbGljeTo6RGVmYXVsdCB9OwogICAgIGJvb2wgbV9hbGxvd1NpdGVTcGVjaWZpY1F1aXJr c1RvT3ZlcnJpZGVDb21wYXRpYmlsaXR5TW9kZSB7IGZhbHNlIH07CisgICAgV1RGOjpTdHJpbmcg bV9hcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnRXaXRoTW9kZXJuQ29tcGF0aWJpbGl0eTsKIH07 CiAKIH0gLy8gbmFtZXNwYWNlIEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2VicGFnZVByZWZlcmVuY2VzLm1tIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2VicGFnZVByZWZlcmVuY2VzLm1tCmluZGV4IDM5MjJmMWM1ZTI2 OTExMGE3ZmM1YTc2NDk5YTY1ZjJkZjFkZjIyZjQuLjZhMzZiMWI1YWQzZTM4MTlkYTY2Yzc1ODM2 YWEzZWRjMWNhMmZiYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYnBhZ2VQcmVmZXJlbmNlcy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJwYWdlUHJlZmVyZW5jZXMubW0KQEAgLTI4Niw2ICsyODYsMTYgQEAg LSAodm9pZClfc2V0QWxsb3dTaXRlU3BlY2lmaWNRdWlya3NUb092ZXJyaWRlQ29tcGF0aWJpbGl0 eU1vZGU6KEJPT0wpdmFsdWUKICAgICBfd2Vic2l0ZVBvbGljaWVzLT5zZXRBbGxvd1NpdGVTcGVj aWZpY1F1aXJrc1RvT3ZlcnJpZGVDb21wYXRpYmlsaXR5TW9kZSh2YWx1ZSk7CiB9CiAKKy0gKE5T U3RyaW5nICopX2FwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudFdpdGhNb2Rlcm5Db21wYXRpYmls aXR5Cit7CisgICAgcmV0dXJuIF93ZWJzaXRlUG9saWNpZXMtPmFwcGxpY2F0aW9uTmFtZUZvclVz ZXJBZ2VudFdpdGhNb2Rlcm5Db21wYXRpYmlsaXR5KCk7Cit9CisKKy0gKHZvaWQpX3NldEFwcGxp Y2F0aW9uTmFtZUZvclVzZXJBZ2VudFdpdGhNb2Rlcm5Db21wYXRpYmlsaXR5OihOU1N0cmluZyAq KWFwcGxpY2F0aW9uTmFtZQoreworICAgIF93ZWJzaXRlUG9saWNpZXMtPnNldEFwcGxpY2F0aW9u TmFtZUZvclVzZXJBZ2VudFdpdGhNb2Rlcm5Db21wYXRpYmlsaXR5KGFwcGxpY2F0aW9uTmFtZSk7 Cit9CisKIC0gKEFQSTo6T2JqZWN0JilfYXBpT2JqZWN0CiB7CiAgICAgcmV0dXJuICpfd2Vic2l0 ZVBvbGljaWVzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2VicGFnZVByZWZlcmVuY2VzUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2VicGFnZVByZWZlcmVuY2VzUHJpdmF0ZS5oCmluZGV4IDY5MmYzMjk2ZDdh OTA5N2MzZGZkMGIyZmQ4N2ZkZTI2YjQ0NTQ1MDAuLjBiZDBmYWM2N2MyMmZiYmMyOWFiOWEzMmNi OGQ4OWM4NWI4YzZmM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYnBhZ2VQcmVmZXJlbmNlc1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJwYWdlUHJlZmVyZW5jZXNQcml2YXRlLmgKQEAgLTY5LDQg KzY5LDYgQEAgdHlwZWRlZiBOU19PUFRJT05TKE5TVUludGVnZXIsIF9XS1dlYnNpdGVEZXZpY2VP cmllbnRhdGlvbkFuZE1vdGlvbkFjY2Vzc1BvbGljeSkKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBz ZXR0ZXI9X3NldERldmljZU9yaWVudGF0aW9uQW5kTW90aW9uQWNjZXNzUG9saWN5OikgX1dLV2Vi c2l0ZURldmljZU9yaWVudGF0aW9uQW5kTW90aW9uQWNjZXNzUG9saWN5IF9kZXZpY2VPcmllbnRh dGlvbkFuZE1vdGlvbkFjY2Vzc1BvbGljeTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9 X3NldEFsbG93U2l0ZVNwZWNpZmljUXVpcmtzVG9PdmVycmlkZUNvbXBhdGliaWxpdHlNb2RlOikg Qk9PTCBfYWxsb3dTaXRlU3BlY2lmaWNRdWlya3NUb092ZXJyaWRlQ29tcGF0aWJpbGl0eU1vZGU7 CiAKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5LCBzZXR0ZXI9X3NldEFwcGxpY2F0aW9uTmFt ZUZvclVzZXJBZ2VudFdpdGhNb2Rlcm5Db21wYXRpYmlsaXR5OikgTlNTdHJpbmcgKl9hcHBsaWNh dGlvbk5hbWVGb3JVc2VyQWdlbnRXaXRoTW9kZXJuQ29tcGF0aWJpbGl0eTsKKwogQGVuZAo=