19778 2008-06-26 06:15:16 -0700 [Gtk] Initialize webview settings before running DRT tests 2008-06-27 15:27:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo webkit-unassigned oldest_to_newest 84470 0 jmalonzo 2008-06-26 06:15:16 -0700 We need to initialize WebView settings before running the tests as some tests depend on font family, sizes, etc... 84471 1 21946 jmalonzo 2008-06-26 06:17:29 -0700 Created attachment 21946 Initialize webView settings before running test This matches some of Mac's font settings. Is there anything else I'm missing? (apart from the ones that are not yet implemented) 84592 2 21946 christian 2008-06-27 10:52:03 -0700 Comment on attachment 21946 Initialize webView settings before running test >+ g_object_set(G_OBJECT(settings), >+ "default-font-family", "Times", >+ "monospace-font-family", "Courier", >+ "serif-font-family", "Times", >+ "sans-serif-font-family", "Helvetica", >+ "default-font-size", 16, >+ "default-monospace-font-size", 13, >+ "minimum-font-size", 1, >+ NULL); This looks fine to me. > This matches some of Mac's font settings. Is there anything else I'm missing? You might also disable the back forward list via webkit_web_view_set_maintains_back_forward_list. According to a comment in the mac port leaving it enabled, which is the case by default, can cause layout bugs. 84608 3 jmalonzo 2008-06-27 15:27:57 -0700 Thanks. Landed in r34837. The backforward patch will be a different patch. 21946 2008-06-26 06:17:29 -0700 2008-06-27 10:52:03 -0700 Initialize webView settings before running test webkitgtk-drt-initwebviewstate.patch text/plain 1393 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJl ZS5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3Bw CmluZGV4IGFmNjU4NjMuLjA0MGY4MzUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtMjA2LDYgKzIwNiwyMSBAQCB2b2lkIGR1 bXAoKQogICAgIGRvbmUgPSB0cnVlOwogfQogCitzdGF0aWMgdm9pZCBzZXREZWZhdWx0c1RvQ29u c2lzdGVudFN0YXRlVmFsdWVzRm9yVGVzdGluZygpCit7CisgICAgV2ViS2l0V2ViU2V0dGluZ3Mg KnNldHRpbmdzID0gd2Via2l0X3dlYl92aWV3X2dldF9zZXR0aW5ncyh3ZWJWaWV3KTsKKworICAg IGdfb2JqZWN0X3NldChHX09CSkVDVChzZXR0aW5ncyksCisgICAgICAgICAgICAgICAgICJkZWZh dWx0LWZvbnQtZmFtaWx5IiwgIlRpbWVzIiwKKyAgICAgICAgICAgICAgICAgIm1vbm9zcGFjZS1m b250LWZhbWlseSIsICJDb3VyaWVyIiwKKyAgICAgICAgICAgICAgICAgInNlcmlmLWZvbnQtZmFt aWx5IiwgIlRpbWVzIiwKKyAgICAgICAgICAgICAgICAgInNhbnMtc2VyaWYtZm9udC1mYW1pbHki LCAiSGVsdmV0aWNhIiwKKyAgICAgICAgICAgICAgICAgImRlZmF1bHQtZm9udC1zaXplIiwgMTYs CisgICAgICAgICAgICAgICAgICJkZWZhdWx0LW1vbm9zcGFjZS1mb250LXNpemUiLCAxMywKKyAg ICAgICAgICAgICAgICAgIm1pbmltdW0tZm9udC1zaXplIiwgMSwKKyAgICAgICAgICAgICAgICAg TlVMTCk7Cit9CisKIHN0YXRpYyB2b2lkIHJ1blRlc3QoY29uc3QgY2hhciogcGF0aE9yVVJMKQog ewogICAgIGdjaGFyKiB1cmwgPSBhdXRvY29ycmVjdFVSTChwYXRoT3JVUkwpOwpAQCAtMzUzLDYg KzM2OCw4IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiAgICAgZ19zaWduYWxf Y29ubmVjdChHX09CSkVDVCh3ZWJWaWV3KSwgInNjcmlwdC1wcm9tcHQiLCBHX0NBTExCQUNLKHdl YlZpZXdTY3JpcHRQcm9tcHQpLCAwKTsKICAgICBnX3NpZ25hbF9jb25uZWN0KEdfT0JKRUNUKHdl YlZpZXcpLCAic2NyaXB0LWNvbmZpcm0iLCBHX0NBTExCQUNLKHdlYlZpZXdTY3JpcHRDb25maXJt KSwgMCk7CiAKKyAgICBzZXREZWZhdWx0c1RvQ29uc2lzdGVudFN0YXRlVmFsdWVzRm9yVGVzdGlu ZygpOworCiAgICAgaWYgKGFyZ2MgPT0gb3B0aW5kKzEgJiYgc3RyY21wKGFyZ3Zbb3B0aW5kXSwg Ii0iKSA9PSAwKSB7CiAgICAgICAgIGNoYXIgZmlsZW5hbWVCdWZmZXJbMjA0OF07CiAgICAgICAg IHByaW50U2VwYXJhdG9ycyA9IHRydWU7Cg==