197766 2019-05-09 21:42:57 -0700 When the scroller hosting a shared layer becomes non-scrollable, content disappears 2019-05-11 13:58:59 -0700 1 1 1 Unclassified WebKit Compositing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 197561 1 simon.fraser simon.fraser commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1534947 0 369542 simon.fraser 2019-05-09 21:42:57 -0700 Created attachment 369542 Testcase Attached testcase shows a bug where when a scroller becomes non-scrollable, we change the layer configuration in a way that ends up leaving content unpainted. 1535365 1 webkit-bug-importer 2019-05-11 11:54:27 -0700 <rdar://problem/50695808> 1535366 2 369657 simon.fraser 2019-05-11 11:55:19 -0700 Created attachment 369657 Patch 1535367 3 369657 zalan 2019-05-11 11:59:45 -0700 Comment on attachment 369657 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369657&action=review > Source/WebCore/ChangeLog:10 > + its backing store. We always made backing for overlap layers, so even if the sharing layers even if (extra whitespace) 1535374 4 369657 commit-queue 2019-05-11 13:58:57 -0700 Comment on attachment 369657 Patch Clearing flags on attachment: 369657 Committed r245206: <https://trac.webkit.org/changeset/245206> 1535375 5 commit-queue 2019-05-11 13:58:59 -0700 All reviewed patches have been landed. Closing bug. 369542 2019-05-09 21:42:57 -0700 2019-05-09 21:42:57 -0700 Testcase shared-layer-has-reflection.html text/html 1357 simon.fraser PCFET0NUWVBFIGh0bWw+IDwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgaW50ZXJuYWw6QXN5bmNP dmVyZmxvd1Njcm9sbGluZ0VuYWJsZWQ9dHJ1ZSBdIC0tPgo8aHRtbD4KPGhlYWQ+CiAgICA8dGl0 bGU+VGVzdHMgcGFpbnRpbmcgb2YgYSByZWZsZWN0ZWQgbGF5ZXIgaW50byBzaGFyZWQgYmFja2lu ZzwvdGl0bGU+CiAgICA8c3R5bGU+CiAgICAgICAgLnNjcm9sbGFibGUgewogICAgICAgICAgICBv dmVyZmxvdzogc2Nyb2xsOwogICAgICAgICAgICBoZWlnaHQ6IDQwMHB4OwogICAgICAgICAgICB3 aWR0aDogMzAwcHg7CiAgICAgICAgICAgIG1hcmdpbjogMTBweDsKICAgICAgICAgICAgYm9yZGVy OiAxcHggc29saWQgYmxhY2s7CiAgICAgICAgfQoKICAgICAgICAuc2hhcmluZyB7CiAgICAgICAg ICAgIG1hcmdpbjogMjBweDsKICAgICAgICAgICAgd2lkdGg6IDE1MHB4OwogICAgICAgICAgICBo ZWlnaHQ6IDEzMHB4OwogICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKICAgICAg ICAgICAgYm9yZGVyLWJvdHRvbTogMjBweCBzb2xpZCBvcmFuZ2U7Ci8qICAgICAgICAgICAgLXdl YmtpdC1ib3gtcmVmbGVjdDogYmVsb3cgMTBweDsqLwovKiAgICAgICAgICAgIGZpbHRlcjogc2F0 dXJhdGUoMCk7Ki8KICAgICAgICAgICAgb3BhY2l0eTogMC41OwogICAgICAgIH0KICAgIAogICAg ICAgIC5zcGFjZXIgewogICAgICAgICAgICBoZWlnaHQ6IDUwMHB4OwogICAgICAgICAgICB3aWR0 aDogMjBweDsKICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogc2lsdmVyOwogICAgICAgIH0K ICAgICAgICAKICAgICAgICAuc3BhY2VyOmhvdmVyIHsKICAgICAgICAgICAgaGVpZ2h0OiAxMDBw eDsKICAgICAgICB9CiAgICAgICAgCiAgICAgICAgLnNwYWNlci5jaGFuZ2VkIHsKICAgICAgICAg ICAgaGVpZ2h0OiAxMDBweDsKICAgICAgICB9CiAgICA8L3N0eWxlPgogICAgPHNjcmlwdD4KICAg ICAgICAKICAgICAgICAKICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsICgp ID0+IHsKICAgICAgICAgICAgCiAgICAgICAgICAgIHNldFRpbWVvdXQoKCkgPT4gewogICAgICAg ICAgICAgICAgZG9jdW1lbnQucXVlcnlTZWxlY3RvcignLnNwYWNlcicpLmNsYXNzTGlzdC5hZGQo J2NoYW5nZWQnKTsKICAgICAgICAgICAgfSwgNTAwKTsKICAgICAgICB9LCBmYWxzZSk7CiAgICA8 L3NjcmlwdD4KPC9oZWFkPgo8Ym9keT4KICAgIDxkaXYgY2xhc3M9InNjcm9sbGFibGUiPgogICAg ICAgIDxkaXYgY2xhc3M9InNoYXJpbmciPgogICAgICAgIDwvZGl2PgogICAgICAgIDxkaXYgY2xh c3M9InNwYWNlciI+PC9kaXY+CiAgICA8L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+Cg== 369657 2019-05-11 11:55:19 -0700 2019-05-11 13:58:57 -0700 Patch bug-197766-20190511115518.patch text/plain 5832 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MjA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU5NzM3N2E3NGU2Yjhj NDRiZTYzNTVlZDNmZjg3ZmY3MWRjZGYyNi4uOTA0NTg5YTFhMWEwNmJiN2M0MGY5NzVlMmE2MWYx OTM3OTU4MzlhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA1LTExICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFdoZW4gdGhlIHNj cm9sbGVyIGhvc3RpbmcgYSBzaGFyZWQgbGF5ZXIgYmVjb21lcyBub24tc2Nyb2xsYWJsZSwgY29u dGVudCBkaXNhcHBlYXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTc3NjYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUwNjk1ODA4PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmRlckxheWVyQ29t cG9zaXRvcjo6cmVxdWlyZXNPd25CYWNraW5nU3RvcmUoKSBzaG91bGQgcmV0dXJuIHRydWUgZm9y IGEgbGF5ZXIgdGhhdCBzaGFyZXMKKyAgICAgICAgaXRzIGJhY2tpbmcgc3RvcmUuIFdlIGFsd2F5 cyBtYWRlIGJhY2tpbmcgZm9yIG92ZXJsYXAgbGF5ZXJzLCBzbyBldmVuICBpZiB0aGUgc2hhcmlu ZyBsYXllcnMKKyAgICAgICAgaGF2ZSBubyBwYWludGVkIGNvbnRlbnQsIHRoaXMgc2hvdWxkIHJh cmVseSBiZSBhIGJhY2tpbmcgc3RvcmUgbWVtb3J5IHJlZ3Jlc3Npb24uCisKKyAgICAgICAgVGVz dDogY29tcG9zaXRpbmcvc2hhcmVkLWJhY2tpbmcvb3ZlcmZsb3ctc2Nyb2xsL3NoYXJpbmctbGF5 ZXItYmVjb21lcy1ub24tc2Nyb2xsYWJsZS5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29t cG9zaXRvcjo6cmVxdWlyZXNPd25CYWNraW5nU3RvcmUgY29uc3QpOgorCiAyMDE5LTA1LTExICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIExheWVyIGJv dW5kcyBhcmUgaW5jb3JyZWN0IGZvciBzaGFyaW5nIGxheWVycyB0aGF0IHBhaW50IHdpdGggdHJh bnNmb3JtcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy Q29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmNwcAppbmRleCBjYTU0MjRlM2Y4YmE5MzhiODgxZGExMjI4ZGQyNjBlZjhlZjMxN2U1 Li4yODMyNzNjMGY5N2FhOGE0MWIzZGY2MTI3MWQyODQ4NDIyMzFlZWM4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMjM2 Niw2ICsyMzY2LDkgQEAgYm9vbCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzT3duQmFj a2luZ1N0b3JlKGNvbnN0IFJlbmRlckxheWVyJiBsYXllciwgY28KICAgICBpZiAoIWFuY2VzdG9y Q29tcG9zaXRlZEJvdW5kcy5jb250YWlucyhsYXllckNvbXBvc2l0ZWRCb3VuZHNJbkFuY2VzdG9y KSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKKyAgICBpZiAobGF5ZXIuaXNDb21wb3NpdGVkKCkg JiYgbGF5ZXIuYmFja2luZygpLT5oYXNCYWNraW5nU2hhcmluZ0xheWVycygpKQorICAgICAgICBy ZXR1cm4gdHJ1ZTsKKwogICAgIHJldHVybiBmYWxzZTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDA2MmM2MmY2MTYx YWE3ZjRhMTNmZDI5ODgxMWQ4NzRhMTFkYWZkMWMuLjJjMTgzZjNkZGE2Y2I0OGNmZWRmOTRlNTQ1 MDZhYzI3ZTAzZDZjNDQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wNS0xMSAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBXaGVuIHRoZSBzY3Jv bGxlciBob3N0aW5nIGEgc2hhcmVkIGxheWVyIGJlY29tZXMgbm9uLXNjcm9sbGFibGUsIGNvbnRl bnQgZGlzYXBwZWFycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk3NzY2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDY5NTgwOD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNvbXBvc2l0aW5nL3No YXJlZC1iYWNraW5nL292ZXJmbG93LXNjcm9sbC9zaGFyaW5nLWxheWVyLWJlY29tZXMtbm9uLXNj cm9sbGFibGUtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogY29tcG9zaXRpbmcvc2hh cmVkLWJhY2tpbmcvb3ZlcmZsb3ctc2Nyb2xsL3NoYXJpbmctbGF5ZXItYmVjb21lcy1ub24tc2Ny b2xsYWJsZS5odG1sOiBBZGRlZC4KKwogMjAxOS0wNS0xMSAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBMYXllciBib3VuZHMgYXJlIGluY29ycmVjdCBm b3Igc2hhcmluZyBsYXllcnMgdGhhdCBwYWludCB3aXRoIHRyYW5zZm9ybXMKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3NoYXJlZC1iYWNraW5nL292ZXJmbG93LXNjcm9sbC9z aGFyaW5nLWxheWVyLWJlY29tZXMtbm9uLXNjcm9sbGFibGUtZXhwZWN0ZWQuaHRtbCBiL0xheW91 dFRlc3RzL2NvbXBvc2l0aW5nL3NoYXJlZC1iYWNraW5nL292ZXJmbG93LXNjcm9sbC9zaGFyaW5n LWxheWVyLWJlY29tZXMtbm9uLXNjcm9sbGFibGUtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41 OGMxNThmMzA2YTk1MWY1YTU4ODkxNjQ2MTIzMDJlMTFiMjYwYjUyCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvc2hhcmVkLWJhY2tpbmcvb3ZlcmZsb3ctc2Nyb2xs L3NoYXJpbmctbGF5ZXItYmVjb21lcy1ub24tc2Nyb2xsYWJsZS1leHBlY3RlZC5odG1sCkBAIC0w LDAgKzEsMzUgQEAKKzwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIGlu dGVybmFsOkFzeW5jT3ZlcmZsb3dTY3JvbGxpbmdFbmFibGVkPXRydWUgXSAtLT4KKzxodG1sPgor PGhlYWQ+CisgICAgPHN0eWxlPgorICAgICAgICAuc2Nyb2xsYWJsZSB7CisgICAgICAgICAgICBv dmVyZmxvdy15OiBzY3JvbGw7CisgICAgICAgICAgICBoZWlnaHQ6IDQwMHB4OworICAgICAgICAg ICAgd2lkdGg6IDMwMHB4OworICAgICAgICAgICAgbWFyZ2luOiAxMHB4OworICAgICAgICAgICAg Ym9yZGVyOiAxcHggc29saWQgYmxhY2s7CisgICAgICAgIH0KKworICAgICAgICAuc2hhcmluZyB7 CisgICAgICAgICAgICBtYXJnaW46IDIwcHg7CisgICAgICAgICAgICB3aWR0aDogMTUwcHg7Cisg ICAgICAgICAgICBoZWlnaHQ6IDEzMHB4OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjog Z3JlZW47CisgICAgICAgICAgICBvcGFjaXR5OiAwLjc1OworICAgICAgICB9CisgICAgCisgICAg ICAgIC5zcGFjZXIgeworICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgICAgIHdp ZHRoOiAyMHB4OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogc2lsdmVyOworICAgICAg ICB9CisgICAgPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxkaXYgY2xhc3M9InNjcm9s bGFibGUiPgorICAgICAgICA8ZGl2IGNsYXNzPSJzaGFyaW5nIj4KKyAgICAgICAgPC9kaXY+Cisg ICAgICAgIDxkaXYgY2xhc3M9InNwYWNlciI+PC9kaXY+CisgICAgPC9kaXY+Cis8L2JvZHk+Cis8 L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9zaGFyZWQtYmFja2lu Zy9vdmVyZmxvdy1zY3JvbGwvc2hhcmluZy1sYXllci1iZWNvbWVzLW5vbi1zY3JvbGxhYmxlLmh0 bWwgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9zaGFyZWQtYmFja2luZy9vdmVyZmxvdy1zY3Jv bGwvc2hhcmluZy1sYXllci1iZWNvbWVzLW5vbi1zY3JvbGxhYmxlLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u OGQ0ZmY5OGYyODZkNmY2MDQ3MDdjNzRiMjc0MjVkYWIwZTBiZDU4MgotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3NoYXJlZC1iYWNraW5nL292ZXJmbG93LXNjcm9s bC9zaGFyaW5nLWxheWVyLWJlY29tZXMtbm9uLXNjcm9sbGFibGUuaHRtbApAQCAtMCwwICsxLDUy IEBACis8IURPQ1RZUEUgaHRtbD4gPCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBpbnRlcm5hbDpB c3luY092ZXJmbG93U2Nyb2xsaW5nRW5hYmxlZD10cnVlIF0gLS0+Cis8aHRtbD4KKzxoZWFkPgor ICAgIDx0aXRsZT5UZXN0cyB0aGF0IHRoZSBzaGFyaW5nIGxheWVyIHN0aWxsIGhhcyBiYWNraW5n IHN0b3JlIGFuZCBwYWludHMgc2hhcmVkIGxheWVycyBhZnRlciBhIHRyZWUgY29uZmlnIGNoYW5n ZTwvdGl0bGU+CisgICAgPHN0eWxlPgorICAgICAgICAuc2Nyb2xsYWJsZSB7CisgICAgICAgICAg ICBvdmVyZmxvdy15OiBzY3JvbGw7CisgICAgICAgICAgICBoZWlnaHQ6IDQwMHB4OworICAgICAg ICAgICAgd2lkdGg6IDMwMHB4OworICAgICAgICAgICAgbWFyZ2luOiAxMHB4OworICAgICAgICAg ICAgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7CisgICAgICAgIH0KKworICAgICAgICAuc2hhcmlu ZyB7CisgICAgICAgICAgICBtYXJnaW46IDIwcHg7CisgICAgICAgICAgICB3aWR0aDogMTUwcHg7 CisgICAgICAgICAgICBoZWlnaHQ6IDEzMHB4OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xv cjogZ3JlZW47CisgICAgICAgICAgICBvcGFjaXR5OiAwLjc1OworICAgICAgICB9CisgICAgCisg ICAgICAgIC5zcGFjZXIgeworICAgICAgICAgICAgaGVpZ2h0OiA1MDBweDsKKyAgICAgICAgICAg IHdpZHRoOiAyMHB4OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogc2lsdmVyOworICAg ICAgICB9CisgICAgICAgIAorICAgICAgICAuc3BhY2VyLmNoYW5nZWQgeworICAgICAgICAgICAg aGVpZ2h0OiAxMDBweDsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAg ICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICAgICAgdGVzdFJ1bm5lci53YWl0 VW50aWxEb25lKCk7CisKKyAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCAo KSA9PiB7CisgICAgICAgICAgICBzZXRUaW1lb3V0KCgpID0+IHsKKyAgICAgICAgICAgICAgICBk b2N1bWVudC5xdWVyeVNlbGVjdG9yKCcuc3BhY2VyJykuY2xhc3NMaXN0LmFkZCgnY2hhbmdlZCcp OworICAgICAgICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgICAg ICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAgICAgICB9LCAwKTsKKyAgICAg ICAgfSwgZmFsc2UpOworICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisgICAgPGRpdiBj bGFzcz0ic2Nyb2xsYWJsZSI+CisgICAgICAgIDxkaXYgY2xhc3M9InNoYXJpbmciPgorICAgICAg ICA8L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0ic3BhY2VyIj48L2Rpdj4KKyAgICA8L2Rpdj4K KzwvYm9keT4KKzwvaHRtbD4K