19776 2008-06-26 00:44:36 -0700 Number.toExponential() is incorrect for numbers between 0.1 and 1 2008-07-02 17:05:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 webkit zwarich ap eric zwarich oldest_to_newest 84455 0 webkit 2008-06-26 00:44:36 -0700 f number is say 1.1 then numbertoexponential(4) = 1.1000e+0 -- which is fine. number is 0.999 then numbertoexponential(4) = 9.9900e+1 -- which isn't. numbers less than 0.1 & greater than 0.9999 give expected results. tested on safari 2.0.4 & 3.1.1 & 4.beta 84459 1 21943 webkit 2008-06-26 02:56:37 -0700 Created attachment 21943 simple html/javascript showing the behaviour camino,firefox,opera give 'expected' result, webkit browsers don't. 84465 2 ap 2008-06-26 05:26:48 -0700 Looks like fixes made for Acid3 in bug 16640 weren't sufficient. 84986 3 zwarich 2008-07-02 10:24:21 -0700 The value of decimalAdjust in numberProtoFuncToExponential() is wrong when the value is between 0 and 1. Consider what happens with n = 0.1. If the number of digits is undefined, we get: decimalPoint = 0 decimalAdjust = 0 If the number of digits is defined, we get: decimalPoint = 1 decimalAdjust = -1 84994 4 22049 zwarich 2008-07-02 10:40:20 -0700 Created attachment 22049 Proposed patch Actually, the problem isn't with decimalPoint and decimalAdjust, it's with what is done with the decimalPoint value in exponentialPartToString(). The sign check on the exponent is done on the decimalPoint value before subtracting 1 to get the exponent. Here is a patch that fixes it. I'll write some tests later and put it up for review, but I don't have the time before my calculus tutorial. 85002 5 22049 eric 2008-07-02 12:24:50 -0700 Comment on attachment 22049 Proposed patch Makes sense, but needs the tests (hopefully in the fast/js .js file-only form. :) 85017 6 22054 zwarich 2008-07-02 16:53:41 -0700 Created attachment 22054 Proposed patch with tests 85018 7 22054 darin 2008-07-02 16:54:56 -0700 Comment on attachment 22054 Proposed patch with tests r=me 85019 8 zwarich 2008-07-02 17:05:17 -0700 Landed in r34961. 21943 2008-06-26 02:56:37 -0700 2008-06-26 02:56:37 -0700 simple html/javascript showing the behaviour x.toexponential.html text/html 952 webkit ICA8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1czQy8vRFREIEhUTUwgNC4wMSBUcmFuc2l0aW9u YWwvL0VOIgogICAiaHR0cDovL3d3dy53My5vcmcvVFIvMTk5OS9SRUMtaHRtbDQwMS0xOTk5MTIy NC9sb29zZS5kdGQiPgo8IS0tIDwhRE9DVFlQRSBodG1sIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRN TCA0LjAxIFRyYW5zaXRpb25hbC8vRU4iICJodHRwOi8vd3d3LnczLm9yZy9UUi8xOTk5L1JFQy1o dG1sNDAxLTE5OTkxMjI0L2xvb3NlLmR0ZCI+IC0tPgo8aHRtbD4KPGhlYWQ+CjxtZXRhIG5hbWU9 ImdlbmVyYXRvciIgY29udGVudD0iSFRNTCBUaWR5IGZvciBMaW51eCAodmVycyAxIFNlcHRlbWJl ciAyMDA1KSwgc2VlIHd3dy53My5vcmciPgo8dGl0bGU+bnVtYmVyLnRvRXhwb25lbnRpYWwgdGVz dDwvdGl0bGU+CjxtZXRhIG5hbWU9ImRlc2NyaXB0aW9uIiBjb250ZW50PSIiPgo8bWV0YSBuYW1l PSJrZXl3b3JkcyIgY29udGVudD0iIj4KCjwvaGVhZD4KPGJvZHk+Cgo8YnI+CjxzY3JpcHQgdHlw ZT0idGV4dC9qYXZhc2NyaXB0Ij4KCgoKCgoKCgp2YXIgbnVtMiA9IDEuMTsKdmFyIG51bTMgPSAw Ljk5OTk5OTk7Cgpkb2N1bWVudC53cml0ZSgibnVtMiA9ICIpOwpkb2N1bWVudC53cml0ZShudW0y KTsKZG9jdW1lbnQud3JpdGUoIjxicj4gICAgbnVtMi50b0V4cG9uZW50aWFsKDYpID0gIik7Cgpk b2N1bWVudC53cml0ZShudW0yLnRvRXhwb25lbnRpYWwoNikpOwoKZG9jdW1lbnQud3JpdGUoIjxi cj4iKTsKCgoKCgoKZG9jdW1lbnQud3JpdGUoIjxwPiIpOwoKZG9jdW1lbnQud3JpdGUoIm51bTMg PSAiKTsKZG9jdW1lbnQud3JpdGUobnVtMyk7Cgpkb2N1bWVudC53cml0ZSgiPGJyPiAgICBudW0z LnRvRXhwb25lbnRpYWwoNikgPSAiKTsKZG9jdW1lbnQud3JpdGUobnVtMy50b0V4cG9uZW50aWFs KDYpKTsKCgo8L3NjcmlwdD4KCjwvYm9keT4KPC9odG1sPgoKICAgIA== 22049 2008-07-02 10:40:20 -0700 2008-07-02 16:53:41 -0700 Proposed patch toExponential.diff text/plain 1482 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM0OTU2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDct MDIgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE5Nzc2OiBOdW1iZXIu dG9FeHBvbmVudGlhbCgpIGlzIGluY29ycmVjdCBmb3IgbnVtYmVycyBiZXR3ZWVuIDAuMSBhbmQg MQorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Nzc2 PgorCisgICAgICAgIFBlcmZvcm0gdGhlIHNpZ24gY2hlY2sgZm9yIHRoZSBleHBvbmVudCBvbiB0 aGUgYWN0dWFsIGV4cG9uZW50IHZhbHVlLAorICAgICAgICB3aGljaCBpcyAxIGxlc3MgdGhhbiB0 aGUgdmFsdWUgb2YgZGVjaW1hbFBvaW50LCBpbnN0ZWFkIG9mIG9uIHRoZSB2YWx1ZQorICAgICAg ICBvZiBkZWNpbWFsUG9pbnQgaXRzZWxmLgorCisgICAgICAgICoga2pzL051bWJlclByb3RvdHlw ZS5jcHA6CisgICAgICAgIChLSlM6OmV4cG9uZW50aWFsUGFydFRvU3RyaW5nKToKKwogMjAwOC0w Ny0wMiAgU2ltb24gSGF1c21hbm4gIDxoYXVzbWFubkB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1 aWxkIGZpeC4gSW1wbGVtZW50ZWQgbWlzc2luZyBmdW5jdGlvbnMgZm9yIHNpbmdsZS10aHJlYWRl ZCBidWlsZC4KSW5kZXg6IGtqcy9OdW1iZXJQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtq cy9OdW1iZXJQcm90b3R5cGUuY3BwCShyZXZpc2lvbiAzNDk1NikKKysrIGtqcy9OdW1iZXJQcm90 b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODksMTAgKzI4OSwxMCBAQCBzdGF0aWMgdm9p ZCBmcmFjdGlvbmFsUGFydFRvU3RyaW5nKGNoYXIqCiBzdGF0aWMgdm9pZCBleHBvbmVudGlhbFBh cnRUb1N0cmluZyhjaGFyKiBidWYsIGludCYgaSwgaW50IGRlY2ltYWxQb2ludCkKIHsKICAgICBi dWZbaSsrXSA9ICdlJzsKLSAgICBidWZbaSsrXSA9IChkZWNpbWFsUG9pbnQgPj0gMCkgPyAnKycg OiAnLSc7CiAgICAgLy8gZGVjaW1hbFBvaW50IGNhbid0IGJlIG1vcmUgdGhhbiAzIGRpZ2l0cyBk ZWNpbWFsIGdpdmVuIHRoZQogICAgIC8vIG5hdHVyZSBvZiBmbG9hdCByZXByZXNlbnRhdGlvbgog ICAgIGludCBleHBvbmVudGlhbCA9IGRlY2ltYWxQb2ludCAtIDE7CisgICAgYnVmW2krK10gPSAo ZXhwb25lbnRpYWwgPj0gMCkgPyAnKycgOiAnLSc7CiAgICAgaWYgKGV4cG9uZW50aWFsIDwgMCkK ICAgICAgICAgZXhwb25lbnRpYWwgKj0gLTE7CiAgICAgaWYgKGV4cG9uZW50aWFsID49IDEwMCkK 22054 2008-07-02 16:53:41 -0700 2008-07-02 16:54:56 -0700 Proposed patch with tests toExponential.diff text/plain 3665 zwarich SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM0OTYwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDctMDIgIENhbWVyb24g WndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgCisgICAgICAgIEJ1ZyAxOTc3NjogTnVtYmVyLnRvRXhwb25lbnRp YWwoKSBpcyBpbmNvcnJlY3QgZm9yIG51bWJlcnMgYmV0d2VlbiAwLjEgYW5kIDEKKyAgICAgICAg PGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc3Nj4KKworICAgICAg ICBQZXJmb3JtIHRoZSBzaWduIGNoZWNrIGZvciB0aGUgZXhwb25lbnQgb24gdGhlIGFjdHVhbCBl eHBvbmVudCB2YWx1ZSwKKyAgICAgICAgd2hpY2ggaXMgMSBsZXNzIHRoYW4gdGhlIHZhbHVlIG9m IGRlY2ltYWxQb2ludCwgaW5zdGVhZCBvZiBvbiB0aGUgdmFsdWUKKyAgICAgICAgb2YgZGVjaW1h bFBvaW50IGl0c2VsZi4KKworICAgICAgICAqIGtqcy9OdW1iZXJQcm90b3R5cGUuY3BwOgorICAg ICAgICAoS0pTOjpleHBvbmVudGlhbFBhcnRUb1N0cmluZyk6CisKIDIwMDgtMDctMDIgIEtldmlu IE1jQ3VsbG91Z2ggIDxrbWNjdWxsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvTnVtYmVyUHJvdG90eXBlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvTnVtYmVyUHJvdG90eXBlLmNwcAkocmV2 aXNpb24gMzQ5NjApCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvTnVtYmVyUHJvdG90eXBlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjg5LDEwICsyODksMTAgQEAgc3RhdGljIHZvaWQgZnJhY3Rpb25h bFBhcnRUb1N0cmluZyhjaGFyKgogc3RhdGljIHZvaWQgZXhwb25lbnRpYWxQYXJ0VG9TdHJpbmco Y2hhciogYnVmLCBpbnQmIGksIGludCBkZWNpbWFsUG9pbnQpCiB7CiAgICAgYnVmW2krK10gPSAn ZSc7Ci0gICAgYnVmW2krK10gPSAoZGVjaW1hbFBvaW50ID49IDApID8gJysnIDogJy0nOwogICAg IC8vIGRlY2ltYWxQb2ludCBjYW4ndCBiZSBtb3JlIHRoYW4gMyBkaWdpdHMgZGVjaW1hbCBnaXZl biB0aGUKICAgICAvLyBuYXR1cmUgb2YgZmxvYXQgcmVwcmVzZW50YXRpb24KICAgICBpbnQgZXhw b25lbnRpYWwgPSBkZWNpbWFsUG9pbnQgLSAxOworICAgIGJ1ZltpKytdID0gKGV4cG9uZW50aWFs ID49IDApID8gJysnIDogJy0nOwogICAgIGlmIChleHBvbmVudGlhbCA8IDApCiAgICAgICAgIGV4 cG9uZW50aWFsICo9IC0xOwogICAgIGlmIChleHBvbmVudGlhbCA+PSAxMDApCkluZGV4OiBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy ZXZpc2lvbiAzNDk2MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDA4LTA3LTAyICBDYW1lcm9uIFp3YXJpY2ggIDxjd3p3YXJpY2hA dXdhdGVybG9vLmNhPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJ1ZyAxOTc3NjogTnVtYmVyLnRvRXhwb25lbnRpYWwoKSBpcyBpbmNvcnJlY3QgZm9y IG51bWJlcnMgYmV0d2VlbiAwLjEgYW5kIDEKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc3Nj4KKworICAgICAgICAqIGZhc3QvanMvbnVtYmVyLXRv RXhwb25lbnRpYWwtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvanMvcmVzb3VyY2VzL251 bWJlci10b0V4cG9uZW50aWFsLmpzOgorCiAyMDA4LTA3LTAyICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2pzL251bWJlci10b0V4cG9uZW50aWFsLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL251bWJlci10b0V4cG9uZW50aWFsLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMzQ5NjApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL251bWJl ci10b0V4cG9uZW50aWFsLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYs MTEgQEAgUEFTUyAoMTIzNC41NjcpLnRvRXhwb25lbnRpYWwobmVnSW5mKSB0aAogUEFTUyBwb3NJ bmYudG9FeHBvbmVudGlhbCgpIGlzICJJbmZpbml0eSIKIFBBU1MgbmVnSW5mLnRvRXhwb25lbnRp YWwoKSBpcyAiLUluZmluaXR5IgogUEFTUyBuYW4udG9FeHBvbmVudGlhbCgpIGlzICJOYU4iCitQ QVNTICgwLjAxKS50b0V4cG9uZW50aWFsKCkgaXMgIjFlLTIiCitQQVNTICgwLjEpLnRvRXhwb25l bnRpYWwoKSBpcyAiMWUtMSIKK1BBU1MgKDAuOSkudG9FeHBvbmVudGlhbCgpIGlzICI5ZS0xIgor UEFTUyAoMC45OTk5KS50b0V4cG9uZW50aWFsKCkgaXMgIjkuOTk5ZS0xIgorUEFTUyAoMC45OTk5 KS50b0V4cG9uZW50aWFsKDIpIGlzICIxLjAwZSswIgogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291 cmNlcy9udW1iZXItdG9FeHBvbmVudGlhbC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2pzL3Jlc291cmNlcy9udW1iZXItdG9FeHBvbmVudGlhbC5qcwkocmV2aXNpb24gMzQ5NjAp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9udW1iZXItdG9FeHBvbmVudGlhbC5q cwkod29ya2luZyBjb3B5KQpAQCAtNDEsNCArNDEsMTAgQEAgc2hvdWxkQmVFcXVhbFRvU3RyaW5n KCJwb3NJbmYudG9FeHBvbmVudAogc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJuZWdJbmYudG9FeHBv bmVudGlhbCgpIiwgIi1JbmZpbml0eSIpOwogc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJuYW4udG9F eHBvbmVudGlhbCgpIiwgIk5hTiIpOwogCitzaG91bGRCZUVxdWFsVG9TdHJpbmcoIigwLjAxKS50 b0V4cG9uZW50aWFsKCkiLCAiMWUtMiIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCIoMC4xKS50 b0V4cG9uZW50aWFsKCkiLCAiMWUtMSIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCIoMC45KS50 b0V4cG9uZW50aWFsKCkiLCAiOWUtMSIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCIoMC45OTk5 KS50b0V4cG9uZW50aWFsKCkiLCAiOS45OTllLTEiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygi KDAuOTk5OSkudG9FeHBvbmVudGlhbCgyKSIsICIxLjAwZSswIik7CisKIHZhciBzdWNjZXNzZnVs bHlQYXJzZWQgPSB0cnVlOwo=