197758 2019-05-09 16:41:50 -0700 Returning incorrect marked text rects 2019-05-10 13:52:39 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner bdakin commit-queue dbates thorton wenson_hsieh oldest_to_newest 1534892 0 megan_gardner 2019-05-09 16:41:50 -0700 Returning incorrect marked text rects 1534893 1 369529 megan_gardner 2019-05-09 16:43:56 -0700 Created attachment 369529 Patch 1534894 2 megan_gardner 2019-05-09 16:44:22 -0700 <rdar://problem/46548586> 1534916 3 369529 thorton 2019-05-09 17:41:08 -0700 Comment on attachment 369529 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369529&action=review > Source/WebKit/ChangeLog:9 > + We are not returning marked text rects in the correct view coordinant space. coordinate > Source/WebKit/ChangeLog:13 > + (WebKit::WebPage::platformEditorState const): Where's the test :P 1535172 4 369593 megan_gardner 2019-05-10 13:37:08 -0700 Created attachment 369593 Patch for landing 1535176 5 369593 commit-queue 2019-05-10 13:52:38 -0700 Comment on attachment 369593 Patch for landing Clearing flags on attachment: 369593 Committed r245195: <https://trac.webkit.org/changeset/245195> 1535177 6 commit-queue 2019-05-10 13:52:39 -0700 All reviewed patches have been landed. Closing bug. 369529 2019-05-09 16:43:56 -0700 2019-05-10 13:37:07 -0700 Patch bug-197758-20190509164355.patch text/plain 2795 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBiMWE0OGNiYzdlZmNhNjdj YzI3YTQwZTExMDk1MzUwOTJhMWVhOTUuLjcwZjFiMmE5ZTIyNzcyOTQwMzRmN2I4OGY1MzNhZjc0 YjJhOTFhMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDUtMDkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXR1cm5pbmcgaW5j b3JyZWN0IG1hcmtlZCB0ZXh0IHJlY3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTc3NTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NTQ4NTg2 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGFy ZSBub3QgcmV0dXJuaW5nIG1hcmtlZCB0ZXh0IHJlY3RzIGluIHRoZSBjb3JyZWN0IHZpZXcgY29v cmRpbmFudCBzcGFjZS4KKyAgICAgICAgVGhpcyBpcyB0aGUgc2FtZSB0cmFuc2xhdGlvbiB3ZSBh cmUgYXBwbHlpbmcgdG8gdGhlIGNhcmV0IHJlY3RzLiAKKworICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6cGxh dGZvcm1FZGl0b3JTdGF0ZSBjb25zdCk6CisKIDIwMTktMDUtMDkgIERhbmllbCBCYXRlcyAgPGRh YmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIExhemlseSByZXF1ZXN0IGtleWJvYXJk IG9uIGZpcnN0IGhhcmR3YXJlIGtleWRvd24gd2hlbiBhIG5vbi1lZGl0YWJsZSBlbGVtZW50IGlz IGZvY3VzZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lv cy9XZWJQYWdlSU9TLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW0KaW5kZXggZTNlZTMyNjU4OGQzMjNlZGE3N2RiMTg1YTIwYzBmOTA1M2NjMzYz NS4uYjM4ZGI3OTk1ODc3YjM3OWZjMDY3NTM5OTZlMTY5OGNhYTVlOGE3MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTE5 MywxNSArMTkzLDE2IEBAIHN0YXRpYyBib29sIGVuY2xvc2luZ0xheWVySXNUcmFuc3BhcmVudE9y RnVsbHlDbGlwcGVkKGNvbnN0IFJlbmRlck9iamVjdCYgcmVuZGVyCiAKIHZvaWQgV2ViUGFnZTo6 cGxhdGZvcm1FZGl0b3JTdGF0ZShGcmFtZSYgZnJhbWUsIEVkaXRvclN0YXRlJiByZXN1bHQsIElu Y2x1ZGVQb3N0TGF5b3V0RGF0YUhpbnQgc2hvdWxkSW5jbHVkZVBvc3RMYXlvdXREYXRhKSBjb25z dAogeworICAgIEZyYW1lVmlldyogdmlldyA9IGZyYW1lLnZpZXcoKTsKICAgICBpZiAoZnJhbWUu ZWRpdG9yKCkuaGFzQ29tcG9zaXRpb24oKSkgewogICAgICAgICBSZWZQdHI8UmFuZ2U+IGNvbXBv c2l0aW9uUmFuZ2UgPSBmcmFtZS5lZGl0b3IoKS5jb21wb3NpdGlvblJhbmdlKCk7CiAgICAgICAg IFZlY3RvcjxXZWJDb3JlOjpTZWxlY3Rpb25SZWN0PiBjb21wb3NpdGlvblJlY3RzOwogICAgICAg ICBpZiAoY29tcG9zaXRpb25SYW5nZSkgewogICAgICAgICAgICAgY29tcG9zaXRpb25SYW5nZS0+ Y29sbGVjdFNlbGVjdGlvblJlY3RzKGNvbXBvc2l0aW9uUmVjdHMpOwogICAgICAgICAgICAgaWYg KGNvbXBvc2l0aW9uUmVjdHMuc2l6ZSgpKQotICAgICAgICAgICAgICAgIHJlc3VsdC5maXJzdE1h cmtlZFJlY3QgPSBjb21wb3NpdGlvblJlY3RzWzBdLnJlY3QoKTsKKyAgICAgICAgICAgICAgICBy ZXN1bHQuZmlyc3RNYXJrZWRSZWN0ID0gdmlldy0+Y29udGVudHNUb1Jvb3RWaWV3KGNvbXBvc2l0 aW9uUmVjdHNbMF0ucmVjdCgpKTsKICAgICAgICAgICAgIGlmIChjb21wb3NpdGlvblJlY3RzLnNp emUoKSA+IDEpCi0gICAgICAgICAgICAgICAgcmVzdWx0Lmxhc3RNYXJrZWRSZWN0ID0gY29tcG9z aXRpb25SZWN0cy5sYXN0KCkucmVjdCgpOworICAgICAgICAgICAgICAgIHJlc3VsdC5sYXN0TWFy a2VkUmVjdCA9IHZpZXctPmNvbnRlbnRzVG9Sb290Vmlldyhjb21wb3NpdGlvblJlY3RzLmxhc3Qo KS5yZWN0KCkpOwogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIHJlc3VsdC5sYXN0 TWFya2VkUmVjdCA9IHJlc3VsdC5maXJzdE1hcmtlZFJlY3Q7CiAgICAgICAgICAgICByZXN1bHQu bWFya2VkVGV4dCA9IHBsYWluVGV4dFJlcGxhY2luZ05vQnJlYWtTcGFjZShjb21wb3NpdGlvblJh bmdlLmdldCgpKTsKQEAgLTIyMyw3ICsyMjQsNyBAQCB2b2lkIFdlYlBhZ2U6OnBsYXRmb3JtRWRp dG9yU3RhdGUoRnJhbWUmIGZyYW1lLCBFZGl0b3JTdGF0ZSYgcmVzdWx0LCBJbmNsdWRlUG9zdAog ICAgIH0KIAogICAgIGF1dG8mIHBvc3RMYXlvdXREYXRhID0gcmVzdWx0LnBvc3RMYXlvdXREYXRh KCk7Ci0gICAgRnJhbWVWaWV3KiB2aWV3ID0gZnJhbWUudmlldygpOworICAgIAogICAgIGNvbnN0 IFZpc2libGVTZWxlY3Rpb24mIHNlbGVjdGlvbiA9IGZyYW1lLnNlbGVjdGlvbigpLnNlbGVjdGlv bigpOwogICAgIHBvc3RMYXlvdXREYXRhLmlzU3RhYmxlU3RhdGVVcGRhdGUgPSBtX2lzSW5TdGFi bGVTdGF0ZTsKICAgICBib29sIHN0YXJ0Tm9kZUlzSW5zaWRlRml4ZWRQb3NpdGlvbiA9IGZhbHNl Owo= 369593 2019-05-10 13:37:08 -0700 2019-05-10 13:52:38 -0700 Patch for landing bug-197758-20190510133708.patch text/plain 2791 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBiMWE0OGNiYzdlZmNhNjdj YzI3YTQwZTExMDk1MzUwOTJhMWVhOTUuLjExOTEzYzFjZDFmODM0OGVlNTUzZmQ4MDM0OGI0YTQz ZjRkZWRhMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDUtMDkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXR1cm5pbmcgaW5j b3JyZWN0IG1hcmtlZCB0ZXh0IHJlY3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTc3NTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NTQ4NTg2 PgorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgV2UgYXJlIG5v dCByZXR1cm5pbmcgbWFya2VkIHRleHQgcmVjdHMgaW4gdGhlIGNvcnJlY3QgdmlldyBjb29yZGlu YXRlIHNwYWNlLgorICAgICAgICBUaGlzIGlzIHRoZSBzYW1lIHRyYW5zbGF0aW9uIHdlIGFyZSBh cHBseWluZyB0byB0aGUgY2FyZXQgcmVjdHMuIAorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpwbGF0Zm9y bUVkaXRvclN0YXRlIGNvbnN0KToKKwogMjAxOS0wNS0wOSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRl c0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gTGF6aWx5IHJlcXVlc3Qga2V5Ym9hcmQgb24g Zmlyc3QgaGFyZHdhcmUga2V5ZG93biB3aGVuIGEgbm9uLWVkaXRhYmxlIGVsZW1lbnQgaXMgZm9j dXNlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFn ZUlPUy5tbQppbmRleCBlM2VlMzI2NTg4ZDMyM2VkYTc3ZGIxODVhMjBjMGY5MDUzY2MzNjM1Li5i MzhkYjc5OTU4NzdiMzc5ZmMwNjc1Mzk5NmUxNjk4Y2FhNWU4YTczIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtMTkzLDE1 ICsxOTMsMTYgQEAgc3RhdGljIGJvb2wgZW5jbG9zaW5nTGF5ZXJJc1RyYW5zcGFyZW50T3JGdWxs eUNsaXBwZWQoY29uc3QgUmVuZGVyT2JqZWN0JiByZW5kZXIKIAogdm9pZCBXZWJQYWdlOjpwbGF0 Zm9ybUVkaXRvclN0YXRlKEZyYW1lJiBmcmFtZSwgRWRpdG9yU3RhdGUmIHJlc3VsdCwgSW5jbHVk ZVBvc3RMYXlvdXREYXRhSGludCBzaG91bGRJbmNsdWRlUG9zdExheW91dERhdGEpIGNvbnN0CiB7 CisgICAgRnJhbWVWaWV3KiB2aWV3ID0gZnJhbWUudmlldygpOwogICAgIGlmIChmcmFtZS5lZGl0 b3IoKS5oYXNDb21wb3NpdGlvbigpKSB7CiAgICAgICAgIFJlZlB0cjxSYW5nZT4gY29tcG9zaXRp b25SYW5nZSA9IGZyYW1lLmVkaXRvcigpLmNvbXBvc2l0aW9uUmFuZ2UoKTsKICAgICAgICAgVmVj dG9yPFdlYkNvcmU6OlNlbGVjdGlvblJlY3Q+IGNvbXBvc2l0aW9uUmVjdHM7CiAgICAgICAgIGlm IChjb21wb3NpdGlvblJhbmdlKSB7CiAgICAgICAgICAgICBjb21wb3NpdGlvblJhbmdlLT5jb2xs ZWN0U2VsZWN0aW9uUmVjdHMoY29tcG9zaXRpb25SZWN0cyk7CiAgICAgICAgICAgICBpZiAoY29t cG9zaXRpb25SZWN0cy5zaXplKCkpCi0gICAgICAgICAgICAgICAgcmVzdWx0LmZpcnN0TWFya2Vk UmVjdCA9IGNvbXBvc2l0aW9uUmVjdHNbMF0ucmVjdCgpOworICAgICAgICAgICAgICAgIHJlc3Vs dC5maXJzdE1hcmtlZFJlY3QgPSB2aWV3LT5jb250ZW50c1RvUm9vdFZpZXcoY29tcG9zaXRpb25S ZWN0c1swXS5yZWN0KCkpOwogICAgICAgICAgICAgaWYgKGNvbXBvc2l0aW9uUmVjdHMuc2l6ZSgp ID4gMSkKLSAgICAgICAgICAgICAgICByZXN1bHQubGFzdE1hcmtlZFJlY3QgPSBjb21wb3NpdGlv blJlY3RzLmxhc3QoKS5yZWN0KCk7CisgICAgICAgICAgICAgICAgcmVzdWx0Lmxhc3RNYXJrZWRS ZWN0ID0gdmlldy0+Y29udGVudHNUb1Jvb3RWaWV3KGNvbXBvc2l0aW9uUmVjdHMubGFzdCgpLnJl Y3QoKSk7CiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgcmVzdWx0Lmxhc3RNYXJr ZWRSZWN0ID0gcmVzdWx0LmZpcnN0TWFya2VkUmVjdDsKICAgICAgICAgICAgIHJlc3VsdC5tYXJr ZWRUZXh0ID0gcGxhaW5UZXh0UmVwbGFjaW5nTm9CcmVha1NwYWNlKGNvbXBvc2l0aW9uUmFuZ2Uu Z2V0KCkpOwpAQCAtMjIzLDcgKzIyNCw3IEBAIHZvaWQgV2ViUGFnZTo6cGxhdGZvcm1FZGl0b3JT dGF0ZShGcmFtZSYgZnJhbWUsIEVkaXRvclN0YXRlJiByZXN1bHQsIEluY2x1ZGVQb3N0CiAgICAg fQogCiAgICAgYXV0byYgcG9zdExheW91dERhdGEgPSByZXN1bHQucG9zdExheW91dERhdGEoKTsK LSAgICBGcmFtZVZpZXcqIHZpZXcgPSBmcmFtZS52aWV3KCk7CisgICAgCiAgICAgY29uc3QgVmlz aWJsZVNlbGVjdGlvbiYgc2VsZWN0aW9uID0gZnJhbWUuc2VsZWN0aW9uKCkuc2VsZWN0aW9uKCk7 CiAgICAgcG9zdExheW91dERhdGEuaXNTdGFibGVTdGF0ZVVwZGF0ZSA9IG1faXNJblN0YWJsZVN0 YXRlOwogICAgIGJvb2wgc3RhcnROb2RlSXNJbnNpZGVGaXhlZFBvc2l0aW9uID0gZmFsc2U7Cg==