197757 2019-05-09 16:29:10 -0700 Bag's move operator= leaks memory 2019-05-10 17:41:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin cdumez cmarcelo commit-queue dbates ews-watchlist fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1534891 0 saam 2019-05-09 16:29:10 -0700 It doesn't clear the prior |this| 1535232 1 369614 saam 2019-05-10 16:17:39 -0700 Created attachment 369614 patch 1535233 2 369615 saam 2019-05-10 16:18:39 -0700 Created attachment 369615 patch 1535234 3 369615 rmorisset 2019-05-10 16:20:45 -0700 Comment on attachment 369615 patch LGTM 1535236 4 369615 keith_miller 2019-05-10 16:21:48 -0700 Comment on attachment 369615 patch r=me. 1535272 5 369615 commit-queue 2019-05-10 17:40:03 -0700 Comment on attachment 369615 patch Clearing flags on attachment: 369615 Committed r245202: <https://trac.webkit.org/changeset/245202> 1535273 6 commit-queue 2019-05-10 17:40:05 -0700 All reviewed patches have been landed. Closing bug. 1535274 7 webkit-bug-importer 2019-05-10 17:41:16 -0700 <rdar://problem/50684450> 369614 2019-05-10 16:17:39 -0700 2019-05-10 16:18:39 -0700 patch b-backup.diff text/plain 1314 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDUxOTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA1LTEwICBTYWFtIGJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIEJhZydzIG1vdmUgb3BlcmF0b3I9IGxlYWtzIG1lbW9y eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NzU3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgd2Fz IHVudXNlZC4gU28gSSdtIGp1c3QgcmVtb3ZpbmcgaXQuIFdlIGNhbiBpbXBsZW1lbnQgaXQgcHJv cGVybHkKKyAgICAgICAgaWYgd2UgZXZlciBuZWVkIGl0LgorCisgICAgICAgICogd3RmL0JhZy5o OgorICAgICAgICAoV1RGOjpCYWc6Om9wZXJhdG9yPSk6IERlbGV0ZWQuCisKIDIwMTktMDUtMTAg IEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dp bkNhaXJvXSBzdG9yYWdlL2luZGV4ZWRkYiB0ZXN0cyBhcmUgdGltaW5nIG91dApJbmRleDogU291 cmNlL1dURi93dGYvQmFnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvQmFnLmgJKHJl dmlzaW9uIDI0NTE5NykKKysrIFNvdXJjZS9XVEYvd3RmL0JhZy5oCSh3b3JraW5nIGNvcHkpCkBA IC02NSwxMyArNjUsMTMgQEAgcHVibGljOgogICAgICAgICBvdGhlci5tX2hlYWQgPSBudWxscHRy OwogICAgIH0KIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+Ci0gICAgQmFnJiBvcGVyYXRvcj0o QmFnPFQsIFU+JiYgb3RoZXIpCi0gICAgewotICAgICAgICBtX2hlYWQgPSBvdGhlci51bndyYXBw ZWRIZWFkKCk7Ci0gICAgICAgIG90aGVyLm1faGVhZCA9IG51bGxwdHI7Ci0gICAgICAgIHJldHVy biAqdGhpczsKLSAgICB9CisgICAgLy90ZW1wbGF0ZTx0eXBlbmFtZSBVPgorICAgIC8vQmFnJiBv cGVyYXRvcj0oQmFnPFQsIFU+JiYgb3RoZXIpCisgICAgLy97CisgICAgLy8gICAgbV9oZWFkID0g b3RoZXIudW53cmFwcGVkSGVhZCgpOworICAgIC8vICAgIG90aGVyLm1faGVhZCA9IG51bGxwdHI7 CisgICAgLy8gICAgcmV0dXJuICp0aGlzOworICAgIC8vfQogICAgIAogICAgIH5CYWcoKQogICAg IHsK 369615 2019-05-10 16:18:39 -0700 2019-05-10 17:40:03 -0700 patch b-backup.diff text/plain 1141 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDUxOTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA1LTEwICBTYWFtIGJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIEJhZydzIG1vdmUgb3BlcmF0b3I9IGxlYWtzIG1lbW9y eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NzU3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgd2Fz IHVudXNlZC4gU28gSSdtIGp1c3QgcmVtb3ZpbmcgaXQuIFdlIGNhbiBpbXBsZW1lbnQgaXQgcHJv cGVybHkKKyAgICAgICAgaWYgd2UgZXZlciBuZWVkIGl0LgorCisgICAgICAgICogd3RmL0JhZy5o OgorICAgICAgICAoV1RGOjpCYWc6Om9wZXJhdG9yPSk6IERlbGV0ZWQuCisKIDIwMTktMDUtMTAg IEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dp bkNhaXJvXSBzdG9yYWdlL2luZGV4ZWRkYiB0ZXN0cyBhcmUgdGltaW5nIG91dApJbmRleDogU291 cmNlL1dURi93dGYvQmFnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvQmFnLmgJKHJl dmlzaW9uIDI0NTE5NykKKysrIFNvdXJjZS9XVEYvd3RmL0JhZy5oCSh3b3JraW5nIGNvcHkpCkBA IC02NSwxNCArNjUsNiBAQCBwdWJsaWM6CiAgICAgICAgIG90aGVyLm1faGVhZCA9IG51bGxwdHI7 CiAgICAgfQogCi0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4KLSAgICBCYWcmIG9wZXJhdG9yPShC YWc8VCwgVT4mJiBvdGhlcikKLSAgICB7Ci0gICAgICAgIG1faGVhZCA9IG90aGVyLnVud3JhcHBl ZEhlYWQoKTsKLSAgICAgICAgb3RoZXIubV9oZWFkID0gbnVsbHB0cjsKLSAgICAgICAgcmV0dXJu ICp0aGlzOwotICAgIH0KLSAgICAKICAgICB+QmFnKCkKICAgICB7CiAgICAgICAgIGNsZWFyKCk7 Cg==