197749 2019-05-09 12:00:55 -0700 parseStatementListItem needs a stack overflow check 2019-05-09 16:09:04 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist mark.lam msaboff ryanhaddad saam webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1534811 0 keith_miller 2019-05-09 12:00:55 -0700 parseStatementListItem needs a stack overflow check 1534812 1 369506 keith_miller 2019-05-09 12:02:18 -0700 Created attachment 369506 Patch 1534813 2 369507 keith_miller 2019-05-09 12:03:09 -0700 Created attachment 369507 Patch 1534814 3 keith_miller 2019-05-09 12:03:34 -0700 rdar://problem/50302697 1534816 4 369507 ysuzuki 2019-05-09 12:05:07 -0700 Comment on attachment 369507 Patch r=me too :) 1534834 5 369507 commit-queue 2019-05-09 12:40:54 -0700 Comment on attachment 369507 Patch Clearing flags on attachment: 369507 Committed r245152: <https://trac.webkit.org/changeset/245152> 1534835 6 commit-queue 2019-05-09 12:40:55 -0700 All reviewed patches have been landed. Closing bug. 1534873 7 ryanhaddad 2019-05-09 15:40:39 -0700 stress/many-nested-functions-parser-stack-overflow.js is failing on the release JSC bot: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20JSC%20(Tests)/builds/9309/steps/jscore-test/logs/stdio 1534877 8 ryanhaddad 2019-05-09 15:49:52 -0700 It looks like jsc-ews saw the same: ** The following JSC stress test failures have been introduced: stress/many-nested-functions-parser-stack-overflow.js.bytecode-cache stress/many-nested-functions-parser-stack-overflow.js.default stress/many-nested-functions-parser-stack-overflow.js.dfg-eager stress/many-nested-functions-parser-stack-overflow.js.dfg-eager-no-cjit-validate stress/many-nested-functions-parser-stack-overflow.js.dfg-maximal-flush-validate-no-cjit stress/many-nested-functions-parser-stack-overflow.js.ftl-eager stress/many-nested-functions-parser-stack-overflow.js.ftl-eager-no-cjit stress/many-nested-functions-parser-stack-overflow.js.ftl-eager-no-cjit-b3o1 stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-b3o0 stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-no-inline-validate stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-no-put-stack-validate stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-small-pool stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-validate-sampling-profiler stress/many-nested-functions-parser-stack-overflow.js.no-cjit-collect-continuously stress/many-nested-functions-parser-stack-overflow.js.no-cjit-validate-phases stress/many-nested-functions-parser-stack-overflow.js.no-ftl stress/many-nested-functions-parser-stack-overflow.js.no-llint 1534889 9 keith_miller 2019-05-09 16:09:04 -0700 (In reply to Ryan Haddad from comment #8) > It looks like jsc-ews saw the same: > ** The following JSC stress test failures have been introduced: > stress/many-nested-functions-parser-stack-overflow.js.bytecode-cache > stress/many-nested-functions-parser-stack-overflow.js.default > stress/many-nested-functions-parser-stack-overflow.js.dfg-eager > stress/many-nested-functions-parser-stack-overflow.js.dfg-eager-no-cjit- > validate > stress/many-nested-functions-parser-stack-overflow.js.dfg-maximal-flush- > validate-no-cjit > stress/many-nested-functions-parser-stack-overflow.js.ftl-eager > stress/many-nested-functions-parser-stack-overflow.js.ftl-eager-no-cjit > stress/many-nested-functions-parser-stack-overflow.js.ftl-eager-no-cjit-b3o1 > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-b3o0 > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-no-inline- > validate > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-no-put- > stack-validate > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-small-pool > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-validate- > sampling-profiler > stress/many-nested-functions-parser-stack-overflow.js.no-cjit-collect- > continuously > stress/many-nested-functions-parser-stack-overflow.js.no-cjit-validate- > phases > stress/many-nested-functions-parser-stack-overflow.js.no-ftl > stress/many-nested-functions-parser-stack-overflow.js.no-llint Should be fixed with: https://trac.webkit.org/changeset/245163 369506 2019-05-09 12:02:18 -0700 2019-05-09 12:03:08 -0700 Patch bug-197749-20190509120216.patch text/plain 2888 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy MTFiMzE1Nzk0YTcwY2RlYWViZmQ1YjBlMTBjODRkMDg2N2ZiMDE0Li4wMmM1ZDk2ODVhODEyMDEz OWJlMzYzZjQwNzUxZjNmYjQyYjU2ODE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wNS0wOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBwYXJzZVN0YXRlbWVudExpc3RJdGVtIG5lZWRzIGEgc3RhY2sgb3Zl cmZsb3cgY2hlY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5Nzc0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZXJlIGN1cnJlbnRseSBleGlzdHMgYSBwYXRoIGluIHRoZSBwYXJzZXIgd2hlcmUgeW91 IGNhbiBsb29wCisgICAgICAgIGFyYmlicmFyaWx5IG1hbnkgdGltZXMgd2l0aG91dCBhIHN0YWNr IG92ZXJmbG93IGNoZWNrLiBUaGlzIHBhdGNoCisgICAgICAgIGFkZHMgYSBjaGVjayB0byBwYXJz ZVN0YXRlbWVudExpc3RJdGVtIHRvIGJyZWFrIHRoYXQgY3ljbGUuCisKKyAgICAgICAgKiBwYXJz ZXIvUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6UGFyc2VyPExleGVyVHlwZT46OnBhcnNlU3Rh dGVtZW50TGlzdEl0ZW0pOgorCiAyMDE5LTA1LTA5ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxs ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNDUwNjQpOiBBU1NFUlRJT04g RkFJTEVEOiBtX3B0ciBzZWVuIHdpdGggd2FzbS55YW1sL3dhc20vanMtYXBpL3Rlc3RfRGF0YS5q cy53YXNtLXNsb3ctbWVtb3J5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFy c2VyL1BhcnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAK aW5kZXggZGNlNDU1MTU5ZmQ5ZjI2MzdhYzAxNTc3MzU4NmFiY2VhYTVmY2E4Yi4uYTNiODUxYzU3 YTlkNzUzM2ZjOTY1MWJhODc1MjFkNmJmNzg1NWQ3ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9w YXJzZXIvUGFyc2VyLmNwcApAQCAtNjUyLDYgKzY1Miw3IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVl QnVpbGRlcj4gVHJlZVN0YXRlbWVudCBQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VTdGF0ZW1lbnRM aXN0CiAgICAgLy8gaHR0cDovL3d3dy5lY21hLWludGVybmF0aW9uYWwub3JnL2VjbWEtMjYyLzYu MC9pbmRleC5odG1sI3NlYy1zdGF0ZW1lbnRzCiAgICAgRGVwdGhNYW5hZ2VyIHN0YXRlbWVudERl cHRoKCZtX3N0YXRlbWVudERlcHRoKTsKICAgICBtX3N0YXRlbWVudERlcHRoKys7CisgICAgZmFp bElmU3RhY2tPdmVyZmxvdygpOwogICAgIFRyZWVTdGF0ZW1lbnQgcmVzdWx0ID0gMDsKICAgICBi b29sIHNob3VsZFNldEVuZE9mZnNldCA9IHRydWU7CiAgICAgYm9vbCBzaG91bGRTZXRQYXVzZUxv Y2F0aW9uID0gZmFsc2U7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMv Q2hhbmdlTG9nCmluZGV4IDUwYzI2OGE0MjNkOTBhNzQ2MWZmZTk4ZGJmMGM3ZTc5MzBkNDMxOTQu LmVmNmZiYTc2ZGJmZGY2NTQ0YjY1NmE4YjhkOWJhZWUzMGU4NDgyYjAgMTAwNjQ0Ci0tLSBhL0pT VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTktMDUtMDkgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CisKKyAg ICAgICAgcGFyc2VTdGF0ZW1lbnRMaXN0SXRlbSBuZWVkcyBhIHN0YWNrIG92ZXJmbG93IGNoZWNr CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc3NDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVz cy9tYW55LW5lc3RlZC1mdW5jdGlvbnMtcGFyc2VyLXN0YWNrLW92ZXJmbG93LmpzOiBBZGRlZC4K KwogMjAxOS0wNS0wOCAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAg ICBBY2Nlc3NHZW5lcmF0aW9uU3RhdGU6OmVtaXRFeHBsaWNpdEV4Y2VwdGlvbkhhbmRsZXIgY2Fu IGNsb2JiZXIgYW4gaW4gdXNlIHJlZ2lzdGVyCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9t YW55LW5lc3RlZC1mdW5jdGlvbnMtcGFyc2VyLXN0YWNrLW92ZXJmbG93LmpzIGIvSlNUZXN0cy9z dHJlc3MvbWFueS1uZXN0ZWQtZnVuY3Rpb25zLXBhcnNlci1zdGFjay1vdmVyZmxvdy5qcwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5hYjNjN2Q5NjFhMTQ1YTgxZTM3Y2FkNmRkODM2MDE0M2M4OTEwODdkCi0tLSAvZGV2 L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvbWFueS1uZXN0ZWQtZnVuY3Rpb25zLXBhcnNlci1z dGFjay1vdmVyZmxvdy5qcwpAQCAtMCwwICsxLDEzIEBACit2YXIgY29kZSA9ICJmdW5jdGlvbiBm MSgpIHtcbiIucmVwZWF0KDgwMDAwKTsgCisgCitjb2RlICs9IGNvZGU7IAorIAorY29kZSArPSAi LCB4IiArIC0yMTQ3NDgzNjQ4ICsgIiA9ICIgKyAxOyAKKyAKK2NvZGUgKz0gIjtcbiI7IAorIAor Y29kZSArPSAiICByZXR1cm4gODAwMDA7XG4iOyAKKyAKK2NvZGUgKz0gIn1cbiI7IAorIAorZXZh bChjb2RlKTsgClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo= 369507 2019-05-09 12:03:09 -0700 2019-05-09 12:40:54 -0700 Patch bug-197749-20190509120307.patch text/plain 2923 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy MTFiMzE1Nzk0YTcwY2RlYWViZmQ1YjBlMTBjODRkMDg2N2ZiMDE0Li5hN2JkYTRmN2EyZGRmMjI5 MTBjMWYxN2MxNDkxNDZlNDZiYzM2MjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0wNS0wOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBwYXJzZVN0YXRlbWVudExpc3RJdGVtIG5lZWRzIGEgc3RhY2sgb3Zl cmZsb3cgY2hlY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5Nzc0OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTAzMDI2OTc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgY3VycmVudGx5IGV4 aXN0cyBhIHBhdGggaW4gdGhlIHBhcnNlciB3aGVyZSB5b3UgY2FuIGxvb3AKKyAgICAgICAgYXJi aWJyYXJpbHkgbWFueSB0aW1lcyB3aXRob3V0IGEgc3RhY2sgb3ZlcmZsb3cgY2hlY2suIFRoaXMg cGF0Y2gKKyAgICAgICAgYWRkcyBhIGNoZWNrIHRvIHBhcnNlU3RhdGVtZW50TGlzdEl0ZW0gdG8g YnJlYWsgdGhhdCBjeWNsZS4KKworICAgICAgICAqIHBhcnNlci9QYXJzZXIuY3BwOgorICAgICAg ICAoSlNDOjpQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VTdGF0ZW1lbnRMaXN0SXRlbSk6CisKIDIw MTktMDUtMDkgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTiAocjI0NTA2NCk6IEFTU0VSVElPTiBGQUlMRUQ6IG1fcHRyIHNlZW4gd2l0 aCB3YXNtLnlhbWwvd2FzbS9qcy1hcGkvdGVzdF9EYXRhLmpzLndhc20tc2xvdy1tZW1vcnkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAppbmRleCBkY2U0NTUxNTlmZDlmMjYz N2FjMDE1NzczNTg2YWJjZWFhNWZjYThiLi5hM2I4NTFjNTdhOWQ3NTMzZmM5NjUxYmE4NzUyMWQ2 YmY3ODU1ZDdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNl ci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCkBAIC02 NTIsNiArNjUyLDcgQEAgdGVtcGxhdGUgPGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVlU3RhdGVtZW50 IFBhcnNlcjxMZXhlclR5cGU+OjpwYXJzZVN0YXRlbWVudExpc3QKICAgICAvLyBodHRwOi8vd3d3 LmVjbWEtaW50ZXJuYXRpb25hbC5vcmcvZWNtYS0yNjIvNi4wL2luZGV4Lmh0bWwjc2VjLXN0YXRl bWVudHMKICAgICBEZXB0aE1hbmFnZXIgc3RhdGVtZW50RGVwdGgoJm1fc3RhdGVtZW50RGVwdGgp OwogICAgIG1fc3RhdGVtZW50RGVwdGgrKzsKKyAgICBmYWlsSWZTdGFja092ZXJmbG93KCk7CiAg ICAgVHJlZVN0YXRlbWVudCByZXN1bHQgPSAwOwogICAgIGJvb2wgc2hvdWxkU2V0RW5kT2Zmc2V0 ID0gdHJ1ZTsKICAgICBib29sIHNob3VsZFNldFBhdXNlTG9jYXRpb24gPSBmYWxzZTsKZGlmZiAt LWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTBjMjY4 YTQyM2Q5MGE3NDYxZmZlOThkYmYwYzdlNzkzMGQ0MzE5NC4uZWY2ZmJhNzZkYmZkZjY1NDRiNjU2 YThiOGQ5YmFlZTMwZTg0ODJiMCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIv SlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxOS0wNS0wOSAgS2VpdGggTWls bGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KKworICAgICAgICBwYXJzZVN0YXRlbWVudExp c3RJdGVtIG5lZWRzIGEgc3RhY2sgb3ZlcmZsb3cgY2hlY2sKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Nzc0OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL21hbnktbmVzdGVkLWZ1bmN0aW9u cy1wYXJzZXItc3RhY2stb3ZlcmZsb3cuanM6IEFkZGVkLgorCiAyMDE5LTA1LTA4ICBTYWFtIGJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEFjY2Vzc0dlbmVyYXRpb25TdGF0 ZTo6ZW1pdEV4cGxpY2l0RXhjZXB0aW9uSGFuZGxlciBjYW4gY2xvYmJlciBhbiBpbiB1c2UgcmVn aXN0ZXIKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL21hbnktbmVzdGVkLWZ1bmN0aW9ucy1w YXJzZXItc3RhY2stb3ZlcmZsb3cuanMgYi9KU1Rlc3RzL3N0cmVzcy9tYW55LW5lc3RlZC1mdW5j dGlvbnMtcGFyc2VyLXN0YWNrLW92ZXJmbG93LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmFiM2M3ZDk2MWExNDVh ODFlMzdjYWQ2ZGQ4MzYwMTQzYzg5MTA4N2QKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0 cmVzcy9tYW55LW5lc3RlZC1mdW5jdGlvbnMtcGFyc2VyLXN0YWNrLW92ZXJmbG93LmpzCkBAIC0w LDAgKzEsMTMgQEAKK3ZhciBjb2RlID0gImZ1bmN0aW9uIGYxKCkge1xuIi5yZXBlYXQoODAwMDAp OyAKKyAKK2NvZGUgKz0gY29kZTsgCisgCitjb2RlICs9ICIsIHgiICsgLTIxNDc0ODM2NDggKyAi ID0gIiArIDE7IAorIAorY29kZSArPSAiO1xuIjsgCisgCitjb2RlICs9ICIgIHJldHVybiA4MDAw MDtcbiI7IAorIAorY29kZSArPSAifVxuIjsgCisgCitldmFsKGNvZGUpOyAKXCBObyBuZXdsaW5l IGF0IGVuZCBvZiBmaWxlCg==