197724 2019-05-08 16:24:12 -0700 [Legacy WebKit] REGRESSION (r238078): Crash in hardwareKeyboardAvailabilityChangedCallback() 2019-06-04 13:07:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 12 RESOLVED FIXED InRadar, PlatformOnly, Regression P2 Normal --- 190565 1 dbates dbates cdumez thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1534551 0 dbates 2019-05-08 16:24:12 -0700 Sometimes we crash in Legacy WebKit inside hardwareKeyboardAvailabilityChangedCallback(). Here's a snippet from the crash report: Application Specific Information: objc_msgSend() selector name: _frame Thread 4 Crashed: 0 libobjc.A.dylib 0x00000001ec272530 objc_msgSend + 16 1 WebKitLegacy 0x00000001f733c61c ___ZL43hardwareKeyboardAvailabilityChangedCallbackP22__CFNotificationCenterPvPK10__CFStringPKvPK14__CFDictionary_block_invoke + 20 2 WebCore 0x00000001f6b97624 HandleRunSource(void*) + 712 3 CoreFoundation 0x00000001ed0112bc __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 20 4 CoreFoundation 0x00000001ed01123c __CFRunLoopDoSource0 + 84 5 CoreFoundation 0x00000001ed010b74 __CFRunLoopDoSources0 + 252 6 CoreFoundation 0x00000001ed00ba60 __CFRunLoopRun + 1000 7 CoreFoundation 0x00000001ed00b354 CFRunLoopRunSpecific + 432 8 WebCore 0x00000001f5c65480 RunWebThread(void*) + 596 9 libsystem_pthread.dylib 0x00000001ecc9f2c0 _pthread_body + 124 10 libsystem_pthread.dylib 0x00000001ecc9f220 _pthread_start + 40 11 libsystem_pthread.dylib 0x00000001ecca2cdc thread_start + 0 1534552 1 dbates 2019-05-08 16:24:55 -0700 <rdar://problem/49725959> 1534555 2 369444 dbates 2019-05-08 16:30:00 -0700 Created attachment 369444 Patch 1534562 3 369444 thorton 2019-05-08 16:36:37 -0700 Comment on attachment 369444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369444&action=review > Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:824 > + auto weakWebView = WeakObjCPtr<WebHTMLView>((__bridge WebHTMLView *)observer); You can probably just __weak, but this is fine too 1534564 4 369444 dbates 2019-05-08 16:38:03 -0700 Comment on attachment 369444 Patch Clearing flags on attachment: 369444 Committed r245076: <https://trac.webkit.org/changeset/245076> 1534565 5 dbates 2019-05-08 16:38:04 -0700 All reviewed patches have been landed. Closing bug. 1534611 6 wenson_hsieh 2019-05-08 19:01:09 -0700 *** Bug 197124 has been marked as a duplicate of this bug. *** 369444 2019-05-08 16:30:00 -0700 2019-05-08 16:38:03 -0700 Patch bug-197724-20190508162959.patch text/plain 2514 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggZTEzZjljY2M1MGU4Y2E4M2I4Mzk3NDJmZmYzZTc1NWIxMTU1NzU4Yi4uMGU4ZWU1N2I0Yzhm ZDNhYmRmMmVhY2RkZGJjNTlhMzc5NmYzNDBhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA1LTA4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFw cGxlLmNvbT4KKworICAgICAgICBbTGVnYWN5IFdlYktpdF0gUkVHUkVTU0lPTiAocjIzODA3OCk6 IENyYXNoIGluIGhhcmR3YXJlS2V5Ym9hcmRBdmFpbGFiaWxpdHlDaGFuZ2VkQ2FsbGJhY2soKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NzI0Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTcyNTk1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVjdWxhdGl2ZSBmaXggZm9yIHJhY2UgY29uZGl0 aW9uLiBCZXR3ZWVuIHRoZSB0aW1lIHdlIHJlY2VpdmUgYSBrR1NFdmVudEhhcmR3YXJlS2V5Ym9h cmRBdmFpbGFiaWxpdHlDaGFuZ2VkTm90aWZpY2F0aW9uCisgICAgICAgIG5vdGlmaWNhdGlvbiBh bmQgd2hlbiB3ZSBzY2hlZHVsZSBleGVjdXRpb24gdG8gcnVuIG9uIHRoZSBXZWJUaHJlYWQgdGhl IFdlYlZpZXcgdGhhdCBub3RpZmljYXRpb24KKyAgICAgICAgd2FzIGZvciBtYXkgbm8gbG9uZ2Vy IGV4aXN0LiBUYWtlIG91dCBhIHdlYWsgcHRyIG9uIHRoZSBXZWJWaWV3IHdoZW4gd2UgcmVjZWl2 ZSB0aGUgbm90aWZpY2F0aW9uCisgICAgICAgIGFuZCBjaGVjayB0aGF0IHdlIHN0aWxsIGhhdmUg aXQgb25jZSB3ZSBhcmUgcnVubmluZyBvbiB0aGUgV2ViVGhyZWFkLgorCisgICAgICAgICogV2Vi Vmlldy9XZWJIVE1MVmlldy5tbToKKyAgICAgICAgKGhhcmR3YXJlS2V5Ym9hcmRBdmFpbGFiaWxp dHlDaGFuZ2VkQ2FsbGJhY2spOgorCiAyMDE5LTA0LTI2ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGlu QGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgbmV3IGJ1aWxkIHJ1bGUgZm9yIHBvc3QtcHJv Y2Vzc2luZyBoZWFkZXJzIHdoZW4gdXNpbmcgWENCdWlsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KaW5kZXggOTQyZTZkMWExNDU3M2U2NTVkYTVh MTQ5M2Y3Yjk5NTBiZDc4ZmZjYi4uMWZhNWFjYjM1ZTdjZmNiYWUxMTNjYjVhNDA1Mzk0OTk0ZjRm OWVkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJIVE1M Vmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3 Lm1tCkBAIC0xNDYsNiArMTQ2LDcgQEAKICNpbXBvcnQgPHd0Zi9PYmpDUnVudGltZUV4dHJhcy5o PgogI2ltcG9ydCA8d3RmL1J1bkxvb3AuaD4KICNpbXBvcnQgPHd0Zi9TeXN0ZW1UcmFjaW5nLmg+ CisjaW1wb3J0IDx3dGYvV2Vha09iakNQdHIuaD4KIAogI2lmIFBMQVRGT1JNKE1BQykKICNpbXBv cnQgIldlYk5TRXZlbnRFeHRyYXMuaCIKQEAgLTgyMCwxMCArODIxLDEyIEBAIHN0YXRpYyBOU1N0 cmluZyAqIGNvbnN0IFdlYk1hcmtlZFRleHRVcGRhdGVkTm90aWZpY2F0aW9uID0gQCJXZWJNYXJr ZWRUZXh0VXBkYXRlCiBzdGF0aWMgdm9pZCBoYXJkd2FyZUtleWJvYXJkQXZhaWxhYmlsaXR5Q2hh bmdlZENhbGxiYWNrKENGTm90aWZpY2F0aW9uQ2VudGVyUmVmLCB2b2lkKiBvYnNlcnZlciwgQ0ZT dHJpbmdSZWYsIGNvbnN0IHZvaWQqLCBDRkRpY3Rpb25hcnlSZWYpCiB7CiAgICAgQVNTRVJUKG9i c2VydmVyKTsKKyAgICBhdXRvIHdlYWtXZWJWaWV3ID0gV2Vha09iakNQdHI8V2ViSFRNTFZpZXc+ KChfX2JyaWRnZSBXZWJIVE1MVmlldyAqKW9ic2VydmVyKTsKICAgICBXZWJUaHJlYWRSdW4oXnsK LSAgICAgICAgV2ViSFRNTFZpZXcgKndlYlZpZXcgPSAoX19icmlkZ2UgV2ViSFRNTFZpZXcgKilv YnNlcnZlcjsKLSAgICAgICAgaWYgKEZyYW1lKiBjb3JlRnJhbWUgPSBjb3JlKFt3ZWJWaWV3IF9m cmFtZV0pKQotICAgICAgICAgICAgY29yZUZyYW1lLT5ldmVudEhhbmRsZXIoKS5jYXBzTG9ja1N0 YXRlTWF5SGF2ZUNoYW5nZWQoKTsKKyAgICAgICAgaWYgKGF1dG8gd2ViVmlldyA9IHdlYWtXZWJW aWV3LmdldCgpKSB7CisgICAgICAgICAgICBpZiAoYXV0byogY29yZUZyYW1lID0gY29yZShbd2Vi VmlldyBfZnJhbWVdKSkKKyAgICAgICAgICAgICAgICBjb3JlRnJhbWUtPmV2ZW50SGFuZGxlcigp LmNhcHNMb2NrU3RhdGVNYXlIYXZlQ2hhbmdlZCgpOworICAgICAgICB9CiAgICAgfSk7CiB9CiAj ZW5kaWYK