197715 2019-05-08 15:04:05 -0700 AccessGenerationState::emitExplicitExceptionHandler can clobber an in use register 2019-05-08 17:49:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue ews-watchlist fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1534502 0 saam 2019-05-08 15:04:05 -0700 ... 1534513 1 saam 2019-05-08 15:17:17 -0700 <rdar://problem/50399252> 1534522 2 369434 saam 2019-05-08 15:25:48 -0700 Created attachment 369434 patch 1534523 3 ews-watchlist 2019-05-08 15:27:33 -0700 Attachment 369434 did not pass style-queue: ERROR: Source/JavaScriptCore/b3/air/AirCode.cpp:83: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/b3/air/AirCode.cpp:84: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1534597 4 369434 commit-queue 2019-05-08 17:49:41 -0700 Comment on attachment 369434 patch Clearing flags on attachment: 369434 Committed r245084: <https://trac.webkit.org/changeset/245084> 1534598 5 commit-queue 2019-05-08 17:49:43 -0700 All reviewed patches have been landed. Closing bug. 369434 2019-05-08 15:25:48 -0700 2019-05-08 17:49:41 -0700 patch b-backup.diff text/plain 5407 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDUwNzApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTA1LTA4ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIEFjY2Vzc0dlbmVyYXRpb25TdGF0ZTo6ZW1pdEV4cGxpY2l0RXhjZXB0 aW9uSGFuZGxlciBjYW4gY2xvYmJlciBhbiBpbiB1c2UgcmVnaXN0ZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzcxNQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTAzOTkyNTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBzdHJlc3MvcG9seW1vcnBoaWMtYWNjZXNzLWV4Y2VwdGlvbi1oYW5kbGVy LXNob3VsZC1ub3QtY2xvYmJlci11c2VkLXJlZ2lzdGVyLmpzOiBBZGRlZC4KKyAgICAgICAgKGZv byk6CisgICAgICAgIChiYXIpOgorCiAyMDE5LTA1LTA4ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jp c3NldEBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsIHByb3RvdHlwZXMgc2hvdWxkIGNhbGwgZGlk QmVjb21lUHJvdG90eXBlKCkKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3BvbHltb3JwaGljLWFjY2Vz cy1leGNlcHRpb24taGFuZGxlci1zaG91bGQtbm90LWNsb2JiZXItdXNlZC1yZWdpc3Rlci5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9wb2x5bW9ycGhpYy1hY2Nlc3MtZXhjZXB0aW9u LWhhbmRsZXItc2hvdWxkLW5vdC1jbG9iYmVyLXVzZWQtcmVnaXN0ZXIuanMJKG5vbmV4aXN0ZW50 KQorKysgSlNUZXN0cy9zdHJlc3MvcG9seW1vcnBoaWMtYWNjZXNzLWV4Y2VwdGlvbi1oYW5kbGVy LXNob3VsZC1ub3QtY2xvYmJlci11c2VkLXJlZ2lzdGVyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMjIgQEAKKy8vQCBydW5EZWZhdWx0KCItLXVzZUNvbmN1cnJlbnRKSVQ9MCIsICItLXVz ZVJhbmRvbWl6aW5nRnV6emVyQWdlbnQ9MSIsICItLWFpclJhbmRvbWl6ZVJlZ3M9MSIsICItLWFp clJhbmRvbWl6ZVJlZ3NTZWVkPTM0MjExODczNzIiLCAiLS1qaXRQb2xpY3lTY2FsZT0wIikKKwor ZnVuY3Rpb24gZm9vKCkgeworICAgIHRyeSB7CisgICAgICAgIGZvby5jYWxsZXI7CisgICAgfSBj YXRjaCAoZSkgeworICAgICAgICByZXR1cm4gQXJyYXkub2YoYXJndW1lbnRzKS5qb2luKCk7Cisg ICAgfQorICAgIHRocm93IG5ldyBFcnJvcigpOworfQorCitmdW5jdGlvbiBiYXIoKSB7CisndXNl IHN0cmljdCc7CisgICAgdHJ5IHsKKyAgICAgICAgcmV0dXJuIGZvbygpOworICAgIH0gZmluYWxs eSB7CisgICAgfQorfQorCitmb3IgKHZhciBpID0gMDsgaSA8IDEwMDAwOyArK2kpIHsKKyAgICBi YXIoKTsKK30KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ1MDQwKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE5LTA1LTA4ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgor CisgICAgICAgIEFjY2Vzc0dlbmVyYXRpb25TdGF0ZTo6ZW1pdEV4cGxpY2l0RXhjZXB0aW9uSGFu ZGxlciBjYW4gY2xvYmJlciBhbiBpbiB1c2UgcmVnaXN0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzcxNQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTAzOTkyNTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWNjZXNzR2VuZXJhdGlvblN0YXRlOjplbWl0RXhwbGljaXRFeGNlcHRpb25IYW5kbGVy IHdhcyBhbHdheXMgY2xvYmJlcmluZworICAgICAgICB4ODYncyByOSB3aXRob3V0IGNvbnNpZGVy aW5nIGlmIHRoYXQgcmVnaXN0ZXIgd2FzIG5lZWRlZCB0byBiZSBwcmVzZXJ2ZWQKKyAgICAgICAg YnkgdGhlIElDLiBUaGlzIGxlYWRzIHRvIGJhZCB0aGluZ3Mgd2hlbiB0aGUgREZHL0ZUTCBuZWVk IHRoYXQgcmVnaXN0ZXIgd2hlbgorICAgICAgICBPU1IgZXhpdHRpbmcgYWZ0ZXIgYW4gZXhjZXB0 aW9uIGZyb20gYSBHZXRCeUlkIGNhbGwuCisKKyAgICAgICAgKiBiMy9haXIvQWlyQ29kZS5jcHA6 CisgICAgICAgIChKU0M6OkIzOjpBaXI6OkNvZGU6OkNvZGUpOgorICAgICAgICAqIGJ5dGVjb2Rl L1BvbHltb3JwaGljQWNjZXNzLmNwcDoKKyAgICAgICAgKEpTQzo6QWNjZXNzR2VuZXJhdGlvblN0 YXRlOjplbWl0RXhwbGljaXRFeGNlcHRpb25IYW5kbGVyKToKKyAgICAgICAgKiBydW50aW1lL09w dGlvbnMuaDoKKwogMjAxOS0wNS0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgogCiAgICAgICAgIFRlbXBsYXRlT2JqZWN0IHBhc3NlZCB0byB0ZW1wbGF0ZSBsaXRlcmFsIHRh Z3MgYXJlIG5vdCBhbHdheXMgaWRlbnRpY2FsIGZvciB0aGUgc2FtZSBzb3VyY2UgbG9jYXRpb24u CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0FpckNvZGUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyQ29kZS5jcHAJKHJldmlzaW9u IDI0NTA0MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyQ29kZS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTc5LDggKzc5LDkgQEAgQ29kZTo6Q29kZShQcm9jZWR1cmUmIHByb2Mp CiAgICAgICAgICAgICAgICAgICAgICAgICBjYWxsZWVTYXZlUmVncy5hcHBlbmQocmVnKTsKICAg ICAgICAgICAgICAgICB9KTsKICAgICAgICAgICAgIGlmIChPcHRpb25zOjphaXJSYW5kb21pemVS ZWdzKCkpIHsKLSAgICAgICAgICAgICAgICBzaHVmZmxlVmVjdG9yKHZvbGF0aWxlUmVncywgWyZd ICh1bnNpZ25lZCBsaW1pdCkgeyByZXR1cm4gbV93ZWFrUmFuZG9tLmdldFVpbnQzMihsaW1pdCk7 IH0pOwotICAgICAgICAgICAgICAgIHNodWZmbGVWZWN0b3IoY2FsbGVlU2F2ZVJlZ3MsIFsmXSAo dW5zaWduZWQgbGltaXQpIHsgcmV0dXJuIG1fd2Vha1JhbmRvbS5nZXRVaW50MzIobGltaXQpOyB9 KTsKKyAgICAgICAgICAgICAgICBXZWFrUmFuZG9tIHJhbmRvbShPcHRpb25zOjphaXJSYW5kb21p emVSZWdzU2VlZCgpID8gT3B0aW9uczo6YWlyUmFuZG9taXplUmVnc1NlZWQoKSA6IG1fd2Vha1Jh bmRvbS5nZXRVaW50MzIoKSk7CisgICAgICAgICAgICAgICAgc2h1ZmZsZVZlY3Rvcih2b2xhdGls ZVJlZ3MsIFsmXSAodW5zaWduZWQgbGltaXQpIHsgcmV0dXJuIHJhbmRvbS5nZXRVaW50MzIobGlt aXQpOyB9KTsKKyAgICAgICAgICAgICAgICBzaHVmZmxlVmVjdG9yKGNhbGxlZVNhdmVSZWdzLCBb Jl0gKHVuc2lnbmVkIGxpbWl0KSB7IHJldHVybiByYW5kb20uZ2V0VWludDMyKGxpbWl0KTsgfSk7 CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBWZWN0b3I8UmVnPiByZXN1bHQ7CiAgICAgICAg ICAgICByZXN1bHQuYXBwZW5kVmVjdG9yKHZvbGF0aWxlUmVncyk7CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvZGUvUG9seW1vcnBoaWNBY2Nlc3MuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Qb2x5bW9ycGhpY0FjY2Vzcy5jcHAJKHJl dmlzaW9uIDI0NTA0MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Qb2x5bW9y cGhpY0FjY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3OSw3ICsxNzksMTEgQEAgQ2FsbFNp dGVJbmRleCBBY2Nlc3NHZW5lcmF0aW9uU3RhdGU6Om9yaQogdm9pZCBBY2Nlc3NHZW5lcmF0aW9u U3RhdGU6OmVtaXRFeHBsaWNpdEV4Y2VwdGlvbkhhbmRsZXIoKQogewogICAgIHJlc3RvcmVTY3Jh dGNoKCk7Ci0gICAgaml0LT5jb3B5Q2FsbGVlU2F2ZXNUb0VudHJ5RnJhbWVDYWxsZWVTYXZlc0J1 ZmZlcihtX3ZtLnRvcEVudHJ5RnJhbWUpOworICAgIGppdC0+cHVzaFRvU2F2ZShHUFJJbmZvOjpy ZWdUMCk7CisgICAgaml0LT5sb2FkUHRyKCZtX3ZtLnRvcEVudHJ5RnJhbWUsIEdQUkluZm86OnJl Z1QwKTsKKyAgICBqaXQtPmNvcHlDYWxsZWVTYXZlc1RvRW50cnlGcmFtZUNhbGxlZVNhdmVzQnVm ZmVyKEdQUkluZm86OnJlZ1QwKTsKKyAgICBqaXQtPnBvcFRvUmVzdG9yZShHUFJJbmZvOjpyZWdU MCk7CisKICAgICBpZiAobmVlZHNUb1Jlc3RvcmVSZWdpc3RlcnNJZkV4Y2VwdGlvbigpKSB7CiAg ICAgICAgIC8vIFRvIHRoZSBKSVQgdGhhdCBwcm9kdWNlcyB0aGUgb3JpZ2luYWwgZXhjZXB0aW9u IGhhbmRsaW5nCiAgICAgICAgIC8vIGNhbGwgc2l0ZSwgdGhleSB3aWxsIGV4cGVjdCB0aGUgT1NS IGV4aXQgdG8gYmUgYXJyaXZlZApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv T3B0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09w dGlvbnMuaAkocmV2aXNpb24gMjQ1MDQwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvT3B0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC00NDUsNiArNDQ1LDcgQEAgY29uc3RleHBy IGJvb2wgZW5hYmxlV2ViQXNzZW1ibHlTdHJlYW1pbgogICAgIHYoYm9vbCwgYWlyRm9yY2VCcmln Z3NBbGxvY2F0b3IsIGZhbHNlLCBOb3JtYWwsIG51bGxwdHIpIFwKICAgICB2KGJvb2wsIGFpckZv cmNlSVJDQWxsb2NhdG9yLCBmYWxzZSwgTm9ybWFsLCBudWxscHRyKSBcCiAgICAgdihib29sLCBh aXJSYW5kb21pemVSZWdzLCBmYWxzZSwgTm9ybWFsLCBudWxscHRyKSBcCisgICAgdih1bnNpZ25l ZCwgYWlyUmFuZG9taXplUmVnc1NlZWQsIDAsIE5vcm1hbCwgbnVsbHB0cikgXAogICAgIHYoYm9v bCwgY29hbGVzY2VTcGlsbFNsb3RzLCB0cnVlLCBOb3JtYWwsIG51bGxwdHIpIFwKICAgICB2KGJv b2wsIGxvZ0FpclJlZ2lzdGVyUHJlc3N1cmUsIGZhbHNlLCBOb3JtYWwsIG51bGxwdHIpIFwKICAg ICB2KGJvb2wsIHVzZUIzVGFpbER1cCwgdHJ1ZSwgTm9ybWFsLCBudWxscHRyKSBcCg==