197695 2019-05-08 10:17:52 -0700 fast/hidpi/video-controls-in-hidpi.html sometimes asserts in WK1 2019-05-09 11:26:32 -0700 1 1 1 Unclassified WebKit Compositing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=126160 InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1534359 0 simon.fraser 2019-05-08 10:17:52 -0700 With the patch from bug 197561, fast/hidpi/video-controls-in-hidpi.html sometimes asserts on EWS (I have not been able to reproduce). 1534360 1 simon.fraser 2019-05-08 10:18:25 -0700 The assertion is: ASSERT(!parentClipRect.isInfinite()); 1534635 2 simon.fraser 2019-05-08 21:24:07 -0700 This code runs when we have a m_ancestorClippingLayer, and we make one based on the result of RenderLayerCompositor::clippedByAncestor(), which uses: layer.backgroundClipRect(RenderLayer::ClipRectsContext(computeClipRoot, TemporaryClipRects)).isInfinite() However, RenderLayerBacking::computeParentGraphicsLayerRect() is doing: ShouldRespectOverflowClip shouldRespectOverflowClip = compositedAncestor->isolatesCompositedBlending() ? RespectOverflowClip : IgnoreOverflowClip; RenderLayer::ClipRectsContext clipRectsContext(compositedAncestor, TemporaryClipRects, IgnoreOverlayScrollbarSize, shouldRespectOverflowClip); LayoutRect parentClipRect = m_owningLayer.backgroundClipRect(clipRectsContext).rect(); // FIXME: Incorrect for CSS regions. so 'shouldRespectOverflowClip' differs. 1534637 3 simon.fraser 2019-05-08 21:24:14 -0700 *** Bug 197731 has been marked as a duplicate of this bug. *** 1534638 4 simon.fraser 2019-05-08 21:24:37 -0700 That code came from https://trac.webkit.org/changeset/168314/webkit 1534642 5 simon.fraser 2019-05-08 21:49:53 -0700 accessibility/media-element.html also hits this 1534646 6 simon.fraser 2019-05-08 22:37:34 -0700 One thing to note here is that normally we don't have an m_ancestorLayer if our clipping ancestor is a stacking context, but with a composited mix-blend-mode child, RenderLayerCompositor::clippedByAncestor() follows a different code path, and can give us an m_ancestorClippingLayer. I don't know why. 1534648 7 simon.fraser 2019-05-08 22:48:00 -0700 This bug is about maintenance of the isolatesCompositedBlending() bit on RenderLayer vs. the maintenance of m_ancestorClippingLayer. If compositedAncestor->isolatesCompositedBlending() was true at the last compositing update, we made a m_ancestorClippingLayer. At some point another composited sibling with blending became non-composited, so compositedAncestor->isolatesCompositedBlending() is no longer true but we didn't remove the m_ancestorClippingLayer. 1534650 8 simon.fraser 2019-05-08 22:50:10 -0700 isolatesCompositedBlending depends on both m_hasNotIsolatedCompositedBlendingDescendants and isCSSStackingContext 1534656 9 simon.fraser 2019-05-08 23:07:29 -0700 The fix is something like: index 15479365f2edf9776a01e4f4e70c792921824975..8532ac6c3acb2df5eb75a5d6b43981d2cc5c4eaa 100644 --- a/Source/WebCore/rendering/RenderLayerCompositor.cpp +++ b/Source/WebCore/rendering/RenderLayerCompositor.cpp @@ -1022,8 +1022,13 @@ void RenderLayerCompositor::computeCompositingRequirements(RenderLayer* ancestor addToOverlapMap(overlapMap, layer, layerExtent); #if ENABLE(CSS_COMPOSITING) + bool isolatedCompositedBlending = layer.isolatesCompositedBlending(); layer.setHasNotIsolatedCompositedBlendingDescendants(childState.hasNotIsolatedCompositedBlendingDescendants); ASSERT(!layer.hasNotIsolatedCompositedBlendingDescendants() || layer.hasNotIsolatedBlendingDescendants()); + if (layer.isolatesCompositedBlending() != isolatedCompositedBlending) { + // isolatedCompositedBlending affects the answer to clippedByAncestor(). + layer.setChildrenNeedCompositingGeometryUpdate(); + } #endif // Now check for reasons to become composited that depend on the state of descendant layers. RenderLayer::IndirectCompositingReason indirectCompositingReason; 1534725 10 369491 simon.fraser 2019-05-09 07:14:29 -0700 Created attachment 369491 Patch 1534732 11 webkit-bug-importer 2019-05-09 07:38:10 -0700 <rdar://problem/50621407> 1534789 12 369491 commit-queue 2019-05-09 11:26:30 -0700 Comment on attachment 369491 Patch Clearing flags on attachment: 369491 Committed r245147: <https://trac.webkit.org/changeset/245147> 1534790 13 commit-queue 2019-05-09 11:26:32 -0700 All reviewed patches have been landed. Closing bug. 369491 2019-05-09 07:14:29 -0700 2019-05-09 11:26:30 -0700 Patch bug-197695-20190509071428.patch text/plain 3011 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQxNDdjNTk5ODcwNThi OGM2YmE1MjVkYmEyZTU4MmRlZGI4ZmMzNy4uOWUwODNjZTViODMyNGYwYzZiMTJlMTcwNDc1YzA0 NzhhYzhiMjg3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTA1LTA5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIGZhc3QvaGlkcGkv dmlkZW8tY29udHJvbHMtaW4taGlkcGkuaHRtbCBzb21ldGltZXMgYXNzZXJ0cyBpbiBXSzEKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzY5NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpdGggdGhlIGJh Y2tpbmctc2hhcmluZyBjaGFuZ2VzIHRoYXQgbGFuZGVkIGluIHIyNDUwNTgsIHNvbWUgV2ViS2l0 MSB0ZXN0cyB3aXRoIG1lZGlhIGNvbnRyb2xzIGFzc2VydGVkIGluCisgICAgICAgIFJlbmRlckxh eWVyQmFja2luZzo6Y29tcHV0ZVBhcmVudEdyYXBoaWNzTGF5ZXJSZWN0KCkgYmVjYXVzZSBhIGxh eWVyIHdvdWxkIGhhdmUgYSBtX2FuY2VzdG9yQ2xpcHBpbmdMYXllciwKKyAgICAgICAgYnV0IGJh Y2tncm91bmRDbGlwUmVjdCgpIHdvdWxkIHJldHVybiBhbiBpbmZpbml0ZSByZWN0LgorICAgICAg ICAKKyAgICAgICAgVGhpcyBoYXBwZW5lZCB3aGVuIGEgbGF5ZXIgdHJlZSBjaGFuZ2UgY2F1c2Vk IHRoZSBsYXllcidzIGNvbXBvc2l0aW5nIGFuY2VzdG9yIHRvIG5vIGxvbmdlciBpc29sYXRlCisg ICAgICAgIGNvbXBvc2l0ZWQgYmxlbmRpbmcgKHdoaWNoIGFmZmVjdHMgdGhlIGJlaGF2aW9yIG9m IFJlbmRlckxheWVyQ29tcG9zaXRvcjpjbGlwcGVkQnlBbmNlc3RvcigpKSwgYnV0IHdlIGZhaWxl ZAorICAgICAgICB0byBtYXJrIGl0cyBjb21wb3NpdGVkIGNoaWxkcmVuIGFzIG5lZWRpbmcgdGhl IGNvbmZpZ3VyYXRpb24gdXBkYXRlIHdoaWNoIHdvdWxkIGVsaW1pbmF0ZSB0aGVpciBtX2FuY2Vz dG9yQ2xpcHBpbmdMYXllcnMuCisgICAgICAgIAorICAgICAgICBUaGUgZml4IGlzIHRvIGNhbGwg c2V0Q2hpbGRyZW5OZWVkQ29tcG9zaXRpbmdHZW9tZXRyeVVwZGF0ZSgpIHdoZW4gaXNvbGF0ZXND b21wb3NpdGVkQmxlbmRpbmcgY2hhbmdlcy4gV2UgZG9uJ3QgaGFldgorICAgICAgICBzZXRDaGls ZHJlbk5lZWRDb21wb3NpdGluZ0NvbmZpZ3VyYXRpb25VcGRhdGUoKSwgYnV0IHNldENoaWxkcmVu TmVlZENvbXBvc2l0aW5nR2VvbWV0cnlVcGRhdGUoKSBoYXMgdGhlIGRlc2lyZWQgc2lkZS1lZmZl Y3QuCisKKyAgICAgICAgSSB3YXMgdW5hYmxlIHRvIG1ha2UgYSBzdGFuZGFsb25lIHRlc3QgY2Fz ZSBmb3IgdGhpcywgYnV0IHRoZSBjb2RlIGlzIGV4ZXJjaXNlZCBieSBtZWRpYSBjb250cm9sIHRl c3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmNvbXB1dGVDb21wb3NpdGlu Z1JlcXVpcmVtZW50cyk6CisKIDIwMTktMDUtMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IGJhY2tpbmctc2hhcmluZyBpbiBjb21w b3NpdGluZyBsYXllcnMsIGFsbG93aW5nIG92ZXJsYXAgbGF5ZXJzIHRvIHBhaW50IGludG8gdGhl IGJhY2tpbmcgc3RvcmUgb2YgYW5vdGhlciBsYXllcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCAxNTQ3OTM2NWYyZWRmOTc3 NmEwMWU0ZjRlNzBjNzkyOTIxODI0OTc1Li5lM2E0YzlmM2Y4N2FiZWI0ZWJlNDAyNGZlYzFlNjlh YzUxNjQ4ZDM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcApAQCAtMTAyMiw3ICsxMDIyLDEzIEBAIHZvaWQgUmVuZGVyTGF5ZXJD b21wb3NpdG9yOjpjb21wdXRlQ29tcG9zaXRpbmdSZXF1aXJlbWVudHMoUmVuZGVyTGF5ZXIqIGFu Y2VzdG9yCiAgICAgICAgIGFkZFRvT3ZlcmxhcE1hcChvdmVybGFwTWFwLCBsYXllciwgbGF5ZXJF eHRlbnQpOwogCiAjaWYgRU5BQkxFKENTU19DT01QT1NJVElORykKKyAgICBib29sIGlzb2xhdGVk Q29tcG9zaXRlZEJsZW5kaW5nID0gbGF5ZXIuaXNvbGF0ZXNDb21wb3NpdGVkQmxlbmRpbmcoKTsK ICAgICBsYXllci5zZXRIYXNOb3RJc29sYXRlZENvbXBvc2l0ZWRCbGVuZGluZ0Rlc2NlbmRhbnRz KGNoaWxkU3RhdGUuaGFzTm90SXNvbGF0ZWRDb21wb3NpdGVkQmxlbmRpbmdEZXNjZW5kYW50cyk7 CisgICAgaWYgKGxheWVyLmlzb2xhdGVzQ29tcG9zaXRlZEJsZW5kaW5nKCkgIT0gaXNvbGF0ZWRD b21wb3NpdGVkQmxlbmRpbmcpIHsKKyAgICAgICAgLy8gaXNvbGF0ZWRDb21wb3NpdGVkQmxlbmRp bmcgYWZmZWN0cyB0aGUgcmVzdWx0IG9mIGNsaXBwZWRCeUFuY2VzdG9yKCkuCisgICAgICAgIGxh eWVyLnNldENoaWxkcmVuTmVlZENvbXBvc2l0aW5nR2VvbWV0cnlVcGRhdGUoKTsKKyAgICB9CisK ICAgICBBU1NFUlQoIWxheWVyLmhhc05vdElzb2xhdGVkQ29tcG9zaXRlZEJsZW5kaW5nRGVzY2Vu ZGFudHMoKSB8fCBsYXllci5oYXNOb3RJc29sYXRlZEJsZW5kaW5nRGVzY2VuZGFudHMoKSk7CiAj ZW5kaWYKICAgICAvLyBOb3cgY2hlY2sgZm9yIHJlYXNvbnMgdG8gYmVjb21lIGNvbXBvc2l0ZWQg dGhhdCBkZXBlbmQgb24gdGhlIHN0YXRlIG9mIGRlc2NlbmRhbnQgbGF5ZXJzLgo=