<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>197663</bug_id>
          
          <creation_ts>2019-05-07 09:03:08 -0700</creation_ts>
          <short_desc>[GTK][WPE] Cannot build documentation with gtk-doc</short_desc>
          <delta_ts>2019-05-07 13:33:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>berto</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gustavo</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pnormand</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1533934</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2019-05-07 09:03:08 -0700</bug_when>
    <thetext>The following error prevents gtk-doc from generating the HTML output:

[840/840] Generating ../../WebKit2WebExtension-4.0.typelib
samu: job failed: cd /home/aperez/devel/WebKit/build-jsc &amp;&amp; /usr/bin/cmake -E env CC=/usr/lib/ccache/bin/cc &quot;CFLAGS=-fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-psabi -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align  -fno-strict-aliasing -fno-exceptions -Wno-unused-parameter&quot; /home/aperez/devel/WebKit/Tools/gtkdoc/generate-gtkdoc --gtk &amp;&amp; touch docs-build.stamp
html/jsc-glib-4.0/JSCValue.html:2306: warning: no link for: &quot;api-index-2.26&quot; -&gt; (2.26).
html/webkitdomgtk-4.0/WebKitDOMAttr.html:380: warning: no link for: &quot;api-index-2.14&quot; -&gt; (2.14).
html/webkitdomgtk-4.0/WebKitDOMDOMSelection.html:381: warning: no link for: &quot;api-index-2.16&quot; -&gt; (2.16).
html/webkitdomgtk-4.0/WebKitDOMDocument.html:1561: warning: no link for: &quot;api-index-2.12&quot; -&gt; (2.12).
html/webkitdomgtk-4.0/WebKitDOMDocument.html:1886: warning: no link for: &quot;WebKitDOMNodeFilter&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMNodeFilter&lt;/span&gt;).
html/webkitdomgtk-4.0/WebKitDOMDocument.html:2055: warning: no link for: &quot;WebKitDOMXPathNSResolver&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMXPathNSResolver&lt;/span&gt;).
html/webkitdomgtk-4.0/WebKitDOMDocument.html:4267: warning: no link for: &quot;WebKitDOMEntityReference&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMEntityReference&lt;/span&gt;).
html/webkitdomgtk-4.0/WebKitDOMElement.html:2654: warning: no link for: &quot;WebKitDOMClientRect&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMClientRect&lt;/span&gt;).
html/webkitdomgtk-4.0/WebKitDOMElement.html:2677: warning: no link for: &quot;api-index-2.18&quot; -&gt; (2.18).
html/webkitdomgtk-4.0/WebKitDOMElement.html:2707: warning: no link for: &quot;WebKitDOMClientRectList&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMClientRectList&lt;/span&gt;).
html/webkitdomgtk-4.0/WebKitDOMElement.html:2770: warning: no link for: &quot;api-index-2.8&quot; -&gt; (2.8).
html/webkitdomgtk-4.0/WebKitDOMElement.html:3035: warning: no link for: &quot;api-index-2.10&quot; -&gt; (2.10).
html/webkitdomgtk-4.0/WebKitDOMEvent.html:193: warning: no link for: &quot;WebKitDOMEventTarget&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMEventTarget&lt;/span&gt;).
html/webkitdomgtk-4.0/index-all.html:129: warning: no link for: &quot;webkit-dom-client-rect-get-bottom&quot; -&gt; (webkit_dom_client_rect_get_bottom).
html/webkitdomgtk-4.0/index-all.html:133: warning: no link for: &quot;webkit-dom-client-rect-get-height&quot; -&gt; (webkit_dom_client_rect_get_height).
html/webkitdomgtk-4.0/index-all.html:137: warning: no link for: &quot;webkit-dom-client-rect-get-left&quot; -&gt; (webkit_dom_client_rect_get_left).
html/webkitdomgtk-4.0/index-all.html:141: warning: no link for: &quot;webkit-dom-client-rect-get-right&quot; -&gt; (webkit_dom_client_rect_get_right).
html/webkitdomgtk-4.0/index-all.html:145: warning: no link for: &quot;webkit-dom-client-rect-get-top&quot; -&gt; (webkit_dom_client_rect_get_top).
html/webkitdomgtk-4.0/index-all.html:149: warning: no link for: &quot;webkit-dom-client-rect-get-width&quot; -&gt; (webkit_dom_client_rect_get_width).
html/webkitdomgtk-4.0/index-all.html:153: warning: no link for: &quot;webkit-dom-client-rect-list-get-length&quot; -&gt; (webkit_dom_client_rect_list_get_length).
html/webkitdomgtk-4.0/index-all.html:157: warning: no link for: &quot;webkit-dom-client-rect-list-item&quot; -&gt; (webkit_dom_client_rect_list_item).
html/webkitdomgtk-4.0/index-all.html:5218: warning: no link for: &quot;WebKitDOMClientRect-struct&quot; -&gt; (WebKitDOMClientRect).
html/webkitdomgtk-4.0/index-all.html:5222: warning: no link for: &quot;WebKitDOMClientRect--bottom&quot; -&gt; (WebKitDOMClientRect:bottom).
html/webkitdomgtk-4.0/index-all.html:5226: warning: no link for: &quot;WebKitDOMClientRect--height&quot; -&gt; (WebKitDOMClientRect:height).
html/webkitdomgtk-4.0/index-all.html:5230: warning: no link for: &quot;WebKitDOMClientRect--left&quot; -&gt; (WebKitDOMClientRect:left).
html/webkitdomgtk-4.0/index-all.html:5234: warning: no link for: &quot;WebKitDOMClientRect--right&quot; -&gt; (WebKitDOMClientRect:right).
html/webkitdomgtk-4.0/index-all.html:5238: warning: no link for: &quot;WebKitDOMClientRect--top&quot; -&gt; (WebKitDOMClientRect:top).
html/webkitdomgtk-4.0/index-all.html:5242: warning: no link for: &quot;WebKitDOMClientRect--width&quot; -&gt; (WebKitDOMClientRect:width).
html/webkitdomgtk-4.0/index-all.html:5246: warning: no link for: &quot;WebKitDOMClientRectList-struct&quot; -&gt; (WebKitDOMClientRectList).
html/webkitdomgtk-4.0/index-all.html:5250: warning: no link for: &quot;WebKitDOMClientRectList--length&quot; -&gt; (WebKitDOMClientRectList:length).
html/webkitdomgtk-4.0/webkitdomgtk-4.0-WebKitDOMHTMLBaseFontElement.html:102: warning: no link for: &quot;WebKitDOMHTMLBaseFontElement&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMHTMLBaseFontElement&lt;/span&gt;).
html/webkitdomgtk-4.0/webkitdomgtk-4.0-WebKitDOMNodeFilter./home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3395: parser error : Opening and ending tag mismatch: video line 3394 and para
playback support disabled.&lt;/para&gt;
                                 ^
/home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3398: parser error : Opening and ending tag mismatch: track line 3394 and refsect2
 role=&quot;since&quot;&gt;Since: &lt;link linkend=&quot;api-index-2.26&quot;&gt;2.26&lt;/link&gt;&lt;/para&gt;&lt;/refsect2
                                                                               ^
/home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3703: parser error : Opening and ending tag mismatch: audio line 3394 and refsect1
&lt;/refsect1&gt;
           ^
/home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3705: parser error : Opening and ending tag mismatch: para line 3393 and refentry
&lt;/refentry&gt;
           ^
/home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3706: parser error : Premature end of data in tag refsect2 line 3390

^
/home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3706: parser error : Premature end of data in tag refsect1 line 3176

^
/home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3706: parser error : Premature end of data in tag refentry line 6

^
/home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/webkit2gtk-docs.sgml:19: element include: XInclude error : could not load /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml, and no fallback was found
html:180: warning: no link for: &quot;api-index-2.6&quot; -&gt; (2.6).
html/webkitdomgtk-4.0/webkitdomgtk-4.0-WebKitDOMNodeFilter.html:229: warning: no link for: &quot;WebKitDOMCDataSection&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMCDataSection&lt;/span&gt;).
html/webkitdomgtk-4.0/webkitdomgtk-4.0-WebKitDOMNodeFilter.html:301: warning: no link for: &quot;WebKitDOMEntity&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMEntity&lt;/span&gt;).
html/webkitdomgtk-4.0/webkitdomgtk-4.0-WebKitDOMNodeFilter.html:325: warning: no link for: &quot;WebKitDOMNotation&quot; -&gt; (&lt;span class=&quot;type&quot;&gt;WebKitDOMNotation&lt;/span&gt;).
Traceback (most recent call last):
  File &quot;/home/aperez/devel/WebKit/Tools/gtkdoc/generate-gtkdoc&quot;, line 254, in &lt;module&gt;
    build_gtkdoc_for_wkgtk(arguments)
  File &quot;/home/aperez/devel/WebKit/Tools/gtkdoc/generate-gtkdoc&quot;, line 224, in build_gtkdoc_for_wkgtk
    saw_warnings = generate_documentation(webkit2_generator)
  File &quot;/home/aperez/devel/WebKit/Tools/gtkdoc/generate-gtkdoc&quot;, line 158, in generate_documentation
    return generate_doc(generator, arguments.skip_html)
  File &quot;/home/aperez/devel/WebKit/Tools/gtkdoc/generate-gtkdoc&quot;, line 145, in generate_doc
    generator.generate(not skip_html)
  File &quot;/home/aperez/devel/WebKit/Tools/gtkdoc/gtkdoc.py&quot;, line 153, in generate
    self._run_gtkdoc_mkhtml()
  File &quot;/home/aperez/devel/WebKit/Tools/gtkdoc/gtkdoc.py&quot;, line 379, in _run_gtkdoc_mkhtml
    cwd=html_dest_dir)
  File &quot;/home/aperez/devel/WebKit/Tools/gtkdoc/gtkdoc.py&quot;, line 222, in _run_command
    &quot;\n  &quot;.join(stderr.splitlines())))
Exception: gtkdoc-mkhtml produced a non-zero return code 6
Command:
  gtkdoc-mkhtml webkit2gtk-4.0 /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/webkit2gtk-docs.sgml
Error output:
  /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3395: parser error : Opening and ending tag mismatch: video line 3394 and para
  playback support disabled.&lt;/para&gt;
                                   ^
  /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3398: parser error : Opening and ending tag mismatch: track line 3394 and refsect2
   role=&quot;since&quot;&gt;Since: &lt;link linkend=&quot;api-index-2.26&quot;&gt;2.26&lt;/link&gt;&lt;/para&gt;&lt;/refsect2
                                                                                 ^
  /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3703: parser error : Opening and ending tag mismatch: audio line 3394 and refsect1
  &lt;/refsect1&gt;
             ^
  /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3705: parser error : Opening and ending tag mismatch: para line 3393 and refentry
  &lt;/refentry&gt;
             ^
  /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3706: parser error : Premature end of data in tag refsect2 line 3390

  ^
  /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3706: parser error : Premature end of data in tag refsect1 line 3176

  ^
  /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml:3706: parser error : Premature end of data in tag refentry line 6

  ^
  /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/webkit2gtk-docs.sgml:19: element include: XInclude error : could not load /home/aperez/devel/WebKit/build-jsc/Documentation/webkit2gtk-4.0/xml/WebKitSettings.xml, and no fallback was found

samu: subcommand failed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1533937</commentid>
    <comment_count>1</comment_count>
      <attachid>369290</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2019-05-07 09:08:10 -0700</bug_when>
    <thetext>Created attachment 369290
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1533938</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-05-07 09:10:37 -0700</bug_when>
    <thetext>Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1533951</commentid>
    <comment_count>3</comment_count>
      <attachid>369290</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2019-05-07 09:24:41 -0700</bug_when>
    <thetext>Comment on attachment 369290
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369290&amp;action=review

Oops. My bad :/

&gt; Source/WebKit/ChangeLog:11
&gt; +        tag names in the documentation for the WebKitSettings:enabl-media property.

little typo in enabl-media ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1534027</commentid>
    <comment_count>4</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2019-05-07 12:14:52 -0700</bug_when>
    <thetext>(In reply to Philippe Normand from comment #3)
&gt; Comment on attachment 369290 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=369290&amp;action=review
&gt; 
&gt; Oops. My bad :/
&gt; 
&gt; &gt; Source/WebKit/ChangeLog:11
&gt; &gt; +        tag names in the documentation for the WebKitSettings:enabl-media property.
&gt; 
&gt; little typo in enabl-media ;)

Nice catch. I&apos;ll fix the typo and then land the updated patch.
Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1534029</commentid>
    <comment_count>5</comment_count>
      <attachid>369311</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2019-05-07 12:16:40 -0700</bug_when>
    <thetext>Created attachment 369311
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1534084</commentid>
    <comment_count>6</comment_count>
      <attachid>369311</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-07 13:29:23 -0700</bug_when>
    <thetext>Comment on attachment 369311
Patch for landing

Clearing flags on attachment: 369311

Committed r245027: &lt;https://trac.webkit.org/changeset/245027&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1534085</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-07 13:29:24 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1534088</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-05-07 13:33:30 -0700</bug_when>
    <thetext>&lt;rdar://problem/50553141&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>369290</attachid>
            <date>2019-05-07 09:08:10 -0700</date>
            <delta_ts>2019-05-07 12:16:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-197663-20190507190808.patch</filename>
            <type>text/plain</type>
            <size>1728</size>
            <attacher name="Adrian Perez">aperez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg4Y2U0NWVlMzAzZDhhOGUz
M2U5YjNkNDFhNjJhZDE3OTYxNjc3OGUuLjNmYTdmMmU3YWYxMDM0ZTBjZjk1NTYwZDRjODRmMTNm
OTQ5ODM1NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDUtMDcgIEFkcmlhbiBQ
ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVd
IENhbm5vdCBidWlsZCBkb2N1bWVudGF0aW9uIHdpdGggZ3RrLWRvYworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NjYzCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2Vi
S2l0U2V0dGluZ3MuY3BwOgorICAgICAgICAod2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQpOiBF
c2NhcGUgY29udGVudCB3aGljaCBnZXRzIHdyb25nbHkgaW50ZXJwcmV0ZWQgYXMKKyAgICAgICAg
U0dNTCB0YWdzIGJ5IGd0ay1kb2MgYXMgTWFya2Rvd24gcHJlZm9ybWF0dGVkIGNvbnRlbnQsIHdo
aWNoIGZpdHMgd2VsbCBmb3IgdGhlCisgICAgICAgIHRhZyBuYW1lcyBpbiB0aGUgZG9jdW1lbnRh
dGlvbiBmb3IgdGhlIFdlYktpdFNldHRpbmdzOmVuYWJsLW1lZGlhIHByb3BlcnR5LgorCiAyMDE5
LTA1LTA3ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAg
IFttYWNPU10gQXZvaWQgY3Jhc2hpbmcgdGhlIFVJIHByb2Nlc3Mgd2hlbiB3cml0aW5nIGVtcHR5
IGRhdGEgdG8gdGhlIHBhc3RlYm9hcmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz
L0FQSS9nbGliL1dlYktpdFNldHRpbmdzLmNwcAppbmRleCAwMjNiMTRjMzNmNGRiYzczZGZjMzQ0
OGMzZmU2ZjY2YmZjNGI2MzcyLi42NTdiMWZlYmY1ZDFlZTMyNjEyNjcwNGNjMjFkYTk1ZTY0Mzdm
OGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRT
ZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0
U2V0dGluZ3MuY3BwCkBAIC0xNTA1LDcgKzE1MDUsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfc2V0
dGluZ3NfY2xhc3NfaW5pdChXZWJLaXRTZXR0aW5nc0NsYXNzKiBrbGFzcykKICAgICAgKiBXZWJL
aXRTZXR0aW5nczplbmFibGUtbWVkaWE6CiAgICAgICoKICAgICAgKiBFbmFibGUgb3IgZGlzYWJs
ZSBzdXBwb3J0IGZvciBtZWRpYSBwbGF5YmFjayBvbiBwYWdlcy4gVGhpcyBzZXR0aW5nIGlzIGVu
YWJsZWQgYnkKLSAgICAgKiBkZWZhdWx0LiBEaXNhYmxpbmcgaXQgbWVhbnMgPGF1ZGlvPiwgPHRy
YWNrPiBhbmQgPHZpZGVvPiBlbGVtZW50cyB3aWxsIGhhdmUKKyAgICAgKiBkZWZhdWx0LiBEaXNh
YmxpbmcgaXQgbWVhbnMgYDxhdWRpbz5gLCBgPHRyYWNrPmAgYW5kIGA8dmlkZW8+YCBlbGVtZW50
cyB3aWxsIGhhdmUKICAgICAgKiBwbGF5YmFjayBzdXBwb3J0IGRpc2FibGVkLgogICAgICAqCiAg
ICAgICogU2luY2U6IDIuMjYK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>369311</attachid>
            <date>2019-05-07 12:16:40 -0700</date>
            <delta_ts>2019-05-07 13:29:23 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-197663-20190507221639.patch</filename>
            <type>text/plain</type>
            <size>1748</size>
            <attacher name="Adrian Perez">aperez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdjYjRhN2M2OTM1ZWNiYTgz
ZDNmNjk1ZTA1MmJlZjkxOTM1OGZlZGIuLjNiNTVlYTZmNjQ0Mjg2N2Y1MTBlNzFiNGUzMjliYWZl
ZjYwNTlhNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDUtMDcgIEFkcmlhbiBQ
ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVd
IENhbm5vdCBidWlsZCBkb2N1bWVudGF0aW9uIHdpdGggZ3RrLWRvYworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NjYzCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgUGhpbGlwcGUgTm9ybWFuZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9X
ZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh3ZWJraXRfc2V0dGluZ3NfY2xhc3NfaW5pdCk6
IEVzY2FwZSBjb250ZW50IHdoaWNoIGdldHMgd3JvbmdseSBpbnRlcnByZXRlZCBhcworICAgICAg
ICBTR01MIHRhZ3MgYnkgZ3RrLWRvYyBhcyBNYXJrZG93biBwcmVmb3JtYXR0ZWQgY29udGVudCwg
d2hpY2ggZml0cyB3ZWxsIGZvciB0aGUKKyAgICAgICAgdGFnIG5hbWVzIGluIHRoZSBkb2N1bWVu
dGF0aW9uIGZvciB0aGUgV2ViS2l0U2V0dGluZ3M6ZW5hYmxlLW1lZGlhIHByb3BlcnR5LgorCiAy
MDE5LTA1LTA3ICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAg
IENoYW5nZSBJc0lUUEZpcnN0UGFydHlXZWJzaXRlRGF0YVJlbW92YWxFbmFibGVkIGZyb20gREVG
QVVMVF9FWFBFUklNRU5UQUxfRkVBVFVSRVNfRU5BQkxFRCB0byB0cnVlLgpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwIGIvU291
cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IDAy
M2IxNGMzM2Y0ZGJjNzNkZmMzNDQ4YzNmZTZmNjZiZmM0YjYzNzIuLjY1N2IxZmViZjVkMWVlMzI2
MTI2NzA0Y2MyMWRhOTVlNjQzN2Y4YzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5ncy5jcHAKQEAgLTE1MDUsNyArMTUwNSw3IEBAIHN0
YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0KFdlYktpdFNldHRpbmdzQ2xhc3Mq
IGtsYXNzKQogICAgICAqIFdlYktpdFNldHRpbmdzOmVuYWJsZS1tZWRpYToKICAgICAgKgogICAg
ICAqIEVuYWJsZSBvciBkaXNhYmxlIHN1cHBvcnQgZm9yIG1lZGlhIHBsYXliYWNrIG9uIHBhZ2Vz
LiBUaGlzIHNldHRpbmcgaXMgZW5hYmxlZCBieQotICAgICAqIGRlZmF1bHQuIERpc2FibGluZyBp
dCBtZWFucyA8YXVkaW8+LCA8dHJhY2s+IGFuZCA8dmlkZW8+IGVsZW1lbnRzIHdpbGwgaGF2ZQor
ICAgICAqIGRlZmF1bHQuIERpc2FibGluZyBpdCBtZWFucyBgPGF1ZGlvPmAsIGA8dHJhY2s+YCBh
bmQgYDx2aWRlbz5gIGVsZW1lbnRzIHdpbGwgaGF2ZQogICAgICAqIHBsYXliYWNrIHN1cHBvcnQg
ZGlzYWJsZWQuCiAgICAgICoKICAgICAgKiBTaW5jZTogMi4yNgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>