197655 2019-05-07 03:59:57 -0700 REGRESSION(r244230): Web Automation: use null instead of empty string as success result of scripts when alert is open 2019-05-07 18:07:17 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196847 Gtk, InRadar, Regression P2 Normal --- 1 cgarcia webkit-unassigned bburg commit-queue hi webkit-bug-importer oldest_to_newest 1533877 0 cgarcia 2019-05-07 03:59:57 -0700 This regressed in r244230, the case of an alert open while running a script is now handled in WebKit side, but an empty string is returned as a result, which is not a valid JSON serialized string. That made all user prompts tests to fail. 1533878 1 369274 cgarcia 2019-05-07 04:08:57 -0700 Created attachment 369274 Patch 1534187 2 369274 hi 2019-05-07 17:39:08 -0700 Comment on attachment 369274 Patch rs=me 1534201 3 369274 commit-queue 2019-05-07 18:06:18 -0700 Comment on attachment 369274 Patch Clearing flags on attachment: 369274 Committed r245046: <https://trac.webkit.org/changeset/245046> 1534202 4 commit-queue 2019-05-07 18:06:19 -0700 All reviewed patches have been landed. Closing bug. 1534203 5 webkit-bug-importer 2019-05-07 18:07:17 -0700 <rdar://problem/50564291> 369274 2019-05-07 04:08:57 -0700 2019-05-07 18:06:18 -0700 Patch wd-script-alert.diff text/plain 1814 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNDUyNWYyNzU5MTIuLmYzMjlkMzJlZmFhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDE5LTA1LTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNDQyMzApOiBXZWIgQXV0b21hdGlvbjogdXNl IG51bGwgaW5zdGVhZCBvZiBlbXB0eSBzdHJpbmcgYXMgc3VjY2VzcyByZXN1bHQgb2Ygc2NyaXB0 cyB3aGVuIGFsZXJ0IGlzIG9wZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NzY1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcmVncmVzc2VkIGluIHIyNDQyMzAsIHRoZSBjYXNlIG9mIGFuIGFs ZXJ0IG9wZW4gd2hpbGUgcnVubmluZyBhIHNjcmlwdCBpcyBub3cgaGFuZGxlZCBpbiBXZWJLaXQg c2lkZSwgYnV0CisgICAgICAgIGFuIGVtcHR5IHN0cmluZyBpcyByZXR1cm5lZCBhcyBhIHJlc3Vs dCwgd2hpY2ggaXMgbm90IGEgdmFsaWQgSlNPTiBzZXJpYWxpemVkIHN0cmluZy4gVGhhdCBtYWRl IGFsbCB1c2VyIHByb21wdHMKKyAgICAgICAgdGVzdHMgdG8gZmFpbC4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViQXV0b21hdGlvblNlc3Npb246OndpbGxTaG93SmF2YVNjcmlwdERpYWxvZyk6IFVz ZSBudWxsIGFzIHNjcmlwdCByZXN1bHQgaW5zdGVhZCBvZiBhbiBlbXB0eSBzdHJpbmcuCisKIDIw MTktMDUtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIENyYXNoIGluIHdlYmtpdFdlYlZpZXdCYXNlU2V0RW5hYmxlQmFja0Zvcndh cmROYXZpZ2F0aW9uR2VzdHVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcAppbmRleCAwMThiZjkxYWNm Zi4uYzI1Yjk1MTc3MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dG9t YXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwCkBAIC02NTQsNyArNjU0LDcg QEAgdm9pZCBXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6d2lsbFNob3dKYXZhU2NyaXB0RGlhbG9nKFdl YlBhZ2VQcm94eSYgcGFnZSkKICAgICAgICAgaWYgKCFtX2V2YWx1YXRlSmF2YVNjcmlwdEZ1bmN0 aW9uQ2FsbGJhY2tzLmlzRW1wdHkoKSkgewogICAgICAgICAgICAgZm9yIChhdXRvIGtleSA6IGNv cHlUb1ZlY3RvcihtX2V2YWx1YXRlSmF2YVNjcmlwdEZ1bmN0aW9uQ2FsbGJhY2tzLmtleXMoKSkp IHsKICAgICAgICAgICAgICAgICBhdXRvIGNhbGxiYWNrID0gbV9ldmFsdWF0ZUphdmFTY3JpcHRG dW5jdGlvbkNhbGxiYWNrcy50YWtlKGtleSk7Ci0gICAgICAgICAgICAgICAgY2FsbGJhY2stPnNl bmRTdWNjZXNzKGVtcHR5U3RyaW5nKCkpOworICAgICAgICAgICAgICAgIGNhbGxiYWNrLT5zZW5k U3VjY2VzcygibnVsbCJfcyk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAo=