197649 2019-05-07 01:17:45 -0700 iOSMac Share Sheet shows up at the wrong place 2019-05-07 12:12:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1533823 0 thorton 2019-05-07 01:17:45 -0700 iOSMac Share Sheet shows up at the wrong place 1533824 1 369255 thorton 2019-05-07 01:17:58 -0700 Created attachment 369255 Patch 1533825 2 thorton 2019-05-07 01:18:00 -0700 <rdar://problem/50295563> 1533898 3 369255 megan_gardner 2019-05-07 06:57:45 -0700 Comment on attachment 369255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369255&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5838 > + } Is there no way to make a Rect from a Point? That seems like a thing we would want. I’m also assuming that it expands the rect to whatever size is best, and that giving it this start location is the best option. 1534005 4 369255 thorton 2019-05-07 11:51:56 -0700 Comment on attachment 369255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369255&action=review Actually <rdar://problem/49922942> > Source/WebKit/ChangeLog:5 > + <rdar://problem/50295563> This should be rdar://problem/49922942 1534009 5 369255 thorton 2019-05-07 11:53:04 -0700 Comment on attachment 369255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369255&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5838 >> + } > > Is there no way to make a Rect from a Point? That seems like a thing we would want. > I’m also assuming that it expands the rect to whatever size is best, and that giving it this start location is the best option. There are ways, but IMO they're uglier (maybe not anymore with {{{{{}}}}} magic) It's a rect to present *from*, so giving it one point just means that's where the popover arrow (or context menu) appears to originate from/point to. 1534017 6 thorton 2019-05-07 12:04:18 -0700 https://trac.webkit.org/changeset/245022/webkit 369255 2019-05-07 01:17:58 -0700 2019-05-07 12:02:21 -0700 Patch bug-197649-20190507011757.patch text/plain 3124 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0OTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM3ZmU3MGIzZmJlYjMxYzQz NWUxZGI1Mzk5OWRkZTU3M2RkZmRhYjguLjc0NDJkNGE1YTI1OWUzNWE2Njk1ZDA0MjJkNzVhM2Uy ZDg3MTQ4MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDUtMDcgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgaU9TTWFjIFNoYXJlIFNo ZWV0IHNob3dzIHVwIGF0IHRoZSB3cm9uZyBwbGFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NjQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81 MDI5NTU2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmg6CisgICAgICAgICog VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dL Q29udGVudFZpZXcgX3Nob3dTaGFyZVNoZWV0OmluUmVjdDpjb21wbGV0aW9uSGFuZGxlcjpdKToK KyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfaG92ZXJHZXN0dXJlUmVjb2duaXplckNoYW5nZWQ6 XSk6CisgICAgICAgIFBhc3MgdGhlIGxhc3QgbW91c2Utb3ZlciBsb2NhdGlvbiBhcyB0aGUgcHJl c2VudGF0aW9uIGxvY2F0aW9uIGZvciB0aGUgCisgICAgICAgIHNoYXJlIHNoZWV0LCBpZiB3ZSBk b24ndCBoYXZlIGEgcmVjdCB0byBwcmVzZW50IGZyb20uIENlbnRlcmluZyB0aGUgcG9wb3Zlcgor ICAgICAgICBsaWtlIHdlIGRvIG9uIGlQYWQgZG9lc24ndCB3b3JrIHNvIHdlbGwgKGF0IGFsbCkg d2l0aCBhIG1hY09TIGNvbnRleHQgbWVudS4KKwogMjAxOS0wNS0wNiAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2UgU1BJIHRvIHJlcXVl c3QgbW9kZXJuIGNvbXBhdGliaWxpdHkgbW9kZSBidXQgZGVmZXIgdG8gc2l0ZS1zcGVjaWZpYyBx dWlya3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24uaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24uaAppbmRleCAwNWEwNWIwZTY4Y2ZhMDUwYmM1NTAzZmNiMGEzYzBiMWRl Zjc2YjMxLi43OTllMmQ3MjI2ZmIwMTBkNzg5MjBhNDkwZDEzNzJkOTYzMjUyOTM3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5oCkBAIC0yMzAsNiArMjMwLDcgQEAgc3RydWN0IFdLQXV0b0NvcnJlY3Rpb25EYXRhIHsK ICNpZiBQTEFURk9STShJT1NNQUMpCiAgICAgUmV0YWluUHRyPFVJSG92ZXJHZXN0dXJlUmVjb2du aXplcj4gX2hvdmVyR2VzdHVyZVJlY29nbml6ZXI7CiAgICAgUmV0YWluUHRyPF9VSUxvb2t1cEdl c3R1cmVSZWNvZ25pemVyPiBfbG9va3VwR2VzdHVyZVJlY29nbml6ZXI7CisgICAgQ0dQb2ludCBf bGFzdEhvdmVyTG9jYXRpb247CiAjZW5kaWYKIAogICAgIFJldGFpblB0cjxVSVdLVGV4dEludGVy YWN0aW9uQXNzaXN0YW50PiBfdGV4dFNlbGVjdGlvbkFzc2lzdGFudDsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmlu ZGV4IDEyZThmM2RhMDExM2YyODhlN2RmNGU3NzgzNmRkMTFjMGRiYTkyNzguLmU2MmY3Mzc0ZjI3 ZTIxZmNlMGQwMmY2YWU3NGVhYzNiMTVhNTI1ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNTgzMCw2 ICs1ODMwLDEzIEBAIC0gKHZvaWQpX3Nob3dTaGFyZVNoZWV0Oihjb25zdCBXZWJDb3JlOjpTaGFy ZURhdGFXaXRoUGFyc2VkVVJMJilkYXRhIGluUmVjdDooV1RGCiAgICAgCiAgICAgX3NoYXJlU2hl ZXQgPSBhZG9wdE5TKFtbV0tTaGFyZVNoZWV0IGFsbG9jXSBpbml0V2l0aFZpZXc6X3dlYlZpZXdd KTsKICAgICBbX3NoYXJlU2hlZXQgc2V0RGVsZWdhdGU6c2VsZl07CisKKyNpZiBQTEFURk9STShJ T1NNQUMpCisgICAgaWYgKCFyZWN0KSB7CisgICAgICAgIGF1dG8gaG92ZXJMb2NhdGlvbkluV2Vi VmlldyA9IFtzZWxmIGNvbnZlcnRQb2ludDpfbGFzdEhvdmVyTG9jYXRpb24gdG9WaWV3Ol93ZWJW aWV3XTsKKyAgICAgICAgcmVjdCA9IFdlYkNvcmU6OkZsb2F0UmVjdChob3ZlckxvY2F0aW9uSW5X ZWJWaWV3LngsIGhvdmVyTG9jYXRpb25JbldlYlZpZXcueSwgMSwgMSk7CisgICAgfQorI2VuZGlm CiAgICAgCiAgICAgW19zaGFyZVNoZWV0IHByZXNlbnRXaXRoUGFyYW1ldGVyczpkYXRhIGluUmVj dDpyZWN0IGNvbXBsZXRpb25IYW5kbGVyOldURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXTsKICNl bmRpZgpAQCAtNzA0MSw2ICs3MDQ4LDcgQEAgLSAodm9pZClfaG92ZXJHZXN0dXJlUmVjb2duaXpl ckNoYW5nZWQ6KFVJR2VzdHVyZVJlY29nbml6ZXIgKilnZXN0dXJlUmVjb2duaXplcgogICAgIGNh c2UgVUlHZXN0dXJlUmVjb2duaXplclN0YXRlQmVnYW46CiAgICAgY2FzZSBVSUdlc3R1cmVSZWNv Z25pemVyU3RhdGVDaGFuZ2VkOgogICAgICAgICBwb2ludCA9IFtnZXN0dXJlUmVjb2duaXplciBs b2NhdGlvbkluVmlldzpzZWxmXTsKKyAgICAgICAgX2xhc3RIb3ZlckxvY2F0aW9uID0gcG9pbnQ7 CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgVUlHZXN0dXJlUmVjb2duaXplclN0YXRlRW5kZWQ6 CiAgICAgY2FzZSBVSUdlc3R1cmVSZWNvZ25pemVyU3RhdGVDYW5jZWxsZWQ6Cg==