197618 2019-05-06 11:41:22 -0700 Null check m_mainFrame in WebPageProxy.cpp 2019-05-06 13:24:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen commit-queue ggaren webkit-bug-importer oldest_to_newest 1533457 0 achristensen 2019-05-06 11:41:22 -0700 Null check m_mainFrame in WebPageProxy.cpp 1533459 1 369151 achristensen 2019-05-06 11:43:01 -0700 Created attachment 369151 Patch 1533460 2 achristensen 2019-05-06 11:43:04 -0700 <rdar://problem/47463054> 1533493 3 369151 ggaren 2019-05-06 12:56:39 -0700 Comment on attachment 369151 Patch r=me 1533521 4 369151 commit-queue 2019-05-06 13:24:35 -0700 Comment on attachment 369151 Patch Clearing flags on attachment: 369151 Committed r244970: <https://trac.webkit.org/changeset/244970> 1533522 5 commit-queue 2019-05-06 13:24:36 -0700 All reviewed patches have been landed. Closing bug. 369151 2019-05-06 11:43:01 -0700 2019-05-06 13:24:35 -0700 Patch bug-197618-20190506114301.patch text/plain 3891 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQ5NjgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA1LTA2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBjaGVjayBt X21haW5GcmFtZSBpbiBXZWJQYWdlUHJveHkuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc2MTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3 NDYzMDU0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEl0J3MgYWxyZWFkeSBudWxsIGNoZWNrZWQgaW4gc29tZSBwbGFjZXMsIGFuZCB0aGUgcGxhY2Vz IHdoZXJlIGl0IGlzbid0IGFyZSBjYXVzaW5nIGNyYXNoZXMuCisgICAgICAgIExldCdzIGZpeCBh bGwgb2YgdGhlbS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rp b24pOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmRlY2lkZVBvbGljeUZvck5ld1dp bmRvd0FjdGlvbik6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y3JlYXRlTmV3UGFn ZSk6CisKIDIwMTktMDUtMDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CiAKICAgICAgICAgSW50cm9kdWNlIFNQSSB0byByZXF1ZXN0IG1vZGVybiBjb21wYXRpYmlsaXR5 IG1vZGUgYnV0IGRlZmVyIHRvIHNpdGUtc3BlY2lmaWMgcXVpcmtzCkluZGV4OiBTb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9uIDI0NDk1NCkKKysrIFNvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2 NzcsNyArNDY3NywxMCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5Rm9yTmF2aWdh CiAgICAgICAgICAgICBzb3VyY2VGcmFtZUluZm8gPSBBUEk6OkZyYW1lSW5mbzo6Y3JlYXRlKG9y aWdpbmF0aW5nRnJhbWVJbmZvRGF0YSwgb3JpZ2luYXRpbmdQYWdlSUQgPyBwcm9jZXNzLT53ZWJQ YWdlKG9yaWdpbmF0aW5nUGFnZUlEKSA6IG51bGxwdHIpOwogCiAgICAgICAgIGF1dG8gdXNlcklu aXRpYXRlZEFjdGl2aXR5ID0gcHJvY2Vzcy0+dXNlckluaXRpYXRlZEFjdGl2aXR5KG5hdmlnYXRp b25BY3Rpb25EYXRhLnVzZXJHZXN0dXJlVG9rZW5JZGVudGlmaWVyKTsKLSAgICAgICAgYm9vbCBz aG91bGRPcGVuQXBwTGlua3MgPSAhbV9zaG91bGRTdXBwcmVzc0FwcExpbmtzSW5OZXh0TmF2aWdh dGlvblBvbGljeURlY2lzaW9uICYmIGRlc3RpbmF0aW9uRnJhbWVJbmZvLT5pc01haW5GcmFtZSgp ICYmICFob3N0c0FyZUVxdWFsKFVSTCh7IH0sIG1fbWFpbkZyYW1lLT51cmwoKSksIHJlcXVlc3Qu dXJsKCkpICYmIG5hdmlnYXRpb25BY3Rpb25EYXRhLm5hdmlnYXRpb25UeXBlICE9IFdlYkNvcmU6 Ok5hdmlnYXRpb25UeXBlOjpCYWNrRm9yd2FyZDsKKyAgICAgICAgYm9vbCBzaG91bGRPcGVuQXBw TGlua3MgPSAhbV9zaG91bGRTdXBwcmVzc0FwcExpbmtzSW5OZXh0TmF2aWdhdGlvblBvbGljeURl Y2lzaW9uCisgICAgICAgICAgICAmJiBkZXN0aW5hdGlvbkZyYW1lSW5mby0+aXNNYWluRnJhbWUo KQorICAgICAgICAgICAgJiYgKG1fbWFpbkZyYW1lID8gIWhvc3RzQXJlRXF1YWwobV9tYWluRnJh bWUtPnVybCgpLCByZXF1ZXN0LnVybCgpKSA6IGZhbHNlKQorICAgICAgICAgICAgJiYgbmF2aWdh dGlvbkFjdGlvbkRhdGEubmF2aWdhdGlvblR5cGUgIT0gV2ViQ29yZTo6TmF2aWdhdGlvblR5cGU6 OkJhY2tGb3J3YXJkOwogCiAgICAgICAgIGF1dG8gbmF2aWdhdGlvbkFjdGlvbiA9IEFQSTo6TmF2 aWdhdGlvbkFjdGlvbjo6Y3JlYXRlKFdURk1vdmUobmF2aWdhdGlvbkFjdGlvbkRhdGEpLCBzb3Vy Y2VGcmFtZUluZm8uZ2V0KCksIGRlc3RpbmF0aW9uRnJhbWVJbmZvLnB0cigpLCBXVEY6Om51bGxv cHQsIFdURk1vdmUocmVxdWVzdCksIG9yaWdpbmFsUmVxdWVzdC51cmwoKSwgc2hvdWxkT3BlbkFw cExpbmtzLCBXVEZNb3ZlKHVzZXJJbml0aWF0ZWRBY3Rpdml0eSksIG1haW5GcmFtZU5hdmlnYXRp b24pOwogCkBAIC00ODA3LDcgKzQ4MTAsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGVjaWRlUG9s aWN5Rm9yTmV3V2luCiAgICAgICAgICAgICBzb3VyY2VGcmFtZUluZm8gPSBBUEk6OkZyYW1lSW5m bzo6Y3JlYXRlKCpmcmFtZSwgZnJhbWVTZWN1cml0eU9yaWdpbi5zZWN1cml0eU9yaWdpbigpKTsK IAogICAgICAgICBhdXRvIHVzZXJJbml0aWF0ZWRBY3Rpdml0eSA9IG1fcHJvY2Vzcy0+dXNlcklu aXRpYXRlZEFjdGl2aXR5KG5hdmlnYXRpb25BY3Rpb25EYXRhLnVzZXJHZXN0dXJlVG9rZW5JZGVu dGlmaWVyKTsKLSAgICAgICAgYm9vbCBzaG91bGRPcGVuQXBwTGlua3MgPSAhaG9zdHNBcmVFcXVh bChVUkwoeyB9LCBtX21haW5GcmFtZS0+dXJsKCkpLCByZXF1ZXN0LnVybCgpKTsKKyAgICAgICAg Ym9vbCBzaG91bGRPcGVuQXBwTGlua3MgPSBtX21haW5GcmFtZSA/ICFob3N0c0FyZUVxdWFsKG1f bWFpbkZyYW1lLT51cmwoKSwgcmVxdWVzdC51cmwoKSkgOiBmYWxzZTsKICAgICAgICAgYXV0byBu YXZpZ2F0aW9uQWN0aW9uID0gQVBJOjpOYXZpZ2F0aW9uQWN0aW9uOjpjcmVhdGUoV1RGTW92ZShu YXZpZ2F0aW9uQWN0aW9uRGF0YSksIHNvdXJjZUZyYW1lSW5mby5nZXQoKSwgbnVsbHB0ciwgZnJh bWVOYW1lLCBXVEZNb3ZlKHJlcXVlc3QpLCBVUkwgeyB9LCBzaG91bGRPcGVuQXBwTGlua3MsIFdU Rk1vdmUodXNlckluaXRpYXRlZEFjdGl2aXR5KSk7CiAKICAgICAgICAgbV9uYXZpZ2F0aW9uQ2xp ZW50LT5kZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKCp0aGlzLCBuYXZpZ2F0aW9uQWN0 aW9uLmdldCgpLCBXVEZNb3ZlKGxpc3RlbmVyKSwgbV9wcm9jZXNzLT50cmFuc2Zvcm1IYW5kbGVz VG9PYmplY3RzKHVzZXJEYXRhLm9iamVjdCgpKS5nZXQoKSk7CkBAIC00OTk0LDcgKzQ5OTcsNyBA QCB2b2lkIFdlYlBhZ2VQcm94eTo6Y3JlYXRlTmV3UGFnZShjb25zdCBGCiB7CiAgICAgTUVTU0FH RV9DSEVDSyhtX3Byb2Nlc3MsIG1fcHJvY2Vzcy0+d2ViRnJhbWUob3JpZ2luYXRpbmdGcmFtZUlu Zm9EYXRhLmZyYW1lSUQpKTsKICAgICBhdXRvIG9yaWdpbmF0aW5nRnJhbWVJbmZvID0gQVBJOjpG cmFtZUluZm86OmNyZWF0ZShvcmlnaW5hdGluZ0ZyYW1lSW5mb0RhdGEsIG1fcHJvY2Vzcy0+d2Vi UGFnZShvcmlnaW5hdGluZ1BhZ2VJRCkpOwotICAgIGF1dG8gbWFpbkZyYW1lVVJMID0gbV9tYWlu RnJhbWUtPnVybCgpOworICAgIGF1dG8gbWFpbkZyYW1lVVJMID0gbV9tYWluRnJhbWUgPyBtX21h aW5GcmFtZS0+dXJsKCkgOiBVUkwoKTsKICAgICBhdXRvIGNvbXBsZXRpb25IYW5kbGVyID0gW3Ro aXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgbWFpbkZyYW1lVVJMLCByZXF1ZXN0 LCByZXBseSA9IFdURk1vdmUocmVwbHkpXSAoUmVmUHRyPFdlYlBhZ2VQcm94eT4gbmV3UGFnZSkg bXV0YWJsZSB7CiAgICAgICAgIGlmICghbmV3UGFnZSkgewogICAgICAgICAgICAgcmVwbHkoMCwg V1RGOjpudWxsb3B0KTsK