197605 2019-05-05 23:37:28 -0700 JS2 should print scores for different categories 2019-05-06 13:37:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin cdumez commit-queue ews-watchlist fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset rniwa ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1533317 0 saam 2019-05-05 23:37:28 -0700 ... 1533318 1 369101 saam 2019-05-05 23:42:01 -0700 Created attachment 369101 patch 1533319 2 tzagallo 2019-05-05 23:48:08 -0700 Why is this only for the CLI? Also, the ChangeLog entry is missing. 1533322 3 369101 ysuzuki 2019-05-05 23:59:17 -0700 Comment on attachment 369101 patch r=me. As Tadeu said, adding this feature to non-cli version would be also useful too (yeah, it would involve some UI changes... And please add ChangeLog for this. 1533454 4 saam 2019-05-06 11:34:58 -0700 (In reply to Tadeu Zagallo from comment #2) > Why is this only for the CLI? Also, the ChangeLog entry is missing. If we add it to the website, we should do it behind some kind of key click when we're done running. Let me look into it. 1533470 5 369153 saam 2019-05-06 12:03:57 -0700 Created attachment 369153 patch 1533475 6 369153 ysuzuki 2019-05-06 12:17:31 -0700 Comment on attachment 369153 patch View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review r=me > PerformanceTests/JetStream2/JetStreamDriver.js:53 > + for (let [category, scores] of categoryScores) > + summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>` I think sorting the categories is better. > PerformanceTests/JetStream2/JetStreamDriver.js:247 > + for (let [category, scores] of categoryScores) > + console.log(`${category}: ${uiFriendlyNumber(geomean(scores))}`); Ditto. 1533480 7 369153 saam 2019-05-06 12:27:35 -0700 Comment on attachment 369153 patch View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review >> PerformanceTests/JetStream2/JetStreamDriver.js:53 >> + summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>` > > I think sorting the categories is better. How would you sort it? It's nice now that benchmarks that share sub categories end up printing next to each other. 1533519 8 369153 ysuzuki 2019-05-06 13:17:54 -0700 Comment on attachment 369153 patch View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review >>> PerformanceTests/JetStream2/JetStreamDriver.js:53 >>> + summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>` >> >> I think sorting the categories is better. > > How would you sort it? It's nice now that benchmarks that share sub categories end up printing next to each other. OK, talked with Saam. The order is kept by ES6 Map. 1533532 9 369153 commit-queue 2019-05-06 13:36:46 -0700 Comment on attachment 369153 patch Clearing flags on attachment: 369153 Committed r244973: <https://trac.webkit.org/changeset/244973> 1533533 10 commit-queue 2019-05-06 13:36:47 -0700 All reviewed patches have been landed. Closing bug. 1533534 11 webkit-bug-importer 2019-05-06 13:37:21 -0700 <rdar://problem/50511028> 369101 2019-05-05 23:42:01 -0700 2019-05-06 12:03:57 -0700 patch a-backup.diff text/plain 1879 saam SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvSmV0U3RyZWFtMi9KZXRTdHJlYW1Ecml2ZXIuanMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9KZXRTdHJlYW0yL0pldFN0cmVhbURyaXZlci5q cwkocmV2aXNpb24gMjQ0ODEzKQorKysgUGVyZm9ybWFuY2VUZXN0cy9KZXRTdHJlYW0yL0pldFN0 cmVhbURyaXZlci5qcwkod29ya2luZyBjb3B5KQpAQCAtMTc0LDcgKzE3NCw2IEBAIGNsYXNzIERy aXZlciB7CiAgICAgICAgICAgICBhd2FpdCB1cGRhdGVVSSgpOwogCiAgICAgICAgICAgICB0cnkg ewotCiAgICAgICAgICAgICAgICAgYXdhaXQgYmVuY2htYXJrLnJ1bigpOwogICAgICAgICAgICAg fSBjYXRjaChlKSB7CiAgICAgICAgICAgICAgICAgSmV0U3RyZWFtLnJlcG9ydEVycm9yKGJlbmNo bWFyayk7CkBAIC0yMDEsOCArMjAwLDI2IEBAIGNsYXNzIERyaXZlciB7CiAgICAgICAgICAgICBz dW1tYXJ5RWxlbWVudC5jbGFzc0xpc3QuYWRkKCdkb25lJyk7CiAgICAgICAgICAgICBzdW1tYXJ5 RWxlbWVudC5pbm5lckhUTUwgPSAiPGRpdiBjbGFzcz1cInNjb3JlXCI+IiArIHVpRnJpZW5kbHlO dW1iZXIoZ2VvbWVhbihhbGxTY29yZXMpKSArICI8L2Rpdj48bGFiZWw+U2NvcmU8L2xhYmVsPiI7 CiAgICAgICAgICAgICBzdGF0dXNFbGVtZW50LmlubmVySFRNTCA9ICcnOwotICAgICAgICB9IGVs c2UKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGxldCBjYXRlZ29yaWVzID0gbmV3IE1h cDsKKyAgICAgICAgICAgIGZvciAobGV0IGJlbmNobWFyayBvZiB0aGlzLmJlbmNobWFya3MpIHsK KyAgICAgICAgICAgICAgICBmb3IgKGxldCBjYXRlZ29yeSBvZiBPYmplY3Qua2V5cyhiZW5jaG1h cmsuc3ViVGltZXMoKSkpCisgICAgICAgICAgICAgICAgICAgIGNhdGVnb3JpZXMuc2V0KGNhdGVn b3J5LCBbXSk7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZvciAobGV0IGJlbmNobWFy ayBvZiB0aGlzLmJlbmNobWFya3MpIHsKKyAgICAgICAgICAgICAgICBmb3IgKGxldCBbY2F0ZWdv cnksIHZhbHVlXSBvZiBPYmplY3QuZW50cmllcyhiZW5jaG1hcmsuc3ViVGltZXMoKSkpIHsKKyAg ICAgICAgICAgICAgICAgICAgbGV0IGFyciA9IGNhdGVnb3JpZXMuZ2V0KGNhdGVnb3J5KTsKKyAg ICAgICAgICAgICAgICAgICAgYXJyLnB1c2godmFsdWUpOworICAgICAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIH0KKworICAgICAgICAgICAgY29uc29sZS5sb2coIlxuIik7CisgICAgICAgICAg ICBmb3IgKGxldCBbY2F0ZWdvcnksIHNjb3Jlc10gb2YgY2F0ZWdvcmllcykKKyAgICAgICAgICAg ICAgICBjb25zb2xlLmxvZyhgJHtjYXRlZ29yeX06ICR7dWlGcmllbmRseU51bWJlcihnZW9tZWFu KHNjb3JlcykpfWApOworCiAgICAgICAgICAgICBjb25zb2xlLmxvZygiXG5Ub3RhbCBTY29yZTog IiwgdWlGcmllbmRseU51bWJlcihnZW9tZWFuKGFsbFNjb3JlcykpLCAiXG4iKTsKKyAgICAgICAg fQogCiAgICAgICAgIHRoaXMucmVwb3J0U2NvcmVUb1J1bkJlbmNobWFya1J1bm5lcigpOwogICAg IH0KQEAgLTMzMSw3ICszNDgsNyBAQCBjbGFzcyBEcml2ZXIgewogICAgICAgICAgICAgICAgICAg ICAiVGltZSI6IFsiR2VvbWV0cmljIl0sCiAgICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAg ICAgICAidGVzdHMiOiBzdWJSZXN1bHRzLAotICAgICAgICAgICAgfTs7CisgICAgICAgICAgICB9 OwogICAgICAgICB9CiAKICAgICAgICAgcmVzdWx0cyA9IHsiSmV0U3RyZWFtMi4wIjogeyJtZXRy aWNzIiA6IHsiU2NvcmUiIDogWyJHZW9tZXRyaWMiXX0sICJ0ZXN0cyIgOiByZXN1bHRzfX07Cg== 369153 2019-05-06 12:03:57 -0700 2019-05-06 13:36:46 -0700 patch a-backup.diff text/plain 3770 saam SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQ5NjgpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA1LTA2ICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIEpTMiBzaG91bGQgcHJp bnQgc2NvcmVzIGZvciBkaWZmZXJlbnQgY2F0ZWdvcmllcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NjA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBKZXRTdHJlYW0yL0pldFN0cmVhbURyaXZlci5q czoKKyAgICAgICAgKGRpc3BsYXlDYXRlZ29yeVNjb3Jlcyk6CisgICAgICAgIChpc0luQnJvd3Nl ci5kb2N1bWVudC5vbmtleWRvd24pOgorICAgICAgICAoRHJpdmVyLnByb3RvdHlwZS5hc3luYy5z dGFydCk6CisgICAgICAgIChEcml2ZXIucHJvdG90eXBlLmFzeW5jLnJlcG9ydFNjb3JlVG9SdW5C ZW5jaG1hcmtSdW5uZXIpOgorCiAyMDE5LTA0LTE2ICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNv bT4KIAogICAgICAgICBbTW90aW9uTWFya10gVGhlIHRleHQgImtra2oiIGlzIGNhdXNpbmcgRmly ZWZveCBjb25zb2xlIHdhcm5pbmc6IGB1bnJlYWNoYWJsZSBjb2RlIGFmdGVyIHJldHVybiBzdGF0 ZW1lbnRgCkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL0pldFN0cmVhbTIvSmV0U3RyZWFtRHJpdmVy LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvSmV0U3RyZWFtMi9KZXRTdHJlYW1E cml2ZXIuanMJKHJldmlzaW9uIDI0NDk2OCkKKysrIFBlcmZvcm1hbmNlVGVzdHMvSmV0U3RyZWFt Mi9KZXRTdHJlYW1Ecml2ZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTQxLDYgKzQxLDMxIEBAIHRo aXMuY3VycmVudFJlamVjdCA9IG51bGw7CiBjb25zdCBkZWZhdWx0SXRlcmF0aW9uQ291bnQgPSAx MjA7CiBjb25zdCBkZWZhdWx0V29yc3RDYXNlQ291bnQgPSA0OwogCitsZXQgc2hvd1Njb3JlRGV0 YWlscyA9IGZhbHNlOworbGV0IGNhdGVnb3J5U2NvcmVzID0gbnVsbDsKKworZnVuY3Rpb24gZGlz cGxheUNhdGVnb3J5U2NvcmVzKCkgeworICAgIGlmICghY2F0ZWdvcnlTY29yZXMpCisgICAgICAg IHJldHVybjsKKworICAgIGxldCBzdW1tYXJ5RWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJyZXN1bHQtc3VtbWFyeSIpOworICAgIGZvciAobGV0IFtjYXRlZ29yeSwgc2NvcmVzXSBv ZiBjYXRlZ29yeVNjb3JlcykKKyAgICAgICAgc3VtbWFyeUVsZW1lbnQuaW5uZXJIVE1MICs9IGA8 cD4gJHtjYXRlZ29yeX06ICR7dWlGcmllbmRseU51bWJlcihnZW9tZWFuKHNjb3JlcykpfTwvcD5g CisKKyAgICBjYXRlZ29yeVNjb3JlcyA9IG51bGw7Cit9CisKK2lmIChpc0luQnJvd3Nlcikgewor ICAgIGRvY3VtZW50Lm9ua2V5ZG93biA9IChrZXlib2FyZEV2ZW50KSA9PiB7CisgICAgICAgIGxl dCBrZXkgPSBrZXlib2FyZEV2ZW50LmtleTsKKyAgICAgICAgaWYgKGtleSA9PT0gImQiIHx8IGtl eSA9PT0gIkQiKSB7CisgICAgICAgICAgICBzaG93U2NvcmVEZXRhaWxzID0gdHJ1ZTsKKworICAg ICAgICAgICAgZGlzcGxheUNhdGVnb3J5U2NvcmVzKCk7CisgICAgICAgIH0KKyAgICB9OworfQor CiBmdW5jdGlvbiBhc3NlcnQoYiwgbSA9ICIiKSB7CiAgICAgaWYgKCFiKQogICAgICAgICB0aHJv dyBuZXcgRXJyb3IoIkJhZCBhc3NlcnRpb246ICIgKyBtKTsKQEAgLTE3NCw3ICsxOTksNiBAQCBj bGFzcyBEcml2ZXIgewogICAgICAgICAgICAgYXdhaXQgdXBkYXRlVUkoKTsKIAogICAgICAgICAg ICAgdHJ5IHsKLQogICAgICAgICAgICAgICAgIGF3YWl0IGJlbmNobWFyay5ydW4oKTsKICAgICAg ICAgICAgIH0gY2F0Y2goZSkgewogICAgICAgICAgICAgICAgIEpldFN0cmVhbS5yZXBvcnRFcnJv cihiZW5jaG1hcmspOwpAQCAtMTk3LDEyICsyMjEsMzMgQEAgY2xhc3MgRHJpdmVyIHsKICAgICAg ICAgZm9yIChsZXQgYmVuY2htYXJrIG9mIHRoaXMuYmVuY2htYXJrcykKICAgICAgICAgICAgIGFs bFNjb3Jlcy5wdXNoKGJlbmNobWFyay5zY29yZSk7CiAKKyAgICAgICAgY2F0ZWdvcnlTY29yZXMg PSBuZXcgTWFwOworICAgICAgICBmb3IgKGxldCBiZW5jaG1hcmsgb2YgdGhpcy5iZW5jaG1hcmtz KSB7CisgICAgICAgICAgICBmb3IgKGxldCBjYXRlZ29yeSBvZiBPYmplY3Qua2V5cyhiZW5jaG1h cmsuc3ViVGltZXMoKSkpCisgICAgICAgICAgICAgICAgY2F0ZWdvcnlTY29yZXMuc2V0KGNhdGVn b3J5LCBbXSk7CisgICAgICAgIH0KKworICAgICAgICBmb3IgKGxldCBiZW5jaG1hcmsgb2YgdGhp cy5iZW5jaG1hcmtzKSB7CisgICAgICAgICAgICBmb3IgKGxldCBbY2F0ZWdvcnksIHZhbHVlXSBv ZiBPYmplY3QuZW50cmllcyhiZW5jaG1hcmsuc3ViVGltZXMoKSkpIHsKKyAgICAgICAgICAgICAg ICBsZXQgYXJyID0gY2F0ZWdvcnlTY29yZXMuZ2V0KGNhdGVnb3J5KTsKKyAgICAgICAgICAgICAg ICBhcnIucHVzaCh2YWx1ZSk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKwogICAgICAgICBp ZiAoaXNJbkJyb3dzZXIpIHsKICAgICAgICAgICAgIHN1bW1hcnlFbGVtZW50LmNsYXNzTGlzdC5h ZGQoJ2RvbmUnKTsKICAgICAgICAgICAgIHN1bW1hcnlFbGVtZW50LmlubmVySFRNTCA9ICI8ZGl2 IGNsYXNzPVwic2NvcmVcIj4iICsgdWlGcmllbmRseU51bWJlcihnZW9tZWFuKGFsbFNjb3Jlcykp ICsgIjwvZGl2PjxsYWJlbD5TY29yZTwvbGFiZWw+IjsKKyAgICAgICAgICAgIHN1bW1hcnlFbGVt ZW50Lm9uY2xpY2sgPSBkaXNwbGF5Q2F0ZWdvcnlTY29yZXM7CisgICAgICAgICAgICBpZiAoc2hv d1Njb3JlRGV0YWlscykKKyAgICAgICAgICAgICAgICBkaXNwbGF5Q2F0ZWdvcnlTY29yZXMoKTsK ICAgICAgICAgICAgIHN0YXR1c0VsZW1lbnQuaW5uZXJIVE1MID0gJyc7Ci0gICAgICAgIH0gZWxz ZQorICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgY29uc29sZS5sb2coIlxuIik7CisgICAg ICAgICAgICBmb3IgKGxldCBbY2F0ZWdvcnksIHNjb3Jlc10gb2YgY2F0ZWdvcnlTY29yZXMpCisg ICAgICAgICAgICAgICAgY29uc29sZS5sb2coYCR7Y2F0ZWdvcnl9OiAke3VpRnJpZW5kbHlOdW1i ZXIoZ2VvbWVhbihzY29yZXMpKX1gKTsKKwogICAgICAgICAgICAgY29uc29sZS5sb2coIlxuVG90 YWwgU2NvcmU6ICIsIHVpRnJpZW5kbHlOdW1iZXIoZ2VvbWVhbihhbGxTY29yZXMpKSwgIlxuIik7 CisgICAgICAgIH0KIAogICAgICAgICB0aGlzLnJlcG9ydFNjb3JlVG9SdW5CZW5jaG1hcmtSdW5u ZXIoKTsKICAgICB9CkBAIC0zMzEsNyArMzc2LDcgQEAgY2xhc3MgRHJpdmVyIHsKICAgICAgICAg ICAgICAgICAgICAgIlRpbWUiOiBbIkdlb21ldHJpYyJdLAogICAgICAgICAgICAgICAgIH0sCiAg ICAgICAgICAgICAgICAgInRlc3RzIjogc3ViUmVzdWx0cywKLSAgICAgICAgICAgIH07OworICAg ICAgICAgICAgfTsKICAgICAgICAgfQogCiAgICAgICAgIHJlc3VsdHMgPSB7IkpldFN0cmVhbTIu MCI6IHsibWV0cmljcyIgOiB7IlNjb3JlIiA6IFsiR2VvbWV0cmljIl19LCAidGVzdHMiIDogcmVz dWx0c319Owo=