197586 2019-05-03 16:18:55 -0700 iOS JSC tests frequently exiting with exception after stress/json-stringify-string-builder-overflow.js.no-cjit-validate-phases 2019-05-03 19:26:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff darin keith_miller webkit-bug-importer oldest_to_newest 1533061 0 msaboff 2019-05-03 16:18:55 -0700 This test uses lots of memory. We should restrict where we run it and if we do run it, e don't need to run all configurations. 1533062 1 msaboff 2019-05-03 16:19:09 -0700 <rdar://problem/50458665> 1533065 2 369015 msaboff 2019-05-03 16:22:34 -0700 Created attachment 369015 Patch 1533069 3 369015 keith_miller 2019-05-03 16:27:14 -0700 Comment on attachment 369015 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369015&action=review r=me with change. > JSTests/stress/json-stringify-string-builder-overflow.js:4 > //@ skip if $architecture != "arm64" and $architecture != "x86-64" Can we remove this line since it doesn't do anything. 1533072 4 msaboff 2019-05-03 16:31:47 -0700 (In reply to Keith Miller from comment #3) > Comment on attachment 369015 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369015&action=review > > r=me with change. > > > JSTests/stress/json-stringify-string-builder-overflow.js:4 > > //@ skip if $architecture != "arm64" and $architecture != "x86-64" > > Can we remove this line since it doesn't do anything. I'll move this above the //@ lines I added. 1533075 5 msaboff 2019-05-03 16:34:54 -0700 Committed r244937: <https://trac.webkit.org/changeset/244937> 369015 2019-05-03 16:22:34 -0700 2019-05-03 16:27:14 -0700 Patch 197586.patch text/plain 1214 msaboff SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDQ5MzUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE5LTA1LTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgorCisgICAgICAgIGlPUyBKU0MgdGVzdHMgZnJlcXVlbnRseSBleGl0aW5nIHdpdGgg ZXhlY3B0aW9uIGFmdGVyIHN0cmVzcy9qc29uLXN0cmluZ2lmeS1zdHJpbmctYnVpbGRlci1vdmVy Zmxvdy5qcy5uby1jaml0LXZhbGlkYXRlLXBoYXNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIG9ubHkgcnVuIG9uZSBjb25maWcgb2Yg dGhpcyB0ZXN0IGFuZCBvbmx5IHdoZW4gd2UgdGhpbmsgd2UnbGwgaGF2ZSB0aGUgbWVtb3J5Lgor CisgICAgICAgICogc3RyZXNzL2pzb24tc3RyaW5naWZ5LXN0cmluZy1idWlsZGVyLW92ZXJmbG93 LmpzOgorCiAyMDE5LTA1LTAzICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAK ICAgICAgICAgW0pTQ10gR2VuZXJhdG9yIENvZGVCbG9jayBnZW5lcmF0aW9uIHNob3VsZCBiZSBp ZGVtcG90ZW50CkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9qc29uLXN0cmluZ2lmeS1zdHJpbmctYnVp bGRlci1vdmVyZmxvdy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9qc29uLXN0cmlu Z2lmeS1zdHJpbmctYnVpbGRlci1vdmVyZmxvdy5qcwkocmV2aXNpb24gMjQ0OTE0KQorKysgSlNU ZXN0cy9zdHJlc3MvanNvbi1zdHJpbmdpZnktc3RyaW5nLWJ1aWxkZXItb3ZlcmZsb3cuanMJKHdv cmtpbmcgY29weSkKQEAgLTEsNCArMSw2IEBACiAvL0Agc2xvdyEKKy8vQCBza2lwIGlmICRtZW1v cnlMaW1pdGVkCisvL0AgcnVuRGVmYXVsdCBpZiAhJG1lbW9yeUxpbWl0ZWQKIC8vQCBza2lwIGlm ICRhcmNoaXRlY3R1cmUgIT0gImFybTY0IiBhbmQgJGFyY2hpdGVjdHVyZSAhPSAieDg2LTY0Igog CiB2YXIgZXhjZXB0aW9uOwo=