<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>197568</bug_id>
          
          <creation_ts>2019-05-03 10:46:24 -0700</creation_ts>
          <short_desc>Investigate no longer resolving symlinks when creating a SandboxExtension</short_desc>
          <delta_ts>2019-05-17 10:18:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>REOPENED</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=197389</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>197389</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>bfulgham</cc>
    
    <cc>darin</cc>
    
    <cc>mjs</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1532852</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2019-05-03 10:46:24 -0700</bug_when>
    <thetext>When we originally wrote the SandboxExtension logic for handling files, we believed that they had to be defined in terms of the canonical paths on the file system. We added logic to resolve symlinks prior to issuing the extensions.

We now know that this is unnecessary work, and could be avoided entirely. This is likely to improve performance of certain file operations, and should be investigated as a way to further improve performance.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1532854</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2019-05-03 10:46:55 -0700</bug_when>
    <thetext>&lt;rdar://problem/14062743&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537143</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2019-05-17 10:07:59 -0700</bug_when>
    <thetext>After discussing this with Sandbox experts, it is not true that we can avoid resolving symlinks. We should not pursue this idea.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537144</commentid>
    <comment_count>3</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2019-05-17 10:18:25 -0700</bug_when>
    <thetext>Whoops -- we need fully-resolved names in Sandbox profile rules. But I think we can pass a sandbox extension to a path containing symlinks, and it&apos;s usable.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>