197547 2019-05-02 20:07:56 -0700 Add logging for RenderLayer clip rects 2019-05-12 20:08:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197639 InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue ryanhaddad simon.fraser webkit-bug-importer zalan oldest_to_newest 1532615 0 simon.fraser 2019-05-02 20:07:56 -0700 Add logging for RenderLayer clip rects 1532616 1 368877 simon.fraser 2019-05-02 20:08:40 -0700 Created attachment 368877 Patch 1532661 2 368877 commit-queue 2019-05-02 22:01:55 -0700 Comment on attachment 368877 Patch Clearing flags on attachment: 368877 Committed r244900: <https://trac.webkit.org/changeset/244900> 1532662 3 commit-queue 2019-05-02 22:01:56 -0700 All reviewed patches have been landed. Closing bug. 1532663 4 webkit-bug-importer 2019-05-02 22:02:18 -0700 <rdar://problem/50433802> 1533986 5 ryanhaddad 2019-05-07 11:21:31 -0700 As noted in https://bugs.webkit.org/show_bug.cgi?id=197639, this caused media/track/track-cue-missing.html to fail on macOS and iOS debug queues. 1533995 6 ryanhaddad 2019-05-07 11:42:22 -0700 Reverted r244900 for reason: Caused media/track/track-cue-missing.html to fail on debug queues Committed r245019: <https://trac.webkit.org/changeset/245019> 1535513 7 simon.fraser 2019-05-12 20:08:51 -0700 Re-landed in https://trac.webkit.org/r245219 in a way that shouldn't slow tests. 368877 2019-05-02 20:08:40 -0700 2019-05-02 22:01:55 -0700 Patch bug-197547-20190502200839.patch text/plain 6702 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWY3Yjc3MWRjMDIyMzZm Y2I0MzgzMTFjMjJhMTA3NTc4NDBlZmNjZi4uODBkMjFiMjc0OTA1OGQzZmMxYTkxYjI1N2YzZWRl YWU3ZGVhMTk0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA1LTAyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBsb2dnaW5n IGZvciBSZW5kZXJMYXllciBjbGlwIHJlY3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgYSBDbGlwUmVjdHMgbG9nIGNoYW5uZWwsIGFuZCBzdHJl YW0gb3V0cHV0IGZvciBDbGlwUmVjdCBhbmQgQ2xpcFJlY3RzLgorCisgICAgICAgICogcGxhdGZv cm0vTG9nZ2luZy5oOgorICAgICAgICAqIHJlbmRlcmluZy9DbGlwUmVjdC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpvcGVyYXRvcjw8KToKKyAgICAgICAgKiByZW5kZXJpbmcvQ2xpcFJlY3QuaDoK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 b3BlcmF0b3I8PCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6Y2FsY3VsYXRlQ2xp cFJlY3RzIGNvbnN0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaDoKKwogMjAx OS0wNS0wMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IGJhY2sgaGFzTnVsbFJlZmVyZW5jZXMoKSBhc3NlcnQgaW4gRG9jdW1lbnQ6OnVwZGF0ZUlzUGxh eWluZ01lZGlhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKaW5kZXggMDE3MTIyOWJkY2Q4ZmFm M2RjMjMxOWIxYjBiODFkMDA3M2Y4NmE4Zi4uZTEyMGEyOTJhODMyNWJiYjgwZjYxMTU2NjZjNTc2 YzQ0ZjFiMjRlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaApAQCAtNDIsNiArNDIsNyBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgTShBbmltYXRpb25zKSBcCiAgICAgTShBcHBsZVBh eSkgXAogICAgIE0oQXJjaGl2ZXMpIFwKKyAgICBNKENsaXBSZWN0cykgXAogICAgIE0oQ29tcG9z aXRpbmcpIFwKICAgICBNKENvbnRlbnRGaWx0ZXJpbmcpIFwKICAgICBNKENvbnRlbnRPYnNlcnZh dGlvbikgXApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0NsaXBSZWN0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9DbGlwUmVjdC5jcHAKaW5kZXggYjRkYjU2MzIz ZmE5ZmFhMzgxZmJiN2QzYmQzOTZmYjlkZWE4YjU0Yi4uMzYzMGQxNmFiZWY2MDJlZWM1Yzg0NzVh YjMzOTJiYzAzY2U0MjkxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Ns aXBSZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQ2xpcFJlY3QuY3BwCkBA IC0zOCw0ICszOCwxNyBAQCBib29sIENsaXBSZWN0OjppbnRlcnNlY3RzKGNvbnN0IEhpdFRlc3RM b2NhdGlvbiYgaGl0VGVzdExvY2F0aW9uKSBjb25zdAogICAgIHJldHVybiBoaXRUZXN0TG9jYXRp b24uaW50ZXJzZWN0cyhtX3JlY3QpOwogfQogCitUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFRleHRT dHJlYW0mIHRzLCBjb25zdCBDbGlwUmVjdCYgY2xpcFJlY3QpCit7CisgICAgdHMgPDwgInJlY3Qg IjsKKyAgICBpZiAoY2xpcFJlY3QuaXNJbmZpbml0ZSgpKQorICAgICAgICB0cyA8PCAiaW5maW5p dGUiOworICAgIGVsc2UKKyAgICAgICAgdHMgPDwgY2xpcFJlY3QucmVjdCgpOworCisgICAgaWYg KGNsaXBSZWN0LmFmZmVjdGVkQnlSYWRpdXMoKSkKKyAgICAgICAgdHMgPDwgIiBhZmZlY3RlZCBi eSByYWRpdXMiOworICAgIHJldHVybiB0czsKK30KKwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0NsaXBSZWN0LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQ2xp cFJlY3QuaAppbmRleCA1ZWQ3YTZjMGQ4ODk3NjgxOWYwYTFjMWFlYjk5OTk2ZTU0MTE2NDY2Li41 MmFiYjY3MWRhNWE2MDYzYzk3MDhjZjUyNDcyNGQzMmVlNmVjZDMzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvQ2xpcFJlY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvQ2xpcFJlY3QuaApAQCAtMjcsNiArMjcsMTAgQEAKIAogI2luY2x1ZGUgIkxheW91dFJl Y3QuaCIKIAorbmFtZXNwYWNlIFdURiB7CitjbGFzcyBUZXh0U3RyZWFtOworfQorCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIGNsYXNzIEhpdFRlc3RMb2NhdGlvbjsKQEAgLTEwMyw0ICsxMDcsNiBA QCBpbmxpbmUgQ2xpcFJlY3QgaW50ZXJzZWN0aW9uKGNvbnN0IENsaXBSZWN0JiBhLCBjb25zdCBD bGlwUmVjdCYgYikKICAgICByZXR1cm4gYzsKIH0KIAorV1RGOjpUZXh0U3RyZWFtJiBvcGVyYXRv cjw8KFdURjo6VGV4dFN0cmVhbSYsIGNvbnN0IENsaXBSZWN0Jik7CisKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IGEz ZmY1MjAwYWVlNzkyNTQxMmJhMDc3NTc1NDhjN2Y1ZjQ5NjkyMWUuLjIxYzI4YzMwYzFkZjQzYTky ODM3ZjQ1NDgxNTg2N2VhYmJkYjI2ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcApAQCAtMjY4LDYgKzI2OCwxOSBAQCB2b2lkIG1ha2VNYXRyaXhSZW5kZXJhYmxl KFRyYW5zZm9ybWF0aW9uTWF0cml4JiBtYXRyaXgsIGJvb2wgaGFzM0RSZW5kZXJpbmcpCiAjZW5k aWYKIH0KIAorI2lmICFMT0dfRElTQUJMRUQKK3N0YXRpYyBUZXh0U3RyZWFtJiBvcGVyYXRvcjw8 KFRleHRTdHJlYW0mIHRzLCBjb25zdCBDbGlwUmVjdHMmIGNsaXBSZWN0cykKK3sKKyAgICBUZXh0 U3RyZWFtOjpHcm91cFNjb3BlIHNjb3BlKHRzKTsKKyAgICB0cyA8PCBpbmRlbnQgPDwgIkNsaXBS ZWN0c1xuIjsKKyAgICB0cyA8PCBpbmRlbnQgPDwgIiAgb3ZlcmZsb3cgIDogIiA8PCBjbGlwUmVj dHMub3ZlcmZsb3dDbGlwUmVjdCgpIDw8ICJcbiI7CisgICAgdHMgPDwgaW5kZW50IDw8ICIgIGZp eGVkICAgICA6ICIgPDwgY2xpcFJlY3RzLmZpeGVkQ2xpcFJlY3QoKSA8PCAiXG4iOworICAgIHRz IDw8IGluZGVudCA8PCAiICBwb3NpdGlvbmVkOiAiIDw8IGNsaXBSZWN0cy5wb3NDbGlwUmVjdCgp IDw8ICJcbiI7CisKKyAgICByZXR1cm4gdHM7Cit9CisjZW5kaWYKKwogUmVuZGVyTGF5ZXI6OlJl bmRlckxheWVyKFJlbmRlckxheWVyTW9kZWxPYmplY3QmIHJlbmRlcmVyTGF5ZXJNb2RlbE9iamVj dCkKICAgICA6IG1faXNSZW5kZXJWaWV3TGF5ZXIocmVuZGVyZXJMYXllck1vZGVsT2JqZWN0Lmlz UmVuZGVyVmlldygpKQogICAgICwgbV9mb3JjZWRTdGFja2luZ0NvbnRleHQocmVuZGVyZXJMYXll ck1vZGVsT2JqZWN0LmlzTWVkaWEoKSkKQEAgLTU1MjgsNiArNTU0MSw4IEBAIHZvaWQgUmVuZGVy TGF5ZXI6OmNhbGN1bGF0ZUNsaXBSZWN0cyhjb25zdCBDbGlwUmVjdHNDb250ZXh0JiBjbGlwUmVj dHNDb250ZXh0LCBDCiAgICAgICAgICAgICBjbGlwUmVjdHMuc2V0Rml4ZWRDbGlwUmVjdChpbnRl cnNlY3Rpb24obmV3UG9zQ2xpcCwgY2xpcFJlY3RzLmZpeGVkQ2xpcFJlY3QoKSkpOwogICAgICAg ICB9CiAgICAgfQorICAgIAorICAgIExPR19XSVRIX1NUUkVBTShDbGlwUmVjdHMsIHN0cmVhbSA8 PCAiUmVuZGVyTGF5ZXIgIiA8PCB0aGlzIDw8ICIgY2FsY3VsYXRlQ2xpcFJlY3RzICIgPDwgY2xp cFJlY3RzKTsKIH0KIAogUmVmPENsaXBSZWN0cz4gUmVuZGVyTGF5ZXI6OnBhcmVudENsaXBSZWN0 cyhjb25zdCBDbGlwUmVjdHNDb250ZXh0JiBjbGlwUmVjdHNDb250ZXh0KSBjb25zdApAQCAtNTU3 Nyw2ICs1NTkyLDggQEAgQ2xpcFJlY3QgUmVuZGVyTGF5ZXI6OmJhY2tncm91bmRDbGlwUmVjdChj b25zdCBDbGlwUmVjdHNDb250ZXh0JiBjbGlwUmVjdHNDb250ZXgKICAgICAvLyBOb3RlOiBpbmZp bml0ZSBjbGlwUmVjdHMgc2hvdWxkIG5vdCBiZSBzY3JvbGxlZCBoZXJlLCBvdGhlcndpc2UgdGhl eSB3aWxsIGFjY2lkZW50YWxseSBubyBsb25nZXIgYmUgY29uc2lkZXJlZCBpbmZpbml0ZS4KICAg ICBpZiAocGFyZW50UmVjdHMtPmZpeGVkKCkgJiYgJmNsaXBSZWN0c0NvbnRleHQucm9vdExheWVy LT5yZW5kZXJlcigpID09ICZ2aWV3ICYmICFiYWNrZ3JvdW5kQ2xpcFJlY3QuaXNJbmZpbml0ZSgp KQogICAgICAgICBiYWNrZ3JvdW5kQ2xpcFJlY3QubW92ZUJ5KHZpZXcuZnJhbWVWaWV3KCkuc2Ny b2xsUG9zaXRpb25Gb3JGaXhlZFBvc2l0aW9uKCkpOworCisgICAgTE9HX1dJVEhfU1RSRUFNKENs aXBSZWN0cywgc3RyZWFtIDw8ICJSZW5kZXJMYXllciAiIDw8IHRoaXMgPDwgIiBiYWNrZ3JvdW5k Q2xpcFJlY3Qgd2l0aCBjb250ZXh0ICIgPDwgY2xpcFJlY3RzQ29udGV4dCA8PCAiIHJldHVybmlu ZyAiIDw8IGJhY2tncm91bmRDbGlwUmVjdCk7CiAgICAgcmV0dXJuIGJhY2tncm91bmRDbGlwUmVj dDsKIH0KIApAQCAtNjczOSw2ICs2NzU2LDIxIEBAIHZvaWQgUmVuZGVyTGF5ZXI6OmludmFsaWRh dGVFdmVudFJlZ2lvbigpCiAjZW5kaWYKIH0KIAorVGV4dFN0cmVhbSYgb3BlcmF0b3I8PChXVEY6 OlRleHRTdHJlYW0mIHRzLCBDbGlwUmVjdHNUeXBlIGNsaXBSZWN0c1R5cGUpCit7CisgICAgc3dp dGNoIChjbGlwUmVjdHNUeXBlKSB7CisgICAgY2FzZSBQYWludGluZ0NsaXBSZWN0czogdHMgPDwg InBhaW50aW5nIjsgYnJlYWs7CisgICAgY2FzZSBSb290UmVsYXRpdmVDbGlwUmVjdHM6IHRzIDw8 ICJyb290LXJlbGF0aXZlIjsgYnJlYWs7CisgICAgY2FzZSBBYnNvbHV0ZUNsaXBSZWN0czogdHMg PDwgImFic29sdXRlIjsgYnJlYWs7CisgICAgY2FzZSBUZW1wb3JhcnlDbGlwUmVjdHM6IHRzIDw8 ICJ0ZW1wb3JhcnkiOyBicmVhazsKKyAgICBjYXNlIE51bUNhY2hlZENsaXBSZWN0c1R5cGVzOgor ICAgIGNhc2UgQWxsQ2xpcFJlY3RUeXBlczoKKyAgICAgICAgdHMgPDwgIj8iOworICAgICAgICBi cmVhazsKKyAgICB9CisgICAgcmV0dXJuIHRzOworfQorCiBUZXh0U3RyZWFtJiBvcGVyYXRvcjw8 KFRleHRTdHJlYW0mIHRzLCBjb25zdCBSZW5kZXJMYXllciYgbGF5ZXIpCiB7CiAgICAgdHMgPDwg IlJlbmRlckxheWVyICIgPDwgJmxheWVyIDw8ICIgIiA8PCBsYXllci5zaXplKCk7CkBAIC02NzU3 LDYgKzY3ODksMTUgQEAgVGV4dFN0cmVhbSYgb3BlcmF0b3I8PChUZXh0U3RyZWFtJiB0cywgY29u c3QgUmVuZGVyTGF5ZXImIGxheWVyKQogICAgIHJldHVybiB0czsKIH0KIAorVGV4dFN0cmVhbSYg b3BlcmF0b3I8PChUZXh0U3RyZWFtJiB0cywgY29uc3QgUmVuZGVyTGF5ZXI6OkNsaXBSZWN0c0Nv bnRleHQmIGNvbnRleHQpCit7CisgICAgdHMuZHVtcFByb3BlcnR5KCJyb290IGxheWVyOiIsIGNv bnRleHQucm9vdExheWVyKTsKKyAgICB0cy5kdW1wUHJvcGVydHkoInR5cGU6IiwgY29udGV4dC5j bGlwUmVjdHNUeXBlKTsKKyAgICB0cy5kdW1wUHJvcGVydHkoIm92ZXJmbG93LWNsaXA6IiwgY29u dGV4dC5yZXNwZWN0T3ZlcmZsb3dDbGlwID09IElnbm9yZU92ZXJmbG93Q2xpcCA/ICJpZ25vcmUi IDogInJlc3BlY3QiKTsKKyAgICAKKyAgICByZXR1cm4gdHM7Cit9CisKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKIAogI2lmIEVOQUJMRShUUkVFX0RFQlVHR0lORykKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyLmgKaW5kZXggN2FhZDE5NjE0NzNlZjI1YzFlYWUwODExNWIxYTI3MmI3 YjI2ODJmYy4uZmVlNTA2MGM3ODNjYThlNzNiZTM3NzU5ZGY1N2M5Nzc3YzQxZjAzYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTEzNjksNyArMTM2OSw5IEBAIHZv aWQgbWFrZU1hdHJpeFJlbmRlcmFibGUoVHJhbnNmb3JtYXRpb25NYXRyaXgmLCBib29sIGhhczNE UmVuZGVyaW5nKTsKIAogYm9vbCBjb21wb3NpdGVkV2l0aE93bkJhY2tpbmdTdG9yZShjb25zdCBS ZW5kZXJMYXllciYpOwogCitXVEY6OlRleHRTdHJlYW0mIG9wZXJhdG9yPDwoV1RGOjpUZXh0U3Ry ZWFtJiwgQ2xpcFJlY3RzVHlwZSk7CiBXVEY6OlRleHRTdHJlYW0mIG9wZXJhdG9yPDwoV1RGOjpU ZXh0U3RyZWFtJiwgY29uc3QgUmVuZGVyTGF5ZXImKTsKK1dURjo6VGV4dFN0cmVhbSYgb3BlcmF0 b3I8PChXVEY6OlRleHRTdHJlYW0mLCBjb25zdCBSZW5kZXJMYXllcjo6Q2xpcFJlY3RzQ29udGV4 dCYpOwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAK