197524 2019-05-02 11:31:39 -0700 Remove needsAppIdQuirks in 2023 2023-04-03 11:24:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED LATER InRadar P2 Normal --- 246032 1 jiewen_tan rniwa ahmad.saleem792 ap bfulgham cdumez commit-queue james jiewen_tan pascoe rniwa webkit-bug-importer oldest_to_newest 1532368 0 jiewen_tan 2019-05-02 11:31:39 -0700 Remove needsAppIdQuirks in 2023. 1900613 1 ahmad.saleem792 2022-09-23 05:47:33 -0700 https://github.com/WebKit/WebKit/blob/6bd8e23cd7a92e9c5e92fc130b31b4351bfa19b7/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp#L56 I tried to search "needsAppIdQuirks" in https://source.chromium.org but couldn't find anything. Is there any update? Thanks! 1902240 2 ap 2022-09-29 18:12:49 -0700 Source//WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:static bool needsAppIdQuirks(const String& host, const String& appId) Source//WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp: if (!appIdURL.isValid() || facetId.protocol() != appIdURL.protocol() || (RegistrableDomain(appIdURL) != RegistrableDomain::uncheckedCreateFromHost(facetId.host()) && !needsAppIdQuirks(facetId.host(), appId))) This can probably be removed right now. 1903044 3 rniwa 2022-10-03 23:22:02 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4968 1903159 4 ews-feeder 2022-10-04 10:02:31 -0700 Committed 255131@main (e289f6f60014): <https://commits.webkit.org/255131@main> Reviewed commits have been landed. Closing PR #4968 and removing active labels. 1903160 5 webkit-bug-importer 2022-10-04 10:03:23 -0700 <rdar://problem/100768951> 1903161 6 pascoe 2022-10-04 10:09:55 -0700 Google still actively uses this quirk and login breaks without it. I think we will need to consult before removing this quirk. 1903163 7 pascoe 2022-10-04 10:15:07 -0700 This quirk is still in Chrome: https://github.com/chromium/chromium/blob/829d766699652d4678325623846cf5a33f996f4f/content/browser/webauth/webauth_request_security_checker.cc#L307 1903187 8 commit-queue 2022-10-04 11:23:17 -0700 Re-opened since this is blocked by bug 246032 1945869 9 ahmad.saleem792 2023-03-31 17:29:07 -0700 Hi Team - we have now passed original time of January 2023. Can we check whether we can remove it or not? Or update comment to track it for future? Thanks! 1946249 10 rniwa 2023-04-03 11:24:38 -0700 Quirk is still present in Chromium: https://github.com/chromium/chromium/blob/776ba6a94375a2ab65bd6924859e2de628328cd2/content/browser/webauth/webauth_request_security_checker.cc#LL201C42-L201C52