197490 2019-05-02 00:55:09 -0700 Web Inspector: Timelines: imported recordings do not have JavaScript call trees 2019-06-11 09:17:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck tsavell webkit-bug-importer oldest_to_newest 1532228 0 hi 2019-05-02 00:55:09 -0700 This makes exported recordings less useful, as severely inhibits the ability to track down performance issues in JavaScript (e.g. no timing information). 1534391 1 webkit-bug-importer 2019-05-08 11:30:34 -0700 <rdar://problem/50589157> 1534392 2 webkit-bug-importer 2019-05-08 11:30:34 -0700 <rdar://problem/50589158> 1543245 3 371719 hi 2019-06-09 20:41:01 -0700 Created attachment 371719 Patch 1543246 4 371719 hi 2019-06-09 20:42:43 -0700 Comment on attachment 371719 Patch I'm not sure if this actually "fixes" the issue completely (e.g. there may be other changes, like all the `FIXME: CallFrames`, but with this change the "Call Trees" view is no longer empty :) 1543498 5 371719 joepeck 2019-06-10 15:45:30 -0700 Comment on attachment 371719 Patch r=me 1543512 6 371719 commit-queue 2019-06-10 16:15:47 -0700 Comment on attachment 371719 Patch Clearing flags on attachment: 371719 Committed r246292: <https://trac.webkit.org/changeset/246292> 1543513 7 commit-queue 2019-06-10 16:15:48 -0700 All reviewed patches have been landed. Closing bug. 1543714 8 tsavell 2019-06-11 08:41:45 -0700 The changes in https://trac.webkit.org/changeset/246292/webkit has broken inspector/timeline/timeline-recording.html There are a lot of added lines in the diff. Did this test just need a rebasline? History: http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Ftimeline%2Ftimeline-recording.html Diff: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r246309%20(4628)/inspector/timeline/timeline-recording-diff.txt 1543722 9 hi 2019-06-11 09:17:14 -0700 (In reply to Truitt Savell from comment #8) > The changes in https://trac.webkit.org/changeset/246292/webkit > > has broken inspector/timeline/timeline-recording.html > > There are a lot of added lines in the diff. Did this test just need a rebasline? > > History: > http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. html#showAllRuns=true&tests=inspector%2Ftimeline%2Ftimeline-recording.html > > Diff: > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r246309%20(4628)/inspector/timeline/timeline-recording-diff.txt Committed r246317: <https://trac.webkit.org/r246317> 371719 2019-06-09 20:41:01 -0700 2019-06-10 16:15:47 -0700 Patch bug-197490-20190609204100.patch text/plain 3851 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGMxN2Y3MGI2N2QyZDhjYzdjODhkMTI2MjE0ZTA3 MjkzOWE5ZmFmMGIuLjZiNzliODFkNjNhODU5ZTBhMDZhMGViMDA0ODYwMTI4NTQ3YTgyMjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA2LTA5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBU aW1lbGluZXM6IGltcG9ydGVkIHJlY29yZGluZ3MgZG8gbm90IGhhdmUgSmF2YVNjcmlwdCBjYWxs IHRyZWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTc0OTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUwNTg5MTU4PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMv VGltZWxpbmVSZWNvcmRpbmcuanM6CisgICAgICAgIChXSS5UaW1lbGluZVJlY29yZGluZy5wcm90 b3R5cGUuaW5pdGlhbGl6ZUNhbGxpbmdDb250ZXh0VHJlZXMpOgorICAgICAgICBNYWtlIHN1cmUg dG8gYWN0dWFsbHkgc2F2ZSB0aGUgcHJvdmlkZWQgc3RhY2sgdHJhY2VzIGFuZCBzYW1wbGVzIGlu IHRoZSBleHBvcnQgZGF0YS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1Njcmlw dFRpbWVsaW5lUmVjb3JkLmpzOgorICAgICAgICAoV0kuU2NyaXB0VGltZWxpbmVSZWNvcmQuZnJv bUpTT04pOgorICAgICAgICAoV0kuU2NyaXB0VGltZWxpbmVSZWNvcmQucHJvdG90eXBlLnRvSlNP Tik6CisgICAgICAgIERyaXZlLWJ5OiBpbmNsdWRlIGBleHRyYURldGFpbHNgLCB3aGljaCBjb250 YWlucyB1c2VmdWwgaW5mb3JtYXRpb24gbGlrZSAiZGVmYXVsdCBwcmV2ZW50ZWQiLgorCiAyMDE5 LTA2LTA3ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IGxvbmdoYW5kIENTUyBwcm9wZXJ0aWVzIG92ZXJyaWRkZW4gYnkgc2hv cnRoYW5kcyBtaXNzIHN0cmlrZXRocm91Z2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGluZVJlY29yZC5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGluZVJlY29y ZC5qcwppbmRleCAxYjMyOGYzYTdhODkzOGI5OWFlNmU1ZDE5MmJhODU1Y2Q2NzcwMTQyLi5mNWQ3 YzU4OTU1MjA2OGE3YWMyYWFiZThlOTcyZDA1MjM2MGY1M2FkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0VGltZWxpbmVSZWNvcmQu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1Njcmlw dFRpbWVsaW5lUmVjb3JkLmpzCkBAIC01MywxOCArNTMsMTkgQEAgV0kuU2NyaXB0VGltZWxpbmVS ZWNvcmQgPSBjbGFzcyBTY3JpcHRUaW1lbGluZVJlY29yZCBleHRlbmRzIFdJLlRpbWVsaW5lUmVj b3JkCiAKICAgICBzdGF0aWMgZnJvbUpTT04oanNvbikKICAgICB7Ci0gICAgICAgIGxldCB7ZXZl bnRUeXBlLCBzdGFydFRpbWUsIGVuZFRpbWUsIGNhbGxGcmFtZXMsIHNvdXJjZUNvZGVMb2NhdGlv biwgZGV0YWlscywgcHJvZmlsZVBheWxvYWR9ID0ganNvbjsKKyAgICAgICAgbGV0IHtldmVudFR5 cGUsIHN0YXJ0VGltZSwgZW5kVGltZSwgY2FsbEZyYW1lcywgc291cmNlQ29kZUxvY2F0aW9uLCBk ZXRhaWxzLCBwcm9maWxlUGF5bG9hZCwgZXh0cmFEZXRhaWxzfSA9IGpzb247CiAKICAgICAgICAg aWYgKHR5cGVvZiBkZXRhaWxzID09PSAib2JqZWN0IiAmJiBkZXRhaWxzLl9fdHlwZSA9PT0gIkdh cmJhZ2VDb2xsZWN0aW9uIikKICAgICAgICAgICAgIGRldGFpbHMgPSBXSS5HYXJiYWdlQ29sbGVj dGlvbi5mcm9tSlNPTihkZXRhaWxzKTsKIAotICAgICAgICByZXR1cm4gbmV3IFdJLlNjcmlwdFRp bWVsaW5lUmVjb3JkKGV2ZW50VHlwZSwgc3RhcnRUaW1lLCBlbmRUaW1lLCBjYWxsRnJhbWVzLCBz b3VyY2VDb2RlTG9jYXRpb24sIGRldGFpbHMsIHByb2ZpbGVQYXlsb2FkKTsKKyAgICAgICAgcmV0 dXJuIG5ldyBXSS5TY3JpcHRUaW1lbGluZVJlY29yZChldmVudFR5cGUsIHN0YXJ0VGltZSwgZW5k VGltZSwgY2FsbEZyYW1lcywgc291cmNlQ29kZUxvY2F0aW9uLCBkZXRhaWxzLCBwcm9maWxlUGF5 bG9hZCwgZXh0cmFEZXRhaWxzKTsKICAgICB9CiAKICAgICB0b0pTT04oKQogICAgIHsKICAgICAg ICAgLy8gRklYTUU6IENhbGxGcmFtZXMKICAgICAgICAgLy8gRklYTUU6IFNvdXJjZUNvZGVMb2Nh dGlvbgorICAgICAgICAvLyBGSVhNRTogcHJvZmlsZVBheWxvYWQKIAogICAgICAgICByZXR1cm4g ewogICAgICAgICAgICAgdHlwZTogdGhpcy50eXBlLApAQCAtNzIsNiArNzMsNyBAQCBXSS5TY3Jp cHRUaW1lbGluZVJlY29yZCA9IGNsYXNzIFNjcmlwdFRpbWVsaW5lUmVjb3JkIGV4dGVuZHMgV0ku VGltZWxpbmVSZWNvcmQKICAgICAgICAgICAgIHN0YXJ0VGltZTogdGhpcy5zdGFydFRpbWUsCiAg ICAgICAgICAgICBlbmRUaW1lOiB0aGlzLmVuZFRpbWUsCiAgICAgICAgICAgICBkZXRhaWxzOiB0 aGlzLl9kZXRhaWxzLAorICAgICAgICAgICAgZXh0cmFEZXRhaWxzOiB0aGlzLl9leHRyYURldGFp bHMsCiAgICAgICAgIH07CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvVGltZWxpbmVSZWNvcmRpbmcuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvVGltZWxpbmVSZWNvcmRpbmcuanMKaW5k ZXggOTc0NDA5Y2RmM2FkNWNkODUxYmI0YzNiZmMzNWEzYWI0NzA0MDdlNi4uMGI0YmJjNDNhZjM4 NjFjMDg4OGU0YmM0ZmM3MzA5ZjY5ODUwNGIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1RpbWVsaW5lUmVjb3JkaW5nLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9UaW1lbGluZVJlY29yZGlu Zy5qcwpAQCAtNDMxLDggKzQzMSw4IEBAIFdJLlRpbWVsaW5lUmVjb3JkaW5nID0gY2xhc3MgVGlt ZWxpbmVSZWNvcmRpbmcgZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgIGluaXRpYWxpemVDYWxsaW5n Q29udGV4dFRyZWVzKHN0YWNrVHJhY2VzLCBzYW1wbGVEdXJhdGlvbnMpCiAgICAgewotICAgICAg ICB0aGlzLl9leHBvcnREYXRhU2FtcGxlU3RhY2tUcmFjZXMuY29uY2F0KHN0YWNrVHJhY2VzKTsK LSAgICAgICAgdGhpcy5fZXhwb3J0RGF0YVNhbXBsZUR1cmF0aW9ucy5jb25jYXQoc2FtcGxlRHVy YXRpb25zKTsKKyAgICAgICAgdGhpcy5fZXhwb3J0RGF0YVNhbXBsZVN0YWNrVHJhY2VzID0gdGhp cy5fZXhwb3J0RGF0YVNhbXBsZVN0YWNrVHJhY2VzLmNvbmNhdChzdGFja1RyYWNlcyk7CisgICAg ICAgIHRoaXMuX2V4cG9ydERhdGFTYW1wbGVEdXJhdGlvbnMgPSB0aGlzLl9leHBvcnREYXRhU2Ft cGxlRHVyYXRpb25zLmNvbmNhdChzYW1wbGVEdXJhdGlvbnMpOwogCiAgICAgICAgIGZvciAobGV0 IGkgPSAwOyBpIDwgc3RhY2tUcmFjZXMubGVuZ3RoOyBpKyspIHsKICAgICAgICAgICAgIHRoaXMu X3RvcERvd25DYWxsaW5nQ29udGV4dFRyZWUudXBkYXRlVHJlZVdpdGhTdGFja1RyYWNlKHN0YWNr VHJhY2VzW2ldLCBzYW1wbGVEdXJhdGlvbnNbaV0pOwo=