<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>197483</bug_id>
          
          <creation_ts>2019-05-01 16:03:09 -0700</creation_ts>
          <short_desc>[PlayStation] Update port for WEBKIT_EXECUTABLE changes</short_desc>
          <delta_ts>2019-05-01 17:09:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Stephan Szabo">stephan.szabo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>ross.kirsling</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1532121</commentid>
    <comment_count>0</comment_count>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2019-05-01 16:03:09 -0700</bug_when>
    <thetext>PlayStation was wrapping add_executable for doing some setup and signing, but this usage does not function as expected after the WEBKIT_EXECUTABLE changes and the timing change of when add_executable is called.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1532124</commentid>
    <comment_count>1</comment_count>
      <attachid>368728</attachid>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2019-05-01 16:08:25 -0700</bug_when>
    <thetext>Created attachment 368728
Patch

Move to wrapping the new WEBKIT_EXECUTABLE macro rather than add_executable for post-port-configuration executable setup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1532148</commentid>
    <comment_count>2</comment_count>
      <attachid>368728</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-01 17:09:55 -0700</bug_when>
    <thetext>Comment on attachment 368728
Patch

Clearing flags on attachment: 368728

Committed r244859: &lt;https://trac.webkit.org/changeset/244859&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1532149</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-01 17:09:57 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>368728</attachid>
            <date>2019-05-01 16:08:25 -0700</date>
            <delta_ts>2019-05-01 17:09:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>197483.1.diff</filename>
            <type>text/plain</type>
            <size>1756</size>
            <attacher name="Stephan Szabo">stephan.szabo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlYjJkNzM0MDAzNy4uNWUz
ZTM2MzdmZDQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNCBAQAorMjAxOS0wNS0wMSAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5j
b20+CisKKyAgICAgICAgW1BsYXlTdGF0aW9uXSBVcGRhdGUgcG9ydCBmb3IgV0VCS0lUX0VYRUNV
VEFCTEUgY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTk3NDgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1BsYXlTdGF0aW9uLmNtYWtlOgorICAgICAgICBV
cGRhdGUgd3JhcHBpbmcgZm9yIGNvbmZpZ3VyaW5nIGV4ZWN1dGFibGVzJyBwbGF5c3RhdGlvbgor
ICAgICAgICBzcGVjaWZpYyBkYXRhIHRvIG5ldyBXRUJLSVRfRVhFQ1VUQUJMRSBtYWNyby4KKwog
MjAxOS0wNC0zMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK
ICAgICAgICAgW0dUS10gU3VwcG9ydCBwcmVmZXJzLWNvbG9yLXNjaGVtZSBtZWRpYSBxdWVyeQpk
aWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNQbGF5U3RhdGlvbi5jbWFrZSBiL1NvdXJj
ZS9jbWFrZS9PcHRpb25zUGxheVN0YXRpb24uY21ha2UKaW5kZXggMTYxZjdhZmMxZWEuLjZiZTM1
YTcwMDFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1BsYXlTdGF0aW9uLmNtYWtl
CisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zUGxheVN0YXRpb24uY21ha2UKQEAgLTE1MCwxNiAr
MTUwLDE2IEBAIGZ1bmN0aW9uKGFkZF9saWJyYXJ5IHRhcmdldCB0eXBlKQogICAgIGVuZGlmICgp
CiBlbmRmdW5jdGlvbigpCiAKLWZ1bmN0aW9uKGFkZF9leGVjdXRhYmxlIHRhcmdldCkKLSAgICBf
YWRkX2V4ZWN1dGFibGUoJHtBUkdWfSkKLSAgICBwbGF5c3RhdGlvbl9zZXR1cF9saWJjKCR7dGFy
Z2V0fSkKLSAgICBwbGF5c3RhdGlvbl9zZXR1cF9mcCgke3RhcmdldH0pCi0gICAgaWYgKE5PVCAk
e3RhcmdldH0gTUFUQ0hFUyAiXkxMSW50IikKLSAgICAgICAgc2lnbigke3RhcmdldH0pCittYWNy
byhXRUJLSVRfRVhFQ1VUQUJMRSBfdGFyZ2V0KQorICAgIF9XRUJLSVRfRVhFQ1VUQUJMRSgke190
YXJnZXR9KQorICAgIHBsYXlzdGF0aW9uX3NldHVwX2xpYmMoJHtfdGFyZ2V0fSkKKyAgICBwbGF5
c3RhdGlvbl9zZXR1cF9mcCgke190YXJnZXR9KQorICAgIGlmIChOT1QgJHtfdGFyZ2V0fSBNQVRD
SEVTICJeTExJbnQiKQorICAgICAgICBzaWduKCR7X3RhcmdldH0pCiAgICAgZW5kaWYgKCkKLSAg
ICBpZiAoUExBWVNUQVRJT05fJHt0YXJnZXR9X1dSQVApCi0gICAgICAgIGZvcmVhY2ggKFdSQVAg
JHtQTEFZU1RBVElPTl8ke3RhcmdldH1fV1JBUH0pCi0gICAgICAgICAgICB0YXJnZXRfbGlua19v
cHRpb25zKCR7dGFyZ2V0fSBQUklWQVRFIC1XbCwtLXdyYXA9JHtXUkFQfSkKKyAgICBpZiAoUExB
WVNUQVRJT05fJHtfdGFyZ2V0fV9XUkFQKQorICAgICAgICBmb3JlYWNoIChXUkFQICR7UExBWVNU
QVRJT05fJHtfdGFyZ2V0fV9XUkFQfSkKKyAgICAgICAgICAgIHRhcmdldF9saW5rX29wdGlvbnMo
JHtfdGFyZ2V0fSBQUklWQVRFIC1XbCwtLXdyYXA9JHtXUkFQfSkKICAgICAgICAgZW5kZm9yZWFj
aCAoKQogICAgIGVuZGlmICgpCi1lbmRmdW5jdGlvbigpCitlbmRtYWNybygpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>