197477 2019-05-01 14:13:35 -0700 Add back hasNullReferences() assert in Document::updateIsPlayingMedia 2019-05-02 15:35:28 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue darin eric.carlson jer.noble oldest_to_newest 1532063 0 youennf 2019-05-01 14:13:35 -0700 Add back hasNullReferences() assert in Document::updateIsPlayingMedia 1532123 1 368727 youennf 2019-05-01 16:08:07 -0700 Created attachment 368727 Patch 1532151 2 368727 commit-queue 2019-05-01 17:20:45 -0700 Comment on attachment 368727 Patch Clearing flags on attachment: 368727 Committed r244860: <https://trac.webkit.org/changeset/244860> 1532152 3 commit-queue 2019-05-01 17:20:46 -0700 All reviewed patches have been landed. Closing bug. 1532174 4 368727 darin 2019-05-01 18:34:18 -0700 Comment on attachment 368727 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368727&action=review > Source/WebCore/Modules/webaudio/AudioContext.cpp:1069 > ScriptExecutionContext* AudioContext::scriptExecutionContext() const > { > - return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext(); > + return ActiveDOMObject::scriptExecutionContext(); > } Could we come back and just remove this override later? 1532190 5 youennf 2019-05-01 19:34:52 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 368727 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368727&action=review > > > Source/WebCore/Modules/webaudio/AudioContext.cpp:1069 > > ScriptExecutionContext* AudioContext::scriptExecutionContext() const > > { > > - return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext(); > > + return ActiveDOMObject::scriptExecutionContext(); > > } > > Could we come back and just remove this override later? Could you clarify your suggestion? This override is currently needed as AudioContext is an EventTarget. 1532447 6 368727 darin 2019-05-02 14:33:37 -0700 Comment on attachment 368727 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368727&action=review >>> Source/WebCore/Modules/webaudio/AudioContext.cpp:1069 >>> } >> >> Could we come back and just remove this override later? > > Could you clarify your suggestion? > This override is currently needed as AudioContext is an EventTarget. OK, then we can’t remove it. 1532483 7 webkit-bug-importer 2019-05-02 15:35:28 -0700 <rdar://problem/50424860> 368727 2019-05-01 16:08:07 -0700 2019-05-01 17:20:45 -0700 Patch bug-197477-20190501160807.patch text/plain 3538 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkwN2IzOWJkMjFlZGE2 YmU3YjUwNmU3MDQwOWZhMDNkOGUzMDc3Mi4uN2E2MWEyZWYwNmVhMWQ0YzM1MzIzMGM5ZDNmOWQ5 ZTliNDM2OTVhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTA1LTAxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYmFjayBoYXNOdWxs UmVmZXJlbmNlcygpIGFzc2VydCBpbiBEb2N1bWVudDo6dXBkYXRlSXNQbGF5aW5nTWVkaWEKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzQ3NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF1ZGlvQ29udGV4 dCBoYWQgYSBzcGVjaWFsIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBnZXR0ZXIKKyAgICAgICAg dGhhdCB3YXMgcmV0dXJuaW5nIG51bGxwdHIgd2hlbiBBdWRpb0NvbnRleHQgaXMgc3RvcHBlZC4K KyAgICAgICAgSW5zdGVhZCwgbWFrZSB0aGlzIGdldHRlciBiZWhhdmUgYXMgYWxsIG90aGVyIHNj cmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBnZXR0ZXJzCisgICAgICAgIGFuZCBtYWtlIHN1cmUgZXhp c3RpbmcgY2FsbCBzaXRlcyBvZiB0aGUgZ2V0dGVyIGFyZSBmaW5lIHdpdGggdGhlIGNoYW5nZS4K KworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogTW9kdWxl cy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250 ZXh0OjpBdWRpb0NvbnRleHQpOgorICAgICAgICBObyBuZWVkIHRvIGNoZWNrIHdoZXRoZXIgb2Zm bGluZSBzaW5jZSB0aGlzIGNvbnN0cnVjdG9yIGlzIGZvciBub24gb2ZmbGluZSBBdWRpb0NvbnRl eHQuCisgICAgICAgIChXZWJDb3JlOjpBdWRpb0NvbnRleHQ6OnNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0OjpmaXJlQ29tcGxldGlv bkV2ZW50KToKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RG9jdW1lbnQ6OnVwZGF0ZUlzUGxheWluZ01lZGlhKToKKwogMjAxOS0wNS0wMSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2FjaGUuYWRkIGFuZCBDYWNoZS5h ZGRBbGwgc2hvdWxkIGNvbXB1dGUgYSBjb3JyZWN0IHJlc3BvbnNlIGJvZHkgc2l6ZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCmluZGV4IDc0 ZmM4NTkwOTc0NDk1NGE4YzE4NWJjZTBjMjgwZTFhOTliYmQyNTcuLmVkOGFlNDkxY2M4Y2ZjNWUx MDNkOWZlYWI5ZmQ5NWY5MWM3YjM4YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAKQEAgLTE0OCwxMCArMTQ4LDggQEAgQXVkaW9Db250 ZXh0OjpBdWRpb0NvbnRleHQoRG9jdW1lbnQmIGRvY3VtZW50KQogICAgIC8vIEluaXRpYWxpemUg dGhlIGRlc3RpbmF0aW9uIG5vZGUncyBtdXRlZCBzdGF0ZSB0byBtYXRjaCB0aGUgcGFnZSdzIGN1 cnJlbnQgbXV0ZWQgc3RhdGUuCiAgICAgcGFnZU11dGVkU3RhdGVEaWRDaGFuZ2UoKTsKIAotICAg IGlmICghaXNPZmZsaW5lQ29udGV4dCgpKSB7Ci0gICAgICAgIGRvY3VtZW50LmFkZEF1ZGlvUHJv ZHVjZXIoKnRoaXMpOwotICAgICAgICBkb2N1bWVudC5yZWdpc3RlckZvclZpc2liaWxpdHlTdGF0 ZUNoYW5nZWRDYWxsYmFja3MoKnRoaXMpOwotICAgIH0KKyAgICBkb2N1bWVudC5hZGRBdWRpb1By b2R1Y2VyKCp0aGlzKTsKKyAgICBkb2N1bWVudC5yZWdpc3RlckZvclZpc2liaWxpdHlTdGF0ZUNo YW5nZWRDYWxsYmFja3MoKnRoaXMpOwogfQogCiAvLyBDb25zdHJ1Y3RvciBmb3Igb2ZmbGluZSAo bm9uLXJlYWx0aW1lKSByZW5kZXJpbmcuCkBAIC0xMDY3LDcgKzEwNjUsNyBAQCB2b2lkIEF1ZGlv Q29udGV4dDo6cHJvY2Vzc0F1dG9tYXRpY1B1bGxOb2RlcyhzaXplX3QgZnJhbWVzVG9Qcm9jZXNz KQogCiBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBBdWRpb0NvbnRleHQ6OnNjcmlwdEV4ZWN1dGlv bkNvbnRleHQoKSBjb25zdAogewotICAgIHJldHVybiBtX2lzU3RvcFNjaGVkdWxlZCA/IDAgOiBB Y3RpdmVET01PYmplY3Q6OnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKTsKKyAgICByZXR1cm4gQWN0 aXZlRE9NT2JqZWN0OjpzY3JpcHRFeGVjdXRpb25Db250ZXh0KCk7CiB9CiAKIHZvaWQgQXVkaW9D b250ZXh0Ojpub2RlV2lsbEJlZ2luUGxheWJhY2soKQpAQCAtMTE4Niw3ICsxMTg0LDcgQEAgdm9p ZCBBdWRpb0NvbnRleHQ6OmZpcmVDb21wbGV0aW9uRXZlbnQoKQogICAgICAgICByZXR1cm47CiAK ICAgICAvLyBBdm9pZCBmaXJpbmcgdGhlIGV2ZW50IGlmIHRoZSBkb2N1bWVudCBoYXMgYWxyZWFk eSBnb25lIGF3YXkuCi0gICAgaWYgKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkgeworICAgIGlm ICghbV9pc1N0b3BTY2hlZHVsZWQpIHsKICAgICAgICAgLy8gQ2FsbCB0aGUgb2ZmbGluZSByZW5k ZXJpbmcgY29tcGxldGlvbiBldmVudCBsaXN0ZW5lci4KICAgICAgICAgbV9ldmVudFF1ZXVlLT5l bnF1ZXVlRXZlbnQoT2ZmbGluZUF1ZGlvQ29tcGxldGlvbkV2ZW50OjpjcmVhdGUocmVuZGVyZWRC dWZmZXIpKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCAyNGI3MDE4ZDkxNzYy ZjY2YjljYTI5NGI2NGJmY2M4NDVjZGU1NDYzLi5kZTc5ZGM0ZjI3Y2M1ZmViZmEzZTczODg3YzJl Njc0NzgwNGUwMzRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTM5MjYsNiArMzkyNiw3 IEBAIHZvaWQgRG9jdW1lbnQ6Om5vdGVVc2VySW50ZXJhY3Rpb25XaXRoTWVkaWFFbGVtZW50KCkK IAogdm9pZCBEb2N1bWVudDo6dXBkYXRlSXNQbGF5aW5nTWVkaWEodWludDY0X3Qgc291cmNlRWxl bWVudElEKQogeworICAgIEFTU0VSVCghbV9hdWRpb1Byb2R1Y2Vycy5oYXNOdWxsUmVmZXJlbmNl cygpKTsKICAgICBNZWRpYVByb2R1Y2VyOjpNZWRpYVN0YXRlRmxhZ3Mgc3RhdGUgPSBNZWRpYVBy b2R1Y2VyOjpJc05vdFBsYXlpbmc7CiAgICAgZm9yIChhdXRvJiBhdWRpb1Byb2R1Y2VyIDogbV9h dWRpb1Byb2R1Y2VycykKICAgICAgICAgc3RhdGUgfD0gYXVkaW9Qcm9kdWNlci5tZWRpYVN0YXRl KCk7Cg==