197451 2019-04-30 18:18:54 -0700 REGRESSION (r244182): RenderingUpdate should not be scheduled for invisible pages 2019-05-01 12:31:13 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177484 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue dino simon.fraser webkit-bug-importer oldest_to_newest 1531822 0 sabouhallawa 2019-04-30 18:18:54 -0700 Safari creates a blank web page when it is opened. This page will not be visible unless the user selects to open new tabs with "Empty page". The loader of this page forces Document::resolveStyle() which requires RenderLayerCompositor::scheduleLayerFlushNow(). Before r244182, this would just call scheduleCompositingLayerFlush() immediately. After r244182, RenderLayerCompositor::scheduleLayerFlushNow() has to schedule a RenderingUpdate and when it fires it calls scheduleCompositingLayerFlush(). We need to optimize this case by checking whether the page is visible or not before scheduling the RenderingUpdate. 1531827 1 368642 sabouhallawa 2019-04-30 18:28:49 -0700 Created attachment 368642 Patch 1531977 2 368684 sabouhallawa 2019-05-01 10:26:39 -0700 Created attachment 368684 Patch 1531980 3 sabouhallawa 2019-05-01 10:30:05 -0700 <rdar://problem/50224329> 1532011 4 368684 commit-queue 2019-05-01 12:31:11 -0700 Comment on attachment 368684 Patch Clearing flags on attachment: 368684 Committed r244837: <https://trac.webkit.org/changeset/244837> 1532012 5 commit-queue 2019-05-01 12:31:13 -0700 All reviewed patches have been landed. Closing bug. 368642 2019-04-30 18:28:49 -0700 2019-05-01 10:26:37 -0700 Patch bug-197451-20190430182849.patch text/plain 6549 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NDgxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM3IEBACisyMDE5LTA0LTMwICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TiAocjI0NDE4Mik6IFJlbmRlcmluZ1VwZGF0ZSBzaG91bGQgbm90IGJlIHNjaGVkdWxlZCBmb3Ig aW52aXNpYmxlIHBhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTc0NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBCZWZvcmUgcjI0NDE4Miwgc29tZSB3ZWIgcGFnZXMgbmV2ZXIgbmVlZCB0byBzY2hl ZHVsZSBhIFJlbmRlcmluZ1VwZGF0ZS4KKyAgICAgICAgT25seSBwYWdlcyB3aXRoIHJBRiBjYWxs YmFja3MsIHdlYiBhbmltYXRpb25zLCBpbnRlcnNlY3Rpb24gYW5kIHJlc2l6ZSAKKyAgICAgICAg b2JzZXJ2ZXIgbmVlZCB0byBkbyBzby4KKworICAgICAgICBXaGVuIFNhZmFyaSBvcGVucywgaXQg Y3JlYXRlIGEgJ2JsYW5rJyB3ZWIgcGFnZS4gVGhlIGJsYW5rIHBhZ2Ugd2lsbCBub3QKKyAgICAg ICAgYmUgdmlzaWJsZSB1bmxlc3MgdGhlIHVzZXIgc2VsZWN0cyB0byBzaG93IHRoZSAnRW1wdHkg cGFnZScsIGluIHRoZSBuZXcKKyAgICAgICAgdGFiLiBBbHRob3VnaCB0aGUgYmxhbmsgcGFnZSBp cyBub3QgdmlzaWJsZSwgdGhlIGxvYWRlciBuZWVkcyByZXNvbHZlU3R5bGUoKQorICAgICAgICB3 aGljaCByZXF1aXJlcyBzY2hlZHVsZUxheWVyRmx1c2hOb3coKS4gU28gd2UgbmVlZCB0byBvcHRp bWl6ZSB0aGlzIGNhc2UKKyAgICAgICAgYnkgY2hlY2tpbmcgaWYgdGhlIHBhZ2UgaXMgdmlzaWJs ZSBiZWZvcmUgc2NoZWR1bGluZyB0aGUgUmVuZGVyaW5nVXBkYXRlLgorCisgICAgICAgIEFsc28g d2UgbmVlZCB0byBjaGFuZ2Ugb3IgZ2V0IHJpZCBvZiBzY2hlZHVsZUxheWVyRmx1c2hOb3coKSBz aW5jZSBpdCBpcworICAgICAgICBub3cgY29uZnVzaW5nLiBJdHMgbmFtZSBzdWdnZXN0cyB0aGF0 IGl0IGlzIGdvaW5nIHRvIHNjaGVkdWxlIGZsdXNoaW5nCisgICAgICAgIHRoZSBsYXllciAnbm93 Jy4gQnV0IGFmdGVyIHIyNDQxODIsIGl0IGhhcyB0byBzY2hlZHVsZVJlbmRlcmluZ1VwZGF0ZSgp LgorICAgICAgICBXaGVuIGl0IGZpcmVzIGl0IHdpbGwgc2NoZWR1bGVDb21wb3NpdGluZ0xheWVy Rmx1c2goKS4KKworICAgICAgICAqIHBhZ2UvUmVuZGVyaW5nVXBkYXRlU2NoZWR1bGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlcmluZ1VwZGF0ZVNjaGVkdWxlcjo6c2NoZWR1bGVSZW5k ZXJpbmdVcGRhdGUpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpzY2hlZHVsZUxh eWVyRmx1c2gpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpkaWRD aGFuZ2VWaXNpYmxlUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0 b3I6OmZyYW1lVmlld0RpZFNjcm9sbCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNv bXBvc2l0b3I6OmF0dGFjaFJvb3RMYXllcik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXll ckNvbXBvc2l0b3I6OnNldExheWVyRmx1c2hUaHJvdHRsaW5nRW5hYmxlZCk6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmxheWVyRmx1c2hUaW1lckZpcmVkKToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6c2NoZWR1bGVMYXllckZsdXNo Tm93KTogRGVsZXRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y Lmg6CisKIDIwMTktMDQtMzAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAg ICAgICAgIE1ha2UgRG9jdW1lbnQgYXVkaW8gcHJvZHVjZXJzIHVzZSBXZWFrUHRyCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wYWdlL1JlbmRlcmluZ1VwZGF0ZVNjaGVkdWxlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9SZW5kZXJpbmdVcGRhdGVTY2hlZHVsZXIuY3BwCShy ZXZpc2lvbiAyNDQ1MDEpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1JlbmRlcmluZ1VwZGF0ZVNj aGVkdWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDYgKzQ3LDEyIEBAIHZvaWQgUmVuZGVy aW5nVXBkYXRlU2NoZWR1bGVyOjpzY2hlZHVsZVIKICAgICBpZiAoaXNTY2hlZHVsZWQoKSkKICAg ICAgICAgcmV0dXJuOwogCisgICAgLy8gT3B0aW1pemUgdGhlIGNhc2Ugd2hlbiBhbiBpbnZpc2li bGUgcGFnZSB3YW50cyBqdXN0IHRvIHNjaGVkdWxlIGxheWVyIGZsdXNoLgorICAgIGlmICghbV9w YWdlLmlzVmlzaWJsZSgpKSB7CisgICAgICAgIHNjaGVkdWxlQ29tcG9zaXRpbmdMYXllckZsdXNo KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICB0cmFjZVBvaW50KFNjaGVkdWxlUmVu ZGVyaW5nVXBkYXRlKTsKIAogI2lmIFVTRShSRVFVRVNUX0FOSU1BVElPTl9GUkFNRV9ESVNQTEFZ X01PTklUT1IpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmNwcAkocmV2aXNpb24gMjQ0NTAxKQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0 OCwxMiArNDQ4LDYgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6Om5vdGlmeUZsdXNoUgog ICAgIHNjaGVkdWxlTGF5ZXJGbHVzaChsYXllci0+Y2FuVGhyb3R0bGVMYXllckZsdXNoKCkpOwog fQogCi12b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6c2NoZWR1bGVMYXllckZsdXNoTm93KCkK LXsKLSAgICBtX2hhc1BlbmRpbmdMYXllckZsdXNoID0gZmFsc2U7Ci0gICAgcGFnZSgpLnJlbmRl cmluZ1VwZGF0ZVNjaGVkdWxlcigpLnNjaGVkdWxlUmVuZGVyaW5nVXBkYXRlKCk7Ci19Ci0KIHZv aWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpzY2hlZHVsZUxheWVyRmx1c2goYm9vbCBjYW5UaHJv dHRsZSkKIHsKICAgICBBU1NFUlQoIW1fZmx1c2hpbmdMYXllcnMpOwpAQCAtNDYxLDExICs0NTUs MTIgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnNjaGVkdWxlTGF5ZQogICAgIGlmIChj YW5UaHJvdHRsZSkKICAgICAgICAgc3RhcnRJbml0aWFsTGF5ZXJGbHVzaFRpbWVySWZOZWVkZWQo KTsKIAotICAgIGlmIChjYW5UaHJvdHRsZSAmJiBpc1Rocm90dGxpbmdMYXllckZsdXNoZXMoKSkg eworICAgIGlmIChjYW5UaHJvdHRsZSAmJiBpc1Rocm90dGxpbmdMYXllckZsdXNoZXMoKSkKKyAg ICAgICAgbV9oYXNQZW5kaW5nTGF5ZXJGbHVzaCA9IGZhbHNlOworICAgIGVsc2UgewogICAgICAg ICBtX2hhc1BlbmRpbmdMYXllckZsdXNoID0gdHJ1ZTsKLSAgICAgICAgcmV0dXJuOworICAgICAg ICBwYWdlKCkucmVuZGVyaW5nVXBkYXRlU2NoZWR1bGVyKCkuc2NoZWR1bGVSZW5kZXJpbmdVcGRh dGUoKTsKICAgICB9Ci0gICAgc2NoZWR1bGVMYXllckZsdXNoTm93KCk7CiB9CiAKIEZsb2F0UmVj dCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnZpc2libGVSZWN0Rm9yTGF5ZXJGbHVzaGluZygpIGNv bnN0CkBAIC01OTUsNyArNTkwLDcgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmRpZENo YW5nZVZpcwogICAgIGJvb2wgcmVxdWlyZXNGbHVzaCA9IHJvb3RMYXllci0+dmlzaWJsZVJlY3RD aGFuZ2VSZXF1aXJlc0ZsdXNoKHZpc2libGVSZWN0KTsKICAgICBMT0dfV0lUSF9TVFJFQU0oQ29t cG9zaXRpbmcsIHN0cmVhbSA8PCAiUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpkaWRDaGFuZ2VWaXNp YmxlUmVjdCAiIDw8IHZpc2libGVSZWN0IDw8ICIgcmVxdWlyZXNGbHVzaCAiIDw8IHJlcXVpcmVz Rmx1c2gpOwogICAgIGlmIChyZXF1aXJlc0ZsdXNoKQotICAgICAgICBzY2hlZHVsZUxheWVyRmx1 c2hOb3coKTsKKyAgICAgICAgc2NoZWR1bGVMYXllckZsdXNoKCk7CiB9CiAKIHZvaWQgUmVuZGVy TGF5ZXJDb21wb3NpdG9yOjpub3RpZnlGbHVzaEJlZm9yZURpc3BsYXlSZWZyZXNoKGNvbnN0IEdy YXBoaWNzTGF5ZXIqKQpAQCAtMTg4OSw3ICsxODg0LDcgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBv c2l0b3I6OmZyYW1lVmlld0RpZAogICAgIC8vIGl0IHdpbGwgYWxzbyBtYW5hZ2UgdXBkYXRpbmcg dGhlIHNjcm9sbCBsYXllciBwb3NpdGlvbi4KICAgICBpZiAoaGFzQ29vcmRpbmF0ZWRTY3JvbGxp bmcoKSkgewogICAgICAgICAvLyBXZSBoYXZlIHRvIHNjaGVkdWxlIGEgZmx1c2ggaW4gb3JkZXIg Zm9yIHRoZSBtYWluIFRpbGVkQmFja2luZyB0byB1cGRhdGUgaXRzIHRpbGUgY292ZXJhZ2UuCi0g ICAgICAgIHNjaGVkdWxlTGF5ZXJGbHVzaE5vdygpOworICAgICAgICBzY2hlZHVsZUxheWVyRmx1 c2goKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIApAQCAtMzc4MCw3ICszNzc1LDcgQEAgdm9p ZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmF0dGFjaFJvb3RMYQogICAgIHJvb3RMYXllckF0dGFj aG1lbnRDaGFuZ2VkKCk7CiAgICAgCiAgICAgaWYgKG1fc2hvdWxkRmx1c2hPblJlYXR0YWNoKSB7 Ci0gICAgICAgIHNjaGVkdWxlTGF5ZXJGbHVzaE5vdygpOworICAgICAgICBzY2hlZHVsZUxheWVy Rmx1c2goKTsKICAgICAgICAgbV9zaG91bGRGbHVzaE9uUmVhdHRhY2ggPSBmYWxzZTsKICAgICB9 CiB9CkBAIC00MzUyLDcgKzQzNDcsNyBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6c2V0 TGF5ZXJGbHVzCiAgICAgbV9sYXllckZsdXNoVGltZXIuc3RvcCgpOwogICAgIGlmICghbV9oYXNQ ZW5kaW5nTGF5ZXJGbHVzaCkKICAgICAgICAgcmV0dXJuOwotICAgIHNjaGVkdWxlTGF5ZXJGbHVz aE5vdygpOworICAgIHNjaGVkdWxlTGF5ZXJGbHVzaCgpOwogfQogCiB2b2lkIFJlbmRlckxheWVy Q29tcG9zaXRvcjo6ZGlzYWJsZUxheWVyRmx1c2hUaHJvdHRsaW5nVGVtcG9yYXJpbHlGb3JJbnRl cmFjdGlvbigpCkBAIC00Mzk1LDcgKzQzOTAsNyBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRv cjo6bGF5ZXJGbHVzaFRpCiB7CiAgICAgaWYgKCFtX2hhc1BlbmRpbmdMYXllckZsdXNoKQogICAg ICAgICByZXR1cm47Ci0gICAgc2NoZWR1bGVMYXllckZsdXNoTm93KCk7CisgICAgc2NoZWR1bGVM YXllckZsdXNoKCk7CiB9CiAKICNpZiBVU0UoUkVRVUVTVF9BTklNQVRJT05fRlJBTUVfRElTUExB WV9NT05JVE9SKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuaAkocmV2aXNpb24gMjQ0NTAxKQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjgsNyAr MTY4LDcgQEAgcHVibGljOgogCiAgICAgLy8gR3JhcGhpY3NMYXllcnMgYnVmZmVyIHN0YXRlLCB3 aGljaCBnZXRzIHB1c2hlZCB0byB0aGUgdW5kZXJseWluZyBwbGF0Zm9ybSBsYXllcnMKICAgICAv LyBhdCBzcGVjaWZpYyB0aW1lcy4KLSAgICB2b2lkIHNjaGVkdWxlTGF5ZXJGbHVzaChib29sIGNh blRocm90dGxlKTsKKyAgICB2b2lkIHNjaGVkdWxlTGF5ZXJGbHVzaChib29sIGNhblRocm90dGxl ID0gZmFsc2UpOwogICAgIHZvaWQgZmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKGJvb2wgaXNGbHVz aFJvb3QgPSB0cnVlKTsKIAogICAgIC8vIENhbGxlZCB3aGVuIHRoZSBHcmFwaGljc0xheWVyIGZv ciB0aGUgZ2l2ZW4gUmVuZGVyTGF5ZXIgaGFzIGZsdXNoZWQgY2hhbmdlcyBpbnNpZGUgb2YgZmx1 c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKCkuCkBAIC01MjYsNyArNTI2LDYgQEAgcHJpdmF0ZToKIAog ICAgIGJvb2wgc2hvdWxkQ29tcG9zaXRlT3ZlcmZsb3dDb250cm9scygpIGNvbnN0OwogCi0gICAg dm9pZCBzY2hlZHVsZUxheWVyRmx1c2hOb3coKTsKICAgICBib29sIGlzVGhyb3R0bGluZ0xheWVy Rmx1c2hlcygpIGNvbnN0OwogICAgIHZvaWQgc3RhcnRJbml0aWFsTGF5ZXJGbHVzaFRpbWVySWZO ZWVkZWQoKTsKICAgICB2b2lkIHN0YXJ0TGF5ZXJGbHVzaFRpbWVySWZOZWVkZWQoKTsK 368684 2019-05-01 10:26:39 -0700 2019-05-01 12:31:11 -0700 Patch bug-197451-20190501102638.patch text/plain 6769 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NDgxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQxIEBACisyMDE5LTA0LTMwICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TiAocjI0NDE4Mik6IFJlbmRlcmluZ1VwZGF0ZSBzaG91bGQgbm90IGJlIHNjaGVkdWxlZCBmb3Ig aW52aXNpYmxlIHBhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTc0NTEKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAg ICAgICAgQmVmb3JlIHIyNDQxODIsIHNvbWUgd2ViIHBhZ2VzIG5ldmVyIG5lZWQgdG8gc2NoZWR1 bGUgYSBSZW5kZXJpbmdVcGRhdGUuCisgICAgICAgIE9ubHkgcGFnZXMgd2l0aCByQUYgY2FsbGJh Y2tzLCB3ZWIgYW5pbWF0aW9ucywgaW50ZXJzZWN0aW9uIGFuZCByZXNpemUgCisgICAgICAgIG9i c2VydmVycyBuZWVkZWQgdG8gZG8gc28uIEFmdGVyIHIyNDQxODIsIGFsbCBwYWdlcyBoYXZlIHRv IHNjaGVkdWxlIGEKKyAgICAgICAgUmVuZGVyaW5nVXBkYXRlIHdoZW4gYSBwYWdlIHJlbmRlcmlu ZyB1cGRhdGUgaXMgcmVxdWlyZWQuCisKKyAgICAgICAgV2hlbiBTYWZhcmkgb3BlbnMsIGl0IGNy ZWF0ZSBhICdibGFuaycgd2ViIHBhZ2UuIFRoZSBibGFuayBwYWdlIHdpbGwgbm90CisgICAgICAg IGJlIHZpc2libGUgdW5sZXNzIHRoZSB1c2VyIHNlbGVjdHMgdG8gc2hvdyB0aGUgJ0VtcHR5IHBh Z2UnIGluIHRoZSBuZXcKKyAgICAgICAgdGFiLiBBbHRob3VnaCB0aGUgYmxhbmsgcGFnZSBpcyBu b3QgdmlzaWJsZSwgdGhlIGxvYWRlciBuZWVkcyB0byByZXNvbHZlU3R5bGUoKQorICAgICAgICB3 aGljaCByZXF1aXJlcyB0byBzY2hlZHVsZUxheWVyRmx1c2hOb3coKS4gCisKKyAgICAgICAgV2Ug bmVlZCB0byBvcHRpbWl6ZSB0aGlzIGNhc2U6IGNhbGxpbmcgc2NoZWR1bGVMYXllckZsdXNoTm93 KCkgZm9yIGludmlzaWJsZQorICAgICAgICBwYWdlcy4gV2UgZG8gdGhhdCBieSBjaGVja2luZyBp ZiB0aGUgcGFnZSBpcyB2aXNpYmxlIGJlZm9yZSBzY2hlZHVsaW5nCisgICAgICAgIHRoZSBSZW5k ZXJpbmdVcGRhdGUuCisKKyAgICAgICAgQWxzbyB3ZSBuZWVkIHRvIGNoYW5nZSBvciBnZXQgcmlk IG9mIHNjaGVkdWxlTGF5ZXJGbHVzaE5vdygpIHNpbmNlIGl0cyBuYW1lCisgICAgICAgIGhhcyBi ZWNvbWUgY29uZnVzaW5nLiBJdCBzdWdnZXN0cyB0aGF0IGl0IGlzIGdvaW5nIHRvIHNjaGVkdWxl IGZsdXNoaW5nCisgICAgICAgIHRoZSBsYXllciAnbm93Jy4gQnV0IGFmdGVyIHIyNDQxODIsIGl0 IGRvZXMgc2NoZWR1bGVSZW5kZXJpbmdVcGRhdGUoKSBmaXJzdC4KKyAgICAgICAgQW5kIHdoZW4g aXQgZmlyZXMsIHNjaGVkdWxlQ29tcG9zaXRpbmdMYXllckZsdXNoKCkgd2lsbCBiZSBjYWxsZWQu CisKKyAgICAgICAgKiBwYWdlL1JlbmRlcmluZ1VwZGF0ZVNjaGVkdWxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJpbmdVcGRhdGVTY2hlZHVsZXI6OnNjaGVkdWxlUmVuZGVyaW5nVXBk YXRlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6c2NoZWR1bGVMYXllckZsdXNo KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZGlkQ2hhbmdlVmlz aWJsZVJlY3QpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpmcmFt ZVZpZXdEaWRTY3JvbGwpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9y OjphdHRhY2hSb290TGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3Np dG9yOjpzZXRMYXllckZsdXNoVGhyb3R0bGluZ0VuYWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpsYXllckZsdXNoVGltZXJGaXJlZCk6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnNjaGVkdWxlTGF5ZXJGbHVzaE5vdyk6IERl bGV0ZWQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oOgorCiAy MDE5LTA0LTMwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBN YWtlIERvY3VtZW50IGF1ZGlvIHByb2R1Y2VycyB1c2UgV2Vha1B0cgpJbmRleDogU291cmNlL1dl YkNvcmUvcGFnZS9SZW5kZXJpbmdVcGRhdGVTY2hlZHVsZXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BhZ2UvUmVuZGVyaW5nVXBkYXRlU2NoZWR1bGVyLmNwcAkocmV2aXNpb24g MjQ0NTAxKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9SZW5kZXJpbmdVcGRhdGVTY2hlZHVsZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw2ICs0NywxMiBAQCB2b2lkIFJlbmRlcmluZ1VwZGF0 ZVNjaGVkdWxlcjo6c2NoZWR1bGVSCiAgICAgaWYgKGlzU2NoZWR1bGVkKCkpCiAgICAgICAgIHJl dHVybjsKIAorICAgIC8vIE9wdGltaXplIHRoZSBjYXNlIHdoZW4gYW4gaW52aXNpYmxlIHBhZ2Ug d2FudHMganVzdCB0byBzY2hlZHVsZSBsYXllciBmbHVzaC4KKyAgICBpZiAoIW1fcGFnZS5pc1Zp c2libGUoKSkgeworICAgICAgICBzY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJGbHVzaCgpOworICAg ICAgICByZXR1cm47CisgICAgfQorCiAgICAgdHJhY2VQb2ludChTY2hlZHVsZVJlbmRlcmluZ1Vw ZGF0ZSk7CiAKICNpZiBVU0UoUkVRVUVTVF9BTklNQVRJT05fRlJBTUVfRElTUExBWV9NT05JVE9S KQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5jcHAJKHJldmlzaW9uIDI0NDUwMSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDgsMTIgKzQ0 OCw2IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpub3RpZnlGbHVzaFIKICAgICBzY2hl ZHVsZUxheWVyRmx1c2gobGF5ZXItPmNhblRocm90dGxlTGF5ZXJGbHVzaCgpKTsKIH0KIAotdm9p ZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnNjaGVkdWxlTGF5ZXJGbHVzaE5vdygpCi17Ci0gICAg bV9oYXNQZW5kaW5nTGF5ZXJGbHVzaCA9IGZhbHNlOwotICAgIHBhZ2UoKS5yZW5kZXJpbmdVcGRh dGVTY2hlZHVsZXIoKS5zY2hlZHVsZVJlbmRlcmluZ1VwZGF0ZSgpOwotfQotCiB2b2lkIFJlbmRl ckxheWVyQ29tcG9zaXRvcjo6c2NoZWR1bGVMYXllckZsdXNoKGJvb2wgY2FuVGhyb3R0bGUpCiB7 CiAgICAgQVNTRVJUKCFtX2ZsdXNoaW5nTGF5ZXJzKTsKQEAgLTQ2MSwxMSArNDU1LDEyIEBAIHZv aWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpzY2hlZHVsZUxheWUKICAgICBpZiAoY2FuVGhyb3R0 bGUpCiAgICAgICAgIHN0YXJ0SW5pdGlhbExheWVyRmx1c2hUaW1lcklmTmVlZGVkKCk7CiAKLSAg ICBpZiAoY2FuVGhyb3R0bGUgJiYgaXNUaHJvdHRsaW5nTGF5ZXJGbHVzaGVzKCkpIHsKKyAgICBp ZiAoY2FuVGhyb3R0bGUgJiYgaXNUaHJvdHRsaW5nTGF5ZXJGbHVzaGVzKCkpCiAgICAgICAgIG1f aGFzUGVuZGluZ0xheWVyRmx1c2ggPSB0cnVlOwotICAgICAgICByZXR1cm47CisgICAgZWxzZSB7 CisgICAgICAgIG1faGFzUGVuZGluZ0xheWVyRmx1c2ggPSBmYWxzZTsKKyAgICAgICAgcGFnZSgp LnJlbmRlcmluZ1VwZGF0ZVNjaGVkdWxlcigpLnNjaGVkdWxlUmVuZGVyaW5nVXBkYXRlKCk7CiAg ICAgfQotICAgIHNjaGVkdWxlTGF5ZXJGbHVzaE5vdygpOwogfQogCiBGbG9hdFJlY3QgUmVuZGVy TGF5ZXJDb21wb3NpdG9yOjp2aXNpYmxlUmVjdEZvckxheWVyRmx1c2hpbmcoKSBjb25zdApAQCAt NTk1LDcgKzU5MCw3IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpkaWRDaGFuZ2VWaXMK ICAgICBib29sIHJlcXVpcmVzRmx1c2ggPSByb290TGF5ZXItPnZpc2libGVSZWN0Q2hhbmdlUmVx dWlyZXNGbHVzaCh2aXNpYmxlUmVjdCk7CiAgICAgTE9HX1dJVEhfU1RSRUFNKENvbXBvc2l0aW5n LCBzdHJlYW0gPDwgIlJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZGlkQ2hhbmdlVmlzaWJsZVJlY3Qg IiA8PCB2aXNpYmxlUmVjdCA8PCAiIHJlcXVpcmVzRmx1c2ggIiA8PCByZXF1aXJlc0ZsdXNoKTsK ICAgICBpZiAocmVxdWlyZXNGbHVzaCkKLSAgICAgICAgc2NoZWR1bGVMYXllckZsdXNoTm93KCk7 CisgICAgICAgIHNjaGVkdWxlTGF5ZXJGbHVzaCgpOwogfQogCiB2b2lkIFJlbmRlckxheWVyQ29t cG9zaXRvcjo6bm90aWZ5Rmx1c2hCZWZvcmVEaXNwbGF5UmVmcmVzaChjb25zdCBHcmFwaGljc0xh eWVyKikKQEAgLTE4ODksNyArMTg4NCw3IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpm cmFtZVZpZXdEaWQKICAgICAvLyBpdCB3aWxsIGFsc28gbWFuYWdlIHVwZGF0aW5nIHRoZSBzY3Jv bGwgbGF5ZXIgcG9zaXRpb24uCiAgICAgaWYgKGhhc0Nvb3JkaW5hdGVkU2Nyb2xsaW5nKCkpIHsK ICAgICAgICAgLy8gV2UgaGF2ZSB0byBzY2hlZHVsZSBhIGZsdXNoIGluIG9yZGVyIGZvciB0aGUg bWFpbiBUaWxlZEJhY2tpbmcgdG8gdXBkYXRlIGl0cyB0aWxlIGNvdmVyYWdlLgotICAgICAgICBz Y2hlZHVsZUxheWVyRmx1c2hOb3coKTsKKyAgICAgICAgc2NoZWR1bGVMYXllckZsdXNoKCk7CiAg ICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTM3ODAsNyArMzc3NSw3IEBAIHZvaWQgUmVuZGVy TGF5ZXJDb21wb3NpdG9yOjphdHRhY2hSb290TGEKICAgICByb290TGF5ZXJBdHRhY2htZW50Q2hh bmdlZCgpOwogICAgIAogICAgIGlmIChtX3Nob3VsZEZsdXNoT25SZWF0dGFjaCkgewotICAgICAg ICBzY2hlZHVsZUxheWVyRmx1c2hOb3coKTsKKyAgICAgICAgc2NoZWR1bGVMYXllckZsdXNoKCk7 CiAgICAgICAgIG1fc2hvdWxkRmx1c2hPblJlYXR0YWNoID0gZmFsc2U7CiAgICAgfQogfQpAQCAt NDM1Miw3ICs0MzQ3LDcgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnNldExheWVyRmx1 cwogICAgIG1fbGF5ZXJGbHVzaFRpbWVyLnN0b3AoKTsKICAgICBpZiAoIW1faGFzUGVuZGluZ0xh eWVyRmx1c2gpCiAgICAgICAgIHJldHVybjsKLSAgICBzY2hlZHVsZUxheWVyRmx1c2hOb3coKTsK KyAgICBzY2hlZHVsZUxheWVyRmx1c2goKTsKIH0KIAogdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0 b3I6OmRpc2FibGVMYXllckZsdXNoVGhyb3R0bGluZ1RlbXBvcmFyaWx5Rm9ySW50ZXJhY3Rpb24o KQpAQCAtNDM5NSw3ICs0MzkwLDcgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmxheWVy Rmx1c2hUaQogewogICAgIGlmICghbV9oYXNQZW5kaW5nTGF5ZXJGbHVzaCkKICAgICAgICAgcmV0 dXJuOwotICAgIHNjaGVkdWxlTGF5ZXJGbHVzaE5vdygpOworICAgIHNjaGVkdWxlTGF5ZXJGbHVz aCgpOwogfQogCiAjaWYgVVNFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FX0RJU1BMQVlfTU9OSVRP UikKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmgJKHJldmlzaW9uIDI0NDUwMSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckNvbXBvc2l0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMTY4LDcgKzE2OCw3IEBA IHB1YmxpYzoKIAogICAgIC8vIEdyYXBoaWNzTGF5ZXJzIGJ1ZmZlciBzdGF0ZSwgd2hpY2ggZ2V0 cyBwdXNoZWQgdG8gdGhlIHVuZGVybHlpbmcgcGxhdGZvcm0gbGF5ZXJzCiAgICAgLy8gYXQgc3Bl Y2lmaWMgdGltZXMuCi0gICAgdm9pZCBzY2hlZHVsZUxheWVyRmx1c2goYm9vbCBjYW5UaHJvdHRs ZSk7CisgICAgdm9pZCBzY2hlZHVsZUxheWVyRmx1c2goYm9vbCBjYW5UaHJvdHRsZSA9IGZhbHNl KTsKICAgICB2b2lkIGZsdXNoUGVuZGluZ0xheWVyQ2hhbmdlcyhib29sIGlzRmx1c2hSb290ID0g dHJ1ZSk7CiAKICAgICAvLyBDYWxsZWQgd2hlbiB0aGUgR3JhcGhpY3NMYXllciBmb3IgdGhlIGdp dmVuIFJlbmRlckxheWVyIGhhcyBmbHVzaGVkIGNoYW5nZXMgaW5zaWRlIG9mIGZsdXNoUGVuZGlu Z0xheWVyQ2hhbmdlcygpLgpAQCAtNTI2LDcgKzUyNiw2IEBAIHByaXZhdGU6CiAKICAgICBib29s IHNob3VsZENvbXBvc2l0ZU92ZXJmbG93Q29udHJvbHMoKSBjb25zdDsKIAotICAgIHZvaWQgc2No ZWR1bGVMYXllckZsdXNoTm93KCk7CiAgICAgYm9vbCBpc1Rocm90dGxpbmdMYXllckZsdXNoZXMo KSBjb25zdDsKICAgICB2b2lkIHN0YXJ0SW5pdGlhbExheWVyRmx1c2hUaW1lcklmTmVlZGVkKCk7 CiAgICAgdm9pZCBzdGFydExheWVyRmx1c2hUaW1lcklmTmVlZGVkKCk7Cg==