197437 2019-04-30 13:35:13 -0700 Add memory-limited skipping to some tests generating very large strings 2019-05-01 10:43:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned commit-queue lforschler mark.lam ross.kirsling webkit-bug-importer ysuzuki oldest_to_newest 1531682 0 stephan.szabo 2019-04-30 13:35:13 -0700 These three tests showed up as failing on PlayStation due to failing allocations, they each seem to try to make a 1 gig or larger string with padEnd or repeat, so seem like they should also fail in other highly memory limited environments. Some other tests doing similar things (such as stress/string-overflow-createError.js) have been marked skip if $memoryLimited. 1531683 1 368603 stephan.szabo 2019-04-30 13:37:44 -0700 Created attachment 368603 Patch Add // @skip if $memoryLimited for stress/StringObject-define-length-getter-rope-string-oom.js stress/create-error-out-of-memory-rope-string.js stress/string-16bit-repeat-overflow.js 1531737 2 368603 ross.kirsling 2019-04-30 15:40:26 -0700 Comment on attachment 368603 Patch Looking through other stress tests with values like 2147483644, it certainly appears that this trio was simply overlooked. 1531982 3 368603 commit-queue 2019-05-01 10:42:57 -0700 Comment on attachment 368603 Patch Clearing flags on attachment: 368603 Committed r244832: <https://trac.webkit.org/changeset/244832> 1531983 4 commit-queue 2019-05-01 10:42:58 -0700 All reviewed patches have been landed. Closing bug. 1531984 5 webkit-bug-importer 2019-05-01 10:43:16 -0700 <rdar://problem/50374075> 368603 2019-04-30 13:37:44 -0700 2019-05-01 10:42:57 -0700 Patch 197437.1.diff text/plain 1922 stephan.szabo ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg YzNkYTE2MTE0NGUuLjhkZmRmMDQwMjE4IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZwor KysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA0LTMwICBTdGVw aGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBBZGQgbWVtb3J5 LWxpbWl0ZWQgc2tpcHBpbmcgdG8gc29tZSB0ZXN0cyBnZW5lcmF0aW5nIHZlcnkgbGFyZ2Ugc3Ry aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3 NDM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBz dHJlc3MvU3RyaW5nT2JqZWN0LWRlZmluZS1sZW5ndGgtZ2V0dGVyLXJvcGUtc3RyaW5nLW9vbS5q czoKKyAgICAgICAgKiBzdHJlc3MvY3JlYXRlLWVycm9yLW91dC1vZi1tZW1vcnktcm9wZS1zdHJp bmcuanM6CisgICAgICAgICogc3RyZXNzL3N0cmluZy0xNmJpdC1yZXBlYXQtb3ZlcmZsb3cuanM6 CisKIDIwMTktMDQtMTkgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAg ICAgQWJzdHJhY3RWYWx1ZSBjYW4gcmVwcmVzZW50IG1vcmUgdGhhbiBpbnQ1MgpkaWZmIC0tZ2l0 IGEvSlNUZXN0cy9zdHJlc3MvU3RyaW5nT2JqZWN0LWRlZmluZS1sZW5ndGgtZ2V0dGVyLXJvcGUt c3RyaW5nLW9vbS5qcyBiL0pTVGVzdHMvc3RyZXNzL1N0cmluZ09iamVjdC1kZWZpbmUtbGVuZ3Ro LWdldHRlci1yb3BlLXN0cmluZy1vb20uanMKaW5kZXggZTdlNzA2YzBmZTguLjk2NTMyNDcyZmQ2 IDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9TdHJpbmdPYmplY3QtZGVmaW5lLWxlbmd0aC1n ZXR0ZXItcm9wZS1zdHJpbmctb29tLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL1N0cmluZ09iamVj dC1kZWZpbmUtbGVuZ3RoLWdldHRlci1yb3BlLXN0cmluZy1vb20uanMKQEAgLTEsMyArMSw0IEBA CisvL0Agc2tpcCBpZiAkbWVtb3J5TGltaXRlZAogdHJ5IHsKICAgICBsZXQgY2hhcjE2ID0gZGVj b2RlVVJJKCclRTclOUElODQnKTsKICAgICBsZXQgcm9wZSA9IGNoYXIxNi5wYWRFbmQoMjE0NzQ4 MzY0NCwgMSk7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9jcmVhdGUtZXJyb3Itb3V0LW9m LW1lbW9yeS1yb3BlLXN0cmluZy5qcyBiL0pTVGVzdHMvc3RyZXNzL2NyZWF0ZS1lcnJvci1vdXQt b2YtbWVtb3J5LXJvcGUtc3RyaW5nLmpzCmluZGV4IDMzZmZmN2MxYWI5Li44MWQ4ODE3ZGRmMyAx MDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3MvY3JlYXRlLWVycm9yLW91dC1vZi1tZW1vcnktcm9w ZS1zdHJpbmcuanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvY3JlYXRlLWVycm9yLW91dC1vZi1tZW1v cnktcm9wZS1zdHJpbmcuanMKQEAgLTEsMyArMSw0IEBACisvL0Agc2tpcCBpZiAkbWVtb3J5TGlt aXRlZAogZnVuY3Rpb24gYXNzZXJ0KGEsIG1lc3NhZ2UpIHsKICAgICBpZiAoIWEpCiAgICAgICAg IHRocm93IG5ldyBFcnJvcihtZXNzYWdlKTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3N0 cmluZy0xNmJpdC1yZXBlYXQtb3ZlcmZsb3cuanMgYi9KU1Rlc3RzL3N0cmVzcy9zdHJpbmctMTZi aXQtcmVwZWF0LW92ZXJmbG93LmpzCmluZGV4IGJjNzI0ZmJmNjJiLi5mN2M0MWM4N2MyZSAxMDA2 NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3Mvc3RyaW5nLTE2Yml0LXJlcGVhdC1vdmVyZmxvdy5qcwor KysgYi9KU1Rlc3RzL3N0cmVzcy9zdHJpbmctMTZiaXQtcmVwZWF0LW92ZXJmbG93LmpzCkBAIC0x LDMgKzEsNCBAQAorLy9AIHNraXAgaWYgJG1lbW9yeUxpbWl0ZWQKIHZhciBleGNlcHRpb247CiB0 cnkgewogICAgIHByaW50KCdcdWQwMDAnLnJlcGVhdCgyKiozMCkpOwo=