197425 2019-04-30 11:08:32 -0700 [Mac WK2 Debug] Layout Test scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html is a flaky failure 2019-05-31 16:20:49 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sroberts simon.fraser fred.wang jlewis3 koivisto lforschler ryanhaddad simon.fraser thorton tsavell webkit-bug-importer oldest_to_newest 1531591 0 sroberts 2019-04-30 11:08:32 -0700 The following layout test is flaky on Mojave WK2 Debug scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html Probable cause: Test was added in https://trac.webkit.org/r240505 , then appears to be rebaselined in https://trac.webkit.org/r240536 . Test is a flaky failure in all available dashboard history I cannot reproduce it locally with 500 iterations, and even when running with test list from worker. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=scrollingcoordinator%2Fscrolling-tree%2Fscrolling-tree-includes-frame.html Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-actual.txt @@ -13,29 +13,6 @@ (min layout viewport origin (0,0)) (max layout viewport origin (0,0)) (behavior for fixed 0) - (children 1 - (Frame hosting node - (parent relative scrollable rect at (0,0) size 100x200) - (children 1 - (Frame scrolling node - (scrollable area size 85 185) - (contents size 308 416) - (parent relative scrollable rect at (0,0) size 100x200) - (scrollable area parameters - (horizontal scroll elasticity 0) - (vertical scroll elasticity 0) - (horizontal scrollbar mode 0) - (vertical scrollbar mode 0) - (has enabled horizontal scrollbar 1) - (has enabled vertical scrollbar 1)) - (layout viewport at (0,0) size 85x185) - (min layout viewport origin (0,0)) - (max layout viewport origin (223,231)) - (behavior for fixed 0) - ) - ) - ) - ) ) 1531593 1 webkit-bug-importer 2019-04-30 11:09:17 -0700 <rdar://problem/50342107> 1531598 2 sroberts 2019-04-30 11:18:31 -0700 Updated test expectations in https://trac.webkit.org/changeset/244786/webkit 1540886 3 371095 simon.fraser 2019-05-31 16:19:34 -0700 Created attachment 371095 Patch 1540887 4 simon.fraser 2019-05-31 16:20:43 -0700 Speculative fix landed in https://trac.webkit.org/r245994 371095 2019-05-31 16:19:34 -0700 2019-05-31 16:20:49 -0700 Patch bug-197425-20190531161933.patch text/plain 2194 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1OTkwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODI5NmIwYzU3YjgxNGM4Mjg4YTAw ZmQ5NGVkNzk1NWRmOTdhODFiZi4uMTM2YWQxNTJiYjBiZDc4MjMyN2U4NTkzZTc0NmMxZjdlNTMz Zjk4OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA1LTMxICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWMgV0syIERlYnVnXSBMYXlvdXQg VGVzdCBzY3JvbGxpbmdjb29yZGluYXRvci9zY3JvbGxpbmctdHJlZS9zY3JvbGxpbmctdHJlZS1p bmNsdWRlcy1mcmFtZS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NDI1CisKKyAgICAgICAgVW5yZXZpZXdl ZCB0ZXN0IGdhcmRlbmluZy4KKyAgICAgICAgCisgICAgICAgIFNwZWN1bGF0aXZlIGZpeCBmb3Ig Zmxha2V5IHRlc3Q7IHRyaWdnZXIgbGF5b3V0IGluc2lkZSB0aGUgc3ViZnJhbWUuCisKKyAgICAg ICAgKiBzY3JvbGxpbmdjb29yZGluYXRvci9zY3JvbGxpbmctdHJlZS9zY3JvbGxpbmctdHJlZS1p bmNsdWRlcy1mcmFtZS5odG1sOgorCiAyMDE5LTA1LTMxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIGlPUzogTWFpbiBmcmFtZSBzaG91bGQgYmUgc2Nyb2xsYWJs ZSB3aGVuIHBpbmNoIHpvb21lZCBvciBzb2Z0d2FyZSBrZXlib2FyZCBpcyB1cApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvc2Nyb2xsaW5nY29vcmRpbmF0b3Ivc2Nyb2xsaW5nLXRyZWUvc2Nyb2xs aW5nLXRyZWUtaW5jbHVkZXMtZnJhbWUuaHRtbCBiL0xheW91dFRlc3RzL3Njcm9sbGluZ2Nvb3Jk aW5hdG9yL3Njcm9sbGluZy10cmVlL3Njcm9sbGluZy10cmVlLWluY2x1ZGVzLWZyYW1lLmh0bWwK aW5kZXggNGJiMmQxOTAwMDU2MTIwZTQ1MDA5NWY0MjM3Y2NkMjVmNGZkNWY5MS4uYWY2NTFhYjk4 OGY1ZmUxNDQ4ODMyYmM0NzU5ZjU4YTRiNjkxZTgxNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv c2Nyb2xsaW5nY29vcmRpbmF0b3Ivc2Nyb2xsaW5nLXRyZWUvc2Nyb2xsaW5nLXRyZWUtaW5jbHVk ZXMtZnJhbWUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9zY3JvbGxpbmdjb29yZGluYXRvci9zY3Jv bGxpbmctdHJlZS9zY3JvbGxpbmctdHJlZS1pbmNsdWRlcy1mcmFtZS5odG1sCkBAIC0xMSw4ICsx MSwxMSBAQAogICAgICAgICAgIHdpbmRvdy5pbnRlcm5hbHMuc2V0dGluZ3Muc2V0QXN5bmNGcmFt ZVNjcm9sbGluZ0VuYWJsZWQodHJ1ZSk7CiAgICAgICBmdW5jdGlvbiBkb1Rlc3QoKQogICAgICAg ewotICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQotICAgICAgICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnc2Nyb2xsaW5nVHJlZScpLmlubmVyVGV4dCA9IHdpbmRvdy5pbnRl cm5hbHMuc2Nyb2xsaW5nU3RhdGVUcmVlQXNUZXh0KCkgKyAiXG4iOworICAgICAgICAgIGlmICh3 aW5kb3cuaW50ZXJuYWxzKSB7CisJCQkgIHN1YmZyYW1lLmNvbnRlbnRXaW5kb3cuaW50ZXJuYWxz LnNjcm9sbGluZ1N0YXRlVHJlZUFzVGV4dCgpOyAvLyBUcmlnZ2VyIGZyYW1lIGxheW91dC4KKyAg ICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Njcm9sbGluZ1RyZWUnKS5pbm5l clRleHQgPSBpbnRlcm5hbHMuc2Nyb2xsaW5nU3RhdGVUcmVlQXNUZXh0KCkgKyAiXG4iOworICAg ICAgICAgIH0KKwogICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKICAgICAgICAgICAg ICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CiAgICAgICB9CkBAIC0zMSw3ICszNCw3IEBACiAg ICAgPC9zdHlsZT4KICAgPC9oZWFkPgogICA8Ym9keT4KLSAgICA8aWZyYW1lIG9ubG9hZD0iZG9U ZXN0KCkiIHNyY2RvYz0iCisgICAgPGlmcmFtZSBpZD0ic3ViZnJhbWUiIG9ubG9hZD0iZG9UZXN0 KCkiIHNyY2RvYz0iCiAgICAgICAgIDxkaXYgc3R5bGU9J3dpZHRoOiAzMDBweDsgaGVpZ2h0OiA0 MDBweDsgYmFja2dyb3VuZDogZ3JheTsnPjwvZGl2PiI+CiAgICAgPC9pZnJhbWU+CiAgICAgPHBy ZSBpZD0ic2Nyb2xsaW5nVHJlZSI+PC9wcmU+Cg==