197423 2019-04-30 10:54:44 -0700 [ews-build] Parse and display bindings test failures 2019-04-30 11:34:21 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1531578 0 aakash_jain 2019-04-30 10:54:44 -0700 Bindings tests queue should parse the test failures from the json output, and include that information in step and build status. 1531580 1 368578 aakash_jain 2019-04-30 10:56:13 -0700 Created attachment 368578 Patch 1531584 2 aakash_jain 2019-04-30 11:00:16 -0700 Sample runs: Patch with bindings test failures: https://ews-build.webkit-uat.org/#/builders/21/builds/4802 Patch without bindings test failures: https://ews-build.webkit-uat.org/#/builders/21/builds/4801 1531588 3 368578 lforschler 2019-04-30 11:06:34 -0700 Comment on attachment 368578 Patch lgtm... I'm curious about the timeout. how long do these normally take to run? 1531595 4 aakash_jain 2019-04-30 11:13:08 -0700 > lgtm... I'm curious about the timeout. how long do these normally take to run? Usually takes a minute or two to run. Timeout is for the amount of time without any output, in case the script/machine is hanging/slow for any reason. 1531597 5 ews-watchlist 2019-04-30 11:14:58 -0700 Attachment 368578 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:470: [RunBindingsTests.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:478: [RunBindingsTests.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:478: [RunBindingsTests.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:479: [RunBindingsTests.getResultSummary] Instance of 'RunBindingsTests' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:303: [TestRunBindingsTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:303: [TestRunBindingsTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1531601 6 368578 commit-queue 2019-04-30 11:33:35 -0700 Comment on attachment 368578 Patch Clearing flags on attachment: 368578 Committed r244789: <https://trac.webkit.org/changeset/244789> 1531602 7 commit-queue 2019-04-30 11:33:37 -0700 All reviewed patches have been landed. Closing bug. 1531604 8 webkit-bug-importer 2019-04-30 11:34:21 -0700 <rdar://problem/50343367> 368578 2019-04-30 10:56:13 -0700 2019-04-30 11:33:35 -0700 Patch bug-197423-20190430135613.patch text/plain 4444 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDc4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTA0LTMwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBQYXJzZSBhbmQgZGlzcGxheSBiaW5kaW5ncyB0ZXN0 IGZhaWx1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTc0MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKFJ1bkJp bmRpbmdzVGVzdHMuX19pbml0X18pOiBTZXQgdGltZW91dCBvZiA1IG1pbnV0ZXMuCisgICAgICAg IChSdW5CaW5kaW5nc1Rlc3RzLnN0YXJ0KTogSW5pdGlhbGl6ZSBsb2dfb2JzZXJ2ZXIgZm9yIGpz b24gb3V0cHV0LgorICAgICAgICAoUnVuQmluZGluZ3NUZXN0cy5nZXRSZXN1bHRTdW1tYXJ5KTog VXBkYXRlIHN0ZXAgYW5kIGJ1aWxkIHN1bW1hcnkgYmFzZWQgb24gYmluZGluZ3MgdGVzdCByZXN1 bHRzLgorICAgICAgICAoUnVuQmluZGluZ3NUZXN0cy5fYWRkVG9Mb2cpOiBNZXRob2QgdG8gYWRk IG1lc3NhZ2UgdG8gbG9nLgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weTogVXBkYXRlZCB1bml0LXRlc3QgYWNjb3JkaW5nbHkuCisKIDIwMTkt MDQtMzAgIFBhYmxvIFNhYXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZC4gQWRkIG15c2VsZiBhcyBhIGNvbW1pdHRlci4KSW5kZXg6IFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI0NDc3OCkKKysrIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpA QCAtNDY3LDYgKzQ2Nyw0NSBAQCBjbGFzcyBSdW5CaW5kaW5nc1Rlc3RzKHNoZWxsLlNoZWxsQ29t bWFuCiAgICAgbG9nZmlsZXMgPSB7J2pzb24nOiBqc29uRmlsZU5hbWV9CiAgICAgY29tbWFuZCA9 IFsnVG9vbHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMnLCAnLS1qc29uLW91dHB1dD17MH0n LmZvcm1hdChqc29uRmlsZU5hbWUpXQogCisgICAgZGVmIF9faW5pdF9fKHNlbGYsICoqa3dhcmdz KToKKyAgICAgICAgc3VwZXIoUnVuQmluZGluZ3NUZXN0cywgc2VsZikuX19pbml0X18odGltZW91 dD01ICogNjAsICoqa3dhcmdzKQorCisgICAgZGVmIHN0YXJ0KHNlbGYpOgorICAgICAgICBzZWxm LmxvZ19vYnNlcnZlciA9IGxvZ29ic2VydmVyLkJ1ZmZlckxvZ09ic2VydmVyKCkKKyAgICAgICAg c2VsZi5hZGRMb2dPYnNlcnZlcignanNvbicsIHNlbGYubG9nX29ic2VydmVyKQorICAgICAgICBy ZXR1cm4gc2hlbGwuU2hlbGxDb21tYW5kLnN0YXJ0KHNlbGYpCisKKyAgICBkZWYgZ2V0UmVzdWx0 U3VtbWFyeShzZWxmKToKKyAgICAgICAgaWYgc2VsZi5yZXN1bHRzID09IFNVQ0NFU1M6CisgICAg ICAgICAgICBtZXNzYWdlID0gJ1Bhc3NlZCBiaW5kaW5ncyB0ZXN0cycKKyAgICAgICAgICAgIHNl bGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbbWVzc2FnZV0sIFNVQ0NFU1MpCisgICAgICAgICAgICBy ZXR1cm4ge3Unc3RlcCc6IHVuaWNvZGUobWVzc2FnZSl9CisKKyAgICAgICAgbG9nTGluZXMgPSBz ZWxmLmxvZ19vYnNlcnZlci5nZXRTdGRvdXQoKQorICAgICAgICBqc29uX3RleHQgPSAnJy5qb2lu KFtsaW5lIGZvciBsaW5lIGluIGxvZ0xpbmVzLnNwbGl0bGluZXMoKV0pCisgICAgICAgIHRyeToK KyAgICAgICAgICAgIHdlYmtpdHB5X3Jlc3VsdHMgPSBqc29uLmxvYWRzKGpzb25fdGV4dCkKKyAg ICAgICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBleDoKKyAgICAgICAgICAgIHNlbGYuX2FkZFRvTG9n KCdzdGRlcnInLCAnRVJST1I6IHVuYWJsZSB0byBwYXJzZSBkYXRhLCBleGNlcHRpb246IHt9Jy5m b3JtYXQoZXgpKQorICAgICAgICAgICAgcmV0dXJuIHN1cGVyKFJ1bkJpbmRpbmdzVGVzdHMsIHNl bGYpLmdldFJlc3VsdFN1bW1hcnkoKQorCisgICAgICAgIGZhaWx1cmVzID0gd2Via2l0cHlfcmVz dWx0cy5nZXQoJ2ZhaWx1cmVzJykKKyAgICAgICAgaWYgbm90IGZhaWx1cmVzOgorICAgICAgICAg ICAgcmV0dXJuIHN1cGVyKFJ1bkJpbmRpbmdzVGVzdHMsIHNlbGYpLmdldFJlc3VsdFN1bW1hcnko KQorICAgICAgICBwbHVyYWxTdWZmaXggPSAncycgaWYgbGVuKGZhaWx1cmVzKSA+IDEgZWxzZSAn JworICAgICAgICBmYWlsdXJlc19zdHJpbmcgPSAnLCAnLmpvaW4oW2ZhaWx1cmUucmVwbGFjZSgn KEpTKSAnLCAnJykgZm9yIGZhaWx1cmUgaW4gZmFpbHVyZXNdKQorICAgICAgICBtZXNzYWdlID0g J0ZvdW5kIHt9IEJpbmRpbmcgdGVzdCBmYWlsdXJle306IHt9Jy5mb3JtYXQobGVuKGZhaWx1cmVz KSwgcGx1cmFsU3VmZml4LCBmYWlsdXJlc19zdHJpbmcpCisgICAgICAgIHNlbGYuYnVpbGQuYnVp bGRGaW5pc2hlZChbbWVzc2FnZV0sIEZBSUxVUkUpCisgICAgICAgIHJldHVybiB7dSdzdGVwJzog dW5pY29kZShtZXNzYWdlKX0KKworICAgIEBkZWZlci5pbmxpbmVDYWxsYmFja3MKKyAgICBkZWYg X2FkZFRvTG9nKHNlbGYsIGxvZ05hbWUsIG1lc3NhZ2UpOgorICAgICAgICB0cnk6CisgICAgICAg ICAgICBsb2cgPSBzZWxmLmdldExvZyhsb2dOYW1lKQorICAgICAgICBleGNlcHQgS2V5RXJyb3I6 CisgICAgICAgICAgICBsb2cgPSB5aWVsZCBzZWxmLmFkZExvZyhsb2dOYW1lKQorICAgICAgICBs b2cuYWRkU3Rkb3V0KG1lc3NhZ2UpCisKIAogY2xhc3MgUnVuV2ViS2l0UGVybFRlc3RzKHNoZWxs LlNoZWxsQ29tbWFuZCk6CiAgICAgbmFtZSA9ICd3ZWJraXRwZXJsLXRlc3RzJwpJbmRleDogVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5w eQkocmV2aXNpb24gMjQ0Nzc4KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yOTQsMTggKzI5NCwyMCBAQCBj bGFzcyBUZXN0UnVuQmluZGluZ3NUZXN0cyhCdWlsZFN0ZXBNaXhpCiAgICAgICAgIHNlbGYuc2V0 dXBTdGVwKFJ1bkJpbmRpbmdzVGVzdHMoKSkKICAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21t YW5kcygKICAgICAgICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAgICAgICAg ICAgICAgICAgICAgICAgIHRpbWVvdXQ9MzAwLAogICAgICAgICAgICAgICAgICAgICAgICAgY29t bWFuZD1bJ1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRlc3RzJywgJy0tanNvbi1vdXRwdXQ9 ezB9Jy5mb3JtYXQoc2VsZi5qc29uRmlsZU5hbWUpXSwKICAgICAgICAgICAgICAgICAgICAgICAg IGxvZ2ZpbGVzPXsnanNvbic6IHNlbGYuanNvbkZpbGVOYW1lfSwKICAgICAgICAgICAgICAgICAg ICAgICAgICkKICAgICAgICAgICAgICsgMCwKICAgICAgICAgKQotICAgICAgICBzZWxmLmV4cGVj dE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nYmluZGluZ3MtdGVzdHMnKQor ICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0n UGFzc2VkIGJpbmRpbmdzIHRlc3RzJykKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAK ICAgICBkZWYgdGVzdF9mYWlsdXJlKHNlbGYpOgogICAgICAgICBzZWxmLnNldHVwU3RlcChSdW5C aW5kaW5nc1Rlc3RzKCkpCiAgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCiAgICAg ICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCisgICAgICAgICAgICAgICAgICAg ICAgICB0aW1lb3V0PTMwMCwKICAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9WydUb29s cy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0cycsICctLWpzb24tb3V0cHV0PXswfScuZm9ybWF0 KHNlbGYuanNvbkZpbGVOYW1lKV0sCiAgICAgICAgICAgICAgICAgICAgICAgICBsb2dmaWxlcz17 J2pzb24nOiBzZWxmLmpzb25GaWxlTmFtZX0sCiAgICAgICAgICAgICAgICAgICAgICAgICApCg==