<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>19742</bug_id>
          
          <creation_ts>2008-06-24 05:55:00 -0700</creation_ts>
          <short_desc>[GTK] Auto generate webkitmarshal.list</short_desc>
          <delta_ts>2008-08-02 02:40:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Marco Barisione">marco.barisione</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>84245</commentid>
    <comment_count>0</comment_count>
    <who name="Marco Barisione">marco.barisione</who>
    <bug_when>2008-06-24 05:55:00 -0700</bug_when>
    <thetext>I keep all my changes to WebKit in git branches, but when merging I often get conmflicts in the marshal.list file.

It would be nice it this file was autogenerated from source code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>84246</commentid>
    <comment_count>1</comment_count>
      <attachid>21901</attachid>
    <who name="Marco Barisione">marco.barisione</who>
    <bug_when>2008-06-24 06:02:53 -0700</bug_when>
    <thetext>Created attachment 21901
Auto generate webkitmarshal.list

This is the same approach used in telepathy related projects and in other sw, so it should be portable everywhere.

I also renamed webkit-marshal to webkitmarshal.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>84261</commentid>
    <comment_count>2</comment_count>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2008-06-24 08:53:07 -0700</bug_when>
    <thetext>Does the sed work with BSD sed? The shell foo is working with dash and zsh? If that is the case I&apos;m willing to say r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>84264</commentid>
    <comment_count>3</comment_count>
    <who name="Marco Barisione">marco.barisione</who>
    <bug_when>2008-06-24 09:04:30 -0700</bug_when>
    <thetext>I didn&apos;t test on BSD as I only have access to linux machines but it should work because we never got any bug reports about that for telepathy-related projects or for avahi-gobject. Nevertheless I would like if someone could test it before committing.

Note also that the code in my patch should just use POSIX syntax for portability reasons.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86223</commentid>
    <comment_count>4</comment_count>
      <attachid>21901</attachid>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2008-07-17 09:31:47 -0700</bug_when>
    <thetext>Comment on attachment 21901
Auto generate webkitmarshal.list

Okay. The change is reasonable, the sed is a bit hard to follow but looks sane.

In case it is broken for BSD sed we can look into a solution. Either detecting GNU sed, or changing the sed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87404</commentid>
    <comment_count>5</comment_count>
      <attachid>21901</attachid>
    <who name="Christian Dywan">christian</who>
    <bug_when>2008-07-30 11:18:48 -0700</bug_when>
    <thetext>Comment on attachment 21901
Auto generate webkitmarshal.list

Committed in r35455.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87605</commentid>
    <comment_count>6</comment_count>
      <attachid>22607</attachid>
    <who name="Christian Dywan">christian</who>
    <bug_when>2008-08-01 12:33:27 -0700</bug_when>
    <thetext>Created attachment 22607
Remove marshaller file

The now obsolete marshaller file wasn&apos;t removed. This patch does just that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87668</commentid>
    <comment_count>7</comment_count>
      <attachid>22607</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-08-02 00:48:24 -0700</bug_when>
    <thetext>Comment on attachment 22607
Remove marshaller file

Looks good to me.  This won&apos;t show up in the commit queue because it&apos;s marked as Fixed.  Perhaps this was already commited?  If not, please re-open the bug so it will show up in the queue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87679</commentid>
    <comment_count>8</comment_count>
    <who name="Jan Alonzo">jmalonzo</who>
    <bug_when>2008-08-02 02:40:26 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 22607 [edit])
&gt; Looks good to me.  This won&apos;t show up in the commit queue because it&apos;s marked
&gt; as Fixed.  Perhaps this was already commited?  If not, please re-open the bug
&gt; so it will show up in the queue.
&gt; 

landed in r35525
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>21901</attachid>
            <date>2008-06-24 06:02:53 -0700</date>
            <delta_ts>2008-07-30 11:18:48 -0700</delta_ts>
            <desc>Auto generate webkitmarshal.list</desc>
            <filename>marshal.patch</filename>
            <type>text/plain</type>
            <size>4308</size>
            <attacher name="Marco Barisione">marco.barisione</attacher>
            
              <data encoding="base64">SW5kZXg6IEdOVW1ha2VmaWxlLmFtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEdOVW1ha2VmaWxlLmFtCShyZXZp
c2lvbmUgMzQ3NjYpCisrKyBHTlVtYWtlZmlsZS5hbQkoY29waWEgbG9jYWxlKQpAQCAtMzIwLDgg
KzMyMCw4IEBACiAJV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5oCiAKIHdlYmtpdGd0
a19idWlsdF9zb3VyY2VzICs9IFwKLQlEZXJpdmVkU291cmNlcy93ZWJraXQtbWFyc2hhbC5oIFwK
LQlEZXJpdmVkU291cmNlcy93ZWJraXQtbWFyc2hhbC5jcHAgXAorCURlcml2ZWRTb3VyY2VzL3dl
YmtpdG1hcnNoYWwuaCBcCisJRGVyaXZlZFNvdXJjZXMvd2Via2l0bWFyc2hhbC5jcHAgXAogCURl
cml2ZWRTb3VyY2VzL3dlYmtpdGVudW10eXBlcy5jcHAgXAogCVdlYktpdC9ndGsvd2Via2l0L3dl
YmtpdGVudW10eXBlcy5oCiAKQEAgLTM2NywyNiArMzY3LDM3IEBACiBwa2djb25maWdfREFUQSA9
IFdlYktpdC9ndGsvd2Via2l0LTEuMC5wYwogCiBzdGFtcF9maWxlcyA6PSBcCi0Jc3RhbXAtd2Vi
a2l0LW1hcnNoYWwuY3BwIFwKLQlzdGFtcC13ZWJraXQtbWFyc2hhbC5oIFwKKwlzdGFtcC13ZWJr
aXRtYXJzaGFsLmNwcCBcCisJc3RhbXAtd2Via2l0bWFyc2hhbC5oIFwKIAlzdGFtcC13ZWJraXRl
bnVtdHlwZXMuY3BwIFwKIAlzdGFtcC13ZWJraXRlbnVtdHlwZXMuaAogCi1XRUJLSVRfTUFSU0hB
TCA9ICQoR0VOU09VUkNFUykvd2Via2l0LW1hcnNoYWwKLVdFQktJVF9NQVJTSEFMX0xJU1QgPSAk
KHNyY2RpcikvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0LW1hcnNoYWwubGlzdAorV0VCS0lUX01B
UlNIQUwgPSAkKEdFTlNPVVJDRVMpL3dlYmtpdG1hcnNoYWwKK1dFQktJVF9NQVJTSEFMX0xJU1Qg
PSAkKFdFQktJVF9NQVJTSEFMKS5saXN0CiAKLURlcml2ZWRTb3VyY2VzL3dlYmtpdC1tYXJzaGFs
LmNwcDogc3RhbXAtd2Via2l0LW1hcnNoYWwuY3BwCiskKFdFQktJVF9NQVJTSEFMX0xJU1QpOiAk
KHdlYmtpdGd0a19zb3VyY2VzKSBHTlVtYWtlZmlsZS5hbQorCSggY2QgJCh0b3Bfc3JjZGlyKSAm
JiBcCisJc2VkIC1uIC1lICdzLy4qd2Via2l0X21hcnNoYWxfXChbWzp1cHBlcjpdWzpkaWdpdDpd
XSpfX1tbOnVwcGVyOl1bOmRpZ2l0Ol1fXSpcKS4qL1wxL3AnIFwKKwkkKHdlYmtpdGd0a19zb3Vy
Y2VzKSApIFwKKwl8IHNlZCAtZSAncy9fXy86LycgLWUgJ3kvXy8sLycgfCBzb3J0IC11ID4gJEAu
dG1wCisJaWYgY21wIC1zICRALnRtcCAkQDsgdGhlbiBcCisJCXJtICRALnRtcDsgXAorCWVsc2Ug
XAorCQltdiAkQC50bXAgJEA7IFwKKwlmaQorCiskKFdFQktJVF9NQVJTSEFMKS5jcHA6IHN0YW1w
LXdlYmtpdG1hcnNoYWwuY3BwCiAJQHRydWUKIAotRGVyaXZlZFNvdXJjZXMvd2Via2l0LW1hcnNo
YWwuaDogc3RhbXAtd2Via2l0LW1hcnNoYWwuaAorJChXRUJLSVRfTUFSU0hBTCkuaDogc3RhbXAt
d2Via2l0bWFyc2hhbC5oCiAJQHRydWUKIAotc3RhbXAtd2Via2l0LW1hcnNoYWwuY3BwOiAkKFdF
QktJVF9NQVJTSEFMX0xJU1QpCitzdGFtcC13ZWJraXRtYXJzaGFsLmNwcDogJChXRUJLSVRfTUFS
U0hBTF9MSVNUKQogCWVjaG8gImV4dGVybiBcIkNcIiB7IiA+ICQoV0VCS0lUX01BUlNIQUwpLmNw
cCAmJiBcCiAJJChHTElCX0dFTk1BUlNIQUwpIC0tcHJlZml4PXdlYmtpdF9tYXJzaGFsICQoV0VC
S0lUX01BUlNIQUxfTElTVCkgLS1ib2R5ID4+ICQoV0VCS0lUX01BUlNIQUwpLmNwcCAmJiBlY2hv
ICd9JyA+PiAkKFdFQktJVF9NQVJTSEFMKS5jcHAgJiYgXAogCWVjaG8gdGltZXN0YW1wID4gJChA
RikKIAotc3RhbXAtd2Via2l0LW1hcnNoYWwuaDogJChXRUJLSVRfTUFSU0hBTF9MSVNUKQorc3Rh
bXAtd2Via2l0bWFyc2hhbC5oOiAkKFdFQktJVF9NQVJTSEFMX0xJU1QpCiAJJChHTElCX0dFTk1B
UlNIQUwpIC0tcHJlZml4PXdlYmtpdF9tYXJzaGFsICQoV0VCS0lUX01BUlNIQUxfTElTVCkgLS1o
ZWFkZXIgPiAkKFdFQktJVF9NQVJTSEFMKS5oICYmIFwKIAllY2hvIHRpbWVzdGFtcCA+ICQoQEYp
CiAKSW5kZXg6IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAJKHJldmlzaW9uZSAzNDc2
NikKKysrIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcAkoY29waWEgbG9jYWxl
KQpAQCAtMjUsNyArMjUsNyBAQAogCiAjaW5jbHVkZSAid2Via2l0d2ViZnJhbWUuaCIKICNpbmNs
dWRlICJ3ZWJraXR3ZWJ2aWV3LmgiCi0jaW5jbHVkZSAid2Via2l0LW1hcnNoYWwuaCIKKyNpbmNs
dWRlICJ3ZWJraXRtYXJzaGFsLmgiCiAjaW5jbHVkZSAid2Via2l0cHJpdmF0ZS5oIgogCiAjaW5j
bHVkZSAiQ1N0cmluZy5oIgpJbmRleDogV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j
cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAJKHJl
dmlzaW9uZSAzNDc2NikKKysrIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCShj
b3BpYSBsb2NhbGUpCkBAIC0yNSw3ICsyNSw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAKICNp
bmNsdWRlICJ3ZWJraXR3ZWJ2aWV3LmgiCi0jaW5jbHVkZSAid2Via2l0LW1hcnNoYWwuaCIKKyNp
bmNsdWRlICJ3ZWJraXRtYXJzaGFsLmgiCiAjaW5jbHVkZSAid2Via2l0cHJpdmF0ZS5oIgogI2lu
Y2x1ZGUgIndlYmtpdHdlYmJhY2tmb3J3YXJkbGlzdC5oIgogI2luY2x1ZGUgIndlYmtpdHdlYmhp
c3RvcnlpdGVtLmgiCkluZGV4OiBXZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX
ZWJLaXQvZ3RrL0NoYW5nZUxvZwkocmV2aXNpb25lIDM0NzY2KQorKysgV2ViS2l0L2d0ay9DaGFu
Z2VMb2cJKGNvcGlhIGxvY2FsZSkKQEAgLTEsMyArMSwxNCBAQAorMjAwOC0wNi0yNCAgTWFyY28g
QmFyaXNpb25lICA8bWFyY28uYmFyaXNpb25lQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc0MgorICAgICAgICBbR1RLXSBBdXRvIGdlbmVyYXRlIHdl
YmtpdG1hcnNoYWwubGlzdAorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcDog
SW5jbHVkZSB3ZWJraXRtYXJzaGFsLmggaW5zdGVhZCBvZgorICAgICAgICB3ZWJraXQtbWFyc2hh
bC5oLgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDogRGl0dG8uCisKIDIwMDgt
MDYtMTggIE1hcmNvIEJhcmlzaW9uZSAgPG1hcmNvLmJhcmlzaW9uZUBjb2xsYWJvcmEuY28udWs+
CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxwIFRva2VyLgpJbmRleDogQ2hhbmdlTG9nCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIENoYW5nZUxvZwkocmV2aXNpb25lIDM0NzY2KQorKysgQ2hhbmdlTG9nCShjb3Bp
YSBsb2NhbGUpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDYtMjQgIE1hcmNvIEJhcmlzaW9uZSAg
PG1hcmNvLmJhcmlzaW9uZUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTk3NDIKKyAgICAgICAgW0dUS10gQXV0byBnZW5lcmF0ZSB3ZWJraXRtYXJzaGFs
Lmxpc3QKKworICAgICAgICBBdXRvIGdlbmVyYXRlIHdlYmtpdG1hcnNoYWwubGlzdCBmcm9tIHNv
dXJjZSBmaWxlcyB0byByZWR1Y2UgdGhlCisgICAgICAgIG51bWJlciBvZiBjb25mbGljdHMgd2hl
biBtZXJnaW5nIGdpdCBicmFuY2hlcyBvciB3aGVuIGFwcGx5aW5nCisgICAgICAgIHBhdGNoZXMu
CisgICAgICAgIEFsc28gcmVuYW1lIHdlYmtpdC1tYXJzaGFsLiogdG8gd2Via2l0bWFyc2hhbC4q
IGZvciBjb25zaXN0ZW5jeS4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgorCiAyMDA4LTA2
LTE4ICBNYXJjbyBCYXJpc2lvbmUgIDxtYXJjby5iYXJpc2lvbmVAY29sbGFib3JhLmNvLnVrPgog
CiAgICAgICAgIFJldmlld2VkIGJ5IEFscCBUb2tlci4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>22607</attachid>
            <date>2008-08-01 12:33:27 -0700</date>
            <delta_ts>2008-08-02 00:48:24 -0700</delta_ts>
            <desc>Remove marshaller file</desc>
            <filename>mshlist.diff</filename>
            <type>text/plain</type>
            <size>959</size>
            <attacher name="Christian Dywan">christian</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK
aW5kZXggMzI0MzllMC4uNmFkYTUwNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK
KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAwOC0wOC0wMSAg
Q2hyaXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgd2Via2l0LW1hcnNoYWwu
bGlzdCwgd2hpY2ggd2FzIG1hZGUgb2Jzb2xldGUgaW4gIzE5NzQyCisKKyAgICAgICAgKiB3ZWJr
aXQvd2Via2l0LW1hcnNoYWwubGlzdDogUmVtb3ZlZC4KKwogMjAwOC0wNy0zMCAgTWFyY28gQmFy
aXNpb25lICA8bWFyY28uYmFyaXNpb25lQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBSZXZp
ZXdlZCBieSBIb2xnZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXQtbWFy
c2hhbC5saXN0IGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0LW1hcnNoYWwubGlzdApkZWxldGVk
IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggYThmMjQ1My4uMDAwMDAwMAotLS0gYS9XZWJLaXQvZ3Rr
L3dlYmtpdC93ZWJraXQtbWFyc2hhbC5saXN0CisrKyAvZGV2L251bGwKQEAgLTEsMTIgKzAsMCBA
QAotVk9JRDpPQkpFQ1QKLVZPSUQ6U1RSSU5HCi1WT0lEOlNUUklORyxTVFJJTkcKLVZPSUQ6T0JK
RUNULEJPT0xFQU4KLVZPSUQ6T0JKRUNULFNUUklORwotVk9JRDpPQkpFQ1QsT0JKRUNUCi1WT0lE
Ok9CSkVDVCxQT0lOVEVSLFBPSU5URVIKLUJPT0xFQU46U1RSSU5HLElOVCxTVFJJTkcKLUJPT0xF
QU46T0JKRUNULFNUUklORwotQk9PTEVBTjpPQkpFQ1QsU1RSSU5HLEJPT0xFQU4KLUJPT0xFQU46
T0JKRUNULFNUUklORyxTVFJJTkcsU1RSSU5HCi1JTlQ6T0JKRUNULE9CSkVDVAo=
</data>
<flag name="review"
          id="9994"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>