197415 2019-04-30 08:03:10 -0700 [WPE][Qt] Use C++17 instead of C++14 2019-05-20 07:51:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ludovico.denittis webkit-unassigned commit-queue lforschler pnormand webkit-bug-importer oldest_to_newest 1531499 0 ludovico.denittis 2019-04-30 08:03:10 -0700 This is a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131 The WPE Qt port was not updated to C++17 and this leaded to a compilation error. In file included from DerivedSources/ForwardingHeaders/wtf/HashTraits.h:28, from DerivedSources/ForwardingHeaders/wtf/glib/GRefPtr.h:28, from ../../Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.h:31, from ../../Source/WebKit/UIProcess/API/wpe/qt/WPEQmlExtensionPlugin.cpp:24: DerivedSources/ForwardingHeaders/wtf/Optional.h:322:68: error: expected ‘)’ before ‘,’ token template <class... Args> explicit Optional_base(std::in_place_t, Args&&... args) ~ ^ ) [...] Full log here https://paste.ubuntu.com/p/nvWmBjpq65/ I'm going to upload a patch for this. 1531504 1 368563 ludovico.denittis 2019-04-30 08:08:39 -0700 Created attachment 368563 Patch 1537576 2 368563 commit-queue 2019-05-20 07:51:00 -0700 Comment on attachment 368563 Patch Clearing flags on attachment: 368563 Committed r245516: <https://trac.webkit.org/changeset/245516> 1537577 3 commit-queue 2019-05-20 07:51:01 -0700 All reviewed patches have been landed. Closing bug. 1537578 4 webkit-bug-importer 2019-05-20 07:51:18 -0700 <rdar://problem/50945871> 368563 2019-04-30 08:08:39 -0700 2019-05-20 07:51:00 -0700 Patch bug-197415-20190430170837.patch text/plain 2868 ludovico.denittis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY2Y2MzNDgwZWMxY2VlNjRm MjRkN2E2MWE1NDA3ZTAyOTZjZWVhMDIuLmQzYmM2NmEzNjJlMjhlOGQ1NTNiNGY3ZGExOWRlZjA0 OTAxOTA2MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDQtMzAgIEx1ZG92aWNv IGRlIE5pdHRpcyAgPGx1ZG92aWNvLmRlbml0dGlzQGNvbGxhYm9yYS5jb20+CisKKyAgICAgICAg W1dQRV1bUXRdIFVzZSBDKysxNyBpbnN0ZWFkIG9mIEMrKzE0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc0MTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSB3YXMgYSByZWdyZXNzaW9uIGludHJv ZHVjZWQgd2l0aCB0aGUgY29tbWl0IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTcxMzEKKyAgICAgICAgVGhlIFdQRSBRdCBwb3J0IHdhcyBub3QgdXBkYXRlZCB0byBD KysxNyBhbmQgdGhpcyBsZWFkZWQgdG8gYSBjb21waWxhdGlvbiBlcnJvci4KKworICAgICAgICAq IFBsYXRmb3JtV1BFLmNtYWtlOgorCiAyMDE5LTA0LTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNDQ3NTApOiBbR1RL XVtXUEVdIE5ldHdvcmsgcHJvY2VzcyBpcyBjcmFzaGluZyBpbiBhbGwgbGF5b3V0IHRlc3RzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlIGIvU291cmNlL1dlYktp dC9QbGF0Zm9ybVdQRS5jbWFrZQppbmRleCA4ZjQ5NDhlMjg5ZWJjZGM5ZTNkYWU1ZmM3N2RiMWUw NDI2YjlmYzZiLi40M2I3ZGFlYzQ4MTc0MzhmY2U1OGRlMTBiYjQxMzJiMDQ5NTllYTZkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJL aXQvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTM5MSw3ICszOTEsNyBAQCBpZiAoRU5BQkxFX1dQRV9R VF9BUEkpCiAgICAgc2V0X3RhcmdldF9wcm9wZXJ0aWVzKHF0d3BlIFBST1BFUlRJRVMKICAgICAg ICAgT1VUUFVUX05BTUUgcXR3cGUKICAgICAgICAgQVVUT01PQyBPTgotICAgICAgICBDWFhfU1RB TkRBUkQgMTQKKyAgICAgICAgQ1hYX1NUQU5EQVJEIDE3CiAgICAgKQogICAgIHRhcmdldF9jb21w aWxlX2RlZmluaXRpb25zKHF0d3BlIFBVQkxJQyBRVF9OT19LRVlXT1JEUz0xKQogICAgIHRhcmdl dF9saW5rX2xpYnJhcmllcyhxdHdwZSAke3F0d3BlX0xJQlJBUklFU30pCmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTBmYTEwNzUzYzgwMGUzZDE2 ZDlmOTg3YTcwMDAwNzYyNGU1NTZkMC4uNWFiM2U3YWRiNTI4MmU2NGU2YzljNGZlYTFjYWM5NWIz OTg5Y2ZiYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTMwICBMdWRvdmljbyBkZSBOaXR0aXMgIDxsdWRv dmljby5kZW5pdHRpc0Bjb2xsYWJvcmEuY29tPgorCisgICAgICAgIFtXUEVdW1F0XSBVc2UgQysr MTcgaW5zdGVhZCBvZiBDKysxNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk3NDE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlcmUgd2FzIGEgcmVncmVzc2lvbiBpbnRyb2R1Y2VkIHdpdGggdGhlIGNv bW1pdCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3MTMxCisgICAg ICAgIFRoZSBXUEUgUXQgcG9ydCB3YXMgbm90IHVwZGF0ZWQgdG8gQysrMTcgYW5kIHRoaXMgbGVh ZGVkIHRvIGEgY29tcGlsYXRpb24gZXJyb3IuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL2ds aWIvQ01ha2VMaXN0cy50eHQ6CisKIDIwMTktMDQtMzAgIEFha2FzaCBKYWluICA8YWFrYXNoX2ph aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtld3MtYnVpbGRdIEVuYWJsZSB3ZWJraXRweSBxdWV1 ZSBvbiBuZXcgRVdTCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvQ01ha2VM aXN0cy50eHQgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvQ01ha2VMaXN0cy50eHQKaW5kZXgg N2NmMjE3Nzg4OGFkOWE2OWI1MTJkOWZiMzJlYWFmZWE3MzkwYTZhNi4uMmE3NDNhNzE4OTM0MDE4 NDlmNTQxZDQzNGVmYjhkM2Y4ZTc3NmRkYyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9nbGliL0NNYWtlTGlzdHMudHh0CisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xpYi9DTWFr ZUxpc3RzLnR4dApAQCAtMTU4LDcgKzE1OCw3IEBAIG1hY3JvKEFERF9XUEVfUVRfVEVTVCB0ZXN0 X25hbWUpCiAgICAgc2V0X3RhcmdldF9wcm9wZXJ0aWVzKCR7dGVzdF9uYW1lfSBQUk9QRVJUSUVT CiAgICAgICAgIFJVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWSAke0NNQUtFX1JVTlRJTUVfT1VUUFVU X0RJUkVDVE9SWX0vVGVzdFdlYktpdEFQSS9XUEVRdAogICAgICAgICBBVVRPTU9DIE9OCi0gICAg ICAgIENYWF9TVEFOREFSRCAxNAorICAgICAgICBDWFhfU1RBTkRBUkQgMTcKICAgICApCiAgICAg dGFyZ2V0X2NvbXBpbGVfZGVmaW5pdGlvbnMoJHt0ZXN0X25hbWV9IFBVQkxJQyBRVF9OT19LRVlX T1JEUz0xKQogICAgIHRhcmdldF9saW5rX2xpYnJhcmllcygke3Rlc3RfbmFtZX0gJHtXUEVRdEFQ SVRlc3RfTElCUkFSSUVTfSkK