197414 2019-04-30 06:44:46 -0700 Tighten type of ScrollingTree:rootNode() to ScrollingTreeFrameScrollingNode 2019-04-30 08:13:14 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned cmarcelo commit-queue ews-watchlist fred.wang jamesr luiz simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1531477 0 koivisto 2019-04-30 06:44:46 -0700 It is always one. 1531478 1 368558 koivisto 2019-04-30 06:48:59 -0700 Created attachment 368558 patch 1531509 2 368558 commit-queue 2019-04-30 08:12:32 -0700 Comment on attachment 368558 patch Clearing flags on attachment: 368558 Committed r244772: <https://trac.webkit.org/changeset/244772> 1531510 3 commit-queue 2019-04-30 08:12:33 -0700 All reviewed patches have been landed. Closing bug. 1531513 4 webkit-bug-importer 2019-04-30 08:13:14 -0700 <rdar://problem/50335269> 368558 2019-04-30 06:48:59 -0700 2019-04-30 08:12:32 -0700 patch scrolling-root-tighten-2.patch text/plain 6185 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NDY0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA0LTMwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBUaWdodGVuIHR5cGUgb2YgU2Ny b2xsaW5nVHJlZTpyb290Tm9kZSgpIHRvIFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzQxNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdU cmVlOjpzaG91bGRIYW5kbGVXaGVlbEV2ZW50U3luY2hyb25vdXNseSk6CisgICAgICAgIChXZWJD b3JlOjpTY3JvbGxpbmdUcmVlOjpoYW5kbGVXaGVlbEV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6 OlNjcm9sbGluZ1RyZWU6Om1haW5GcmFtZVZpZXdwb3J0Q2hhbmdlZFZpYURlbGVnYXRlZFNjcm9s bGluZyk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdUcmVlOjp1cGRhdGVUcmVlRnJvbVN0 YXRlTm9kZSk6CisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5oOgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZTo6cm9vdE5vZGUgY29uc3QpOgorCiAyMDE5LTA0 LTI1ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICByZWRlZmlu aXRpb24gb2YgZW51bWVyYXRvciAnTlNBdHRhY2htZW50Q2hhcmFjdGVyJyB3aXRoIEFwcGxlIGlu dGVybmFsIGJ1aWxkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxp bmdUcmVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlLmNwcAkocmV2aXNpb24gMjQ0NjQxKQorKysgU291cmNlL1dlYkNvcmUvcGFn ZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDkgKzYw LDggQEAgYm9vbCBTY3JvbGxpbmdUcmVlOjpzaG91bGRIYW5kbGVXaGVlbEV2ZQogICAgICAgICBt X3RyZWVTdGF0ZS5sYXRjaGVkTm9kZUlEID0gMDsKICAgICAKICAgICBpZiAoIW1fdHJlZVN0YXRl LmV2ZW50VHJhY2tpbmdSZWdpb25zLmlzRW1wdHkoKSAmJiBtX3Jvb3ROb2RlKSB7Ci0gICAgICAg IGF1dG8mIGZyYW1lU2Nyb2xsaW5nTm9kZSA9IGRvd25jYXN0PFNjcm9sbGluZ1RyZWVGcmFtZVNj cm9sbGluZ05vZGU+KCptX3Jvb3ROb2RlKTsKICAgICAgICAgRmxvYXRQb2ludCBwb3NpdGlvbiA9 IHdoZWVsRXZlbnQucG9zaXRpb24oKTsKLSAgICAgICAgcG9zaXRpb24ubW92ZShmcmFtZVNjcm9s bGluZ05vZGUudmlld1RvQ29udGVudHNPZmZzZXQobV90cmVlU3RhdGUubWFpbkZyYW1lU2Nyb2xs UG9zaXRpb24pKTsKKyAgICAgICAgcG9zaXRpb24ubW92ZShtX3Jvb3ROb2RlLT52aWV3VG9Db250 ZW50c09mZnNldChtX3RyZWVTdGF0ZS5tYWluRnJhbWVTY3JvbGxQb3NpdGlvbikpOwogCiAgICAg ICAgIGNvbnN0IEV2ZW50TmFtZXMmIG5hbWVzID0gZXZlbnROYW1lcygpOwogICAgICAgICBJbnRQ b2ludCByb3VuZGVkUG9zaXRpb24gPSByb3VuZGVkSW50UG9pbnQocG9zaXRpb24pOwpAQCAtOTcs NyArOTYsNyBAQCBTY3JvbGxpbmdFdmVudFJlc3VsdCBTY3JvbGxpbmdUcmVlOjpoYW5kCiAKICAg ICBpZiAoIWFzeW5jRnJhbWVPck92ZXJmbG93U2Nyb2xsaW5nRW5hYmxlZCgpKSB7CiAgICAgICAg IGlmIChtX3Jvb3ROb2RlKQotICAgICAgICAgICAgZG93bmNhc3Q8U2Nyb2xsaW5nVHJlZVNjcm9s bGluZ05vZGU+KCptX3Jvb3ROb2RlKS5oYW5kbGVXaGVlbEV2ZW50KHdoZWVsRXZlbnQpOworICAg ICAgICAgICAgbV9yb290Tm9kZS0+aGFuZGxlV2hlZWxFdmVudCh3aGVlbEV2ZW50KTsKICAgICAg ICAgcmV0dXJuIFNjcm9sbGluZ0V2ZW50UmVzdWx0OjpEaWROb3RIYW5kbGVFdmVudDsKICAgICB9 CiAKQEAgLTEwOSwxMCArMTA4LDggQEAgU2Nyb2xsaW5nRXZlbnRSZXN1bHQgU2Nyb2xsaW5nVHJl ZTo6aGFuZAogICAgIH0KIAogICAgIGlmIChtX3Jvb3ROb2RlKSB7Ci0gICAgICAgIGF1dG8mIGZy YW1lU2Nyb2xsaW5nTm9kZSA9IGRvd25jYXN0PFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05v ZGU+KCptX3Jvb3ROb2RlKTsKLQogICAgICAgICBGbG9hdFBvaW50IHBvc2l0aW9uID0gd2hlZWxF dmVudC5wb3NpdGlvbigpOwotICAgICAgICBTY3JvbGxpbmdUcmVlTm9kZSogbm9kZSA9IGZyYW1l U2Nyb2xsaW5nTm9kZS5zY3JvbGxpbmdOb2RlRm9yUG9pbnQoTGF5b3V0UG9pbnQocG9zaXRpb24p KTsKKyAgICAgICAgU2Nyb2xsaW5nVHJlZU5vZGUqIG5vZGUgPSBtX3Jvb3ROb2RlLT5zY3JvbGxp bmdOb2RlRm9yUG9pbnQoTGF5b3V0UG9pbnQocG9zaXRpb24pKTsKIAogICAgICAgICBMT0dfV0lU SF9TVFJFQU0oU2Nyb2xsaW5nLCBzdHJlYW0gPDwgIlNjcm9sbGluZ1RyZWU6OmhhbmRsZVdoZWVs RXZlbnQgZm91bmQgbm9kZSAiIDw8IChub2RlID8gbm9kZS0+c2Nyb2xsaW5nTm9kZUlEKCkgOiAw KSA8PCAiIGZvciBwb2ludCAiIDw8IHBvc2l0aW9uIDw8ICJcbiIpOwogCkBAIC0xMzYsOCArMTMz LDcgQEAgdm9pZCBTY3JvbGxpbmdUcmVlOjptYWluRnJhbWVWaWV3cG9ydENoYQogICAgIGlmICgh bV9yb290Tm9kZSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgYXV0byYgZnJhbWVTY3JvbGxpbmdO b2RlID0gZG93bmNhc3Q8U2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZT4oKm1fcm9vdE5v ZGUpOwotICAgIGZyYW1lU2Nyb2xsaW5nTm9kZS53YXNTY3JvbGxlZEJ5RGVsZWdhdGVkU2Nyb2xs aW5nKHNjcm9sbFBvc2l0aW9uLCBsYXlvdXRWaWV3cG9ydCk7CisgICAgbV9yb290Tm9kZS0+d2Fz U2Nyb2xsZWRCeURlbGVnYXRlZFNjcm9sbGluZyhzY3JvbGxQb3NpdGlvbiwgbGF5b3V0Vmlld3Bv cnQpOwogfQogCiB2b2lkIFNjcm9sbGluZ1RyZWU6OmNvbW1pdFRyZWVTdGF0ZShzdGQ6OnVuaXF1 ZV9wdHI8U2Nyb2xsaW5nU3RhdGVUcmVlPiBzY3JvbGxpbmdTdGF0ZVRyZWUpCkBAIC0yMTIsNyAr MjA4LDcgQEAgdm9pZCBTY3JvbGxpbmdUcmVlOjp1cGRhdGVUcmVlRnJvbVN0YXRlTgogICAgICAg ICBpZiAoIXBhcmVudE5vZGVJRCkgewogICAgICAgICAgICAgLy8gVGhpcyBpcyB0aGUgcm9vdCBu b2RlLiBDbGVhciB0aGUgbm9kZSBtYXAuCiAgICAgICAgICAgICBBU1NFUlQoc3RhdGVOb2RlLT5p c0ZyYW1lU2Nyb2xsaW5nTm9kZSgpKTsKLSAgICAgICAgICAgIG1fcm9vdE5vZGUgPSBub2RlOwor ICAgICAgICAgICAgbV9yb290Tm9kZSA9IGRvd25jYXN0PFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9s bGluZ05vZGU+KG5vZGUuZ2V0KCkpOwogICAgICAgICAgICAgbV9ub2RlTWFwLmNsZWFyKCk7CiAg ICAgICAgIH0gCiAgICAgICAgIG1fbm9kZU1hcC5zZXQobm9kZUlELCBub2RlLmdldCgpKTsKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmgJKHJl dmlzaW9uIDI0NDY0MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z1RyZWUuaAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiBjbGFzcyBJbnRQb2ludDsKIGNsYXNzIFNjcm9sbGluZ1N0YXRlVHJlZTsKIGNsYXNzIFNj cm9sbGluZ1N0YXRlTm9kZTsKK2NsYXNzIFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGU7 CiBjbGFzcyBTY3JvbGxpbmdUcmVlTm9kZTsKIGNsYXNzIFNjcm9sbGluZ1RyZWVTY3JvbGxpbmdO b2RlOwogCkBAIC0xMjksNyArMTMwLDcgQEAgcHVibGljOgogICAgIFdFQkNPUkVfRVhQT1JUIHZv aWQgc2V0U2Nyb2xsaW5nUGVyZm9ybWFuY2VMb2dnaW5nRW5hYmxlZChib29sIGZsYWcpOwogICAg IGJvb2wgc2Nyb2xsaW5nUGVyZm9ybWFuY2VMb2dnaW5nRW5hYmxlZCgpOwogCi0gICAgU2Nyb2xs aW5nVHJlZU5vZGUqIHJvb3ROb2RlKCkgY29uc3QgeyByZXR1cm4gbV9yb290Tm9kZS5nZXQoKTsg fQorICAgIFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGUqIHJvb3ROb2RlKCkgY29uc3Qg eyByZXR1cm4gbV9yb290Tm9kZS5nZXQoKTsgfQogCiAgICAgU2Nyb2xsaW5nTm9kZUlEIGxhdGNo ZWROb2RlKCk7CiAgICAgdm9pZCBzZXRMYXRjaGVkTm9kZShTY3JvbGxpbmdOb2RlSUQpOwpAQCAt MTcwLDcgKzE3MSw3IEBAIHByaXZhdGU6CiAKICAgICBMb2NrIG1fdHJlZU11dGV4OyAvLyBQcm90 ZWN0cyB0aGUgc2Nyb2xsaW5nIHRyZWUuCiAKLSAgICBSZWZQdHI8U2Nyb2xsaW5nVHJlZU5vZGU+ IG1fcm9vdE5vZGU7CisgICAgUmVmUHRyPFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGU+ IG1fcm9vdE5vZGU7CiAKICAgICB1c2luZyBTY3JvbGxpbmdUcmVlTm9kZU1hcCA9IEhhc2hNYXA8 U2Nyb2xsaW5nTm9kZUlELCBTY3JvbGxpbmdUcmVlTm9kZSo+OwogICAgIFNjcm9sbGluZ1RyZWVO b2RlTWFwIG1fbm9kZU1hcDsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQ3NjcpCisrKyBTb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE5 LTA0LTMwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBUaWdo dGVuIHR5cGUgb2YgU2Nyb2xsaW5nVHJlZTpyb290Tm9kZSgpIHRvIFNjcm9sbGluZ1RyZWVGcmFt ZVNjcm9sbGluZ05vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NzQxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVUlQcm9jZXNzL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVTY3JvbGxpbmdDb29yZGlu YXRvclByb3h5LmNwcDoKKwogMjAxOS0wNC0zMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjQ0NzUwKTogW0dUS11bV1BF XSBOZXR3b3JrIHByb2Nlc3MgaXMgY3Jhc2hpbmcgaW4gYWxsIGxheW91dCB0ZXN0cwpJbmRleDog U291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZVNjcm9sbGluZ0Nv b3JkaW5hdG9yUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1JlbW90ZUxheWVyVHJlZS9SZW1vdGVTY3JvbGxpbmdDb29yZGluYXRvclByb3h5LmNwcAkocmV2 aXNpb24gMjQ0NjQxKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVtb3RlTGF5ZXJUcmVl L1JlbW90ZVNjcm9sbGluZ0Nvb3JkaW5hdG9yUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z OSw3ICszOSw3IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9TY3JvbGxpbmdTdGF0ZU92ZXJmbG93U2Ny b2xsaW5nTm9kZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU2Nyb2xsaW5nU3RhdGVQb3NpdGlvbmVk Tm9kZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU2Nyb2xsaW5nU3RhdGVUcmVlLmg+Ci0jaW5jbHVk ZSA8V2ViQ29yZS9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZS5oPgorI2luY2x1ZGUgPFdlYkNv cmUvU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZS5oPgogCiBuYW1lc3BhY2UgV2ViS2l0 IHsKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwo=