197412 2019-04-30 06:17:05 -0700 WebCore::StyleColorScheme should not have explicitly-declared copy constructor 2019-04-30 07:33:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue don.olmstead mcatanzaro webkit-bug-importer oldest_to_newest 1531471 0 mcatanzaro 2019-04-30 06:17:05 -0700 Since we enabled dark mode CSS for GTK, I can't see any real warnings past this warning spam: [1135/1984] Building CXX object Source/WebCore/CMakeFiles...s/WebCore/unified-sources/UnifiedSource-043dd90b-29.cpp.o In file included from ../../Source/WebCore/rendering/RenderObject.h:35, from ../../Source/WebCore/rendering/RenderElement.h:26, from ../../Source/WebCore/rendering/RenderLayerModelObject.h:25, from ../../Source/WebCore/rendering/RenderBoxModelObject.h:28, from ../../Source/WebCore/rendering/RenderBox.h:26, from ../../Source/WebCore/rendering/RenderLayer.h:51, from ../../Source/WebCore/rendering/svg/SVGRenderingContext.cpp:32, from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-29.cpp:1: ../../Source/WebCore/rendering/style/RenderStyle.h: In member function ‘void WebCore::RenderStyle::setColorScheme(WebCore::StyleColorScheme)’: ../../Source/WebCore/rendering/style/RenderStyle.h:1182:97: warning: implicitly-declared ‘constexpr WebCore::StyleColorScheme& WebCore::StyleColorScheme::operator=(const WebCore::StyleColorScheme&)’ is deprecated [-Wdeprecated-copy] 1182 | void setColorScheme(StyleColorScheme supported) { SET_VAR(m_rareInheritedData, colorScheme, supported); } | ^~~~~~~~~ ../../Source/WebCore/rendering/style/RenderStyle.h:94:39: note: in definition of macro ‘SET_VAR’ 94 | group.access().variable = value; \ | ^~~~~ In file included from ../../Source/WebCore/rendering/style/StyleRareInheritedData.h:41, from ../../Source/WebCore/rendering/style/RenderStyle.h:59, from ../../Source/WebCore/rendering/RenderObject.h:35, from ../../Source/WebCore/rendering/RenderElement.h:26, from ../../Source/WebCore/rendering/RenderLayerModelObject.h:25, from ../../Source/WebCore/rendering/RenderBoxModelObject.h:28, from ../../Source/WebCore/rendering/RenderBox.h:26, from ../../Source/WebCore/rendering/RenderLayer.h:51, from ../../Source/WebCore/rendering/svg/SVGRenderingContext.cpp:32, from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-29.cpp:1: ../../Source/WebCore/rendering/style/StyleColorScheme.h:39:5: note: because ‘WebCore::StyleColorScheme’ has user-provided ‘WebCore::StyleColorScheme::StyleColorScheme(const WebCore::StyleColorScheme&)’ 39 | StyleColorScheme(const StyleColorScheme& other) | ^~~~~~~~~~~~~~~~ The copy constructor should be removed. 1531472 1 368555 mcatanzaro 2019-04-30 06:19:45 -0700 Created attachment 368555 Patch 1531473 2 368555 don.olmstead 2019-04-30 06:28:59 -0700 Comment on attachment 368555 Patch r=me assuming bots are happy 1531481 3 368555 commit-queue 2019-04-30 07:32:48 -0700 Comment on attachment 368555 Patch Clearing flags on attachment: 368555 Committed r244768: <https://trac.webkit.org/changeset/244768> 1531482 4 commit-queue 2019-04-30 07:32:50 -0700 All reviewed patches have been landed. Closing bug. 1531483 5 webkit-bug-importer 2019-04-30 07:33:14 -0700 <rdar://problem/50334395> 368555 2019-04-30 06:19:45 -0700 2019-04-30 07:32:48 -0700 Patch bug-197412-20190430081945.patch text/plain 1799 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDJiN2FlNTFhZjI2ZWQ3 ODQ3Mzg2YmNiYTI5OGU0ZWM2NDViM2MwZi4uOTAyMTFlZTJhYjM1YTVkMGUxZjc4YjZkZWI2NjA1 ZjEwZmVhMzQ0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA0LTMwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJDb3Jl OjpTdHlsZUNvbG9yU2NoZW1lIHNob3VsZCBub3QgaGF2ZSBleHBsaWNpdGx5LWRlY2xhcmVkIGNv cHkgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NzQxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEVpdGhlciB3ZSBuZWVkIHRvIGV4cGxpY2l0bHkgZGVjbGFyZSBhIGNvcHkgYXNzaWdu bWVudCBvcGVyYXRvciBoZXJlLCBvciB0aGUgY29weQorICAgICAgICBjb25zdHJ1Y3RvciBuZWVk cyB0byBiZSByZW1vdmVkLiBIYXZpbmcgb25lIHdpdGhvdXQgdGhlIG90aGVyIGNhdXNlcyBhIGh1 Z2Ugd2FybmluZyBzcGFtCisgICAgICAgIHdpdGggR0NDIDkuIEluIHRoaXMgY2FzZSwgdGhlIGNv cHkgY29uc3RydWN0b3IgaXMgcmVkdW5kYW50IGJlY2F1c2UgaXQncyBpZGVudGljYWwgdG8gYW4K KyAgICAgICAgaW1wbGljaXRseS1kZWNsYXJlZCBjb3B5IGNvbnN0cnVjdG9yLCBzbyBsZXQncyBq dXN0IHJlbW92ZSBpdC4KKworICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TdHlsZUNvbG9yU2No ZW1lLmg6CisKIDIwMTktMDQtMzAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdIFN1cHBvcnQgcHJlZmVycy1jb2xvci1zY2hlbWUgbWVk aWEgcXVlcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHls ZUNvbG9yU2NoZW1lLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVDb2xv clNjaGVtZS5oCmluZGV4IDUyMWVlNTI2MTZkYWFjNjg2OTZhMmQ0ZjZlNzIxNzEzZDlhMzFmOWEu LmVkMzBhOGFmNzE1ZDJlODAwMjc4Y2RkMjg1ZjljNzMzZWEyYWFjYmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZUNvbG9yU2NoZW1lLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlQ29sb3JTY2hlbWUuaApAQCAtMzYsMTEg KzM2LDYgQEAgY2xhc3MgU3R5bGVDb2xvclNjaGVtZSB7CiBwdWJsaWM6CiAgICAgU3R5bGVDb2xv clNjaGVtZSgpIHsgfQogCi0gICAgU3R5bGVDb2xvclNjaGVtZShjb25zdCBTdHlsZUNvbG9yU2No ZW1lJiBvdGhlcikKLSAgICAgICAgOiBtX2NvbG9yU2NoZW1lKG90aGVyLm1fY29sb3JTY2hlbWUp Ci0gICAgICAgICwgbV9hbGxvd3NUcmFuc2Zvcm1hdGlvbnMob3RoZXIubV9hbGxvd3NUcmFuc2Zv cm1hdGlvbnMpCi0gICAgeyB9Ci0KICAgICBTdHlsZUNvbG9yU2NoZW1lKE9wdGlvblNldDxDb2xv clNjaGVtZT4gY29sb3JTY2hlbWUsIGJvb2wgYWxsb3dzVHJhbnNmb3JtYXRpb25zKQogICAgICAg ICA6IG1fY29sb3JTY2hlbWUoY29sb3JTY2hlbWUpCiAgICAgICAgICwgbV9hbGxvd3NUcmFuc2Zv cm1hdGlvbnMoYWxsb3dzVHJhbnNmb3JtYXRpb25zKQo=